{"files":[{"status":"M","path":"packages\/react-dom\/src\/events\/__tests__\/getEventKey-test.js"}],"commit":{"authorName":"Jan Kassens","subject":"Convert getEventKey-test to createRoot (#28006)","revision":"4c63dc7bddeea8b44466e918708ea44f76b05378","shortRevision":"4c63dc7bdd","authorEmail":"jkassens@meta.com","authoredAt":"2024-01-19T13:51:20-05:00"},"parents":["64d0c94724bea32fa41d6b21cc4ee4938473be1e"],"body":"Convert getEventKey-test to createRoot","patch":"diff --git a\/packages\/react-dom\/src\/events\/__tests__\/getEventKey-test.js b\/packages\/react-dom\/src\/events\/__tests__\/getEventKey-test.js\nindex 1cf7c82d85..4c66a121b8 100644\n--- a\/packages\/react-dom\/src\/events\/__tests__\/getEventKey-test.js\n+++ b\/packages\/react-dom\/src\/events\/__tests__\/getEventKey-test.js\n@@ -10,28 +10,35 @@\n 'use strict';\n \n let React;\n-let ReactDOM;\n+let ReactDOMClient;\n+\n+let act;\n \n describe('getEventKey', () => {\n let container;\n+ let root;\n \n beforeEach(() => {\n React = require('react');\n- ReactDOM = require('react-dom');\n+ ReactDOMClient = require('react-dom\/client');\n+\n+ act = require('internal-test-utils').act;\n \n \/\/ The container has to be attached for events to fire.\n container = document.createElement('div');\n+ root = ReactDOMClient.createRoot(container);\n document.body.appendChild(container);\n });\n \n afterEach(() => {\n document.body.removeChild(container);\n container = null;\n+ root = null;\n });\n \n describe('when key is implemented in a browser', () => {\n describe('when key is not normalized', () => {\n- it('returns a normalized value', () => {\n+ it('returns a normalized value', async () => {\n let key = null;\n class Comp extends React.Component {\n render() {\n@@ -39,7 +46,9 @@ describe('getEventKey', () => {\n }\n }\n \n- ReactDOM.render(, container);\n+ await act(() => {\n+ root.render();\n+ });\n \n const nativeEvent = new KeyboardEvent('keydown', {\n key: 'Del',\n@@ -52,7 +61,7 @@ describe('getEventKey', () => {\n });\n \n describe('when key is normalized', () => {\n- it('returns a key', () => {\n+ it('returns a key', async () => {\n let key = null;\n class Comp extends React.Component {\n render() {\n@@ -60,7 +69,9 @@ describe('getEventKey', () => {\n }\n }\n \n- ReactDOM.render(, container);\n+ await act(() => {\n+ root.render();\n+ });\n \n const nativeEvent = new KeyboardEvent('keydown', {\n key: 'f',\n@@ -76,7 +87,7 @@ describe('getEventKey', () => {\n describe('when key is not implemented in a browser', () => {\n describe('when event type is keypress', () => {\n describe('when charCode is 13', () => {\n- it('returns \"Enter\"', () => {\n+ it('returns \"Enter\"', async () => {\n let key = null;\n class Comp extends React.Component {\n render() {\n@@ -84,7 +95,9 @@ describe('getEventKey', () => {\n }\n }\n \n- ReactDOM.render(, container);\n+ await act(() => {\n+ root.render();\n+ });\n \n const nativeEvent = new KeyboardEvent('keypress', {\n charCode: 13,\n@@ -97,7 +110,7 @@ describe('getEventKey', () => {\n });\n \n describe('when charCode is not 13', () => {\n- it('returns a string from a charCode', () => {\n+ it('returns a string from a charCode', async () => {\n let key = null;\n class Comp extends React.Component {\n render() {\n@@ -105,7 +118,9 @@ describe('getEventKey', () => {\n }\n }\n \n- ReactDOM.render(, container);\n+ await act(() => {\n+ root.render();\n+ });\n \n const nativeEvent = new KeyboardEvent('keypress', {\n charCode: 65,\n@@ -120,7 +135,7 @@ describe('getEventKey', () => {\n \n describe('when event type is keydown or keyup', () => {\n describe('when keyCode is recognized', () => {\n- it('returns a translated key', () => {\n+ it('returns a translated key', async () => {\n let key = null;\n class Comp extends React.Component {\n render() {\n@@ -128,7 +143,9 @@ describe('getEventKey', () => {\n }\n }\n \n- ReactDOM.render(, container);\n+ await act(() => {\n+ root.render();\n+ });\n \n const nativeEvent = new KeyboardEvent('keydown', {\n keyCode: 45,\n@@ -141,7 +158,7 @@ describe('getEventKey', () => {\n });\n \n describe('when keyCode is not recognized', () => {\n- it('returns Unidentified', () => {\n+ it('returns Unidentified', async () => {\n let key = null;\n class Comp extends React.Component {\n render() {\n@@ -149,7 +166,9 @@ describe('getEventKey', () => {\n }\n }\n \n- ReactDOM.render(, container);\n+ await act(() => {\n+ root.render();\n+ });\n \n const nativeEvent = new KeyboardEvent('keydown', {\n keyCode: 1337,\n"}

dillon1000/react

Files changed