{"parents":["9307932fe5b59c2d5ce8d04823b94ec0e48b206e"],"body":"We instead assume a 150ms duration.","files":[{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberBeginWork.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberUnwindWork.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseFuzz-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js","status":"M"}],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js\nindex 68e9ae3e72..9ed2c641cd 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js\n@@ -720,16 +720,14 @@ describe('ReactDOMFiberAsync', () => {\n \n let root = ReactDOM.unstable_createRoot(container);\n root.render(\n- \n- Initial\n- <\/React.Suspense>,\n+ Initial<\/React.Suspense>,\n );\n \n Scheduler.flushAll();\n expect(container.textContent).toBe('Initial');\n \n root.render(\n- \n+ \n \n <\/React.Suspense>,\n );\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js\nindex b0e62e2fc7..36f4441397 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js\n@@ -363,7 +363,7 @@ describe('ReactDOMServerPartialHydration', () => {\n

\n \n \n- \n+ \n \n <\/Suspense>\n <\/span>\n@@ -703,7 +703,7 @@ describe('ReactDOMServerPartialHydration', () => {\n expect(ref.current).toBe(span);\n });\n \n- it('replaces the fallback within the maxDuration if there is a nested suspense', async () => {\n+ it('replaces the fallback within the suspended time if there is a nested suspense', async () => {\n let suspend = false;\n let promise = new Promise(resolvePromise => {});\n let ref = React.createRef();\n@@ -724,7 +724,7 @@ describe('ReactDOMServerPartialHydration', () => {\n function App() {\n return (\n

\n- \n+ \n \n \n <\/span>\n@@ -751,7 +751,7 @@ describe('ReactDOMServerPartialHydration', () => {\n let root = ReactDOM.unstable_createRoot(container, {hydrate: true});\n root.render();\n Scheduler.flushAll();\n- \/\/ This will have exceeded the maxDuration so we should timeout.\n+ \/\/ This will have exceeded the suspended time so we should timeout.\n jest.advanceTimersByTime(500);\n \/\/ The boundary should longer be suspended for the middle content\n \/\/ even though the inner boundary is still suspended.\n@@ -762,7 +762,7 @@ describe('ReactDOMServerPartialHydration', () => {\n expect(ref.current).toBe(span);\n });\n \n- it('replaces the fallback within the maxDuration if there is a nested suspense in a nested suspense', async () => {\n+ it('replaces the fallback within the suspended time if there is a nested suspense in a nested suspense', async () => {\n let suspend = false;\n let promise = new Promise(resolvePromise => {});\n let ref = React.createRef();\n@@ -784,7 +784,7 @@ describe('ReactDOMServerPartialHydration', () => {\n return (\n

\n \n- \n+ \n \n \n <\/span>\n@@ -812,7 +812,7 @@ describe('ReactDOMServerPartialHydration', () => {\n let root = ReactDOM.unstable_createRoot(container, {hydrate: true});\n root.render();\n Scheduler.flushAll();\n- \/\/ This will have exceeded the maxDuration so we should timeout.\n+ \/\/ This will have exceeded the suspended time so we should timeout.\n jest.advanceTimersByTime(500);\n \/\/ The boundary should longer be suspended for the middle content\n \/\/ even though the inner boundary is still suspended.\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.js\nindex 14e02d396d..7a5df7629e 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.js\n@@ -74,12 +74,12 @@ describe('ReactDOMSuspensePlaceholder', () => {\n ];\n function App() {\n return (\n- }>\n+ }>\n

\n \n <\/div>\n

\n- \n+ \n <\/div>\n

\n \n@@ -92,7 +92,7 @@ describe('ReactDOMSuspensePlaceholder', () => {\n expect(divs[1].current.style.display).toEqual('none');\n expect(divs[2].current.style.display).toEqual('none');\n \n- await advanceTimers(1000);\n+ await advanceTimers(500);\n \n expect(divs[0].current.style.display).toEqual('');\n expect(divs[1].current.style.display).toEqual('');\n@@ -103,9 +103,9 @@ describe('ReactDOMSuspensePlaceholder', () => {\n it('hides and unhides timed out text nodes', async () => {\n function App() {\n return (\n- }>\n+ }>\n \n- \n+ \n \n <\/Suspense>\n );\n@@ -113,7 +113,7 @@ describe('ReactDOMSuspensePlaceholder', () => {\n ReactDOM.render(, container);\n expect(container.textContent).toEqual('Loading...');\n \n- await advanceTimers(1000);\n+ await advanceTimers(500);\n \n expect(container.textContent).toEqual('ABC');\n });\n@@ -137,10 +137,10 @@ describe('ReactDOMSuspensePlaceholder', () => {\n \n function App() {\n return (\n- }>\n+ }>\n Sibling<\/Sibling>\n \n- \n+ \n <\/span>\n <\/Suspense>\n );\n@@ -158,7 +158,7 @@ describe('ReactDOMSuspensePlaceholder', () => {\n 'Sibling<\/span><\/span>Loading...',\n );\n \n- await advanceTimers(1000);\n+ await advanceTimers(500);\n \n expect(container.innerHTML).toEqual(\n 'Sibling<\/span>Async<\/span>',\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\nindex e5ac3a605a..e6b04911a7 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\n@@ -157,6 +157,7 @@ let didWarnAboutContextTypeOnFunctionComponent;\n let didWarnAboutGetDerivedStateOnFunctionComponent;\n let didWarnAboutFunctionRefs;\n export let didWarnAboutReassigningProps;\n+let didWarnAboutMaxDuration;\n \n if (__DEV__) {\n didWarnAboutBadClass = {};\n@@ -165,6 +166,7 @@ if (__DEV__) {\n didWarnAboutGetDerivedStateOnFunctionComponent = {};\n didWarnAboutFunctionRefs = {};\n didWarnAboutReassigningProps = false;\n+ didWarnAboutMaxDuration = false;\n }\n \n export function reconcileChildren(\n@@ -1409,6 +1411,19 @@ function updateSuspenseComponent(\n workInProgress.effectTag &= ~DidCapture;\n }\n \n+ if (__DEV__) {\n+ if ('maxDuration' in nextProps) {\n+ if (!didWarnAboutMaxDuration) {\n+ didWarnAboutMaxDuration = true;\n+ warning(\n+ false,\n+ 'maxDuration has been removed from React. ' +\n+ 'Remove the maxDuration prop.',\n+ );\n+ }\n+ }\n+ }\n+\n \/\/ This next part is a bit confusing. If the children timeout, we switch to\n \/\/ showing the fallback children in place of the \"primary\" children.\n \/\/ However, we don't want to delete the primary children because then their\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberUnwindWork.js b\/packages\/react-reconciler\/src\/ReactFiberUnwindWork.js\nindex 006cc5e749..f3b4d749df 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberUnwindWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberUnwindWork.js\n@@ -232,16 +232,12 @@ function throwException(\n break;\n }\n }\n- let timeoutPropMs = workInProgress.pendingProps.maxDuration;\n- if (typeof timeoutPropMs === 'number') {\n- if (timeoutPropMs <= 0) {\n- earliestTimeoutMs = 0;\n- } else if (\n- earliestTimeoutMs === -1 ||\n- timeoutPropMs < earliestTimeoutMs\n- ) {\n- earliestTimeoutMs = timeoutPropMs;\n- }\n+ const defaultSuspenseTimeout = 150;\n+ if (\n+ earliestTimeoutMs === -1 ||\n+ defaultSuspenseTimeout < earliestTimeoutMs\n+ ) {\n+ earliestTimeoutMs = defaultSuspenseTimeout;\n }\n }\n \/\/ If there is a DehydratedSuspenseComponent we don't have to do anything because\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\nindex 4e80064514..cd91c40574 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\n@@ -119,8 +119,8 @@ describe('ReactLazy', () => {\n return ;\n }\n \n- const promiseForFoo = delay(1000).then(() => fakeImport(Foo));\n- const promiseForBar = delay(2000).then(() => fakeImport(Bar));\n+ const promiseForFoo = delay(100).then(() => fakeImport(Foo));\n+ const promiseForBar = delay(500).then(() => fakeImport(Bar));\n \n const LazyFoo = lazy(() => promiseForFoo);\n const LazyBar = lazy(() => promiseForBar);\n@@ -138,13 +138,13 @@ describe('ReactLazy', () => {\n expect(Scheduler).toFlushAndYield(['Loading...']);\n expect(root).toMatchRenderedOutput(null);\n \n- jest.advanceTimersByTime(1000);\n+ jest.advanceTimersByTime(100);\n await promiseForFoo;\n \n expect(Scheduler).toFlushAndYield(['Foo', 'Loading...']);\n expect(root).toMatchRenderedOutput(null);\n \n- jest.advanceTimersByTime(1000);\n+ jest.advanceTimersByTime(500);\n await promiseForBar;\n \n expect(Scheduler).toFlushAndYield(['Foo', 'Bar']);\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js\nindex 913cbfbd32..14fe319b7f 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js\n@@ -140,10 +140,10 @@ describe('ReactSuspense', () => {\n \/\/ Render two sibling Suspense components\n const root = ReactTestRenderer.create(\n \n- }>\n+ }>\n \n <\/Suspense>\n- }>\n+ }>\n \n <\/Suspense>\n <\/React.Fragment>,\n@@ -211,7 +211,7 @@ describe('ReactSuspense', () => {\n }\n \n const root = ReactTestRenderer.create(\n- }>\n+ }>\n \n \n <\/Suspense>,\n@@ -272,7 +272,7 @@ describe('ReactSuspense', () => {\n it('only captures if `fallback` is defined', () => {\n const root = ReactTestRenderer.create(\n }>\n- \n+ \n \n <\/Suspense>\n <\/Suspense>,\n@@ -368,9 +368,7 @@ describe('ReactSuspense', () => {\n \n function App() {\n return (\n- }>\n+ }>\n \n \n \n@@ -631,7 +629,7 @@ describe('ReactSuspense', () => {\n \n function App(props) {\n return (\n- }>\n+ }>\n \n <\/Suspense>\n );\n@@ -681,7 +679,7 @@ describe('ReactSuspense', () => {\n \n function App(props) {\n return (\n- }>\n+ }>\n \n \n \n@@ -726,7 +724,7 @@ describe('ReactSuspense', () => {\n it('does not get stuck with fallback in concurrent mode for a large delay', () => {\n function App(props) {\n return (\n- }>\n+ }>\n \n \n <\/Suspense>\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseFuzz-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseFuzz-test.internal.js\nindex 22c2c051af..5c0323a657 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseFuzz-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseFuzz-test.internal.js\n@@ -268,11 +268,6 @@ describe('ReactSuspenseFuzz', () => {\n remainingElements--;\n const children = createRandomChildren(3);\n \n- const maxDuration = pickRandomWeighted(rand, [\n- {value: undefined, weight: 1},\n- {value: rand.intBetween(0, 5000), weight: 1},\n- ]);\n-\n const fallbackType = pickRandomWeighted(rand, [\n {value: 'none', weight: 1},\n {value: 'normal', weight: 1},\n@@ -290,11 +285,7 @@ describe('ReactSuspenseFuzz', () => {\n );\n }\n \n- return React.createElement(\n- Suspense,\n- {maxDuration, fallback},\n- ...children,\n- );\n+ return React.createElement(Suspense, {fallback}, ...children);\n }\n case 'return':\n default:\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js\nindex bb838c558a..89f25adcd3 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js\n@@ -110,7 +110,7 @@ describe('ReactSuspensePlaceholder', () => {\n \n function App(props) {\n return (\n- }>\n+ }>\n \n \n \n@@ -176,7 +176,7 @@ describe('ReactSuspensePlaceholder', () => {\n it('times out text nodes', async () => {\n function App(props) {\n return (\n- }>\n+ }>\n \n \n \n@@ -225,7 +225,7 @@ describe('ReactSuspensePlaceholder', () => {\n \/\/ uppercase is a special type that causes React Noop to render child\n \/\/ text nodes as uppercase.\n \n- }>\n+ }>\n \n \n \n@@ -293,7 +293,7 @@ describe('ReactSuspensePlaceholder', () => {\n Scheduler.yieldValue('App');\n return (\n \n- }>\n+ }>\n {shouldSuspend && }\n \n <\/Suspense>\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\nindex f438dbb2da..18d85fadb0 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\n@@ -89,6 +89,25 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n }\n }\n \n+ it('warns if the deprecated maxDuration option is used', () => {\n+ function Foo() {\n+ return (\n+ \n+

;\n+ <\/Suspense>\n+ );\n+ }\n+\n+ ReactNoop.render();\n+\n+ expect(() => Scheduler.flushAll()).toWarnDev([\n+ 'Warning: maxDuration has been removed from React. ' +\n+ 'Remove the maxDuration prop.' +\n+ '\\n in Suspense (at **)' +\n+ '\\n in Foo (at **)',\n+ ]);\n+ });\n+\n it('suspends rendering and continues later', async () => {\n function Bar(props) {\n Scheduler.yieldValue('Bar');\n@@ -137,10 +156,10 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \/\/ Render two sibling Suspense components\n ReactNoop.render(\n \n- }>\n+ }>\n \n <\/Suspense>\n- }>\n+ }>\n \n <\/Suspense>\n <\/Fragment>,\n@@ -289,7 +308,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n const errorBoundary = React.createRef();\n function App() {\n return (\n- }>\n+ }>\n \n \n <\/ErrorBoundary>\n@@ -369,6 +388,9 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n });\n \n it('keeps working on lower priority work after being pinged', async () => {\n+ \/\/ Advance the virtual time so that we're close to the edge of a bucket.\n+ ReactNoop.expire(149);\n+\n function App(props) {\n return (\n }>\n@@ -382,8 +404,9 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n expect(Scheduler).toFlushAndYield(['Suspend! [A]', 'Loading...']);\n expect(ReactNoop.getChildren()).toEqual([]);\n \n- \/\/ Advance React's virtual time by enough to fall into a new async bucket.\n- ReactNoop.expire(1200);\n+ \/\/ Advance React's virtual time by enough to fall into a new async bucket,\n+ \/\/ but not enough to expire the suspense timeout.\n+ ReactNoop.expire(120);\n ReactNoop.render();\n expect(Scheduler).toFlushAndYield(['Suspend! [A]', 'B', 'Loading...']);\n expect(ReactNoop.getChildren()).toEqual([]);\n@@ -463,17 +486,16 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n });\n \n it('switches to an inner fallback even if it expires later', async () => {\n+ \/\/ Advance the virtual time so that we're closer to the edge of a bucket.\n+ ReactNoop.expire(200);\n+\n ReactNoop.render(\n \n \n- }>\n- \n- }>\n- \n+ }>\n+ \n+ }>\n+ \n <\/Suspense>\n <\/Suspense>\n <\/Fragment>,\n@@ -492,8 +514,8 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \n \/\/ Expire the outer timeout, but don't expire the inner one.\n \/\/ We should see the outer loading placeholder.\n- ReactNoop.expire(1500);\n- await advanceTimers(1500);\n+ ReactNoop.expire(250);\n+ await advanceTimers(250);\n expect(Scheduler).toFlushWithoutYielding();\n expect(ReactNoop.getChildren()).toEqual([\n span('Sync'),\n@@ -501,11 +523,11 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n ]);\n \n \/\/ Resolve the outer promise.\n- ReactNoop.expire(2000);\n- await advanceTimers(2000);\n- \/\/ At this point, 3.5 seconds have elapsed total. The outer placeholder\n- \/\/ timed out at 1.5 seconds. So, 2 seconds have elapsed since the\n- \/\/ placeholder timed out. That means we still haven't reached the 2.5 second\n+ ReactNoop.expire(50);\n+ await advanceTimers(50);\n+ \/\/ At this point, 250ms have elapsed total. The outer placeholder\n+ \/\/ timed out at around 150-200ms. So, 50-100ms have elapsed since the\n+ \/\/ placeholder timed out. That means we still haven't reached the 150ms\n \/\/ threshold of the inner placeholder.\n expect(Scheduler).toHaveYielded(['Promise resolved [Outer content]']);\n expect(Scheduler).toFlushAndYield([\n@@ -522,7 +544,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \/\/ Expire the inner timeout.\n ReactNoop.expire(500);\n await advanceTimers(500);\n- \/\/ Now that 2.5 seconds have elapsed since the outer placeholder timed out,\n+ \/\/ Now that 750ms have elapsed since the outer placeholder timed out,\n \/\/ we can timeout the inner placeholder.\n expect(ReactNoop.getChildren()).toEqual([\n span('Sync'),\n@@ -595,10 +617,10 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n expect(ReactNoop.getChildren()).toEqual([span('Loading (outer)...')]);\n });\n \n- it('expires early with a `maxDuration` option', async () => {\n+ it('expires early by default', async () => {\n ReactNoop.render(\n \n- }>\n+ }>\n \n <\/Suspense>\n \n@@ -632,7 +654,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \n it('resolves successfully even if fallback render is pending', async () => {\n ReactNoop.render(\n- }>\n+ }>\n \n <\/Suspense>,\n );\n@@ -656,7 +678,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \n it('a Suspense component correctly handles more than one suspended child', async () => {\n ReactNoop.render(\n- }>\n+ }>\n \n \n <\/Suspense>,\n@@ -681,7 +703,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \n it('can resume rendering earlier than a timeout', async () => {\n ReactNoop.render(\n- }>\n+ }>\n \n <\/Suspense>,\n );\n@@ -704,10 +726,11 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n expect(ReactNoop.getChildren()).toEqual([span('Async')]);\n });\n \n- it('starts working on an update even if its priority falls between two suspended levels', async () => {\n+ \/\/ TODO: This cannot be tested until we have a way to long-suspend navigations.\n+ it.skip('starts working on an update even if its priority falls between two suspended levels', async () => {\n function App(props) {\n return (\n- } maxDuration={10000}>\n+ }>\n {props.text === 'C' ? (\n \n ) : (\n@@ -802,55 +825,11 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n expect(ReactNoop.getChildren()).toEqual([span('goodbye')]);\n });\n \n- describe('a Delay component', () => {\n- function Never() {\n- \/\/ Throws a promise that resolves after some arbitrarily large\n- \/\/ number of seconds. The idea is that this component will never\n- \/\/ resolve. It's always wrapped by a Suspense.\n- throw new Promise(resolve => setTimeout(() => resolve(), 10000));\n- }\n-\n- function Delay({ms}) {\n- \/\/ Once ms has elapsed, render null. This allows the rest of the\n- \/\/ tree to resume rendering.\n- return (\n- \n- \n- <\/Suspense>\n- );\n- }\n-\n- function DebouncedText({text, ms}) {\n- return (\n- \n- \n- \n- <\/Fragment>\n- );\n- }\n-\n- it('works', async () => {\n- ReactNoop.render();\n- expect(Scheduler).toFlushAndYield(['A']);\n- expect(ReactNoop.getChildren()).toEqual([]);\n-\n- await advanceTimers(800);\n- ReactNoop.expire(800);\n- expect(Scheduler).toFlushWithoutYielding();\n- expect(ReactNoop.getChildren()).toEqual([]);\n-\n- await advanceTimers(1000);\n- ReactNoop.expire(1000);\n- expect(Scheduler).toFlushWithoutYielding();\n- expect(ReactNoop.getChildren()).toEqual([span('A')]);\n- });\n- });\n-\n describe('sync mode', () => {\n it('times out immediately', async () => {\n function App() {\n return (\n- }>\n+ }>\n \n <\/Suspense>\n );\n@@ -889,7 +868,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n const text = React.createRef(null);\n function App() {\n return (\n- }>\n+ }>\n \n \n \n@@ -969,9 +948,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n function App() {\n return (\n \n- }>\n+ }>\n \n \n {text => (\n@@ -1104,9 +1081,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n function App() {\n return (\n \n- }>\n+ }>\n \n \n {text => (\n@@ -1250,9 +1225,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \n function App() {\n return (\n- }>\n+ }>\n \n \n \n@@ -1517,9 +1490,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \n function App() {\n return (\n- }>\n+ }>\n \n \n \ndiff --git a\/packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js b\/packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js\nindex ed4cca9b56..8df35e979e 100644\n--- a\/packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js\n+++ b\/packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js\n@@ -2362,10 +2362,8 @@ describe('Profiler', () => {\n () => {\n ReactTestRenderer.create(\n \n- }>\n- \n+ }>\n+ \n <\/React.Suspense>\n <\/React.Profiler>,\n );\n@@ -2416,10 +2414,8 @@ describe('Profiler', () => {\n () => {\n ReactTestRenderer.create(\n \n- }>\n- \n+ }>\n+ \n <\/React.Suspense>\n <\/React.Profiler>,\n );\n@@ -2455,10 +2451,8 @@ describe('Profiler', () => {\n () => {\n ReactTestRenderer.create(\n \n- }>\n- \n+ }>\n+ \n <\/React.Suspense>\n <\/React.Profiler>,\n {\n@@ -2468,8 +2462,8 @@ describe('Profiler', () => {\n },\n );\n \n- Scheduler.advanceTime(1500);\n- await awaitableAdvanceTimers(1500);\n+ Scheduler.advanceTime(400);\n+ await awaitableAdvanceTimers(400);\n \n expect(Scheduler).toFlushAndYield([\n 'Suspend [loaded]',\n@@ -2477,8 +2471,8 @@ describe('Profiler', () => {\n ]);\n expect(onInteractionScheduledWorkCompleted).not.toHaveBeenCalled();\n \n- Scheduler.advanceTime(2500);\n- await awaitableAdvanceTimers(2500);\n+ Scheduler.advanceTime(500);\n+ await awaitableAdvanceTimers(500);\n \n expect(Scheduler).toHaveYielded(['Promise resolved [loaded]']);\n expect(Scheduler).toFlushAndYield(['AsyncText [loaded]']);\n@@ -2502,10 +2496,8 @@ describe('Profiler', () => {\n () => {\n ReactTestRenderer.create(\n \n- }>\n- \n+ }>\n+ \n <\/React.Suspense>\n <\/React.Profiler>,\n {unstable_isConcurrent: true},\n@@ -2519,7 +2511,7 @@ describe('Profiler', () => {\n \n expect(onInteractionScheduledWorkCompleted).not.toHaveBeenCalled();\n \n- jest.advanceTimersByTime(1000);\n+ jest.advanceTimersByTime(100);\n await resourcePromise;\n expect(Scheduler).toHaveYielded(['Promise resolved [loaded]']);\n expect(Scheduler).toFlushAndYield(['AsyncText [loaded]']);\n@@ -2545,10 +2537,8 @@ describe('Profiler', () => {\n () => {\n renderer = ReactTestRenderer.create(\n \n- }>\n- \n+ }>\n+ \n <\/React.Suspense>\n \n <\/React.Profiler>,\n@@ -2579,10 +2569,8 @@ describe('Profiler', () => {\n () => {\n renderer.update(\n \n- }>\n- \n+ }>\n+ \n <\/React.Suspense>\n \n <\/React.Profiler>,\n@@ -2600,8 +2588,8 @@ describe('Profiler', () => {\n \n expect(onInteractionScheduledWorkCompleted).not.toHaveBeenCalled();\n \n- Scheduler.advanceTime(1000);\n- jest.advanceTimersByTime(1000);\n+ Scheduler.advanceTime(100);\n+ jest.advanceTimersByTime(100);\n await originalPromise;\n expect(renderer.toJSON()).toEqual(['loaded', 'updated']);\n \n@@ -2631,10 +2619,8 @@ describe('Profiler', () => {\n () => {\n renderer = ReactTestRenderer.create(\n \n- }>\n- \n+ }>\n+ \n <\/React.Suspense>\n \n <\/React.Profiler>,\n@@ -2651,8 +2637,8 @@ describe('Profiler', () => {\n expect(onInteractionScheduledWorkCompleted).not.toHaveBeenCalled();\n expect(onRender).not.toHaveBeenCalled();\n \n- Scheduler.advanceTime(500);\n- jest.advanceTimersByTime(500);\n+ Scheduler.advanceTime(50);\n+ jest.advanceTimersByTime(50);\n \n const highPriUpdateInteraction = {\n id: 1,\n@@ -2669,10 +2655,8 @@ describe('Profiler', () => {\n () => {\n renderer.update(\n \n- }>\n- \n+ }>\n+ \n <\/React.Suspense>\n \n <\/React.Profiler>,\n@@ -2695,8 +2679,8 @@ describe('Profiler', () => {\n \n expect(onInteractionScheduledWorkCompleted).toHaveBeenCalledTimes(0);\n \n- Scheduler.advanceTime(500);\n- jest.advanceTimersByTime(500);\n+ Scheduler.advanceTime(50);\n+ jest.advanceTimersByTime(50);\n await originalPromise;\n expect(Scheduler).toHaveYielded(['Promise resolved [loaded]']);\n expect(Scheduler).toFlushAndYield(['AsyncText [loaded]']);\ndiff --git a\/packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js b\/packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js\nindex 21b691c4ff..8d2bf3cf8b 100644\n--- a\/packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js\n+++ b\/packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js\n@@ -88,7 +88,7 @@ describe('ProfilerDOM', () => {\n const root = ReactDOM.unstable_createRoot(element);\n batch = root.createBatch();\n batch.render(\n- }>\n+ }>\n \n <\/React.Suspense>,\n );\n","commit":{"authorName":"Sebastian Markbåge","authorEmail":"sebastian@calyptus.eu","subject":"Remove maxDuration from tests (#15272)","shortRevision":"4c75881ee3","authoredAt":"2019-04-02T14:27:44-07:00","revision":"4c75881ee38ba2596c5c603d268f0dff178b8581"}}

dillon1000/react

Files changed