{"commit":{"shortRevision":"4c9d62d2b4","authorEmail":"sebastian.silbermann@vercel.com","authoredAt":"2026-02-09T22:52:24+01:00","revision":"4c9d62d2b47be424ad9050725d8bdd8df12fe2a3","authorName":"Sebastian \"Sebbie\" Silbermann","subject":"[DevTools] Fix crash when revealing stable, filtered `` children (#35734)"},"files":[{"path":"packages\/react-devtools-shared\/src\/__tests__\/store-test.js","status":"M"},{"path":"packages\/react-devtools-shared\/src\/backend\/fiber\/renderer.js","status":"M"}],"patch":"diff --git a\/packages\/react-devtools-shared\/src\/__tests__\/store-test.js b\/packages\/react-devtools-shared\/src\/__tests__\/store-test.js\nindex 5e39a0fe68..871b44827e 100644\n--- a\/packages\/react-devtools-shared\/src\/__tests__\/store-test.js\n+++ b\/packages\/react-devtools-shared\/src\/__tests__\/store-test.js\n@@ -3572,4 +3572,48 @@ describe('Store', () => {\n \n `);\n });\n+\n+ \/\/ @reactVersion >= 19\n+ it('can reconcile newly visible Activity with filtered, stable children', async () => {\n+ const Activity = React.Activity || React.unstable_Activity;\n+\n+ function IgnoreMe({children}) {\n+ return children;\n+ }\n+\n+ function Component({children}) {\n+ return

{children}<\/div>;\n+ }\n+\n+ await actAsync(\n+ async () =>\n+ (store.componentFilters = [createDisplayNameFilter('^IgnoreMe', true)]),\n+ );\n+\n+ const children = (\n+ \n+ Left<\/Component>\n+ <\/IgnoreMe>\n+ );\n+\n+ await actAsync(() => {\n+ render({children}<\/Activity>);\n+ });\n+\n+ expect(store).toMatchInlineSnapshot(`\n+ [root]\n+ \n+ `);\n+\n+ await actAsync(() => {\n+ render({children}<\/Activity>);\n+ });\n+\n+ expect(store).toMatchInlineSnapshot(`\n+ [root]\n+ ▾ \n+ ▾ \n+

\n+ `);\n+ });\n });\ndiff --git a\/packages\/react-devtools-shared\/src\/backend\/fiber\/renderer.js b\/packages\/react-devtools-shared\/src\/backend\/fiber\/renderer.js\nindex 7363c66d15..61c6f86dd6 100644\n--- a\/packages\/react-devtools-shared\/src\/backend\/fiber\/renderer.js\n+++ b\/packages\/react-devtools-shared\/src\/backend\/fiber\/renderer.js\n@@ -5416,6 +5416,17 @@ export function attach(\n \/\/ We're hiding the children. Remove them from the Frontend\n unmountRemainingChildren();\n }\n+ } else if (prevWasHidden && !nextIsHidden) {\n+ \/\/ Since we don't mount hidden children and unmount children when hiding,\n+ \/\/ we need to enter the mount path when revealing.\n+ const nextChildSet = nextFiber.child;\n+ if (nextChildSet !== null) {\n+ mountChildrenRecursively(\n+ nextChildSet,\n+ traceNearestHostComponentUpdate,\n+ );\n+ updateFlags |= ShouldResetChildren | ShouldResetSuspenseChildren;\n+ }\n } else if (\n nextFiber.tag === SuspenseComponent &&\n OffscreenComponent !== -1 &&\n","parents":["24f215ce8b0e17a230fbb7317919a6ae0c324f35"],"body":""}

dillon1000/react

Files changed