dillon1000/react

Commit

fix getSnapshot warning when a selector returns NaN (#23333)

* fix getSnapshot warning when a selector returns NaN

useSyncExternalStoreWithSelector delegate a selector as
getSnapshot of useSyncExternalStore.

* Fiber's use sync external store has a same issue

* Small nits

We use Object.is to check whether the snapshot value has been updated,
so we should also use it to check whether the value is cached.

Co-authored-by: Andrew Clark <[email protected]>
Browse files
OGURA Daiki authored 4de99b3ca689e8f995f90f199cd8d7bfb4b35eca Parent 40eaa22
Changed paths4 files
First-parent comparison
M packages/react-reconciler/src/ReactFiberHooks.new.js ModifiedM packages/react-reconciler/src/ReactFiberHooks.old.js ModifiedM packages/use-sync-external-store/src/__tests__/useSyncExternalStoreShared-test.js ModifiedM packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…