{"commit":{"authorName":"Ben Newman","subject":"Fix some odd spacing inconsistencies in ReactRenderDocument-test.","revision":"4f57515f918d519bbd7894d88ea606de4ec07884","authoredAt":"2014-01-06T21:12:32-08:00","authorEmail":"benjamn@fb.com","shortRevision":"4f57515f91"},"parents":["59bd45d594ab3773b23d110b69d1f089cc2c7bbb"],"files":[{"path":"src\/core\/__tests__\/ReactRenderDocument-test.js","status":"M"},{"path":"src\/dom\/components\/createFullPageComponent.js","status":"M"}],"patch":"diff --git a\/src\/core\/__tests__\/ReactRenderDocument-test.js b\/src\/core\/__tests__\/ReactRenderDocument-test.js\nindex 2c7b6b16ad..350c0356b7 100644\n--- a\/src\/core\/__tests__\/ReactRenderDocument-test.js\n+++ b\/src\/core\/__tests__\/ReactRenderDocument-test.js\n@@ -28,6 +28,13 @@ var getTestDocument;\n \n var testDocument;\n \n+var UNMOUNT_INVARIANT_MESSAGE =\n+ 'Invariant Violation: ReactFullPageComponenthtml tried to unmount. ' +\n+ 'Because of cross-browser quirks it is impossible to unmount some ' +\n+ 'top-level components (eg , , and ) reliably and ' +\n+ 'efficiently. To fix this, have a single top-level component that ' +\n+ 'never unmounts render these elements.';\n+\n describe('rendering React components at document', function() {\n beforeEach(function() {\n require('mock-modules').dumpCache();\n@@ -92,13 +99,8 @@ describe('rendering React components at document', function() {\n \n expect(function() {\n React.unmountComponentAtNode(testDocument);\n- }).toThrow(\n- 'Invariant Violation: ReactFullPageComponenthtml tried to unmount. ' +\n- 'Because of cross-browser quirks it is impossible to unmount some ' +\n- 'top-level components (eg , , and ) reliably ' +\n- 'and efficiently. To fix this, have a single top-level component ' +\n- 'that never unmounts render these elements.'\n- );\n+ }).toThrow(UNMOUNT_INVARIANT_MESSAGE);\n+\n expect(testDocument.body.innerHTML).toBe(' Hello world ');\n });\n });\n@@ -146,17 +148,10 @@ describe('rendering React components at document', function() {\n \/\/ Reactive update\n expect(function() {\n React.renderComponent(, testDocument);\n- }).toThrow(\n- 'Invariant Violation: ReactFullPageComponenthtml tried to unmount. ' +\n- 'Because of cross-browser quirks it is impossible to unmount some ' +\n- 'top-level components (eg , , and ) reliably ' +\n- 'and efficiently. To fix this, have a single top-level component ' +\n- 'that never unmounts render these elements.'\n- );\n+ }).toThrow(UNMOUNT_INVARIANT_MESSAGE);\n \n expect(testDocument.body.innerHTML).toBe(' Hello world ');\n });\n-\n });\n \n it('should be able to mount into document', function() {\ndiff --git a\/src\/dom\/components\/createFullPageComponent.js b\/src\/dom\/components\/createFullPageComponent.js\nindex 87bebf6fa3..34ebd688c2 100644\n--- a\/src\/dom\/components\/createFullPageComponent.js\n+++ b\/src\/dom\/components\/createFullPageComponent.js\n@@ -46,7 +46,7 @@ function createFullPageComponent(componentClass) {\n false,\n '%s tried to unmount. Because of cross-browser quirks it is ' +\n 'impossible to unmount some top-level components (eg , , ' +\n- ' and ) reliably and efficiently. To fix this, have a single ' +\n+ 'and ) reliably and efficiently. To fix this, have a single ' +\n 'top-level component that never unmounts render these elements.',\n this.constructor.displayName\n );\n","body":""}

dillon1000/react

Files changed