dillon1000/react

Commit

Refactor Error Dialog Logging (#18487)

* Remove unnecessary CapturedError fields.

componentName is not necessary and is misleading when the error is caused
elsewhere in the stack. The stack is sufficient.

The many error boundary fields are unnecessary because they can be inferred
by the boundary itself.

* Don't attempt to build a stack twice

If it was possible, it would've been done in createCapturedValue.

* Push the work needed by the works into the forks

This avoids needing this in the npm published case.
Browse files
Changed paths7 files
First-parent comparison
M packages/react-reconciler/src/ReactCapturedValue.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-reconciler/src/ReactFiberErrorDialog.js ModifiedM packages/react-reconciler/src/ReactFiberErrorLogger.js ModifiedM packages/react-reconciler/src/ReactFiberThrow.js ModifiedM packages/react-reconciler/src/forks/ReactFiberErrorDialog.native.js ModifiedM packages/react-reconciler/src/forks/ReactFiberErrorDialog.www.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…