{"parents":["36d15d58628baf5e15624a52febae873a7a56345"],"body":"","files":[{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseyCommitPhase-test.js","status":"M"},{"path":"packages\/shared\/ReactFeatureFlags.js","status":"M"}],"patch":"diff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseyCommitPhase-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseyCommitPhase-test.js\nindex 4dbba1bca2..2b5707b8c5 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseyCommitPhase-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseyCommitPhase-test.js\n@@ -491,4 +491,46 @@ describe('ReactSuspenseyCommitPhase', () => {\n <\/>,\n );\n });\n+\n+ \/\/ FIXME: Should pass with `enableYieldingBeforePassive`\n+ \/\/ @gate !enableYieldingBeforePassive\n+ it('runs passive effects after suspended commit resolves', async () => {\n+ function Effect() {\n+ React.useEffect(() => {\n+ Scheduler.log('flush effect');\n+ });\n+ return ;\n+ }\n+\n+ const root = ReactNoop.createRoot();\n+\n+ await act(() => {\n+ root.render(\n+ }>\n+ \n+ \n+ <\/Suspense>,\n+ );\n+ });\n+\n+ assertLog([\n+ 'render effect',\n+ 'Image requested [A]',\n+ 'Loading...',\n+ 'render effect',\n+ ]);\n+ expect(root).toMatchRenderedOutput('Loading...');\n+\n+ await act(() => {\n+ resolveSuspenseyThing('A');\n+ });\n+\n+ assertLog(['flush effect']);\n+ expect(root).toMatchRenderedOutput(\n+ <>\n+ {'render effect'}\n+ \n+ <\/>,\n+ );\n+ });\n });\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex 3046f8f4cb..0720ab2a88 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -78,7 +78,8 @@ export const enableLegacyFBSupport = false;\n \/\/ -----------------------------------------------------------------------------\n \n \/\/ Yield to the browser event loop and not just the scheduler event loop before passive effects.\n-export const enableYieldingBeforePassive = __EXPERIMENTAL__;\n+\/\/ Fix gated tests that fail with this flag enabled before turning it back on.\n+export const enableYieldingBeforePassive = false;\n \n export const enableLegacyCache = __EXPERIMENTAL__;\n \n","commit":{"subject":"Turn off `enableYieldingBeforePassive` (#31857)","shortRevision":"518d06d26a","revision":"518d06d26a97df6d4f5b04e529e5018ad35ea936","authoredAt":"2024-12-19T20:43:01+01:00","authorName":"Sebastian \"Sebbie\" Silbermann","authorEmail":"sebastian.silbermann@vercel.com"}}

dillon1000/react

Files changed