{"parents":["e373190faf3b994707f09488c1a7832f4a91e15a"],"files":[{"path":"packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/client\/ReactFiberConfigDOM.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/events\/DOMPluginEventSystem.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/events\/ReactDOMEventReplaying.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/server\/fizz-instruction-set\/ReactDOMFizzInstructionSetExternalRuntime.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/shared\/ReactDOMFormActions.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMFizzForm-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/react-dom-server-rendering-stub-test.js","status":"M"},{"path":"packages\/react-dom\/src\/client\/ReactDOMRoot.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberBeginWork.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberHooks.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberHostContext.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberNewContext.js","status":"M"},{"path":"packages\/react-server-dom-turbopack\/src\/__tests__\/ReactFlightTurbopackDOMForm-test.js","status":"M"},{"path":"packages\/react-server-dom-webpack\/src\/__tests__\/ReactFlightDOMForm-test.js","status":"M"},{"path":"packages\/react-server\/src\/ReactFizzHooks.js","status":"M"},{"path":"packages\/react\/src\/ReactHooks.js","status":"M"},{"path":"packages\/shared\/ReactFeatureFlags.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.www.js","status":"M"}],"body":"Cleanup enableFormActions flag","commit":{"revision":"527ed72bfd9f5c0045da468ad01db968a9961ad7","shortRevision":"527ed72bfd","authorName":"Jan Kassens","authorEmail":"jkassens@meta.com","authoredAt":"2024-03-25T13:25:14-04:00","subject":"Cleanup enableFormActions flag (#28614)"},"patch":"diff --git a\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js b\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js\nindex 8dbdc99197..0d87dbd81a 100644\n--- a\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js\n+++ b\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js\n@@ -2672,7 +2672,7 @@ describe('ReactHooksInspectionIntegration', () => {\n `);\n });\n \n- \/\/ @gate enableFormActions && enableAsyncActions\n+ \/\/ @gate enableAsyncActions\n it('should support useFormState hook', async () => {\n function Foo() {\n const [value] = ReactDOM.useFormState(function increment(n) {\ndiff --git a\/packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js b\/packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js\nindex bd071b4fd1..7071f32b75 100644\n--- a\/packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js\n+++ b\/packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js\n@@ -69,7 +69,6 @@ import {\n enableBigIntSupport,\n enableCustomElementPropertySupport,\n enableClientRenderFallbackOnTextMismatch,\n- enableFormActions,\n disableIEWorkarounds,\n enableTrustedTypesIntegration,\n enableFilterEmptyStringAttributesDOM,\n@@ -498,71 +497,54 @@ function setProp(\n if (__DEV__) {\n validateFormActionInDevelopment(tag, key, value, props);\n }\n- if (enableFormActions) {\n- if (typeof value === 'function') {\n- \/\/ Set a javascript URL that doesn't do anything. We don't expect this to be invoked\n- \/\/ because we'll preventDefault, but it can happen if a form is manually submitted or\n- \/\/ if someone calls stopPropagation before React gets the event.\n- \/\/ If CSP is used to block javascript: URLs that's fine too. It just won't show this\n- \/\/ error message but the URL will be logged.\n- domElement.setAttribute(\n- key,\n- \/\/ eslint-disable-next-line no-script-url\n- \"javascript:throw new Error('\" +\n- 'A React form was unexpectedly submitted. If you called form.submit() manually, ' +\n- \"consider using form.requestSubmit() instead. If you\\\\'re trying to use \" +\n- 'event.stopPropagation() in a submit event handler, consider also calling ' +\n- 'event.preventDefault().' +\n- \"')\",\n- );\n- break;\n- } else if (typeof prevValue === 'function') {\n- \/\/ When we're switching off a Server Action that was originally hydrated.\n- \/\/ The server control these fields during SSR that are now trailing.\n- \/\/ The regular diffing doesn't apply since we compare against the previous props.\n- \/\/ Instead, we need to force them to be set to whatever they should be now.\n- \/\/ This would be a lot cleaner if we did this whole fork in the per-tag approach.\n- if (key === 'formAction') {\n- if (tag !== 'input') {\n- \/\/ Setting the name here isn't completely safe for inputs if this is switching\n- \/\/ to become a radio button. In that case we let the tag based override take\n- \/\/ control.\n- setProp(domElement, tag, 'name', props.name, props, null);\n- }\n- setProp(\n- domElement,\n- tag,\n- 'formEncType',\n- props.formEncType,\n- props,\n- null,\n- );\n- setProp(\n- domElement,\n- tag,\n- 'formMethod',\n- props.formMethod,\n- props,\n- null,\n- );\n- setProp(\n- domElement,\n- tag,\n- 'formTarget',\n- props.formTarget,\n- props,\n- null,\n- );\n- } else {\n- setProp(domElement, tag, 'encType', props.encType, props, null);\n- setProp(domElement, tag, 'method', props.method, props, null);\n- setProp(domElement, tag, 'target', props.target, props, null);\n+ if (typeof value === 'function') {\n+ \/\/ Set a javascript URL that doesn't do anything. We don't expect this to be invoked\n+ \/\/ because we'll preventDefault, but it can happen if a form is manually submitted or\n+ \/\/ if someone calls stopPropagation before React gets the event.\n+ \/\/ If CSP is used to block javascript: URLs that's fine too. It just won't show this\n+ \/\/ error message but the URL will be logged.\n+ domElement.setAttribute(\n+ key,\n+ \/\/ eslint-disable-next-line no-script-url\n+ \"javascript:throw new Error('\" +\n+ 'A React form was unexpectedly submitted. If you called form.submit() manually, ' +\n+ \"consider using form.requestSubmit() instead. If you\\\\'re trying to use \" +\n+ 'event.stopPropagation() in a submit event handler, consider also calling ' +\n+ 'event.preventDefault().' +\n+ \"')\",\n+ );\n+ break;\n+ } else if (typeof prevValue === 'function') {\n+ \/\/ When we're switching off a Server Action that was originally hydrated.\n+ \/\/ The server control these fields during SSR that are now trailing.\n+ \/\/ The regular diffing doesn't apply since we compare against the previous props.\n+ \/\/ Instead, we need to force them to be set to whatever they should be now.\n+ \/\/ This would be a lot cleaner if we did this whole fork in the per-tag approach.\n+ if (key === 'formAction') {\n+ if (tag !== 'input') {\n+ \/\/ Setting the name here isn't completely safe for inputs if this is switching\n+ \/\/ to become a radio button. In that case we let the tag based override take\n+ \/\/ control.\n+ setProp(domElement, tag, 'name', props.name, props, null);\n }\n+ setProp(\n+ domElement,\n+ tag,\n+ 'formEncType',\n+ props.formEncType,\n+ props,\n+ null,\n+ );\n+ setProp(domElement, tag, 'formMethod', props.formMethod, props, null);\n+ setProp(domElement, tag, 'formTarget', props.formTarget, props, null);\n+ } else {\n+ setProp(domElement, tag, 'encType', props.encType, props, null);\n+ setProp(domElement, tag, 'method', props.method, props, null);\n+ setProp(domElement, tag, 'target', props.target, props, null);\n }\n }\n if (\n value == null ||\n- (!enableFormActions && typeof value === 'function') ||\n typeof value === 'symbol' ||\n typeof value === 'boolean'\n ) {\n@@ -2435,35 +2417,33 @@ function diffHydratedGenericElement(\n );\n continue;\n case 'action':\n- case 'formAction':\n- if (enableFormActions) {\n- const serverValue = domElement.getAttribute(propKey);\n- if (typeof value === 'function') {\n- extraAttributes.delete(propKey.toLowerCase());\n- \/\/ The server can set these extra properties to implement actions.\n- \/\/ So we remove them from the extra attributes warnings.\n- if (propKey === 'formAction') {\n- extraAttributes.delete('name');\n- extraAttributes.delete('formenctype');\n- extraAttributes.delete('formmethod');\n- extraAttributes.delete('formtarget');\n- } else {\n- extraAttributes.delete('enctype');\n- extraAttributes.delete('method');\n- extraAttributes.delete('target');\n- }\n- \/\/ Ideally we should be able to warn if the server value was not a function\n- \/\/ however since the function can return any of these attributes any way it\n- \/\/ wants as a custom progressive enhancement, there's nothing to compare to.\n- \/\/ We can check if the function has the $FORM_ACTION property on the client\n- \/\/ and if it's not, warn, but that's an unnecessary constraint that they\n- \/\/ have to have the extra extension that doesn't do anything on the client.\n- continue;\n- } else if (serverValue === EXPECTED_FORM_ACTION_URL) {\n- extraAttributes.delete(propKey.toLowerCase());\n- warnForPropDifference(propKey, 'function', value);\n- continue;\n+ case 'formAction': {\n+ const serverValue = domElement.getAttribute(propKey);\n+ if (typeof value === 'function') {\n+ extraAttributes.delete(propKey.toLowerCase());\n+ \/\/ The server can set these extra properties to implement actions.\n+ \/\/ So we remove them from the extra attributes warnings.\n+ if (propKey === 'formAction') {\n+ extraAttributes.delete('name');\n+ extraAttributes.delete('formenctype');\n+ extraAttributes.delete('formmethod');\n+ extraAttributes.delete('formtarget');\n+ } else {\n+ extraAttributes.delete('enctype');\n+ extraAttributes.delete('method');\n+ extraAttributes.delete('target');\n }\n+ \/\/ Ideally we should be able to warn if the server value was not a function\n+ \/\/ however since the function can return any of these attributes any way it\n+ \/\/ wants as a custom progressive enhancement, there's nothing to compare to.\n+ \/\/ We can check if the function has the $FORM_ACTION property on the client\n+ \/\/ and if it's not, warn, but that's an unnecessary constraint that they\n+ \/\/ have to have the extra extension that doesn't do anything on the client.\n+ continue;\n+ } else if (serverValue === EXPECTED_FORM_ACTION_URL) {\n+ extraAttributes.delete(propKey.toLowerCase());\n+ warnForPropDifference(propKey, 'function', value);\n+ continue;\n }\n hydrateSanitizedAttribute(\n domElement,\n@@ -2473,6 +2453,7 @@ function diffHydratedGenericElement(\n extraAttributes,\n );\n continue;\n+ }\n case 'xlinkHref':\n hydrateSanitizedAttribute(\n domElement,\ndiff --git a\/packages\/react-dom-bindings\/src\/client\/ReactFiberConfigDOM.js b\/packages\/react-dom-bindings\/src\/client\/ReactFiberConfigDOM.js\nindex 213d80c350..450038eb70 100644\n--- a\/packages\/react-dom-bindings\/src\/client\/ReactFiberConfigDOM.js\n+++ b\/packages\/react-dom-bindings\/src\/client\/ReactFiberConfigDOM.js\n@@ -92,7 +92,6 @@ import {\n enableCreateEventHandleAPI,\n enableScopeAPI,\n enableTrustedTypesIntegration,\n- enableFormActions,\n enableAsyncActions,\n } from 'shared\/ReactFeatureFlags';\n import {\n@@ -1040,11 +1039,7 @@ export function canHydrateInstance(\n if (element.nodeName.toLowerCase() !== type.toLowerCase()) {\n if (!inRootOrSingleton) {\n \/\/ Usually we error for mismatched tags.\n- if (\n- enableFormActions &&\n- element.nodeName === 'INPUT' &&\n- (element: any).type === 'hidden'\n- ) {\n+ if (element.nodeName === 'INPUT' && (element: any).type === 'hidden') {\n \/\/ If we have extra hidden inputs, we don't mismatch. This allows us to embed\n \/\/ extra form data in the original form.\n } else {\n@@ -1054,11 +1049,7 @@ export function canHydrateInstance(\n \/\/ In root or singleton parents we skip past mismatched instances.\n } else if (!inRootOrSingleton) {\n \/\/ Match\n- if (\n- enableFormActions &&\n- type === 'input' &&\n- (element: any).type === 'hidden'\n- ) {\n+ if (type === 'input' && (element: any).type === 'hidden') {\n if (__DEV__) {\n checkAttributeStringCoercion(anyProps.name, 'name');\n }\n@@ -1190,7 +1181,6 @@ export function canHydrateTextInstance(\n \n while (instance.nodeType !== TEXT_NODE) {\n if (\n- enableFormActions &&\n instance.nodeType === ELEMENT_NODE &&\n instance.nodeName === 'INPUT' &&\n (instance: any).type === 'hidden'\n@@ -1316,8 +1306,7 @@ function getNextHydratable(node: ?Node) {\n nodeData === SUSPENSE_START_DATA ||\n nodeData === SUSPENSE_FALLBACK_START_DATA ||\n nodeData === SUSPENSE_PENDING_START_DATA ||\n- (enableFormActions &&\n- enableAsyncActions &&\n+ (enableAsyncActions &&\n (nodeData === FORM_STATE_IS_MATCHING ||\n nodeData === FORM_STATE_IS_NOT_MATCHING))\n ) {\n@@ -1512,9 +1501,7 @@ export function commitHydratedSuspenseInstance(\n export function shouldDeleteUnhydratedTailInstances(\n parentType: string,\n ): boolean {\n- return (\n- !enableFormActions || (parentType !== 'form' && parentType !== 'button')\n- );\n+ return parentType !== 'form' && parentType !== 'button';\n }\n \n export function didNotMatchHydratedContainerTextInstance(\ndiff --git a\/packages\/react-dom-bindings\/src\/events\/DOMPluginEventSystem.js b\/packages\/react-dom-bindings\/src\/events\/DOMPluginEventSystem.js\nindex 6386168268..f26ad48559 100644\n--- a\/packages\/react-dom-bindings\/src\/events\/DOMPluginEventSystem.js\n+++ b\/packages\/react-dom-bindings\/src\/events\/DOMPluginEventSystem.js\n@@ -52,7 +52,6 @@ import {\n enableLegacyFBSupport,\n enableCreateEventHandleAPI,\n enableScopeAPI,\n- enableFormActions,\n } from 'shared\/ReactFeatureFlags';\n import {createEventListenerWrapperWithPriority} from '.\/ReactDOMEventListener';\n import {\n@@ -169,17 +168,15 @@ function extractEvents(\n eventSystemFlags,\n targetContainer,\n );\n- if (enableFormActions) {\n- FormActionEventPlugin.extractEvents(\n- dispatchQueue,\n- domEventName,\n- targetInst,\n- nativeEvent,\n- nativeEventTarget,\n- eventSystemFlags,\n- targetContainer,\n- );\n- }\n+ FormActionEventPlugin.extractEvents(\n+ dispatchQueue,\n+ domEventName,\n+ targetInst,\n+ nativeEvent,\n+ nativeEventTarget,\n+ eventSystemFlags,\n+ targetContainer,\n+ );\n }\n }\n \ndiff --git a\/packages\/react-dom-bindings\/src\/events\/ReactDOMEventReplaying.js b\/packages\/react-dom-bindings\/src\/events\/ReactDOMEventReplaying.js\nindex 59c2920778..5a3e6919cb 100644\n--- a\/packages\/react-dom-bindings\/src\/events\/ReactDOMEventReplaying.js\n+++ b\/packages\/react-dom-bindings\/src\/events\/ReactDOMEventReplaying.js\n@@ -46,7 +46,6 @@ import {\n runWithPriority as attemptHydrationAtPriority,\n getCurrentUpdatePriority,\n } from 'react-reconciler\/src\/ReactEventPriorities';\n-import {enableFormActions} from 'shared\/ReactFeatureFlags';\n \n \/\/ TODO: Upgrade this definition once we're on a newer version of Flow that\n \/\/ has this definition built-in.\n@@ -535,72 +534,70 @@ export function retryIfBlockedOn(\n }\n }\n \n- if (enableFormActions) {\n- \/\/ Check the document if there are any queued form actions.\n- \/\/ If there's no ownerDocument, then this is the document.\n- const root = unblocked.ownerDocument || unblocked;\n- const formReplayingQueue: void | FormReplayingQueue = (root: any)\n- .$$reactFormReplay;\n- if (formReplayingQueue != null) {\n- for (let i = 0; i < formReplayingQueue.length; i += 3) {\n- const form: HTMLFormElement = formReplayingQueue[i];\n- const submitterOrAction:\n- | null\n- | HTMLInputElement\n- | HTMLButtonElement\n- | FormAction = formReplayingQueue[i + 1];\n- const formProps = getFiberCurrentPropsFromNode(form);\n- if (typeof submitterOrAction === 'function') {\n- \/\/ This action has already resolved. We're just waiting to dispatch it.\n- if (!formProps) {\n- \/\/ This was not part of this React instance. It might have been recently\n- \/\/ unblocking us from dispatching our events. So let's make sure we schedule\n- \/\/ a retry.\n- scheduleReplayQueueIfNeeded(formReplayingQueue);\n- }\n- continue;\n+ \/\/ Check the document if there are any queued form actions.\n+ \/\/ If there's no ownerDocument, then this is the document.\n+ const root = unblocked.ownerDocument || unblocked;\n+ const formReplayingQueue: void | FormReplayingQueue = (root: any)\n+ .$$reactFormReplay;\n+ if (formReplayingQueue != null) {\n+ for (let i = 0; i < formReplayingQueue.length; i += 3) {\n+ const form: HTMLFormElement = formReplayingQueue[i];\n+ const submitterOrAction:\n+ | null\n+ | HTMLInputElement\n+ | HTMLButtonElement\n+ | FormAction = formReplayingQueue[i + 1];\n+ const formProps = getFiberCurrentPropsFromNode(form);\n+ if (typeof submitterOrAction === 'function') {\n+ \/\/ This action has already resolved. We're just waiting to dispatch it.\n+ if (!formProps) {\n+ \/\/ This was not part of this React instance. It might have been recently\n+ \/\/ unblocking us from dispatching our events. So let's make sure we schedule\n+ \/\/ a retry.\n+ scheduleReplayQueueIfNeeded(formReplayingQueue);\n }\n- let target: Node = form;\n- if (formProps) {\n- \/\/ This form belongs to this React instance but the submitter might\n- \/\/ not be done yet.\n- let action: null | FormAction = null;\n- const submitter = submitterOrAction;\n- if (submitter && submitter.hasAttribute('formAction')) {\n- \/\/ The submitter is the one that is responsible for the action.\n- target = submitter;\n- const submitterProps = getFiberCurrentPropsFromNode(submitter);\n- if (submitterProps) {\n- \/\/ The submitter is part of this instance.\n- action = (submitterProps: any).formAction;\n- } else {\n- const blockedOn = findInstanceBlockingTarget(target);\n- if (blockedOn !== null) {\n- \/\/ The submitter is not hydrated yet. We'll wait for it.\n- continue;\n- }\n- \/\/ The submitter must have been a part of a different React instance.\n- \/\/ Except the form isn't. We don't dispatch actions in this scenario.\n- }\n- } else {\n- action = (formProps: any).action;\n- }\n- if (typeof action === 'function') {\n- formReplayingQueue[i + 1] = action;\n+ continue;\n+ }\n+ let target: Node = form;\n+ if (formProps) {\n+ \/\/ This form belongs to this React instance but the submitter might\n+ \/\/ not be done yet.\n+ let action: null | FormAction = null;\n+ const submitter = submitterOrAction;\n+ if (submitter && submitter.hasAttribute('formAction')) {\n+ \/\/ The submitter is the one that is responsible for the action.\n+ target = submitter;\n+ const submitterProps = getFiberCurrentPropsFromNode(submitter);\n+ if (submitterProps) {\n+ \/\/ The submitter is part of this instance.\n+ action = (submitterProps: any).formAction;\n } else {\n- \/\/ Something went wrong so let's just delete this action.\n- formReplayingQueue.splice(i, 3);\n- i -= 3;\n+ const blockedOn = findInstanceBlockingTarget(target);\n+ if (blockedOn !== null) {\n+ \/\/ The submitter is not hydrated yet. We'll wait for it.\n+ continue;\n+ }\n+ \/\/ The submitter must have been a part of a different React instance.\n+ \/\/ Except the form isn't. We don't dispatch actions in this scenario.\n }\n- \/\/ Schedule a replay in case this unblocked something.\n- scheduleReplayQueueIfNeeded(formReplayingQueue);\n- continue;\n+ } else {\n+ action = (formProps: any).action;\n }\n- \/\/ Something above this target is still blocked so we can't continue yet.\n- \/\/ We're not sure if this target is actually part of this React instance\n- \/\/ yet. It could be a different React as a child but at least some parent is.\n- \/\/ We must continue for any further queued actions.\n+ if (typeof action === 'function') {\n+ formReplayingQueue[i + 1] = action;\n+ } else {\n+ \/\/ Something went wrong so let's just delete this action.\n+ formReplayingQueue.splice(i, 3);\n+ i -= 3;\n+ }\n+ \/\/ Schedule a replay in case this unblocked something.\n+ scheduleReplayQueueIfNeeded(formReplayingQueue);\n+ continue;\n }\n+ \/\/ Something above this target is still blocked so we can't continue yet.\n+ \/\/ We're not sure if this target is actually part of this React instance\n+ \/\/ yet. It could be a different React as a child but at least some parent is.\n+ \/\/ We must continue for any further queued actions.\n }\n }\n }\ndiff --git a\/packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js b\/packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js\nindex 5e96ca9d66..11a7073487 100644\n--- a\/packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js\n+++ b\/packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js\n@@ -31,7 +31,6 @@ import {\n enableBigIntSupport,\n enableFilterEmptyStringAttributesDOM,\n enableCustomElementPropertySupport,\n- enableFormActions,\n enableFizzExternalRuntime,\n enableNewBooleanProps,\n } from 'shared\/ReactFeatureFlags';\n@@ -1087,7 +1086,7 @@ function pushFormActionAttribute(\n name: any,\n ): void | null | FormData {\n let formData = null;\n- if (enableFormActions && typeof formAction === 'function') {\n+ if (typeof formAction === 'function') {\n \/\/ Function form actions cannot control the form properties\n if (__DEV__) {\n if (name !== null && !didWarnFormActionName) {\n@@ -1881,7 +1880,7 @@ function pushStartForm(\n \n let formData = null;\n let formActionName = null;\n- if (enableFormActions && typeof formAction === 'function') {\n+ if (typeof formAction === 'function') {\n \/\/ Function form actions cannot control the form properties\n if (__DEV__) {\n if (\ndiff --git a\/packages\/react-dom-bindings\/src\/server\/fizz-instruction-set\/ReactDOMFizzInstructionSetExternalRuntime.js b\/packages\/react-dom-bindings\/src\/server\/fizz-instruction-set\/ReactDOMFizzInstructionSetExternalRuntime.js\nindex dc5232c8ee..419817b52e 100644\n--- a\/packages\/react-dom-bindings\/src\/server\/fizz-instruction-set\/ReactDOMFizzInstructionSetExternalRuntime.js\n+++ b\/packages\/react-dom-bindings\/src\/server\/fizz-instruction-set\/ReactDOMFizzInstructionSetExternalRuntime.js\n@@ -9,8 +9,6 @@ import {\n listenToFormSubmissionsForReplaying,\n } from '.\/ReactDOMFizzInstructionSetShared';\n \n-import {enableFormActions} from 'shared\/ReactFeatureFlags';\n-\n export {clientRenderBoundary, completeBoundary, completeSegment};\n \n const resourceMap = new Map();\n@@ -140,6 +138,4 @@ export function completeBoundaryWithStyles(\n );\n }\n \n-if (enableFormActions) {\n- listenToFormSubmissionsForReplaying();\n-}\n+listenToFormSubmissionsForReplaying();\ndiff --git a\/packages\/react-dom-bindings\/src\/shared\/ReactDOMFormActions.js b\/packages\/react-dom-bindings\/src\/shared\/ReactDOMFormActions.js\nindex 80d544cd28..284eaff1bb 100644\n--- a\/packages\/react-dom-bindings\/src\/shared\/ReactDOMFormActions.js\n+++ b\/packages\/react-dom-bindings\/src\/shared\/ReactDOMFormActions.js\n@@ -10,7 +10,7 @@\n import type {Dispatcher} from 'react-reconciler\/src\/ReactInternalTypes';\n import type {Awaited} from 'shared\/ReactTypes';\n \n-import {enableAsyncActions, enableFormActions} from 'shared\/ReactFeatureFlags';\n+import {enableAsyncActions} from 'shared\/ReactFeatureFlags';\n import ReactSharedInternals from 'shared\/ReactSharedInternals';\n \n const ReactCurrentDispatcher = ReactSharedInternals.ReactCurrentDispatcher;\n@@ -67,7 +67,7 @@ function resolveDispatcher() {\n }\n \n export function useFormStatus(): FormStatus {\n- if (!(enableFormActions && enableAsyncActions)) {\n+ if (!enableAsyncActions) {\n throw new Error('Not implemented.');\n } else {\n const dispatcher = resolveDispatcher();\n@@ -81,7 +81,7 @@ export function useFormState(\n initialState: Awaited,\n permalink?: string,\n ): [Awaited, (P) => void, boolean] {\n- if (!(enableFormActions && enableAsyncActions)) {\n+ if (!enableAsyncActions) {\n throw new Error('Not implemented.');\n } else {\n const dispatcher = resolveDispatcher();\ndiff --git a\/packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js b\/packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js\nindex 29767d8a65..95551c616d 100644\n--- a\/packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js\n+++ b\/packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js\n@@ -11,7 +11,6 @@ import possibleStandardNames from '.\/possibleStandardNames';\n import hasOwnProperty from 'shared\/hasOwnProperty';\n import {\n enableCustomElementPropertySupport,\n- enableFormActions,\n enableNewBooleanProps,\n } from 'shared\/ReactFeatureFlags';\n \n@@ -42,21 +41,18 @@ function validateProperty(tagName, name, value, eventRegistry) {\n return true;\n }\n \n- if (enableFormActions) {\n- \/\/ Actions are special because unlike events they can have other value types.\n- if (typeof value === 'function') {\n- if (tagName === 'form' && name === 'action') {\n- return true;\n- }\n- if (tagName === 'input' && name === 'formAction') {\n- return true;\n- }\n- if (tagName === 'button' && name === 'formAction') {\n- return true;\n- }\n+ \/\/ Actions are special because unlike events they can have other value types.\n+ if (typeof value === 'function') {\n+ if (tagName === 'form' && name === 'action') {\n+ return true;\n+ }\n+ if (tagName === 'input' && name === 'formAction') {\n+ return true;\n+ }\n+ if (tagName === 'button' && name === 'formAction') {\n+ return true;\n }\n }\n-\n \/\/ We can't rely on the event system being injected on the server.\n if (eventRegistry != null) {\n const {registrationNameDependencies, possibleRegistrationNames} =\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzForm-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzForm-test.js\nindex ad21f230ed..0c4edff51a 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzForm-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzForm-test.js\n@@ -81,7 +81,6 @@ describe('ReactDOMFizzForm', () => {\n insertNodesAndExecuteScripts(temp, container, null);\n }\n \n- \/\/ @gate enableFormActions\n it('should allow passing a function to form action during SSR', async () => {\n const ref = React.createRef();\n let foo;\n@@ -108,7 +107,6 @@ describe('ReactDOMFizzForm', () => {\n expect(foo).toBe('bar');\n });\n \n- \/\/ @gate enableFormActions\n it('should allow passing a function to an input\/button formAction', async () => {\n const inputRef = React.createRef();\n const buttonRef = React.createRef();\n@@ -167,7 +165,6 @@ describe('ReactDOMFizzForm', () => {\n expect(rootActionCalled).toBe(false);\n });\n \n- \/\/ @gate enableFormActions || !__DEV__\n it('should warn when passing a function action during SSR and string during hydration', async () => {\n function action(formData) {}\n function App({isClient}) {\n@@ -189,7 +186,6 @@ describe('ReactDOMFizzForm', () => {\n );\n });\n \n- \/\/ @gate enableFormActions || !__DEV__\n it('should ideally warn when passing a string during SSR and function during hydration', async () => {\n function action(formData) {}\n function App({isClient}) {\n@@ -208,7 +204,6 @@ describe('ReactDOMFizzForm', () => {\n });\n });\n \n- \/\/ @gate enableFormActions || !__DEV__\n it('should reset form fields after you update away from hydrated function', async () => {\n const formRef = React.createRef();\n const inputRef = React.createRef();\n@@ -264,7 +259,6 @@ describe('ReactDOMFizzForm', () => {\n expect(buttonRef.current.hasAttribute('formTarget')).toBe(false);\n });\n \n- \/\/ @gate enableFormActions || !__DEV__\n it('should reset form fields after you remove a hydrated function', async () => {\n const formRef = React.createRef();\n const inputRef = React.createRef();\n@@ -310,7 +304,6 @@ describe('ReactDOMFizzForm', () => {\n expect(buttonRef.current.hasAttribute('formTarget')).toBe(false);\n });\n \n- \/\/ @gate enableFormActions || !__DEV__\n it('should restore the form fields even if they were incorrectly set', async () => {\n const formRef = React.createRef();\n const inputRef = React.createRef();\n@@ -373,7 +366,6 @@ describe('ReactDOMFizzForm', () => {\n expect(buttonRef.current.hasAttribute('formTarget')).toBe(false);\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useFormStatus is not pending during server render', async () => {\n function App() {\n@@ -389,7 +381,6 @@ describe('ReactDOMFizzForm', () => {\n expect(container.textContent).toBe('Pending: false');\n });\n \n- \/\/ @gate enableFormActions\n it('should replay a form action after hydration', async () => {\n let foo;\n function action(formData) {\n@@ -417,7 +408,6 @@ describe('ReactDOMFizzForm', () => {\n expect(foo).toBe('bar');\n });\n \n- \/\/ @gate enableFormActions\n it('should replay input\/button formAction', async () => {\n let rootActionCalled = false;\n let savedTitle = null;\n@@ -477,7 +467,6 @@ describe('ReactDOMFizzForm', () => {\n expect(container.textContent).toBe('hi');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useActionState returns initial state', async () => {\n async function action(state) {\n@@ -499,7 +488,6 @@ describe('ReactDOMFizzForm', () => {\n expect(container.textContent).toBe('0');\n });\n \n- \/\/ @gate enableFormActions\n it('can provide a custom action on the server for actions', async () => {\n const ref = React.createRef();\n let foo;\n@@ -551,7 +539,6 @@ describe('ReactDOMFizzForm', () => {\n expect(foo).toBe('bar');\n });\n \n- \/\/ @gate enableFormActions\n it('can provide a custom action on buttons the server for actions', async () => {\n const hiddenRef = React.createRef();\n const inputRef = React.createRef();\n@@ -631,7 +618,6 @@ describe('ReactDOMFizzForm', () => {\n expect(foo).toBe('bar');\n });\n \n- \/\/ @gate enableFormActions\n it('can hydrate hidden fields in the beginning of a form', async () => {\n const hiddenRef = React.createRef();\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js\nindex 609d24b6fa..06d0c1b93a 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js\n@@ -6139,7 +6139,6 @@ describe('ReactDOMFizzServer', () => {\n expect(getVisibleChildren(container)).toEqual('Hi');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useActionState hydrates without a mismatch', async () => {\n \/\/ This is testing an implementation detail: useActionState emits comment\n@@ -6193,7 +6192,6 @@ describe('ReactDOMFizzServer', () => {\n expect(childRef.current).toBe(child);\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it(\"useActionState hydrates without a mismatch if there's a render phase update\", async () => {\n async function action(state) {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js\nindex 677c18425b..0ebffb2a41 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js\n@@ -189,7 +189,6 @@ describe('ReactDOMForm', () => {\n });\n }\n \n- \/\/ @gate enableFormActions\n it('should allow passing a function to form action', async () => {\n const ref = React.createRef();\n let foo;\n@@ -230,7 +229,6 @@ describe('ReactDOMForm', () => {\n expect(foo).toBe('bar2');\n });\n \n- \/\/ @gate enableFormActions\n it('should allow passing a function to an input\/button formAction', async () => {\n const inputRef = React.createRef();\n const buttonRef = React.createRef();\n@@ -323,7 +321,6 @@ describe('ReactDOMForm', () => {\n expect(rootActionCalled).toBe(false);\n });\n \n- \/\/ @gate enableFormActions || !__DEV__\n it('should allow preventing default to block the action', async () => {\n const ref = React.createRef();\n let actionCalled = false;\n@@ -346,7 +343,6 @@ describe('ReactDOMForm', () => {\n expect(actionCalled).toBe(false);\n });\n \n- \/\/ @gate enableFormActions\n it('should only submit the inner of nested forms', async () => {\n const ref = React.createRef();\n let data;\n@@ -383,7 +379,6 @@ describe('ReactDOMForm', () => {\n expect(data).toBe('innerinner');\n });\n \n- \/\/ @gate enableFormActions\n it('should only submit once if one root is nested inside the other', async () => {\n const ref = React.createRef();\n let outerCalled = 0;\n@@ -427,7 +422,6 @@ describe('ReactDOMForm', () => {\n expect(innerCalled).toBe(1);\n });\n \n- \/\/ @gate enableFormActions\n it('should only submit once if a portal is nested inside its own root', async () => {\n const ref = React.createRef();\n let outerCalled = 0;\n@@ -471,7 +465,6 @@ describe('ReactDOMForm', () => {\n expect(innerCalled).toBe(1);\n });\n \n- \/\/ @gate enableFormActions\n it('can read the clicked button in the formdata event', async () => {\n const inputRef = React.createRef();\n const buttonRef = React.createRef();\n@@ -519,7 +512,6 @@ describe('ReactDOMForm', () => {\n expect(buttonRef.current.getAttribute('type')).toBe(null);\n });\n \n- \/\/ @gate enableFormActions\n it('excludes the submitter name when the submitter is a function action', async () => {\n const inputRef = React.createRef();\n const buttonRef = React.createRef();\n@@ -570,7 +562,6 @@ describe('ReactDOMForm', () => {\n expect(buttonRef.current.getAttribute('type')).toBe(null);\n });\n \n- \/\/ @gate enableFormActions || !__DEV__\n it('allows a non-function formaction to override a function one', async () => {\n const ref = React.createRef();\n let actionCalled = false;\n@@ -602,7 +593,6 @@ describe('ReactDOMForm', () => {\n expect(actionCalled).toBe(false);\n });\n \n- \/\/ @gate enableFormActions || !__DEV__\n it('allows a non-react html formaction to be invoked', async () => {\n let actionCalled = false;\n \n@@ -638,7 +628,6 @@ describe('ReactDOMForm', () => {\n expect(actionCalled).toBe(false);\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('form actions are transitions', async () => {\n const formRef = React.createRef();\n@@ -677,7 +666,6 @@ describe('ReactDOMForm', () => {\n expect(container.textContent).toBe('Updated');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('multiple form actions', async () => {\n const formRef = React.createRef();\n@@ -724,7 +712,6 @@ describe('ReactDOMForm', () => {\n expect(container.textContent).toBe('Count: 2');\n });\n \n- \/\/ @gate enableFormActions\n it('form actions can be asynchronous', async () => {\n const formRef = React.createRef();\n \n@@ -770,7 +757,7 @@ describe('ReactDOMForm', () => {\n });\n \n it('sync errors in form actions can be captured by an error boundary', async () => {\n- if (gate(flags => !(flags.enableFormActions && flags.enableAsyncActions))) {\n+ if (gate(flags => !flags.enableAsyncActions)) {\n \/\/ TODO: Uncaught JSDOM errors fail the test after the scope has finished\n \/\/ so don't work with the `gate` mechanism.\n return;\n@@ -816,7 +803,7 @@ describe('ReactDOMForm', () => {\n });\n \n it('async errors in form actions can be captured by an error boundary', async () => {\n- if (gate(flags => !(flags.enableFormActions && flags.enableAsyncActions))) {\n+ if (gate(flags => !flags.enableAsyncActions)) {\n \/\/ TODO: Uncaught JSDOM errors fail the test after the scope has finished\n \/\/ so don't work with the `gate` mechanism.\n return;\n@@ -867,7 +854,6 @@ describe('ReactDOMForm', () => {\n expect(container.textContent).toBe('Oh no!');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useFormStatus reads the status of a pending form action', async () => {\n const formRef = React.createRef();\n@@ -919,7 +905,6 @@ describe('ReactDOMForm', () => {\n assertLog(['Async action finished', 'No pending action']);\n });\n \n- \/\/ @gate enableFormActions\n it('should error if submitting a form manually', async () => {\n const ref = React.createRef();\n \n@@ -966,7 +951,6 @@ describe('ReactDOMForm', () => {\n );\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('useActionState updates state asynchronously and queues multiple actions', async () => {\n let actionCounter = 0;\n@@ -1027,7 +1011,6 @@ describe('ReactDOMForm', () => {\n expect(container.textContent).toBe('2');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('useActionState supports inline actions', async () => {\n let increment;\n@@ -1060,7 +1043,6 @@ describe('ReactDOMForm', () => {\n assertLog(['Pending 1', '11']);\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('useActionState: dispatch throws if called during render', async () => {\n function App() {\n@@ -1077,7 +1059,6 @@ describe('ReactDOMForm', () => {\n });\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('queues multiple actions and runs them in order', async () => {\n let action;\n@@ -1110,7 +1091,6 @@ describe('ReactDOMForm', () => {\n expect(container.textContent).toBe('D');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('useActionState: works if action is sync', async () => {\n let increment;\n@@ -1143,7 +1123,6 @@ describe('ReactDOMForm', () => {\n assertLog(['Pending 1', '11']);\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('useActionState: can mix sync and async actions', async () => {\n let action;\n@@ -1172,7 +1151,6 @@ describe('ReactDOMForm', () => {\n expect(container.textContent).toBe('E');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('useActionState: error handling (sync action)', async () => {\n let resetErrorBoundary;\n@@ -1237,7 +1215,6 @@ describe('ReactDOMForm', () => {\n expect(container.textContent).toBe('B');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('useActionState: error handling (async action)', async () => {\n let resetErrorBoundary;\n@@ -1302,7 +1279,6 @@ describe('ReactDOMForm', () => {\n expect(container.textContent).toBe('B');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n test('useFormState works in StrictMode', async () => {\n let actionCounter = 0;\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js b\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\nindex 872ef03f38..3ca77a6615 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\n@@ -817,7 +817,6 @@ describe('ReactDOMServerHydration', () => {\n }\n });\n \n- \/\/ @gate enableFormActions\n it('allows rendering extra hidden inputs in a form', async () => {\n const element = document.createElement('div');\n element.innerHTML =\n@@ -854,7 +853,6 @@ describe('ReactDOMServerHydration', () => {\n expect(c.current.value).toBe('C');\n });\n \n- \/\/ @gate enableFormActions\n it('allows rendering extra hidden inputs immediately before a text instance', async () => {\n const element = document.createElement('div');\n element.innerHTML =\ndiff --git a\/packages\/react-dom\/src\/__tests__\/react-dom-server-rendering-stub-test.js b\/packages\/react-dom\/src\/__tests__\/react-dom-server-rendering-stub-test.js\nindex ec3b05e17a..997f87fa30 100644\n--- a\/packages\/react-dom\/src\/__tests__\/react-dom-server-rendering-stub-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/react-dom-server-rendering-stub-test.js\n@@ -82,7 +82,6 @@ describe('react-dom-server-rendering-stub', () => {\n expect(x).toBe(false);\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('exports useFormStatus', async () => {\n function App() {\ndiff --git a\/packages\/react-dom\/src\/client\/ReactDOMRoot.js b\/packages\/react-dom\/src\/client\/ReactDOMRoot.js\nindex 563fd6be1f..f963030c91 100644\n--- a\/packages\/react-dom\/src\/client\/ReactDOMRoot.js\n+++ b\/packages\/react-dom\/src\/client\/ReactDOMRoot.js\n@@ -19,7 +19,6 @@ import {\n allowConcurrentByDefault,\n disableCommentsAsDOMContainers,\n enableAsyncActions,\n- enableFormActions,\n } from 'shared\/ReactFeatureFlags';\n \n export type RootType = {\n@@ -291,7 +290,7 @@ export function hydrateRoot(\n if (options.unstable_transitionCallbacks !== undefined) {\n transitionCallbacks = options.unstable_transitionCallbacks;\n }\n- if (enableAsyncActions && enableFormActions) {\n+ if (enableAsyncActions) {\n if (options.formState !== undefined) {\n formState = options.formState;\n }\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\nindex c2d7e06132..e754e2aef7 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\n@@ -105,7 +105,6 @@ import {\n enableTransitionTracing,\n enableLegacyHidden,\n enableCPUSuspense,\n- enableFormActions,\n enableAsyncActions,\n enablePostpone,\n enableRenderableContext,\n@@ -1543,7 +1542,7 @@ function updateHostComponent(\n workInProgress.flags |= ContentReset;\n }\n \n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n const memoizedState = workInProgress.memoizedState;\n if (memoizedState !== null) {\n \/\/ This fiber has been upgraded to a stateful component. The only way\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberHooks.js b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\nindex dbfb1669aa..011c9eb504 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n@@ -41,7 +41,6 @@ import {\n enableLegacyCache,\n debugRenderPhaseSideEffectsForStrictMode,\n enableAsyncActions,\n- enableFormActions,\n enableUseDeferredValueInitialArg,\n } from 'shared\/ReactFeatureFlags';\n import {\n@@ -811,7 +810,7 @@ export function renderTransitionAwareHostComponentWithHooks(\n workInProgress: Fiber,\n lanes: Lanes,\n ): TransitionStatus {\n- if (!(enableFormActions && enableAsyncActions)) {\n+ if (!enableAsyncActions) {\n throw new Error('Not implemented.');\n }\n return renderWithHooks(\n@@ -825,7 +824,7 @@ export function renderTransitionAwareHostComponentWithHooks(\n }\n \n export function TransitionAwareHostComponent(): TransitionStatus {\n- if (!(enableFormActions && enableAsyncActions)) {\n+ if (!enableAsyncActions) {\n throw new Error('Not implemented.');\n }\n const dispatcher = ReactCurrentDispatcher.current;\n@@ -2964,11 +2963,6 @@ export function startHostTransition(\n callback: F => mixed,\n formData: F,\n ): void {\n- if (!enableFormActions) {\n- \/\/ Not implemented.\n- return;\n- }\n-\n if (!enableAsyncActions) {\n \/\/ Form actions are enabled, but async actions are not. Call the function,\n \/\/ but don't handle any pending or error states.\n@@ -3089,7 +3083,7 @@ function rerenderTransition(): [\n }\n \n function useHostTransitionStatus(): TransitionStatus {\n- if (!(enableFormActions && enableAsyncActions)) {\n+ if (!enableAsyncActions) {\n throw new Error('Not implemented.');\n }\n const status: TransitionStatus | null = readContext(HostTransitionContext);\n@@ -3512,7 +3506,7 @@ if (enableUseMemoCacheHook) {\n if (enableUseEffectEventHook) {\n (ContextOnlyDispatcher: Dispatcher).useEffectEvent = throwInvalidHookError;\n }\n-if (enableFormActions && enableAsyncActions) {\n+if (enableAsyncActions) {\n (ContextOnlyDispatcher: Dispatcher).useHostTransitionStatus =\n throwInvalidHookError;\n (ContextOnlyDispatcher: Dispatcher).useFormState = throwInvalidHookError;\n@@ -3551,7 +3545,7 @@ if (enableUseMemoCacheHook) {\n if (enableUseEffectEventHook) {\n (HooksDispatcherOnMount: Dispatcher).useEffectEvent = mountEvent;\n }\n-if (enableFormActions && enableAsyncActions) {\n+if (enableAsyncActions) {\n (HooksDispatcherOnMount: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (HooksDispatcherOnMount: Dispatcher).useFormState = mountFormState;\n@@ -3590,7 +3584,7 @@ if (enableUseMemoCacheHook) {\n if (enableUseEffectEventHook) {\n (HooksDispatcherOnUpdate: Dispatcher).useEffectEvent = updateEvent;\n }\n-if (enableFormActions && enableAsyncActions) {\n+if (enableAsyncActions) {\n (HooksDispatcherOnUpdate: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (HooksDispatcherOnUpdate: Dispatcher).useFormState = updateFormState;\n@@ -3629,7 +3623,7 @@ if (enableUseMemoCacheHook) {\n if (enableUseEffectEventHook) {\n (HooksDispatcherOnRerender: Dispatcher).useEffectEvent = updateEvent;\n }\n-if (enableFormActions && enableAsyncActions) {\n+if (enableAsyncActions) {\n (HooksDispatcherOnRerender: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (HooksDispatcherOnRerender: Dispatcher).useFormState = rerenderFormState;\n@@ -3815,7 +3809,7 @@ if (__DEV__) {\n return mountEvent(callback);\n };\n }\n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n (HooksDispatcherOnMountInDEV: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (HooksDispatcherOnMountInDEV: Dispatcher).useFormState =\n@@ -3995,7 +3989,7 @@ if (__DEV__) {\n return mountEvent(callback);\n };\n }\n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n (HooksDispatcherOnMountWithHookTypesInDEV: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (HooksDispatcherOnMountWithHookTypesInDEV: Dispatcher).useFormState =\n@@ -4177,7 +4171,7 @@ if (__DEV__) {\n return updateEvent(callback);\n };\n }\n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n (HooksDispatcherOnUpdateInDEV: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (HooksDispatcherOnUpdateInDEV: Dispatcher).useFormState =\n@@ -4359,7 +4353,7 @@ if (__DEV__) {\n return updateEvent(callback);\n };\n }\n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n (HooksDispatcherOnRerenderInDEV: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (HooksDispatcherOnRerenderInDEV: Dispatcher).useFormState =\n@@ -4562,7 +4556,7 @@ if (__DEV__) {\n return mountEvent(callback);\n };\n }\n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n (InvalidNestedHooksDispatcherOnMountInDEV: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (InvalidNestedHooksDispatcherOnMountInDEV: Dispatcher).useFormState =\n@@ -4771,7 +4765,7 @@ if (__DEV__) {\n return updateEvent(callback);\n };\n }\n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n (InvalidNestedHooksDispatcherOnUpdateInDEV: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (InvalidNestedHooksDispatcherOnUpdateInDEV: Dispatcher).useFormState =\n@@ -4980,7 +4974,7 @@ if (__DEV__) {\n return updateEvent(callback);\n };\n }\n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n (InvalidNestedHooksDispatcherOnRerenderInDEV: Dispatcher).useHostTransitionStatus =\n useHostTransitionStatus;\n (InvalidNestedHooksDispatcherOnRerenderInDEV: Dispatcher).useFormState =\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberHostContext.js b\/packages\/react-reconciler\/src\/ReactFiberHostContext.js\nindex 0b64be766a..f930799f56 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHostContext.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHostContext.js\n@@ -24,7 +24,7 @@ import {\n } from '.\/ReactFiberConfig';\n import {createCursor, push, pop} from '.\/ReactFiberStack';\n import {REACT_CONTEXT_TYPE} from 'shared\/ReactSymbols';\n-import {enableAsyncActions, enableFormActions} from 'shared\/ReactFeatureFlags';\n+import {enableAsyncActions} from 'shared\/ReactFeatureFlags';\n \n const contextStackCursor: StackCursor = createCursor(null);\n const contextFiberStackCursor: StackCursor = createCursor(null);\n@@ -110,7 +110,7 @@ function getHostContext(): HostContext {\n }\n \n function pushHostContext(fiber: Fiber): void {\n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n const stateHook: Hook | null = fiber.memoizedState;\n if (stateHook !== null) {\n \/\/ Only provide context if this fiber has been upgraded by a host\n@@ -139,7 +139,7 @@ function popHostContext(fiber: Fiber): void {\n pop(contextFiberStackCursor, fiber);\n }\n \n- if (enableFormActions && enableAsyncActions) {\n+ if (enableAsyncActions) {\n if (hostTransitionProviderCursor.current === fiber) {\n \/\/ Do not pop unless this Fiber provided the current context. This is mostly\n \/\/ a performance optimization, but conveniently it also prevents a potential\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberNewContext.js b\/packages\/react-reconciler\/src\/ReactFiberNewContext.js\nindex cb9ada3dee..c19e056b0a 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberNewContext.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberNewContext.js\n@@ -44,7 +44,6 @@ import {createUpdate, ForceUpdate} from '.\/ReactFiberClassUpdateQueue';\n import {markWorkInProgressReceivedUpdate} from '.\/ReactFiberBeginWork';\n import {\n enableLazyContextPropagation,\n- enableFormActions,\n enableAsyncActions,\n enableRenderableContext,\n } from 'shared\/ReactFeatureFlags';\n@@ -582,11 +581,7 @@ function propagateParentContextChanges(\n }\n }\n }\n- } else if (\n- enableFormActions &&\n- enableAsyncActions &&\n- parent === getHostTransitionProvider()\n- ) {\n+ } else if (enableAsyncActions && parent === getHostTransitionProvider()) {\n \/\/ During a host transition, a host component can act like a context\n \/\/ provider. E.g. in React DOM, this would be a
.\n const currentParent = parent.alternate;\ndiff --git a\/packages\/react-server-dom-turbopack\/src\/__tests__\/ReactFlightTurbopackDOMForm-test.js b\/packages\/react-server-dom-turbopack\/src\/__tests__\/ReactFlightTurbopackDOMForm-test.js\nindex 3f63222d0a..e7da697fad 100644\n--- a\/packages\/react-server-dom-turbopack\/src\/__tests__\/ReactFlightTurbopackDOMForm-test.js\n+++ b\/packages\/react-server-dom-turbopack\/src\/__tests__\/ReactFlightTurbopackDOMForm-test.js\n@@ -111,7 +111,6 @@ describe('ReactFlightDOMForm', () => {\n insertNodesAndExecuteScripts(temp, container, null);\n }\n \n- \/\/ @gate enableFormActions\n it('can submit a passed server action without hydrating it', async () => {\n let foo = null;\n \ndiff --git a\/packages\/react-server-dom-webpack\/src\/__tests__\/ReactFlightDOMForm-test.js b\/packages\/react-server-dom-webpack\/src\/__tests__\/ReactFlightDOMForm-test.js\nindex e8da630d4e..c958aacbea 100644\n--- a\/packages\/react-server-dom-webpack\/src\/__tests__\/ReactFlightDOMForm-test.js\n+++ b\/packages\/react-server-dom-webpack\/src\/__tests__\/ReactFlightDOMForm-test.js\n@@ -133,7 +133,6 @@ describe('ReactFlightDOMForm', () => {\n insertNodesAndExecuteScripts(temp, container, null);\n }\n \n- \/\/ @gate enableFormActions\n it('can submit a passed server action without hydrating it', async () => {\n let foo = null;\n \n@@ -168,7 +167,6 @@ describe('ReactFlightDOMForm', () => {\n expect(foo).toBe('bar');\n });\n \n- \/\/ @gate enableFormActions\n it('can submit an imported server action without hydrating it', async () => {\n let foo = null;\n \n@@ -201,7 +199,6 @@ describe('ReactFlightDOMForm', () => {\n expect(foo).toBe('bar');\n });\n \n- \/\/ @gate enableFormActions\n it('can submit a complex closure server action without hydrating it', async () => {\n let foo = null;\n \n@@ -236,7 +233,6 @@ describe('ReactFlightDOMForm', () => {\n expect(foo).toBe('barobject');\n });\n \n- \/\/ @gate enableFormActions\n it('can submit a multiple complex closure server action without hydrating it', async () => {\n let foo = null;\n \n@@ -277,7 +273,6 @@ describe('ReactFlightDOMForm', () => {\n expect(foo).toBe('barc');\n });\n \n- \/\/ @gate enableFormActions\n it('can bind an imported server action on the client without hydrating it', async () => {\n let foo = null;\n \n@@ -309,7 +304,6 @@ describe('ReactFlightDOMForm', () => {\n expect(foo).toBe('barobject');\n });\n \n- \/\/ @gate enableFormActions\n it('can bind a server action on the client without hydrating it', async () => {\n let foo = null;\n \n@@ -350,7 +344,6 @@ describe('ReactFlightDOMForm', () => {\n expect(foo).toBe('barobject');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it(\"useActionState's dispatch binds the initial state to the provided action\", async () => {\n const serverAction = serverExports(\n@@ -399,7 +392,6 @@ describe('ReactFlightDOMForm', () => {\n expect(await returnValue).toEqual({count: 6});\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useActionState can reuse state during MPA form submission', async () => {\n const serverAction = serverExports(\n@@ -489,7 +481,6 @@ describe('ReactFlightDOMForm', () => {\n }\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it(\n 'useActionState preserves state if arity is the same, but different ' +\n@@ -609,7 +600,6 @@ describe('ReactFlightDOMForm', () => {\n },\n );\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useActionState does not reuse state if action signatures are different', async () => {\n \/\/ This is the same as the previous test, except instead of using bind to\n@@ -697,7 +687,6 @@ describe('ReactFlightDOMForm', () => {\n expect(container.textContent).toBe('111');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('when permalink is provided, useActionState compares that instead of the keypath', async () => {\n const serverAction = serverExports(\n@@ -804,7 +793,6 @@ describe('ReactFlightDOMForm', () => {\n expect(container.textContent).toBe('1');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useActionState can change the action URL with the `permalink` argument', async () => {\n const serverAction = serverExports(function action(prevState) {\n@@ -850,7 +838,6 @@ describe('ReactFlightDOMForm', () => {\n expect(form.action).toBe('http:\/\/localhost\/permalink');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useActionState `permalink` is coerced to string', async () => {\n const serverAction = serverExports(function action(prevState) {\n@@ -904,7 +891,6 @@ describe('ReactFlightDOMForm', () => {\n expect(form.action).toBe('http:\/\/localhost\/permalink');\n });\n \n- \/\/ @gate enableFormActions\n \/\/ @gate enableAsyncActions\n it('useFormState can return JSX state during MPA form submission', async () => {\n const serverAction = serverExports(\ndiff --git a\/packages\/react-server\/src\/ReactFizzHooks.js b\/packages\/react-server\/src\/ReactFizzHooks.js\nindex 1f3e632d31..3870b699b2 100644\n--- a\/packages\/react-server\/src\/ReactFizzHooks.js\n+++ b\/packages\/react-server\/src\/ReactFizzHooks.js\n@@ -35,7 +35,6 @@ import {\n enableUseEffectEventHook,\n enableUseMemoCacheHook,\n enableAsyncActions,\n- enableFormActions,\n enableUseDeferredValueInitialArg,\n } from 'shared\/ReactFeatureFlags';\n import is from 'shared\/objectIs';\n@@ -814,7 +813,7 @@ if (enableUseEffectEventHook) {\n if (enableUseMemoCacheHook) {\n HooksDispatcher.useMemoCache = useMemoCache;\n }\n-if (enableFormActions && enableAsyncActions) {\n+if (enableAsyncActions) {\n HooksDispatcher.useHostTransitionStatus = useHostTransitionStatus;\n }\n if (enableAsyncActions) {\ndiff --git a\/packages\/react\/src\/ReactHooks.js b\/packages\/react\/src\/ReactHooks.js\nindex 227584698a..fada4c9c8c 100644\n--- a\/packages\/react\/src\/ReactHooks.js\n+++ b\/packages\/react\/src\/ReactHooks.js\n@@ -18,7 +18,7 @@ import {REACT_CONSUMER_TYPE} from 'shared\/ReactSymbols';\n \n import ReactCurrentDispatcher from '.\/ReactCurrentDispatcher';\n import ReactCurrentCache from '.\/ReactCurrentCache';\n-import {enableAsyncActions, enableFormActions} from 'shared\/ReactFeatureFlags';\n+import {enableAsyncActions} from 'shared\/ReactFeatureFlags';\n \n type BasicStateAction = (S => S) | S;\n type Dispatch = A => void;\n@@ -235,7 +235,7 @@ export function useActionState(\n initialState: Awaited,\n permalink?: string,\n ): [Awaited, (P) => void, boolean] {\n- if (!(enableFormActions && enableAsyncActions)) {\n+ if (!enableAsyncActions) {\n throw new Error('Not implemented.');\n } else {\n const dispatcher = resolveDispatcher();\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex cd6273a229..0f77667e5b 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -31,7 +31,6 @@ export const enableComponentStackLocations = true;\n \n \/\/ TODO: Finish rolling out in www\n export const enableClientRenderFallbackOnTextMismatch = true;\n-export const enableFormActions = true;\n export const enableAsyncActions = true;\n \n \/\/ Need to remove didTimeout argument from Scheduler before landing\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex 444d956e8d..e8fb123513 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -46,7 +46,6 @@ export const enableCache = true;\n export const enableLegacyCache = false;\n export const enableCacheElement = true;\n export const enableFetchInstrumentation = false;\n-export const enableFormActions = true; \/\/ Doesn't affect Native\n export const enableBinaryFlight = true;\n export const enableTaint = true;\n export const enablePostpone = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex 8e992b805f..14ccfc88ef 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -54,7 +54,6 @@ export const enableTaint = __NEXT_RN_MAJOR__;\n export const enableUnifiedSyncLane = __NEXT_RN_MAJOR__;\n export const enableFizzExternalRuntime = __NEXT_RN_MAJOR__; \/\/ DOM-only\n export const disableJavaScriptURLs = __NEXT_RN_MAJOR__; \/\/ DOM-only\n-export const enableFormActions = __NEXT_RN_MAJOR__; \/\/ DOM-only\n export const enableBinaryFlight = __NEXT_RN_MAJOR__; \/\/ DOM-only\n export const enableCustomElementPropertySupport = __NEXT_RN_MAJOR__; \/\/ DOM-only\n export const enableServerComponentKeys = __NEXT_RN_MAJOR__;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex 819554d5cf..26866114ae 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -22,7 +22,6 @@ export const enableCache = true;\n export const enableLegacyCache = __EXPERIMENTAL__;\n export const enableCacheElement = __EXPERIMENTAL__;\n export const enableFetchInstrumentation = true;\n-export const enableFormActions = true; \/\/ Doesn't affect Test Renderer\n export const enableBinaryFlight = true;\n export const enableTaint = true;\n export const enablePostpone = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\nindex 01fc8ab188..c9eda11db0 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n@@ -22,7 +22,6 @@ export const enableCache = true;\n export const enableLegacyCache = false;\n export const enableCacheElement = true;\n export const enableFetchInstrumentation = false;\n-export const enableFormActions = true; \/\/ Doesn't affect Test Renderer\n export const enableBinaryFlight = true;\n export const enableTaint = true;\n export const enablePostpone = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex ba307873ce..c3ff077cb0 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -22,7 +22,6 @@ export const enableCache = true;\n export const enableLegacyCache = true;\n export const enableCacheElement = true;\n export const enableFetchInstrumentation = false;\n-export const enableFormActions = true; \/\/ Doesn't affect Test Renderer\n export const enableBinaryFlight = true;\n export const enableTaint = true;\n export const enablePostpone = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex 698cc86366..d0a2642418 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -59,7 +59,6 @@ export const enableCPUSuspense = true;\n export const enableUseMemoCacheHook = true;\n export const enableUseEffectEventHook = true;\n export const enableFilterEmptyStringAttributesDOM = true;\n-export const enableFormActions = true;\n export const enableAsyncActions = true;\n \n \/\/ Logs additional User Timing API marks for use with an experimental profiling tool.\n"}

dillon1000/react

Files changed