dillon1000/react

Commit

Disable console.logs in the second render pass of DEV mode double render (#18547)

* Disable console log during the second rerender

* Use the disabled log to avoid double yielding values in scheduler mock

* Reenable debugRenderPhaseSideEffectsForStrictMode in tests that can
Browse files
Sebastian Markbåge authored 5474a83e258b497584bed9df95de1d554bc53f89 Parent b225d4f
Changed paths43 files
First-parent comparison
M packages/create-subscription/src/__tests__/createSubscription-test.internal.js ModifiedM packages/react-art/src/__tests__/ReactART-test.js ModifiedM packages/react-cache/src/__tests__/ReactCache-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerSelectiveHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactTestUtilsAct-test.js ModifiedM packages/react-dom/src/__tests__/ReactUpdates-test.js ModifiedM packages/react-dom/src/events/__tests__/DOMModernPluginEventSystem-test.internal.js ModifiedM packages/react-dom/src/events/__tests__/DeprecatedDOMEventResponderSystem-test.internal.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.js ModifiedM packages/react-reconciler/src/ReactUpdateQueue.js ModifiedM packages/react-reconciler/src/__tests__/ErrorBoundaryReconciliation-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactBatchedMode-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactDisableSchedulerTimeoutBasedOnReactExpirationTime-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactExpiration-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorLogging-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalReflection-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalSideEffects-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactMemo-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactNewContext-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSchedulerIntegration-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseFuzz-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseList-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspensePlaceholder-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactTransition-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/useMutableSource-test.internal.js ModifiedM packages/react-test-renderer/src/__tests__/ReactTestRendererAsync-test.internal.js ModifiedM packages/react/src/__tests__/ReactDOMTracing-test.internal.js ModifiedM packages/react/src/__tests__/ReactProfiler-test.internal.js ModifiedM packages/react/src/__tests__/ReactProfilerDOM-test.internal.js ModifiedM packages/react/src/__tests__/ReactProfilerDevToolsIntegration-test.internal.js ModifiedM packages/react/src/__tests__/forwardRef-test.internal.js ModifiedM packages/scheduler/src/forks/SchedulerHostConfig.mock.js ModifiedA packages/shared/ConsolePatchingDev.js AddedM packages/use-subscription/src/__tests__/useSubscription-test.internal.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…