dillon1000/react

Commit

Inline some internals, reduce shared/ utilities between isomorphic and renderers (#9903)

* Make ReactControlledValuePropTypes DEV-only

* Remove canDefineProperty

This breaks IE8. We don't support it.

* Remove getNextDebugID

It was added temporarily to avoid Stack shared state issues across renderers.
Not a problem anymore.

* Make KeyEscapeUtils.unescape() DEV-only

* Remove unused deprecated() module

It's unlikely we'll deprecate anything else on React.* object soon.

* Inline getIteratorFn at the call sites

* Inline ReactElementSymbol

* Inline KeyEscapeUtils into Children and move the file into Stack

It's only used in one place in isomorphic.
It's used more broadly in Stack so we move it there to die.

* Update artifacts

* Reorder declarations for consistency

* Fix Flow
Browse files
Changed paths22 files
First-parent comparison
M scripts/fiber/tests-passing.txt ModifiedM scripts/rollup/results.json ModifiedM src/isomorphic/children/__tests__/ReactChildren-test.js ModifiedM src/isomorphic/children/flattenChildren.js ModifiedM src/isomorphic/children/traverseAllChildren.js ModifiedM src/isomorphic/classic/element/ReactElement.js ModifiedM src/isomorphic/classic/element/ReactElementValidator.js ModifiedM src/isomorphic/modern/class/ReactBaseClasses.js ModifiedM src/renderers/dom/shared/utils/ReactControlledValuePropTypes.js ModifiedM src/renderers/shared/fiber/ReactChildFiber.js ModifiedR src/shared/utils/KeyEscapeUtils.js →src/renderers/shared/stack/reconciler/KeyEscapeUtils.js RenamedM src/renderers/shared/stack/reconciler/ReactChildReconciler.js ModifiedM src/renderers/shared/stack/reconciler/flattenStackChildren.js ModifiedM src/renderers/shared/stack/reconciler/instantiateReactComponent.js ModifiedM src/renderers/shared/stack/reconciler/traverseStackChildren.js ModifiedD src/shared/types/ReactPropTypesSecret.js DeletedD src/shared/utils/ReactElementSymbol.js DeletedD src/shared/utils/__tests__/KeyEscapeUtils-test.js DeletedD src/shared/utils/canDefineProperty.js DeletedD src/shared/utils/deprecated.js DeletedD src/shared/utils/getIteratorFn.js DeletedD src/shared/utils/getNextDebugID.js Deleted
Patch

Files changed

Rendering syntax-highlighted changes…