{"files":[{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiber.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberHooks.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberWorkLoop.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactTypeOfMode.js"},{"status":"M","path":"packages\/react-reconciler\/src\/__tests__\/ActivityStrictMode-test.js"},{"status":"M","path":"packages\/react\/src\/__tests__\/ReactStrictMode-test.internal.js"},{"status":"M","path":"packages\/shared\/ReactFeatureFlags.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www.js"}],"commit":{"revision":"5d24c64cc9c019fc644c4c6f0da640131b80ba18","shortRevision":"5d24c64cc9","authorName":"Jan Kassens","authorEmail":"jkassens@meta.com","subject":"Remove feature flag enableDO_NOT_USE_disableStrictPassiveEffect (#33524)","authoredAt":"2025-06-16T12:22:47-04:00"},"patch":"diff --git a\/packages\/react-reconciler\/src\/ReactFiber.js b\/packages\/react-reconciler\/src\/ReactFiber.js\nindex 65feabd8c0..996bc72603 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiber.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiber.js\n@@ -40,7 +40,6 @@ import {\n enableScopeAPI,\n enableLegacyHidden,\n enableTransitionTracing,\n- enableDO_NOT_USE_disableStrictPassiveEffect,\n disableLegacyMode,\n enableObjectFiber,\n enableViewTransition,\n@@ -92,7 +91,6 @@ import {\n ProfileMode,\n StrictLegacyMode,\n StrictEffectsMode,\n- NoStrictPassiveEffectsMode,\n SuspenseyImagesMode,\n } from '.\/ReactTypeOfMode';\n import {\n@@ -599,12 +597,6 @@ export function createFiberFromTypeAndProps(\n if (disableLegacyMode || (mode & ConcurrentMode) !== NoMode) {\n \/\/ Strict effects should never run on legacy roots\n mode |= StrictEffectsMode;\n- if (\n- enableDO_NOT_USE_disableStrictPassiveEffect &&\n- pendingProps.DO_NOT_USE_disableStrictPassiveEffect\n- ) {\n- mode |= NoStrictPassiveEffectsMode;\n- }\n }\n break;\n case REACT_PROFILER_TYPE:\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberHooks.js b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\nindex 1740ee0a86..63332124e2 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n@@ -55,7 +55,6 @@ import {\n ConcurrentMode,\n StrictEffectsMode,\n StrictLegacyMode,\n- NoStrictPassiveEffectsMode,\n } from '.\/ReactTypeOfMode';\n import {\n NoLane,\n@@ -2672,8 +2671,7 @@ function mountEffect(\n ): void {\n if (\n __DEV__ &&\n- (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode &&\n- (currentlyRenderingFiber.mode & NoStrictPassiveEffectsMode) === NoMode\n+ (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode\n ) {\n mountEffectImpl(\n MountPassiveDevEffect | PassiveEffect | PassiveStaticEffect,\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.js b\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.js\nindex fd74620975..813633656e 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.js\n@@ -123,7 +123,6 @@ import {\n ConcurrentMode,\n StrictLegacyMode,\n StrictEffectsMode,\n- NoStrictPassiveEffectsMode,\n } from '.\/ReactTypeOfMode';\n import {\n HostRoot,\n@@ -4607,21 +4606,13 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(\n }\n \n \/\/ Unconditionally disconnects and connects passive and layout effects.\n-function doubleInvokeEffectsOnFiber(\n- root: FiberRoot,\n- fiber: Fiber,\n- shouldDoubleInvokePassiveEffects: boolean = true,\n-) {\n+function doubleInvokeEffectsOnFiber(root: FiberRoot, fiber: Fiber) {\n setIsStrictModeForDevtools(true);\n try {\n disappearLayoutEffects(fiber);\n- if (shouldDoubleInvokePassiveEffects) {\n- disconnectPassiveEffect(fiber);\n- }\n+ disconnectPassiveEffect(fiber);\n reappearLayoutEffects(root, fiber.alternate, fiber, false);\n- if (shouldDoubleInvokePassiveEffects) {\n- reconnectPassiveEffects(root, fiber, NoLanes, null, false, 0);\n- }\n+ reconnectPassiveEffects(root, fiber, NoLanes, null, false, 0);\n } finally {\n setIsStrictModeForDevtools(false);\n }\n@@ -4640,13 +4631,7 @@ function doubleInvokeEffectsInDEVIfNecessary(\n if (fiber.tag !== OffscreenComponent) {\n if (fiber.flags & PlacementDEV) {\n if (isInStrictMode) {\n- runWithFiberInDEV(\n- fiber,\n- doubleInvokeEffectsOnFiber,\n- root,\n- fiber,\n- (fiber.mode & NoStrictPassiveEffectsMode) === NoMode,\n- );\n+ runWithFiberInDEV(fiber, doubleInvokeEffectsOnFiber, root, fiber);\n }\n } else {\n recursivelyTraverseAndDoubleInvokeEffectsInDEV(\ndiff --git a\/packages\/react-reconciler\/src\/ReactTypeOfMode.js b\/packages\/react-reconciler\/src\/ReactTypeOfMode.js\nindex 4348fe2668..22d0a7c6d1 100644\n--- a\/packages\/react-reconciler\/src\/ReactTypeOfMode.js\n+++ b\/packages\/react-reconciler\/src\/ReactTypeOfMode.js\n@@ -16,7 +16,6 @@ export const ProfileMode = \/* *\/ 0b0000010;\n \/\/export const DebugTracingMode = \/* *\/ 0b0000100; \/\/ Removed\n export const StrictLegacyMode = \/* *\/ 0b0001000;\n export const StrictEffectsMode = \/* *\/ 0b0010000;\n-export const NoStrictPassiveEffectsMode = \/* *\/ 0b1000000;\n \/\/ Keep track of if we're in a SuspenseyImages eligible subtree.\n \/\/ TODO: Remove this when enableSuspenseyImages ship where it's always on.\n export const SuspenseyImagesMode = \/* *\/ 0b0100000;\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ActivityStrictMode-test.js b\/packages\/react-reconciler\/src\/__tests__\/ActivityStrictMode-test.js\nindex 78947437f6..de8adc7ce3 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ActivityStrictMode-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ActivityStrictMode-test.js\n@@ -55,28 +55,6 @@ describe('Activity StrictMode', () => {\n ]);\n });\n \n- \/\/ @gate __DEV__ && enableActivity && enableDO_NOT_USE_disableStrictPassiveEffect\n- it('does not trigger strict effects when disableStrictPassiveEffect is presented on StrictMode', async () => {\n- await act(() => {\n- ReactNoop.render(\n- \n- \n- \n- <\/Activity>\n- <\/React.StrictMode>,\n- );\n- });\n-\n- expect(log).toEqual([\n- 'A: render',\n- 'A: render',\n- 'A: useLayoutEffect mount',\n- 'A: useEffect mount',\n- 'A: useLayoutEffect unmount',\n- 'A: useLayoutEffect mount',\n- ]);\n- });\n-\n \/\/ @gate __DEV__ && enableActivity\n it('should not trigger strict effects when offscreen is hidden', async () => {\n await act(() => {\ndiff --git a\/packages\/react\/src\/__tests__\/ReactStrictMode-test.internal.js b\/packages\/react\/src\/__tests__\/ReactStrictMode-test.internal.js\nindex 2867e06483..28ac8a9974 100644\n--- a\/packages\/react\/src\/__tests__\/ReactStrictMode-test.internal.js\n+++ b\/packages\/react\/src\/__tests__\/ReactStrictMode-test.internal.js\n@@ -104,52 +104,6 @@ describe('ReactStrictMode', () => {\n ]);\n });\n \n- \/\/ @gate enableDO_NOT_USE_disableStrictPassiveEffect\n- it('should include legacy + strict effects mode, but not strict passive effect with disableStrictPassiveEffect', async () => {\n- await act(() => {\n- const container = document.createElement('div');\n- const root = ReactDOMClient.createRoot(container);\n- root.render(\n- \n- \n- <\/React.StrictMode>,\n- );\n- });\n-\n- expect(log).toEqual([\n- 'A: render',\n- 'A: render',\n- 'A: useLayoutEffect mount',\n- 'A: useEffect mount',\n- 'A: useLayoutEffect unmount',\n- 'A: useLayoutEffect mount',\n- ]);\n- });\n-\n- \/\/ @gate enableDO_NOT_USE_disableStrictPassiveEffect\n- it('should include legacy + strict effects mode, but not strict passive effect with disableStrictPassiveEffect in Suspense', async () => {\n- await act(() => {\n- const container = document.createElement('div');\n- const root = ReactDOMClient.createRoot(container);\n- root.render(\n- \n- \n- \n- <\/React.Suspense>\n- <\/React.StrictMode>,\n- );\n- });\n-\n- expect(log).toEqual([\n- 'A: render',\n- 'A: render',\n- 'A: useLayoutEffect mount',\n- 'A: useEffect mount',\n- 'A: useLayoutEffect unmount',\n- 'A: useLayoutEffect mount',\n- ]);\n- });\n-\n it('should allow level to be increased with nesting', async () => {\n await act(() => {\n const container = document.createElement('div');\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex a1ea476b56..a56cc2582e 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -260,7 +260,4 @@ export const enableAsyncDebugInfo = __EXPERIMENTAL__;\n \/\/ Track which Fiber(s) schedule render work.\n export const enableUpdaterTracking = __PROFILE__;\n \n-\/\/ Internal only.\n-export const enableDO_NOT_USE_disableStrictPassiveEffect = false;\n-\n export const ownerStackLimit = 1e4;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex 3dd11f4af4..c0eea7ee4c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -44,7 +44,6 @@ export const enableAsyncDebugInfo = false;\n export const enableAsyncIterableChildren = false;\n export const enableCPUSuspense = true;\n export const enableCreateEventHandleAPI = false;\n-export const enableDO_NOT_USE_disableStrictPassiveEffect = false;\n export const enableMoveBefore = true;\n export const enableFizzExternalRuntime = true;\n export const enableHalt = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex b1978f05a1..6893a3215b 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -29,7 +29,6 @@ export const enableAsyncDebugInfo = false;\n export const enableAsyncIterableChildren = false;\n export const enableCPUSuspense = false;\n export const enableCreateEventHandleAPI = false;\n-export const enableDO_NOT_USE_disableStrictPassiveEffect = false;\n export const enableMoveBefore = true;\n export const enableFizzExternalRuntime = true;\n export const enableHalt = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex 4a49fb7316..c0a909ba5c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -49,7 +49,6 @@ export const enableLegacyHidden = false;\n \n export const enableTransitionTracing = false;\n \n-export const enableDO_NOT_USE_disableStrictPassiveEffect = false;\n export const enableFizzExternalRuntime = true;\n \n export const alwaysThrottleRetries = true;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\nindex c001a68557..51c6239dcd 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\n@@ -24,7 +24,6 @@ export const enableAsyncDebugInfo = false;\n export const enableAsyncIterableChildren = false;\n export const enableCPUSuspense = true;\n export const enableCreateEventHandleAPI = false;\n-export const enableDO_NOT_USE_disableStrictPassiveEffect = false;\n export const enableMoveBefore = false;\n export const enableFizzExternalRuntime = true;\n export const enableHalt = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex f58e154d02..209fbd4b8c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -50,7 +50,6 @@ export const enableLegacyHidden = false;\n \n export const enableTransitionTracing = false;\n \n-export const enableDO_NOT_USE_disableStrictPassiveEffect = false;\n export const enableFizzExternalRuntime = false;\n \n export const alwaysThrottleRetries = true;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js b\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\nindex 263d7ca048..eeccf763ca 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\n@@ -17,7 +17,6 @@ export const alwaysThrottleRetries = __VARIANT__;\n export const disableDefaultPropsExceptForClasses = __VARIANT__;\n export const disableLegacyContextForFunctionComponents = __VARIANT__;\n export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;\n-export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;\n export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;\n export const enableNoCloningMemoCache = __VARIANT__;\n export const enableObjectFiber = __VARIANT__;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex 807e86da2b..29bb652fd7 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -19,7 +19,6 @@ export const {\n disableDefaultPropsExceptForClasses,\n disableLegacyContextForFunctionComponents,\n disableSchedulerTimeoutInWorkLoop,\n- enableDO_NOT_USE_disableStrictPassiveEffect,\n enableHiddenSubtreeInsertionEffectCleanup,\n enableInfiniteRenderLoopDetection,\n enableNoCloningMemoCache,\n","body":"","parents":["6b7e207cabe4c1bc9390d862dd9228e94e9edf4b"]}

dillon1000/react

Files changed