{"body":"","parents":["4ba0e95a96507abbcb2819be328fc3d1ed3cc80f"],"patch":"diff --git a\/src\/test\/ReactDefaultPerf.js b\/src\/test\/ReactDefaultPerf.js\nindex 7fdc6e518e..f7de7934f2 100644\n--- a\/src\/test\/ReactDefaultPerf.js\n+++ b\/src\/test\/ReactDefaultPerf.js\n@@ -205,6 +205,9 @@ var ReactDefaultPerf = {\n var id = args[0];\n if (moduleName === 'EventPluginHub') {\n id = id._rootNodeID;\n+ } else if (fnName === 'replaceNodeWithMarkup') {\n+ \/\/ Old node is already unmounted; can't get its instance\n+ id = ReactDOMComponentTree.getInstanceFromNode(args[1].node)._rootNodeID;\n } else if (typeof id === 'object') {\n id = ReactDOMComponentTree.getInstanceFromNode(args[0])._rootNodeID;\n }\ndiff --git a\/src\/test\/__tests__\/ReactDefaultPerf-test.js b\/src\/test\/__tests__\/ReactDefaultPerf-test.js\nindex 9eb3867a9e..f04f9bebaf 100644\n--- a\/src\/test\/__tests__\/ReactDefaultPerf-test.js\n+++ b\/src\/test\/__tests__\/ReactDefaultPerf-test.js\n@@ -36,13 +36,13 @@ describe('ReactDefaultPerf', function() {\n \n App = React.createClass({\n render: function() {\n- return

<\/div>;\n+ return

<\/div>;\n },\n });\n \n Box = React.createClass({\n render: function() {\n- return

<\/div>;\n+ return

<\/div>;\n },\n });\n \n@@ -84,6 +84,28 @@ describe('ReactDefaultPerf', function() {\n \/*eslint-enable dot-notation *\/\n });\n \n+ it('should count no-op update in child as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(, container);\n+\n+ \/\/ Here, we add a Box -- two of the updates are wasted time (but the\n+ \/\/ addition of the third is not)\n+ var measurements = measure(() => {\n+ ReactDOM.render(, container);\n+ });\n+\n+ var summary = ReactDefaultPerf.getMeasurementsSummaryMap(measurements);\n+ expect(summary.length).toBe(1);\n+\n+ \/*eslint-disable dot-notation *\/\n+\n+ expect(summary[0]['Owner > component']).toBe('App > Box');\n+ expect(summary[0]['Wasted time (ms)']).not.toBe(0);\n+ expect(summary[0]['Instances']).toBe(1);\n+\n+ \/*eslint-enable dot-notation *\/\n+ });\n+\n function expectNoWaste(fn) {\n var measurements = measure(fn);\n var summary = ReactDefaultPerf.getMeasurementsSummaryMap(measurements);\n","files":[{"path":"src\/test\/ReactDefaultPerf.js","status":"M"},{"path":"src\/test\/__tests__\/ReactDefaultPerf-test.js","status":"M"}],"commit":{"revision":"5d94d7d43c1804db4e6de2a89036fa63cea3a518","shortRevision":"5d94d7d43c","authorName":"Ben Alpert","authorEmail":"balpert@fb.com","authoredAt":"2015-10-18T14:21:07-07:00","subject":"Perf: Static children count for wasted time"}}

dillon1000/react

Files changed