dillon1000/react
Commit
Browse files Console Logging for StrictMode Double Rendering (#22030)
React currently suppress console logs in StrictMode during double rendering. However, this causes a lot of confusion. This PR moves the console suppression logic from React into React Devtools. Now by default, we no longer suppress console logs. Instead, we gray out the logs in console during double render. We also add a setting in React Devtools to allow developers to hide console logs during double render if they choose.
Changed paths49 files
First-parent comparisonpackages/react-devtools-core/src/standalone.js ModifiedM packages/react-devtools-core/webpack.backend.js ModifiedM packages/react-devtools-core/webpack.standalone.js ModifiedM packages/react-devtools-extensions/src/injectGlobalHook.js ModifiedM packages/react-devtools-extensions/src/main.js ModifiedM packages/react-devtools-extensions/src/utils.js ModifiedM packages/react-devtools-extensions/utils.js ModifiedM packages/react-devtools-extensions/webpack.backend.js ModifiedM packages/react-devtools-extensions/webpack.config.js ModifiedM packages/react-devtools-inline/README.md ModifiedM packages/react-devtools-inline/src/backend.js ModifiedM packages/react-devtools-inline/src/frontend.js ModifiedM packages/react-devtools-inline/webpack.config.js ModifiedM packages/react-devtools-shared/src/__tests__/console-test.js ModifiedM packages/react-devtools-shared/src/__tests__/setupEnv.js ModifiedM packages/react-devtools-shared/src/backend/agent.js ModifiedM packages/react-devtools-shared/src/backend/console.js ModifiedM packages/react-devtools-shared/src/backend/renderer.js ModifiedM packages/react-devtools-shared/src/backend/types.js ModifiedM packages/react-devtools-shared/src/backend/utils.js ModifiedM packages/react-devtools-shared/src/bridge.js ModifiedM packages/react-devtools-shared/src/constants.js ModifiedM packages/react-devtools-shared/src/devtools/views/Settings/DebuggingSettings.js ModifiedM packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js ModifiedM packages/react-devtools-shared/src/devtools/views/Settings/SettingsShared.css ModifiedM packages/react-devtools-shared/src/hook.js ModifiedM packages/react-devtools-shared/src/utils.js ModifiedM packages/react-devtools-shell/src/app/console.js ModifiedM packages/react-devtools-shell/src/app/index.js ModifiedM packages/react-devtools-shell/src/devtools.js ModifiedM packages/react-devtools-shell/webpack.config.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.new.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.old.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.new.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.old.js ModifiedM packages/react-reconciler/src/ReactFiberHooks.new.js ModifiedM packages/react-reconciler/src/ReactFiberHooks.old.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.new.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.old.js ModifiedM packages/react-reconciler/src/ReactUpdateQueue.new.js ModifiedM packages/react-reconciler/src/ReactUpdateQueue.old.js ModifiedM packages/react-reconciler/src/Scheduler.js ModifiedM packages/react/src/__tests__/ReactStrictMode-test.js ModifiedM packages/scheduler/src/forks/SchedulerMock.js ModifiedM packages/shared/consoleWithStackDev.js ModifiedM packages/shared/forks/Scheduler.umd.js ModifiedM packages/shared/forks/consoleWithStackDev.www.js ModifiedM scripts/flow/react-devtools.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…