{"commit":{"shortRevision":"6294b67a40","authorName":"Brian Vaughn","revision":"6294b67a406d21cc6b65162e47497c1e8afe398f","authoredAt":"2018-03-29T12:51:34-07:00","authorEmail":"brian.david.vaughn@gmail.com","subject":"unstable_createRoot (#12487)"},"parents":["8650d2a1357985958c2738da55ea349406482721"],"body":"* Removed enableCreateRoot flag. Renamed createRoot to unstable_createRoot\r\n\r\n* ReactDOMRoot test is no longer internal","files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js"},{"status":"R089","path":"packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.js","previousPath":"packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.internal.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOM.js"},{"status":"M","path":"packages\/react-dom\/src\/events\/__tests__\/ChangeEventPlugin-test.internal.js"},{"status":"M","path":"packages\/react-dom\/src\/events\/__tests__\/SimpleEventPlugin-test.internal.js"},{"status":"M","path":"packages\/shared\/ReactFeatureFlags.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-fabric.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.persistent.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js\nindex 465c6e15b0..e0c256d4a3 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js\n@@ -68,12 +68,11 @@ describe('ReactDOMFiberAsync', () => {\n ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n container = document.createElement('div');\n ReactFeatureFlags.debugRenderPhaseSideEffectsForStrictMode = false;\n- ReactFeatureFlags.enableCreateRoot = true;\n ReactDOM = require('react-dom');\n });\n \n it('createRoot makes the entire tree async', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n root.render(

Hi<\/div>);\n expect(container.textContent).toEqual('');\n jest.runAllTimers();\n@@ -95,7 +94,7 @@ describe('ReactDOMFiberAsync', () => {\n }\n }\n \n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n root.render();\n expect(container.textContent).toEqual('');\n jest.runAllTimers();\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.js\nsimilarity index 89%\nrename from packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.internal.js\nrename to packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.js\nindex 0ece449718..f7cd755b66 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMRoot-test.js\n@@ -66,7 +66,6 @@ describe('ReactDOMRoot', () => {\n };\n \n jest.resetModules();\n- require('shared\/ReactFeatureFlags').enableCreateRoot = true;\n React = require('react');\n ReactDOM = require('react-dom');\n ReactDOMServer = require('react-dom\/server');\n@@ -74,14 +73,14 @@ describe('ReactDOMRoot', () => {\n });\n \n it('renders children', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n root.render(

Hi<\/div>);\n flush();\n expect(container.textContent).toEqual('Hi');\n });\n \n it('unmounts children', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n root.render(

Hi<\/div>);\n flush();\n expect(container.textContent).toEqual('Hi');\n@@ -91,7 +90,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('`root.render` returns a thenable work object', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const work = root.render(Hi<\/AsyncMode>);\n let ops = [];\n work.then(() => {\n@@ -109,7 +108,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('resolves `work.then` callback synchronously if the work already committed', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const work = root.render(Hi<\/AsyncMode>);\n flush();\n let ops = [];\n@@ -133,7 +132,7 @@ describe('ReactDOMRoot', () => {\n \/\/ Does not hydrate by default\n const container1 = document.createElement('div');\n container1.innerHTML = markup;\n- const root1 = ReactDOM.createRoot(container1);\n+ const root1 = ReactDOM.unstable_createRoot(container1);\n root1.render(\n

\n \n@@ -144,7 +143,7 @@ describe('ReactDOMRoot', () => {\n \/\/ Accepts `hydrate` option\n const container2 = document.createElement('div');\n container2.innerHTML = markup;\n- const root2 = ReactDOM.createRoot(container2, {hydrate: true});\n+ const root2 = ReactDOM.unstable_createRoot(container2, {hydrate: true});\n root2.render(\n

\n \n@@ -155,7 +154,7 @@ describe('ReactDOMRoot', () => {\n \n it('does not clear existing children', async () => {\n container.innerHTML = '

a<\/div>

b<\/div>';\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n root.render(\n

\n c<\/span>\n@@ -175,7 +174,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('can defer a commit by batching it', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch = root.createBatch();\n batch.render(

Hi<\/div>);\n \/\/ Hasn't committed yet\n@@ -198,7 +197,7 @@ describe('ReactDOMRoot', () => {\n }\n }\n \n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch = root.createBatch();\n batch.render(\n \n@@ -231,7 +230,7 @@ describe('ReactDOMRoot', () => {\n ops.push('Foo');\n return props.children;\n }\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch = root.createBatch();\n batch.render(Hi<\/Foo>);\n \/\/ Flush all async work.\n@@ -249,7 +248,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('can wait for a batch to finish', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch = root.createBatch();\n batch.render(Foo<\/AsyncMode>);\n \n@@ -271,7 +270,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('`batch.render` returns a thenable work object', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch = root.createBatch();\n const work = batch.render('Hi');\n let ops = [];\n@@ -290,7 +289,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('can commit an empty batch', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n root.render(1<\/AsyncMode>);\n \n expire(2000);\n@@ -307,7 +306,7 @@ describe('ReactDOMRoot', () => {\n \n it('two batches created simultaneously are committed separately', () => {\n \/\/ (In other words, they have distinct expiration times)\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch1 = root.createBatch();\n batch1.render(1);\n const batch2 = root.createBatch();\n@@ -323,7 +322,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('commits an earlier batch without committing a later batch', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch1 = root.createBatch();\n batch1.render(1);\n \n@@ -342,7 +341,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('commits a later batch without committing an earlier batch', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch1 = root.createBatch();\n batch1.render(1);\n \n@@ -362,7 +361,7 @@ describe('ReactDOMRoot', () => {\n });\n \n it('handles fatal errors triggered by batch.commit()', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n const batch = root.createBatch();\n const InvalidType = undefined;\n expect(() => batch.render()).toWarnDev([\ndiff --git a\/packages\/react-dom\/src\/client\/ReactDOM.js b\/packages\/react-dom\/src\/client\/ReactDOM.js\nindex a06dca184d..8a03d03a8b 100644\n--- a\/packages\/react-dom\/src\/client\/ReactDOM.js\n+++ b\/packages\/react-dom\/src\/client\/ReactDOM.js\n@@ -28,7 +28,6 @@ import * as EventPluginHub from 'events\/EventPluginHub';\n import * as EventPluginRegistry from 'events\/EventPluginRegistry';\n import * as EventPropagators from 'events\/EventPropagators';\n import * as ReactInstanceMap from 'shared\/ReactInstanceMap';\n-import {enableCreateRoot} from 'shared\/ReactFeatureFlags';\n import ReactVersion from 'shared\/ReactVersion';\n import * as ReactDOMFrameScheduling from 'shared\/ReactDOMFrameScheduling';\n import {ReactCurrentOwner} from 'shared\/ReactGlobalSharedState';\n@@ -1304,15 +1303,13 @@ type RootOptions = {\n hydrate?: boolean,\n };\n \n-if (enableCreateRoot) {\n- ReactDOM.createRoot = function createRoot(\n- container: DOMContainer,\n- options?: RootOptions,\n- ): ReactRoot {\n- const hydrate = options != null && options.hydrate === true;\n- return new ReactRoot(container, true, hydrate);\n- };\n-}\n+ReactDOM.unstable_createRoot = function createRoot(\n+ container: DOMContainer,\n+ options?: RootOptions,\n+): ReactRoot {\n+ const hydrate = options != null && options.hydrate === true;\n+ return new ReactRoot(container, true, hydrate);\n+};\n \n const foundDevTools = DOMRenderer.injectIntoDevTools({\n findFiberByHostInstance: ReactDOMComponentTree.getClosestInstanceFromNode,\ndiff --git a\/packages\/react-dom\/src\/events\/__tests__\/ChangeEventPlugin-test.internal.js b\/packages\/react-dom\/src\/events\/__tests__\/ChangeEventPlugin-test.internal.js\nindex 1b5d690da9..e5f8969ba1 100644\n--- a\/packages\/react-dom\/src\/events\/__tests__\/ChangeEventPlugin-test.internal.js\n+++ b\/packages\/react-dom\/src\/events\/__tests__\/ChangeEventPlugin-test.internal.js\n@@ -452,12 +452,11 @@ describe('ChangeEventPlugin', () => {\n ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n ReactFeatureFlags.enableAsyncSubtreeAPI = true;\n ReactFeatureFlags.debugRenderPhaseSideEffectsForStrictMode = false;\n- ReactFeatureFlags.enableCreateRoot = true;\n ReactFeatureFlags.debugRenderPhaseSideEffectsForStrictMode = false;\n ReactDOM = require('react-dom');\n });\n it('text input', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n let input;\n \n let ops = [];\n@@ -504,7 +503,7 @@ describe('ChangeEventPlugin', () => {\n });\n \n it('checkbox input', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n let input;\n \n let ops = [];\n@@ -566,7 +565,7 @@ describe('ChangeEventPlugin', () => {\n });\n \n it('textarea', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n let textarea;\n \n let ops = [];\n@@ -613,7 +612,7 @@ describe('ChangeEventPlugin', () => {\n });\n \n it('parent of input', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n let input;\n \n let ops = [];\n@@ -664,7 +663,7 @@ describe('ChangeEventPlugin', () => {\n });\n \n it('is async for non-input events', () => {\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n let input;\n \n let ops = [];\ndiff --git a\/packages\/react-dom\/src\/events\/__tests__\/SimpleEventPlugin-test.internal.js b\/packages\/react-dom\/src\/events\/__tests__\/SimpleEventPlugin-test.internal.js\nindex 64ae22ddd4..ad90110818 100644\n--- a\/packages\/react-dom\/src\/events\/__tests__\/SimpleEventPlugin-test.internal.js\n+++ b\/packages\/react-dom\/src\/events\/__tests__\/SimpleEventPlugin-test.internal.js\n@@ -223,13 +223,12 @@ describe('SimpleEventPlugin', function() {\n ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n ReactFeatureFlags.enableAsyncSubtreeAPI = true;\n ReactFeatureFlags.debugRenderPhaseSideEffectsForStrictMode = false;\n- ReactFeatureFlags.enableCreateRoot = true;\n ReactDOM = require('react-dom');\n });\n \n it('flushes pending interactive work before extracting event handler', () => {\n const container = document.createElement('div');\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n document.body.appendChild(container);\n \n let ops = [];\n@@ -309,7 +308,7 @@ describe('SimpleEventPlugin', function() {\n \n it('end result of many interactive updates is deterministic', () => {\n const container = document.createElement('div');\n- const root = ReactDOM.createRoot(container);\n+ const root = ReactDOM.unstable_createRoot(container);\n document.body.appendChild(container);\n \n let button;\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex 8e1a80ffac..fc0a50083d 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -10,7 +10,6 @@\n import invariant from 'fbjs\/lib\/invariant';\n \n \/\/ Exports ReactDOM.createRoot\n-export const enableCreateRoot = false;\n export const enableUserTimingAPI = __DEV__;\n \n \/\/ Mutating mode (React DOM, React ART, React Native):\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fabric.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fabric.js\nindex 06d87c3182..62a64ef5bd 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fabric.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fabric.js\n@@ -14,7 +14,6 @@ import typeof * as FabricFeatureFlagsType from '.\/ReactFeatureFlags.native-fabri\n \n export const debugRenderPhaseSideEffects = false;\n export const debugRenderPhaseSideEffectsForStrictMode = false;\n-export const enableCreateRoot = false;\n export const enableUserTimingAPI = __DEV__;\n export const enableGetDerivedStateFromCatch = false;\n export const warnAboutDeprecatedLifecycles = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native.js b\/packages\/shared\/forks\/ReactFeatureFlags.native.js\nindex 1c0ef01928..d94807d0fc 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native.js\n@@ -22,7 +22,6 @@ export const {\n } = require('ReactFeatureFlags');\n \n \/\/ The rest of the flags are static for better dead code elimination.\n-export const enableCreateRoot = false;\n export const enableUserTimingAPI = __DEV__;\n export const enableMutatingReconciler = true;\n export const enableNoopReconciler = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.persistent.js b\/packages\/shared\/forks\/ReactFeatureFlags.persistent.js\nindex d9aa80be57..6ae31a7ce5 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.persistent.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.persistent.js\n@@ -14,7 +14,6 @@ import typeof * as PersistentFeatureFlagsType from '.\/ReactFeatureFlags.persiste\n \n export const debugRenderPhaseSideEffects = false;\n export const debugRenderPhaseSideEffectsForStrictMode = false;\n-export const enableCreateRoot = false;\n export const enableUserTimingAPI = __DEV__;\n export const enableGetDerivedStateFromCatch = false;\n export const warnAboutDeprecatedLifecycles = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex e5d4ef7d6b..03642454dd 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -14,7 +14,6 @@ import typeof * as PersistentFeatureFlagsType from '.\/ReactFeatureFlags.persiste\n \n export const debugRenderPhaseSideEffects = false;\n export const debugRenderPhaseSideEffectsForStrictMode = false;\n-export const enableCreateRoot = false;\n export const enableUserTimingAPI = __DEV__;\n export const enableGetDerivedStateFromCatch = false;\n export const warnAboutDeprecatedLifecycles = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex 5cc50cc07f..407a0a662c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -21,7 +21,6 @@ export const {\n } = require('ReactFeatureFlags');\n \n \/\/ The rest of the flags are static for better dead code elimination.\n-export const enableCreateRoot = true;\n \n \/\/ The www bundles only use the mutating reconciler.\n export const enableMutatingReconciler = true;\n"}

dillon1000/react

Files changed