dillon1000/react

Commit

Codemod redundant async act scopes (#26350)

Prior to #26347, our internal `act` API (not the public API) behaved
differently depending on whether the scope function returned a promise
(i.e. was an async function), for historical reasons that no longer
apply. Now that this is fixed, I've codemodded all async act scopes that
don't contain an await to be sync.

No pressing motivation other than it looks nicer and the codemod was
easy. Might help avoid confusion for new contributors who see async act
scopes with nothing async inside and infer it must be like that for a
reason.
Browse files
Changed paths78 files
First-parent comparison
M packages/internal-test-utils/__tests__/ReactInternalTestUtils-test.js ModifiedM packages/react-client/src/__tests__/ReactFlight-test.js ModifiedM packages/react-debug-tools/src/__tests__/ReactHooksInspectionIntegration-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMConsoleErrorReporting-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzSuppressHydrationWarning-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMHooks-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMNativeEventHeuristic-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMNestedEvents-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMRoot-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSafariMicrotaskBug-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerSelectiveHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerSuspense-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js ModifiedM packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactUpdates-test.js ModifiedM packages/react-dom/src/__tests__/ReactWrongReturnPointer-test.js ModifiedM packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js ModifiedM packages/react-dom/src/events/__tests__/DOMPluginEventSystem-test.internal.js ModifiedM packages/react-dom/src/events/plugins/__tests__/ChangeEventPlugin-test.js ModifiedM packages/react-dom/src/events/plugins/__tests__/SimpleEventPlugin-test.js ModifiedM packages/react-interactions/events/src/dom/create-event-handle/__tests__/useFocusWithin-test.internal.js ModifiedM packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js ModifiedM packages/react-native-renderer/src/__tests__/ReactFabricHostComponent-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactCPUSuspense-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactCache-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactClassSetStateCallback-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactConcurrentErrorRecovery-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactContextPropagation-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactDeferredValue-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactEffectOrdering-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactExpiration-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactFlushSync-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalScheduling-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalUpdates-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactInterleavedUpdates-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactMemo-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactNoopRendererAct-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactOffscreen-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactOffscreenStrictMode-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactOffscreenSuspense-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSchedulerIntegration-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSubtreeFlagsWarning-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseEffectsSemantics-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseEffectsSemanticsDOM-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseFuzz-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactThenable-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactTransition-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactTransitionTracing-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactUpdatePriority-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactUpdaters-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js ModifiedM packages/react-reconciler/src/__tests__/StrictEffectsModeDefaults-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/useEffectEvent-test.js ModifiedM packages/react-reconciler/src/__tests__/useMemoCache-test.js ModifiedM packages/react-reconciler/src/__tests__/useMutableSource-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/useMutableSourceHydration-test.js ModifiedM packages/react-reconciler/src/__tests__/useRef-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/useSyncExternalStore-test.js ModifiedM packages/react-refresh/src/__tests__/ReactFresh-test.js ModifiedM packages/react-server-dom-relay/src/__tests__/ReactFlightDOMRelay-test.internal.js ModifiedM packages/react-server-dom-webpack/src/__tests__/ReactFlightDOM-test.js ModifiedM packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js ModifiedM packages/react/src/__tests__/ReactProfiler-test.internal.js ModifiedM packages/react/src/__tests__/ReactStartTransition-test.js ModifiedM packages/react/src/__tests__/ReactStrictMode-test.internal.js ModifiedM packages/react/src/__tests__/ReactStrictMode-test.js ModifiedM packages/use-subscription/src/__tests__/useSubscription-test.js ModifiedM packages/use-sync-external-store/src/__tests__/useSyncExternalStoreNative-test.js ModifiedM packages/use-sync-external-store/src/__tests__/useSyncExternalStoreShared-test.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…