{"patch":"diff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.internal.js\nindex 25c3a3a1ad..4ebcd1f84d 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.internal.js\n@@ -57,6 +57,25 @@ describe('ReactNewContext', () => {\n return render(contextValue);\n },\n );\n+ sharedContextTests('useContext inside forwardRef component', Context =>\n+ React.forwardRef(function Consumer(props, ref) {\n+ const observedBits = props.unstable_observedBits;\n+ const contextValue = useContext(Context, observedBits);\n+ const render = props.children;\n+ return render(contextValue);\n+ }),\n+ );\n+ sharedContextTests(\n+ 'useContext inside memoized function component',\n+ Context =>\n+ React.memo(function Consumer(props) {\n+ const observedBits = props.unstable_observedBits;\n+ const contextValue = useContext(Context, observedBits);\n+ const render = props.children;\n+ return render(contextValue);\n+ }),\n+ true,\n+ );\n sharedContextTests(\n 'readContext(Context) inside class component',\n Context =>\n@@ -70,7 +89,7 @@ describe('ReactNewContext', () => {\n },\n );\n \n- function sharedContextTests(label, getConsumer) {\n+ function sharedContextTests(label, getConsumer, isPure) {\n describe(`reading context with ${label}`, () => {\n it('simple mount and update', () => {\n const Context = React.createContext(1);\n@@ -855,46 +874,48 @@ describe('ReactNewContext', () => {\n expect(ReactNoop.getChildren()).toEqual([span(2), span(2)]);\n });\n \n- \/\/ Context consumer bails out on propagating \"deep\" updates when `value` hasn't changed.\n- \/\/ However, it doesn't bail out from rendering if the component above it re-rendered anyway.\n- \/\/ If we bailed out on referential equality, it would be confusing that you\n- \/\/ can call this.setState(), but an autobound render callback \"blocked\" the update.\n- \/\/ https:\/\/github.com\/facebook\/react\/pull\/12470#issuecomment-376917711\n- it('consumer does not bail out if there were no bailouts above it', () => {\n- const Context = React.createContext(0);\n- const Consumer = getConsumer(Context);\n-\n- class App extends React.Component {\n- state = {\n- text: 'hello',\n- };\n-\n- renderConsumer = context => {\n- ReactNoop.yield('App#renderConsumer');\n- return ;\n- };\n-\n- render() {\n- ReactNoop.yield('App');\n- return (\n- \n- {this.renderConsumer}<\/Consumer>\n- <\/Context.Provider>\n- );\n+ if (!isPure) {\n+ \/\/ Context consumer bails out on propagating \"deep\" updates when `value` hasn't changed.\n+ \/\/ However, it doesn't bail out from rendering if the component above it re-rendered anyway.\n+ \/\/ If we bailed out on referential equality, it would be confusing that you\n+ \/\/ can call this.setState(), but an autobound render callback \"blocked\" the update.\n+ \/\/ https:\/\/github.com\/facebook\/react\/pull\/12470#issuecomment-376917711\n+ it('consumer does not bail out if there were no bailouts above it', () => {\n+ const Context = React.createContext(0);\n+ const Consumer = getConsumer(Context);\n+\n+ class App extends React.Component {\n+ state = {\n+ text: 'hello',\n+ };\n+\n+ renderConsumer = context => {\n+ ReactNoop.yield('App#renderConsumer');\n+ return ;\n+ };\n+\n+ render() {\n+ ReactNoop.yield('App');\n+ return (\n+ \n+ {this.renderConsumer}<\/Consumer>\n+ <\/Context.Provider>\n+ );\n+ }\n }\n- }\n \n- \/\/ Initial mount\n- let inst;\n- ReactNoop.render( (inst = ref)} \/>);\n- expect(ReactNoop.flush()).toEqual(['App', 'App#renderConsumer']);\n- expect(ReactNoop.getChildren()).toEqual([span('hello')]);\n+ \/\/ Initial mount\n+ let inst;\n+ ReactNoop.render( (inst = ref)} \/>);\n+ expect(ReactNoop.flush()).toEqual(['App', 'App#renderConsumer']);\n+ expect(ReactNoop.getChildren()).toEqual([span('hello')]);\n \n- \/\/ Update\n- inst.setState({text: 'goodbye'});\n- expect(ReactNoop.flush()).toEqual(['App', 'App#renderConsumer']);\n- expect(ReactNoop.getChildren()).toEqual([span('goodbye')]);\n- });\n+ \/\/ Update\n+ inst.setState({text: 'goodbye'});\n+ expect(ReactNoop.flush()).toEqual(['App', 'App#renderConsumer']);\n+ expect(ReactNoop.getChildren()).toEqual([span('goodbye')]);\n+ });\n+ }\n \n \/\/ This is a regression case for https:\/\/github.com\/facebook\/react\/issues\/12389.\n it('does not run into an infinite loop', () => {\n","commit":{"revision":"63cc7d2b31b4e5ad17c07b383a328c598c91276e","shortRevision":"63cc7d2b31","authoredAt":"2018-10-15T17:20:05-04:00","authorName":"Dan Abramov","authorEmail":"dan.abramov@gmail.com","subject":"Test useContext in pure, forwardRef, and PureComponent"},"files":[{"status":"M","path":"packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.internal.js"}],"parents":["3a7c6da8d46763991d47ebf2198bc4e2fbfa0d9a"],"body":""}

dillon1000/react

Files changed