{"body":"","parents":["3d6d81052db1da2e33f4ae68e0bfc5cb8de51474"],"patch":"diff --git a\/compiler\/packages\/babel-plugin-react-forget\/.eslintrc.js b\/compiler\/packages\/babel-plugin-react-forget\/.eslintrc.js\nindex a9b06ba320..05c7429a0c 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/.eslintrc.js\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/.eslintrc.js\n@@ -28,6 +28,8 @@ module.exports = {\n \/\/ obvious if the declaration was lifted to the parent root\n \"no-inner-declarations\": \"off\",\n \n+ \"multiline-comment-style\": [\"error\", \"starred-block\"],\n+\n \"@typescript-eslint\/no-empty-function\": \"off\",\n \n \/\/ Explicitly casting to\/through any is sometimes required, often for error messages to\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/Babel\/BabelPlugin.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/Babel\/BabelPlugin.ts\nindex 37ff800602..e717a2856e 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/Babel\/BabelPlugin.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/Babel\/BabelPlugin.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\n@@ -10,7 +10,7 @@\n import type * as BabelCore from \"@babel\/core\";\n import { compileProgram, parsePluginOptions } from \"..\/Entrypoint\";\n \n-\/**\n+\/*\n * The React Forget Babel Plugin\n * @param {*} _babel\n * @returns\n@@ -21,9 +21,11 @@ export default function ReactForgetBabelPlugin(\n return {\n name: \"react-forget\",\n visitor: {\n- \/\/ Note: Babel does some \"smart\" merging of visitors across plugins, so even if A is inserted\n- \/\/ prior to B, if A does not have a Program visitor and B does, B will run first. We always\n- \/\/ want Forget to run true to source as possible.\n+ \/*\n+ * Note: Babel does some \"smart\" merging of visitors across plugins, so even if A is inserted\n+ * prior to B, if A does not have a Program visitor and B does, B will run first. We always\n+ * want Forget to run true to source as possible.\n+ *\/\n Program(prog, pass): void {\n compileProgram(prog, {\n opts: parsePluginOptions(pass.opts),\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/Babel\/RunReactForgetBabelPlugin.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/Babel\/RunReactForgetBabelPlugin.ts\nindex f3493517b9..bc878a516a 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/Babel\/RunReactForgetBabelPlugin.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/Babel\/RunReactForgetBabelPlugin.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/CompilerError.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/CompilerError.ts\nindex d5360bce1f..4686d8af35 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/CompilerError.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/CompilerError.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\n@@ -9,23 +9,15 @@ import type { SourceLocation } from \".\/HIR\";\n import { assertExhaustive } from \".\/Utils\/utils\";\n \n export enum ErrorSeverity {\n- \/**\n- * Invalid JS syntax, or valid syntax that is semantically invalid which may indicate some misunderstanding on the user’s part.\n- *\/\n+ \/\/ Invalid JS syntax, or valid syntax that is semantically invalid which may indicate some misunderstanding on the user’s part.\n InvalidJS = \"InvalidJS\",\n- \/**\n- * Code that breaks the rules of React.\n- *\/\n+ \/\/ Code that breaks the rules of React.\n InvalidReact = \"InvalidReact\",\n- \/**\n- * Incorrect configuration of the compiler.\n- *\/\n+ \/\/ Incorrect configuration of the compiler.\n InvalidConfig = \"InvalidConfig\",\n- \/**\n- * Unhandled syntax that we don't support yet.\n- *\/\n+ \/\/ Unhandled syntax that we don't support yet.\n Todo = \"Todo\",\n- \/**\n+ \/*\n * An unexpected internal error in the compiler that indicates critical issues that can panic\n * the compiler.\n *\/\n@@ -62,7 +54,7 @@ export type CompilerErrorDetailOptions = {\n suggestions: Array | null;\n };\n \n-\/**\n+\/*\n * Each bailout or invariant in HIR lowering creates an {@link CompilerErrorDetail}, which is then\n * aggregated into a single {@link CompilerError} later.\n *\/\n@@ -206,7 +198,7 @@ export class CompilerError extends Error {\n return this.details.length > 0;\n }\n \n- \/**\n+ \/*\n * An error is critical if it means the compiler has entered into a broken state and cannot\n * continue safely. Other expected errors such as Todos mean that we can skip over that component\n * but otherwise continue compiling the rest of the app.\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Gating.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Gating.ts\nindex d596401e05..d180175fb8 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Gating.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Gating.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\n@@ -26,10 +26,12 @@ export function insertGatedFunctionDeclaration(\n );\n \n let compiledFn;\n- \/\/ Convert function declarations to named variables *unless* this is an\n- \/\/ `export default function ...` since `export default const ...` is\n- \/\/ not supported. For that case we fall through to replacing w the raw\n- \/\/ conditional expression\n+ \/*\n+ * Convert function declarations to named variables *unless* this is an\n+ * `export default function ...` since `export default const ...` is\n+ * not supported. For that case we fall through to replacing w the raw\n+ * conditional expression\n+ *\/\n if (\n fnPath.parentPath.node.type !== \"ExportDefaultDeclaration\" &&\n fnPath.node.type === \"FunctionDeclaration\" &&\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Imports.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Imports.ts\nindex 13a3b81505..306f19b87f 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Imports.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Imports.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\n@@ -19,8 +19,10 @@ export function addImportsToProgram(\n const identifiers: Set = new Set();\n const sortedImports: Map> = new Map();\n for (const { importSpecifierName, source } of importList) {\n- \/\/ Codegen currently does not rename import specifiers, so we do additional\n- \/\/ validation here\n+ \/*\n+ * Codegen currently does not rename import specifiers, so we do additional\n+ * validation here\n+ *\/\n if (identifiers.has(importSpecifierName)) {\n CompilerError.invalidConfig({\n reason: `Encountered conflicting import specifier for ${importSpecifierName} in Forget config.`,\n@@ -59,7 +61,7 @@ export function addImportsToProgram(\n path.unshiftContainer(\"body\", stmts);\n }\n \n-\/**\n+\/*\n * Matches `import { ... } from 'react';`\n * but not `import * as React from 'react';`\n *\/\n@@ -108,7 +110,7 @@ export function findExistingImports(program: NodePath): {\n };\n }\n \n-\/**\n+\/*\n * If an existing import of React exists (ie `import {useMemo} from 'React'`), inject useMemoCache\n * into the list of destructured variables.\n *\/\n@@ -140,8 +142,10 @@ export function updateUseMemoCacheImport(\n program: NodePath,\n options: PluginOptions\n ): void {\n- \/\/ If there isn't already an import of * as React, insert it so useMemoCache doesn't\n- \/\/ throw\n+ \/*\n+ * If there isn't already an import of * as React, insert it so useMemoCache doesn't\n+ * throw\n+ *\/\n const { didInsertUseMemoCache, hasExistingReactImport } =\n findExistingImports(program);\n \n@@ -151,9 +155,11 @@ export function updateUseMemoCacheImport(\n }\n \n if (options.enableUseMemoCachePolyfill === false) {\n- \/\/ If Forget did successfully compile inject\/update an import of\n- \/\/ `import {unstable_useMemoCache as useMemoCache} from 'react'` and rename\n- \/\/ `React.unstable_useMemoCache(n)` to `useMemoCache(n)`;\n+ \/*\n+ * If Forget did successfully compile inject\/update an import of\n+ * `import {unstable_useMemoCache as useMemoCache} from 'react'` and rename\n+ * `React.unstable_useMemoCache(n)` to `useMemoCache(n)`;\n+ *\/\n if (hasExistingReactImport) {\n const didUpdateImport = updateExistingReactImportDeclaration(program);\n if (didUpdateImport === false) {\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Instrumentation.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Instrumentation.ts\nindex 6a20854db0..8cd07c53d6 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Instrumentation.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Instrumentation.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\n@@ -33,8 +33,10 @@ export function addInstrumentForget(\n body = t.blockStatement([t.expressionStatement(body)]);\n }\n \n- \/\/ Technically, this is a conditional hook call. However, we expect\n- \/\/ __DEV__ and gatingIdentifier to be runtime constants\n+ \/*\n+ * Technically, this is a conditional hook call. However, we expect\n+ * __DEV__ and gatingIdentifier to be runtime constants\n+ *\/\n const test: t.IfStatement = t.ifStatement(\n t.identifier(\"__DEV__\"),\n t.expressionStatement(\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Options.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Options.ts\nindex 04ece28d5c..438f918d5f 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Options.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Options.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\n@@ -10,14 +10,18 @@ import { CompilerErrorDetailOptions } from \"..\/CompilerError\";\n import { ExternalFunction, PartialEnvironmentConfig } from \"..\/HIR\/Environment\";\n \n export type PanicThresholdOptions =\n- \/\/ Any errors will panic the compiler by throwing an exception, which will\n- \/\/ bubble up to the nearest exception handler above the Forget transform.\n- \/\/ If Forget is invoked through `ReactForgetBabelPlugin`, this will at the least\n- \/\/ skip Forget compilation for the rest of current file.\n+ \/*\n+ * Any errors will panic the compiler by throwing an exception, which will\n+ * bubble up to the nearest exception handler above the Forget transform.\n+ * If Forget is invoked through `ReactForgetBabelPlugin`, this will at the least\n+ * skip Forget compilation for the rest of current file.\n+ *\/\n | \"ALL_ERRORS\"\n- \/\/ Panic by throwing an exception only on critical or unrecognized errors.\n- \/\/ For all other errors, skip the erroring function without inserting\n- \/\/ a Forget-compiled version (i.e. same behavior as noEmit).\n+ \/*\n+ * Panic by throwing an exception only on critical or unrecognized errors.\n+ * For all other errors, skip the erroring function without inserting\n+ * a Forget-compiled version (i.e. same behavior as noEmit).\n+ *\/\n | \"CRITICAL_ERRORS\"\n \/\/ Never panic by throwing an exception.\n | \"NONE\";\n@@ -27,52 +31,52 @@ export type PluginOptions = {\n \n logger: Logger | null;\n \n- \/**\n+ \/*\n * Specifying a `gating` config, makes Forget compile and emit a separate\n * version of the function gated by importing the `gating.importSpecifierName` from the\n * specified `gating.source`.\n *\n * For example:\n- * gating: {\n- * source: 'ReactForgetFeatureFlag',\n- * importSpecifierName: 'isForgetEnabled_Pokes',\n- * }\n+ * gating: {\n+ * source: 'ReactForgetFeatureFlag',\n+ * importSpecifierName: 'isForgetEnabled_Pokes',\n+ * }\n *\n * produces:\n- * import {isForgetEnabled_Pokes} from 'ReactForgetFeatureFlag';\n+ * import {isForgetEnabled_Pokes} from 'ReactForgetFeatureFlag';\n *\n- * Foo_forget() {}\n+ * Foo_forget() {}\n *\n- * Foo_uncompiled() {}\n+ * Foo_uncompiled() {}\n *\n- * var Foo = isForgetEnabled_Pokes() ? Foo_forget : Foo_uncompiled;\n+ * var Foo = isForgetEnabled_Pokes() ? Foo_forget : Foo_uncompiled;\n *\/\n gating: ExternalFunction | null;\n- \/**\n+ \/*\n * Enables instrumentation codegen. This emits a dev-mode only call to an\n * instrumentation function, for components and hooks that Forget compiles.\n * For example:\n- * instrumentForget: {\n- * source: 'react-forget-runtime',\n- * importSpecifierName: 'useRenderCounter',\n- * }\n+ * instrumentForget: {\n+ * source: 'react-forget-runtime',\n+ * importSpecifierName: 'useRenderCounter',\n+ * }\n *\n * produces:\n- * import {useRenderCounter} from 'react-forget-runtime-pokes';\n+ * import {useRenderCounter} from 'react-forget-runtime-pokes';\n *\n- * function Component(props) {\n- * if (__DEV__) {\n- * useRenderCounter();\n- * }\n- * \/\/ ...\n- * }\n+ * function Component(props) {\n+ * if (__DEV__) {\n+ * useRenderCounter();\n+ * }\n+ * \/\/ ...\n+ * }\n *\n *\/\n instrumentForget: ExternalFunction | null;\n \n panicThreshold: PanicThresholdOptions;\n \n- \/**\n+ \/*\n * When enabled, Forget will continue statically analyzing and linting code, but skip over codegen\n * passes.\n *\n@@ -80,21 +84,21 @@ export type PluginOptions = {\n *\/\n noEmit: boolean;\n \n- \/**\n+ \/*\n * Determines the strategy for determining which functions to compile. Note that regardless of\n * which mode is enabled, a component can be opted out by adding the string literal\n * `\"use no forget\"` at the top of the function body, eg.:\n *\n * ```\n * function ComponentYouWantToSkipCompilation(props) {\n- * \"use no forget\";\n- * ...\n+ * \"use no forget\";\n+ * ...\n * }\n * ```\n *\/\n compilationMode: CompilationMode;\n \n- \/**\n+ \/*\n * If enabled, Forget will import `useMemoCache` from a polyfill instead of React. Use this if\n * you are for whatever reason unable to use an experimental version of React.\n *\n@@ -107,14 +111,16 @@ export type PluginOptions = {\n };\n \n export type CompilationMode =\n- \/\/ Compiles functions annotated with \"use forget\" or component\/hook-like functions.\n- \/\/ This latter includes:\n- \/\/ * Components declared with component syntax.\n- \/\/ * Functions which can be inferred to be a component or hook:\n- \/\/ - Be named like a hook or component. This logic matches the ESLint rule.\n- \/\/ - *and* create JSX and\/or call a hook. This is an additional check to help prevent\n- \/\/ false positives, since compilation has a greater impact than linting.\n- \/\/ This is the default mode\n+ \/*\n+ * Compiles functions annotated with \"use forget\" or component\/hook-like functions.\n+ * This latter includes:\n+ * * Components declared with component syntax.\n+ * * Functions which can be inferred to be a component or hook:\n+ * - Be named like a hook or component. This logic matches the ESLint rule.\n+ * - *and* create JSX and\/or call a hook. This is an additional check to help prevent\n+ * false positives, since compilation has a greater impact than linting.\n+ * This is the default mode\n+ *\/\n | \"infer\"\n \/\/ Compile only functions which are explicitly annotated with \"use forget\"\n | \"annotation\"\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Pipeline.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Pipeline.ts\nindex f62e1d9d85..9c2fe645f7 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Pipeline.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Pipeline.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\n@@ -100,7 +100,7 @@ export function* run(\n return ast;\n }\n \n-\/**\n+\/*\n * Note: this is split from run() to make `config` out of scope, so that all\n * access to feature flags has to be through the Environment for consistency.\n *\/\ndiff --git a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Program.ts b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Program.ts\nindex 5010cc031f..94df47909d 100644\n--- a\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Program.ts\n+++ b\/compiler\/packages\/babel-plugin-react-forget\/src\/Entrypoint\/Program.ts\n@@ -1,4 +1,4 @@\n-\/**\n+\/*\n * Copyright (c) Meta Platforms, Inc. and affiliates.\n *\n * This source code is licensed under the MIT license found in the\n@@ -94,10 +94,12 @@ function handleError(\n });\n }\n }\n- \/** Always throw if the flag is enabled, otherwise we only throw if the error is critical\n+ \/*\n+ * Always throw if the flag is enabled, otherwise we only throw if the error is critical\n * (eg an invariant is broken, meaning the compiler may be buggy). See\n * {@link CompilerError.isCritical} for mappings.\n- * *\/\n+ *\n+ *\/\n if (\n pass.opts.panicThreshold === \"ALL_ERRORS\" ||\n (pass.opts.panicThreshold === \"CRITICAL_ERRORS\" && isCriticalError(err))\n@@ -205,9 +207,11 @@ function findEslintSuppressions(\n }\n }\n \n-\/\/ This is a hack to work around what seems to be a Babel bug. Babel doesn't\n-\/\/ consistently respect the `skip()` function to avoid revisiting a node within\n-\/\/ a pass, so we use this set to track nodes that we have compiled.\n+\/*\n+ * This is a hack to work around what seems to be a Babel bug. Babel doesn't\n+ * consistently respect the `skip()` function to avoid revisiting a node within\n+ * a pass, so we use this set to track nodes that we have compiled.\n+ *\/\n const ALREADY_COMPILED: WeakSet

dillon1000/react

Files changed