dillon1000/react

Commit

Fix a mistake in ReactChildren refactor (#18380)

* Regression test for map() returning an array

* Add forgotten argument

This fixes the bug.

* Remove unused arg and retval

These aren't directly observable. The arg wasn't used, it's accidental and I forgot to remove. The retval was triggering a codepath that was unnecessary (pushing to array) so I removed that too.

* Flowify ReactChildren

* Tighten up types

* Rename getComponentKey to getElementKey
Browse files
Dan Abramov authored 6498f62edcdf0bcc02ed96efdad92b7e89330d8a Parent 2ba43ed
Changed paths4 files
First-parent comparison
M packages/react-dom/src/client/ReactDOMOption.js ModifiedM packages/react-dom/src/server/ReactPartialRenderer.js ModifiedM packages/react/src/ReactChildren.js ModifiedM packages/react/src/__tests__/ReactChildren-test.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…