dillon1000/react
Commit
Browse files Use querySelectorAll instead of getElementsByName in ReactDOMInput.
We've been able to use `querySelectorAll` in all the browsers that we support for some time now, but we haven't been able to test code that uses it in the older version of `jsdom` that we were using, until recently. Besides the general goal of modernizing our code, the impetus for this specific change is that I'm trying to support testing without having to render nodes into an actual document. The `.getElementsByName` method is only defined on `document` and only works if the nodes you care about are contained by the document. On the other hand, `querySelectorAll` works on any DOM node, and allows a more precise selection of just the `<input type="radio">` elements that have the appropriate name. IE8's implementation of `querySelectorAll` supports attribute-based selectors, which is all we need here.
Changed paths1 file
First-parent comparisonsrc/dom/components/ReactDOMInput.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…