{"parents":["c0ee8e94b049a8fb19dd3606a5a1cecc0cbc6a1b"],"body":"This is enabled everywhere for a while and I don't think we'd be backing\r\nthis out of 19. Seems like it's good to clean up to me.","files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMFizzDeferredValue-test.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberHooks.js"},{"status":"M","path":"packages\/react-reconciler\/src\/__tests__\/ReactDeferredValue-test.js"},{"status":"M","path":"packages\/react-server\/src\/ReactFizzHooks.js"},{"status":"M","path":"packages\/shared\/ReactFeatureFlags.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzDeferredValue-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzDeferredValue-test.js\nindex 04e60648fb..de83a8f0a5 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzDeferredValue-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzDeferredValue-test.js\n@@ -83,7 +83,6 @@ describe('ReactDOMFizzForm', () => {\n return text;\n }\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it('returns initialValue argument, if provided', async () => {\n function App() {\n return useDeferredValue('Final', 'Initial');\n@@ -100,7 +99,6 @@ describe('ReactDOMFizzForm', () => {\n expect(container.textContent).toEqual('Final');\n });\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n \/\/ @gate enablePostpone\n it(\n 'if initial value postpones during hydration, it will switch to the ' +\n@@ -136,7 +134,6 @@ describe('ReactDOMFizzForm', () => {\n },\n );\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it(\n 'useDeferredValue during hydration has higher priority than remaining ' +\n 'incremental hydration',\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberHooks.js b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\nindex 363646eb7d..3ba251b620 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n@@ -45,7 +45,6 @@ import {\n enableLegacyCache,\n debugRenderPhaseSideEffectsForStrictMode,\n enableAsyncActions,\n- enableUseDeferredValueInitialArg,\n disableLegacyMode,\n enableNoCloningMemoCache,\n enableContextProfiling,\n@@ -2879,7 +2878,6 @@ function rerenderDeferredValue(value: T, initialValue?: T): T {\n \n function mountDeferredValueImpl(hook: Hook, value: T, initialValue?: T): T {\n if (\n- enableUseDeferredValueInitialArg &&\n \/\/ When `initialValue` is provided, we defer the initial render even if the\n \/\/ current render is not synchronous.\n initialValue !== undefined &&\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactDeferredValue-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactDeferredValue-test.js\nindex b321f4bba0..b2c38696cc 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactDeferredValue-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactDeferredValue-test.js\n@@ -371,7 +371,6 @@ describe('ReactDeferredValue', () => {\n });\n });\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it('supports initialValue argument', async () => {\n function App() {\n const value = useDeferredValue('Final', 'Initial');\n@@ -388,7 +387,6 @@ describe('ReactDeferredValue', () => {\n expect(root).toMatchRenderedOutput('Final');\n });\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it('defers during initial render when initialValue is provided, even if render is not sync', async () => {\n function App() {\n const value = useDeferredValue('Final', 'Initial');\n@@ -406,7 +404,6 @@ describe('ReactDeferredValue', () => {\n expect(root).toMatchRenderedOutput('Final');\n });\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it(\n 'if a suspended render spawns a deferred task, we can switch to the ' +\n 'deferred task without finishing the original one (no Suspense boundary)',\n@@ -439,7 +436,6 @@ describe('ReactDeferredValue', () => {\n },\n );\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it(\n 'if a suspended render spawns a deferred task, we can switch to the ' +\n 'deferred task without finishing the original one (no Suspense boundary, ' +\n@@ -479,7 +475,6 @@ describe('ReactDeferredValue', () => {\n },\n );\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it(\n 'if a suspended render spawns a deferred task, we can switch to the ' +\n 'deferred task without finishing the original one (Suspense boundary)',\n@@ -520,7 +515,6 @@ describe('ReactDeferredValue', () => {\n },\n );\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it(\n 'if a suspended render spawns a deferred task that also suspends, we can ' +\n 'finish the original task if that one loads first',\n@@ -556,7 +550,6 @@ describe('ReactDeferredValue', () => {\n },\n );\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it(\n 'if there are multiple useDeferredValues in the same tree, only the ' +\n 'first level defers; subsequent ones go straight to the final value, to ' +\n@@ -604,7 +597,6 @@ describe('ReactDeferredValue', () => {\n },\n );\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n it('avoids a useDeferredValue waterfall when separated by a Suspense boundary', async () => {\n \/\/ Same as the previous test but with a Suspense boundary separating the\n \/\/ two useDeferredValue hooks.\n@@ -649,7 +641,6 @@ describe('ReactDeferredValue', () => {\n expect(root).toMatchRenderedOutput('Content');\n });\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n \/\/ @gate enableActivity\n it('useDeferredValue can spawn a deferred task while prerendering a hidden tree', async () => {\n function App() {\n@@ -696,7 +687,6 @@ describe('ReactDeferredValue', () => {\n expect(root).toMatchRenderedOutput(

Final<\/div>);\n });\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n \/\/ @gate enableActivity\n it('useDeferredValue can prerender the initial value inside a hidden tree', async () => {\n function App({text}) {\n@@ -755,7 +745,6 @@ describe('ReactDeferredValue', () => {\n expect(root).toMatchRenderedOutput(

B<\/div>);\n });\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n \/\/ @gate enableActivity\n it(\n 'useDeferredValue skips the preview state when revealing a hidden tree ' +\n@@ -796,7 +785,6 @@ describe('ReactDeferredValue', () => {\n },\n );\n \n- \/\/ @gate enableUseDeferredValueInitialArg\n \/\/ @gate enableActivity\n it(\n 'useDeferredValue does not skip the preview state when revealing a ' +\ndiff --git a\/packages\/react-server\/src\/ReactFizzHooks.js b\/packages\/react-server\/src\/ReactFizzHooks.js\nindex f5965c4f69..1c136c6b23 100644\n--- a\/packages\/react-server\/src\/ReactFizzHooks.js\n+++ b\/packages\/react-server\/src\/ReactFizzHooks.js\n@@ -43,7 +43,6 @@ import {\n enableUseEffectEventHook,\n enableUseMemoCacheHook,\n enableAsyncActions,\n- enableUseDeferredValueInitialArg,\n } from 'shared\/ReactFeatureFlags';\n import is from 'shared\/objectIs';\n import {\n@@ -570,11 +569,7 @@ function useSyncExternalStore(\n \n function useDeferredValue(value: T, initialValue?: T): T {\n resolveCurrentlyRenderingComponent();\n- if (enableUseDeferredValueInitialArg) {\n- return initialValue !== undefined ? initialValue : value;\n- } else {\n- return value;\n- }\n+ return initialValue !== undefined ? initialValue : value;\n }\n \n function unsupportedStartTransition() {\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex f33391b36e..b0286405a6 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -221,9 +221,6 @@ export const disableLegacyMode = true;\n \/\/ Make equivalent to instead of \n export const enableRenderableContext = true;\n \n-\/\/ Enables the `initialValue` option for `useDeferredValue`\n-export const enableUseDeferredValueInitialArg = true;\n-\n \/\/ -----------------------------------------------------------------------------\n \/\/ Chopping Block\n \/\/\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex 110c152b59..4eda27d16c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -83,7 +83,6 @@ export const enableTaint = true;\n export const enableTransitionTracing = false;\n export const enableTrustedTypesIntegration = false;\n export const enableUpdaterTracking = __PROFILE__;\n-export const enableUseDeferredValueInitialArg = true;\n export const enableUseEffectEventHook = false;\n export const enableUseMemoCacheHook = true;\n export const favorSafetyOverHydrationPerf = true;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex 737ecf01e9..2a4421f41d 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -74,7 +74,6 @@ export const enableSuspenseCallback = false;\n export const enableTaint = true;\n export const enableTransitionTracing = false;\n export const enableTrustedTypesIntegration = false;\n-export const enableUseDeferredValueInitialArg = true;\n export const enableUseEffectEventHook = false;\n export const enableUseMemoCacheHook = true;\n export const favorSafetyOverHydrationPerf = true;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex eb6bef3b29..8778bf6558 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -71,7 +71,6 @@ export const alwaysThrottleRetries = true;\n \n export const passChildrenWhenCloningPersistedNodes = false;\n export const enablePersistedModeClonedFlag = false;\n-export const enableUseDeferredValueInitialArg = __EXPERIMENTAL__;\n export const disableClientCache = true;\n \n export const enableServerComponentLogs = true;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\nindex 0436964f88..3a8a0c1d44 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\n@@ -69,7 +69,6 @@ export const enableTaint = true;\n export const enableTransitionTracing = false;\n export const enableTrustedTypesIntegration = false;\n export const enableUpdaterTracking = false;\n-export const enableUseDeferredValueInitialArg = true;\n export const enableUseEffectEventHook = false;\n export const enableUseMemoCacheHook = true;\n export const favorSafetyOverHydrationPerf = true;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex 9ce6704446..eb801d7bac 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -74,7 +74,6 @@ export const alwaysThrottleRetries = true;\n \n export const passChildrenWhenCloningPersistedNodes = false;\n export const enablePersistedModeClonedFlag = false;\n-export const enableUseDeferredValueInitialArg = true;\n export const disableClientCache = true;\n \n export const enableServerComponentLogs = true;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js b\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\nindex 15e0cf3b3c..e2f2751f0c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\n@@ -26,7 +26,6 @@ export const enableObjectFiber = __VARIANT__;\n export const enableRenderableContext = __VARIANT__;\n export const enableRetryLaneExpiration = __VARIANT__;\n export const enableTransitionTracing = __VARIANT__;\n-export const enableUseDeferredValueInitialArg = __VARIANT__;\n export const favorSafetyOverHydrationPerf = __VARIANT__;\n export const renameElementSymbol = __VARIANT__;\n export const retryLaneExpirationMs = 5000;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex 18fc5c8823..95cd1e5a6e 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -30,7 +30,6 @@ export const {\n enableRetryLaneExpiration,\n enableTransitionTracing,\n enableTrustedTypesIntegration,\n- enableUseDeferredValueInitialArg,\n favorSafetyOverHydrationPerf,\n renameElementSymbol,\n retryLaneExpirationMs,\n","commit":{"authoredAt":"2024-08-05T11:25:05-04:00","revision":"65903583d2ab45aea45bdd23ed0b5dc214ff3c1c","shortRevision":"65903583d2","authorName":"Jan Kassens","authorEmail":"jkassens@meta.com","subject":"Remove flag enableUseDeferredValueInitialArg (#30595)"}}

dillon1000/react

Files changed