{"commit":{"authorEmail":"sema@fb.com","revision":"65bbda7f169394005252b46a5992ece5a2ffadad","authorName":"Sebastian Markbåge","subject":"Rename Chunks API to Blocks (#18086)","authoredAt":"2020-02-20T23:56:40-08:00","shortRevision":"65bbda7f16"},"files":[{"status":"M","path":"packages\/react-debug-tools\/src\/ReactDebugHooks.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactChildFiber.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiber.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberBeginWork.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberCommitWork.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberCompleteWork.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberWorkLoop.js"},{"status":"R095","previousPath":"packages\/react-reconciler\/src\/__tests__\/ReactChunks-test.js","path":"packages\/react-reconciler\/src\/__tests__\/ReactBlocks-test.js"},{"status":"M","path":"packages\/react-test-renderer\/src\/ReactTestRenderer.js"},{"status":"M","path":"packages\/react\/src\/React.js"},{"status":"R074","previousPath":"packages\/react\/src\/chunk.js","path":"packages\/react\/src\/block.js"},{"status":"M","path":"packages\/shared\/ReactFeatureFlags.js"},{"status":"M","path":"packages\/shared\/ReactSymbols.js"},{"status":"M","path":"packages\/shared\/ReactWorkTags.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.persistent.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.testing.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.testing.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www.js"},{"status":"M","path":"packages\/shared\/getComponentName.js"},{"status":"M","path":"packages\/shared\/isValidElementType.js"}],"parents":["8b596e00a4fffd6bb5e6990f4dd59e40e80a5ea0"],"patch":"diff --git a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\nindex 99f7ae8905..d515bac08e 100644\n--- a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n+++ b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n@@ -25,7 +25,7 @@ import {\n SimpleMemoComponent,\n ContextProvider,\n ForwardRef,\n- Chunk,\n+ Block,\n } from 'shared\/ReactWorkTags';\n \n type CurrentDispatcherRef = typeof ReactSharedInternals.ReactCurrentDispatcher;\n@@ -628,7 +628,7 @@ export function inspectHooksOfFiber(\n fiber.tag !== FunctionComponent &&\n fiber.tag !== SimpleMemoComponent &&\n fiber.tag !== ForwardRef &&\n- fiber.tag !== Chunk\n+ fiber.tag !== Block\n ) {\n throw new Error(\n 'Unknown Fiber. Needs to be a function component to inspect hooks.',\ndiff --git a\/packages\/react-reconciler\/src\/ReactChildFiber.js b\/packages\/react-reconciler\/src\/ReactChildFiber.js\nindex 7888d7a34a..59508f776e 100644\n--- a\/packages\/react-reconciler\/src\/ReactChildFiber.js\n+++ b\/packages\/react-reconciler\/src\/ReactChildFiber.js\n@@ -19,7 +19,7 @@ import {\n REACT_ELEMENT_TYPE,\n REACT_FRAGMENT_TYPE,\n REACT_PORTAL_TYPE,\n- REACT_CHUNK_TYPE,\n+ REACT_BLOCK_TYPE,\n } from 'shared\/ReactSymbols';\n import {\n FunctionComponent,\n@@ -27,10 +27,10 @@ import {\n HostText,\n HostPortal,\n Fragment,\n- Chunk,\n+ Block,\n } from 'shared\/ReactWorkTags';\n import invariant from 'shared\/invariant';\n-import {warnAboutStringRefs, enableChunksAPI} from 'shared\/ReactFeatureFlags';\n+import {warnAboutStringRefs, enableBlocksAPI} from 'shared\/ReactFeatureFlags';\n \n import {\n createWorkInProgress,\n@@ -416,9 +416,9 @@ function ChildReconciler(shouldTrackSideEffects) {\n }\n return existing;\n } else if (\n- enableChunksAPI &&\n- current.tag === Chunk &&\n- element.type.$$typeof === REACT_CHUNK_TYPE &&\n+ enableBlocksAPI &&\n+ current.tag === Block &&\n+ element.type.$$typeof === REACT_BLOCK_TYPE &&\n element.type.render === current.type.render\n ) {\n \/\/ Same as above but also update the .type field.\n@@ -1175,10 +1175,10 @@ function ChildReconciler(shouldTrackSideEffects) {\n }\n break;\n }\n- case Chunk:\n- if (enableChunksAPI) {\n+ case Block:\n+ if (enableBlocksAPI) {\n if (\n- element.type.$$typeof === REACT_CHUNK_TYPE &&\n+ element.type.$$typeof === REACT_BLOCK_TYPE &&\n element.type.render === child.type.render\n ) {\n deleteRemainingChildren(returnFiber, child.sibling);\n@@ -1192,7 +1192,7 @@ function ChildReconciler(shouldTrackSideEffects) {\n return existing;\n }\n }\n- \/\/ We intentionally fallthrough here if enableChunksAPI is not on.\n+ \/\/ We intentionally fallthrough here if enableBlocksAPI is not on.\n \/\/ eslint-disable-next-lined no-fallthrough\n default: {\n if (\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiber.js b\/packages\/react-reconciler\/src\/ReactFiber.js\nindex 67aabe830b..35a6c1e6e7 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiber.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiber.js\n@@ -33,7 +33,7 @@ import {\n enableFundamentalAPI,\n enableUserTimingAPI,\n enableScopeAPI,\n- enableChunksAPI,\n+ enableBlocksAPI,\n } from 'shared\/ReactFeatureFlags';\n import {NoEffect, Placement} from 'shared\/ReactSideEffectTags';\n import {ConcurrentRoot, BlockingRoot} from 'shared\/ReactRootTags';\n@@ -59,7 +59,7 @@ import {\n LazyComponent,\n FundamentalComponent,\n ScopeComponent,\n- Chunk,\n+ Block,\n } from 'shared\/ReactWorkTags';\n import getComponentName from 'shared\/getComponentName';\n \n@@ -91,7 +91,7 @@ import {\n REACT_LAZY_TYPE,\n REACT_FUNDAMENTAL_TYPE,\n REACT_SCOPE_TYPE,\n- REACT_CHUNK_TYPE,\n+ REACT_BLOCK_TYPE,\n } from 'shared\/ReactSymbols';\n \n let hasBadMapPolyfill;\n@@ -391,9 +391,9 @@ export function resolveLazyComponentTag(Component: Function): WorkTag {\n if ($$typeof === REACT_MEMO_TYPE) {\n return MemoComponent;\n }\n- if (enableChunksAPI) {\n- if ($$typeof === REACT_CHUNK_TYPE) {\n- return Chunk;\n+ if (enableBlocksAPI) {\n+ if ($$typeof === REACT_BLOCK_TYPE) {\n+ return Block;\n }\n }\n }\n@@ -676,8 +676,8 @@ export function createFiberFromTypeAndProps(\n fiberTag = LazyComponent;\n resolvedType = null;\n break getTag;\n- case REACT_CHUNK_TYPE:\n- fiberTag = Chunk;\n+ case REACT_BLOCK_TYPE:\n+ fiberTag = Block;\n break getTag;\n case REACT_FUNDAMENTAL_TYPE:\n if (enableFundamentalAPI) {\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\nindex ff990e5801..8eb9f9ffb9 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\n@@ -42,7 +42,7 @@ import {\n IncompleteClassComponent,\n FundamentalComponent,\n ScopeComponent,\n- Chunk,\n+ Block,\n } from 'shared\/ReactWorkTags';\n import {\n NoEffect,\n@@ -65,7 +65,7 @@ import {\n enableFundamentalAPI,\n warnAboutDefaultPropsOnFunctionComponents,\n enableScopeAPI,\n- enableChunksAPI,\n+ enableBlocksAPI,\n } from 'shared\/ReactFeatureFlags';\n import invariant from 'shared\/invariant';\n import shallowEqual from 'shared\/shallowEqual';\n@@ -701,10 +701,10 @@ function updateFunctionComponent(\n return workInProgress.child;\n }\n \n-function updateChunk(\n+function updateBlock(\n current: Fiber | null,\n workInProgress: Fiber,\n- chunk: any,\n+ block: any,\n nextProps: any,\n renderExpirationTime: ExpirationTime,\n ) {\n@@ -712,8 +712,8 @@ function updateChunk(\n \/\/ hasn't yet mounted. This happens after the first render suspends.\n \/\/ We'll need to figure out if this is fine or can cause issues.\n \n- const render = chunk.render;\n- const data = chunk.query();\n+ const render = block.render;\n+ const data = block.query();\n \n \/\/ The rest is a fork of updateFunctionComponent\n let nextChildren;\n@@ -1215,10 +1215,10 @@ function mountLazyComponent(\n );\n return child;\n }\n- case Chunk: {\n- if (enableChunksAPI) {\n+ case Block: {\n+ if (enableBlocksAPI) {\n \/\/ TODO: Resolve for Hot Reloading.\n- child = updateChunk(\n+ child = updateBlock(\n null,\n workInProgress,\n Component,\n@@ -3289,14 +3289,14 @@ function beginWork(\n }\n break;\n }\n- case Chunk: {\n- if (enableChunksAPI) {\n- const chunk = workInProgress.type;\n+ case Block: {\n+ if (enableBlocksAPI) {\n+ const block = workInProgress.type;\n const props = workInProgress.pendingProps;\n- return updateChunk(\n+ return updateBlock(\n current,\n workInProgress,\n- chunk,\n+ block,\n props,\n renderExpirationTime,\n );\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCommitWork.js b\/packages\/react-reconciler\/src\/ReactFiberCommitWork.js\nindex 73942936e9..857928aa4c 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCommitWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCommitWork.js\n@@ -53,7 +53,7 @@ import {\n SuspenseListComponent,\n FundamentalComponent,\n ScopeComponent,\n- Chunk,\n+ Block,\n } from 'shared\/ReactWorkTags';\n import {\n invokeGuardedCallback,\n@@ -249,7 +249,7 @@ function commitBeforeMutationLifeCycles(\n case FunctionComponent:\n case ForwardRef:\n case SimpleMemoComponent:\n- case Chunk: {\n+ case Block: {\n return;\n }\n case ClassComponent: {\n@@ -426,7 +426,7 @@ export function commitPassiveHookEffects(finishedWork: Fiber): void {\n case FunctionComponent:\n case ForwardRef:\n case SimpleMemoComponent:\n- case Chunk: {\n+ case Block: {\n \/\/ TODO (#17945) We should call all passive destroy functions (for all fibers)\n \/\/ before calling any create functions. The current approach only serializes\n \/\/ these for a single fiber.\n@@ -450,7 +450,7 @@ function commitLifeCycles(\n case FunctionComponent:\n case ForwardRef:\n case SimpleMemoComponent:\n- case Chunk: {\n+ case Block: {\n \/\/ At this point layout effects have already been destroyed (during mutation phase).\n \/\/ This is done to prevent sibling component effects from interfering with each other,\n \/\/ e.g. a destroy function in one component should never override a ref set\n@@ -779,7 +779,7 @@ function commitUnmount(\n case ForwardRef:\n case MemoComponent:\n case SimpleMemoComponent:\n- case Chunk: {\n+ case Block: {\n const updateQueue: FunctionComponentUpdateQueue | null = (current.updateQueue: any);\n if (updateQueue !== null) {\n const lastEffect = updateQueue.lastEffect;\n@@ -1360,7 +1360,7 @@ function commitWork(current: Fiber | null, finishedWork: Fiber): void {\n case ForwardRef:\n case MemoComponent:\n case SimpleMemoComponent:\n- case Chunk: {\n+ case Block: {\n \/\/ Layout effects are destroyed during the mutation phase so that all\n \/\/ destroy functions for all fibers are called before any create functions.\n \/\/ This prevents sibling component effects from interfering with each other,\n@@ -1403,7 +1403,7 @@ function commitWork(current: Fiber | null, finishedWork: Fiber): void {\n case ForwardRef:\n case MemoComponent:\n case SimpleMemoComponent:\n- case Chunk: {\n+ case Block: {\n \/\/ Layout effects are destroyed during the mutation phase so that all\n \/\/ destroy functions for all fibers are called before any create functions.\n \/\/ This prevents sibling component effects from interfering with each other,\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js b\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\nindex 1138dc5711..e7ecaf3343 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\n@@ -51,7 +51,7 @@ import {\n IncompleteClassComponent,\n FundamentalComponent,\n ScopeComponent,\n- Chunk,\n+ Block,\n } from 'shared\/ReactWorkTags';\n import {NoMode, BlockingMode} from '.\/ReactTypeOfMode';\n import {\n@@ -119,7 +119,7 @@ import {\n enableDeprecatedFlareAPI,\n enableFundamentalAPI,\n enableScopeAPI,\n- enableChunksAPI,\n+ enableBlocksAPI,\n } from 'shared\/ReactFeatureFlags';\n import {\n markSpawnedWork,\n@@ -1295,8 +1295,8 @@ function completeWork(\n }\n break;\n }\n- case Chunk:\n- if (enableChunksAPI) {\n+ case Block:\n+ if (enableBlocksAPI) {\n return null;\n }\n break;\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.js b\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.js\nindex 1c03f8f50a..8c3e4dd170 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberWorkLoop.js\n@@ -88,7 +88,7 @@ import {\n ForwardRef,\n MemoComponent,\n SimpleMemoComponent,\n- Chunk,\n+ Block,\n } from 'shared\/ReactWorkTags';\n import {\n NoEffect,\n@@ -2682,7 +2682,7 @@ function warnAboutUpdateOnUnmountedFiberInDEV(fiber) {\n tag !== ForwardRef &&\n tag !== MemoComponent &&\n tag !== SimpleMemoComponent &&\n- tag !== Chunk\n+ tag !== Block\n ) {\n \/\/ Only warn for user-defined components, not internal ones like Suspense.\n return;\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactChunks-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactBlocks-test.js\nsimilarity index 95%\nrename from packages\/react-reconciler\/src\/__tests__\/ReactChunks-test.js\nrename to packages\/react-reconciler\/src\/__tests__\/ReactBlocks-test.js\nindex 28ed482ebd..280eef0609 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactChunks-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactBlocks-test.js\n@@ -12,17 +12,17 @@ let React;\n let ReactNoop;\n let useState;\n let Suspense;\n-let chunk;\n+let block;\n let readString;\n \n-describe('ReactChunks', () => {\n+describe('ReactBlocks', () => {\n beforeEach(() => {\n jest.resetModules();\n \n React = require('react');\n ReactNoop = require('react-noop-renderer');\n \n- chunk = React.chunk;\n+ block = React.block;\n useState = React.useState;\n Suspense = React.Suspense;\n let cache = new Map();\n@@ -63,7 +63,7 @@ describe('ReactChunks', () => {\n );\n }\n \n- let loadUser = chunk(Query, Render);\n+ let loadUser = block(Query, Render);\n \n function App({User}) {\n return (\n@@ -102,7 +102,7 @@ describe('ReactChunks', () => {\n );\n }\n \n- let loadUser = chunk(Query, Render);\n+ let loadUser = block(Query, Render);\n \n function App({User}) {\n return (\n@@ -164,7 +164,7 @@ describe('ReactChunks', () => {\n );\n }\n \n- let loadUser = chunk(Query, Render);\n+ let loadUser = block(Query, Render);\n \n function App({User}) {\n return (\ndiff --git a\/packages\/react-test-renderer\/src\/ReactTestRenderer.js b\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\nindex e8ec6cbd53..0bd57d4702 100644\n--- a\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\n+++ b\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\n@@ -37,7 +37,7 @@ import {\n Profiler,\n MemoComponent,\n SimpleMemoComponent,\n- Chunk,\n+ Block,\n IncompleteClassComponent,\n ScopeComponent,\n } from 'shared\/ReactWorkTags';\n@@ -188,9 +188,9 @@ function toTree(node: ?Fiber) {\n instance: null,\n rendered: childrenToTree(node.child),\n };\n- case Chunk:\n+ case Block:\n return {\n- nodeType: 'chunk',\n+ nodeType: 'block',\n type: node.type,\n props: {...node.memoizedProps},\n instance: null,\n@@ -233,7 +233,7 @@ const validWrapperTypes = new Set([\n ForwardRef,\n MemoComponent,\n SimpleMemoComponent,\n- Chunk,\n+ Block,\n \/\/ Normally skipped, but used when there's more than one root child.\n HostRoot,\n ]);\ndiff --git a\/packages\/react\/src\/React.js b\/packages\/react\/src\/React.js\nindex ad515bd321..23fb0f8791 100644\n--- a\/packages\/react\/src\/React.js\n+++ b\/packages\/react\/src\/React.js\n@@ -28,7 +28,7 @@ import {createContext} from '.\/ReactContext';\n import {lazy} from '.\/ReactLazy';\n import forwardRef from '.\/forwardRef';\n import memo from '.\/memo';\n-import chunk from '.\/chunk';\n+import block from '.\/block';\n import {\n useCallback,\n useContext,\n@@ -63,7 +63,7 @@ import {\n enableFundamentalAPI,\n enableScopeAPI,\n exposeConcurrentModeAPIs,\n- enableChunksAPI,\n+ enableBlocksAPI,\n disableCreateFactory,\n } from 'shared\/ReactFeatureFlags';\n const React = {\n@@ -120,8 +120,8 @@ if (exposeConcurrentModeAPIs) {\n React.unstable_withSuspenseConfig = withSuspenseConfig;\n }\n \n-if (enableChunksAPI) {\n- React.chunk = chunk;\n+if (enableBlocksAPI) {\n+ React.block = block;\n }\n \n if (enableDeprecatedFlareAPI) {\ndiff --git a\/packages\/react\/src\/chunk.js b\/packages\/react\/src\/block.js\nsimilarity index 74%\nrename from packages\/react\/src\/chunk.js\nrename to packages\/react\/src\/block.js\nindex 90bf8ac56f..575f8b66ea 100644\n--- a\/packages\/react\/src\/chunk.js\n+++ b\/packages\/react\/src\/block.js\n@@ -6,47 +6,47 @@\n *\/\n \n import {\n- REACT_CHUNK_TYPE,\n+ REACT_BLOCK_TYPE,\n REACT_MEMO_TYPE,\n REACT_FORWARD_REF_TYPE,\n } from 'shared\/ReactSymbols';\n \n-opaque type Chunk: React$AbstractComponent<\n+opaque type Block: React$AbstractComponent<\n Props,\n null,\n > = React$AbstractComponent;\n \n-export default function chunk(\n+export default function block(\n query: (...args: Args) => Data,\n render: (props: Props, data: Data) => React$Node,\n-): (...args: Args) => Chunk {\n+): (...args: Args) => Block {\n if (__DEV__) {\n if (typeof query !== 'function') {\n console.error(\n- 'Chunks require a query function but was given %s.',\n+ 'Blocks require a query function but was given %s.',\n query === null ? 'null' : typeof query,\n );\n }\n if (render != null && render.$$typeof === REACT_MEMO_TYPE) {\n console.error(\n- 'Chunks require a render function but received a `memo` ' +\n+ 'Blocks require a render function but received a `memo` ' +\n 'component. Use `memo` on an inner component instead.',\n );\n } else if (render != null && render.$$typeof === REACT_FORWARD_REF_TYPE) {\n console.error(\n- 'Chunks require a render function but received a `forwardRef` ' +\n+ 'Blocks require a render function but received a `forwardRef` ' +\n 'component. Use `forwardRef` on an inner component instead.',\n );\n } else if (typeof render !== 'function') {\n console.error(\n- 'Chunks require a render function but was given %s.',\n+ 'Blocks require a render function but was given %s.',\n render === null ? 'null' : typeof render,\n );\n } else if (render.length !== 0 && render.length !== 2) {\n \/\/ Warn if it's not accepting two args.\n \/\/ Do not warn for 0 arguments because it could be due to usage of the 'arguments' object\n console.error(\n- 'Chunk render functions accept exactly two parameters: props and data. %s',\n+ 'Block render functions accept exactly two parameters: props and data. %s',\n render.length === 1\n ? 'Did you forget to use the data parameter?'\n : 'Any additional parameter will be undefined.',\n@@ -58,15 +58,15 @@ export default function chunk(\n (render.defaultProps != null || render.propTypes != null)\n ) {\n console.error(\n- 'Chunk render functions do not support propTypes or defaultProps. ' +\n+ 'Block render functions do not support propTypes or defaultProps. ' +\n 'Did you accidentally pass a React component?',\n );\n }\n }\n- return function(): Chunk {\n+ return function(): Block {\n let args = arguments;\n return {\n- $$typeof: REACT_CHUNK_TYPE,\n+ $$typeof: REACT_BLOCK_TYPE,\n query: function() {\n return query.apply(null, args);\n },\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex 383bbe3c24..1008cd05fd 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -31,7 +31,7 @@ export const enableSuspenseServerRenderer = __EXPERIMENTAL__;\n export const enableSelectiveHydration = __EXPERIMENTAL__;\n \n \/\/ Flight experiments\n-export const enableChunksAPI = __EXPERIMENTAL__;\n+export const enableBlocksAPI = __EXPERIMENTAL__;\n \n \/\/ Only used in www builds.\n export const enableSchedulerDebugging = false;\ndiff --git a\/packages\/shared\/ReactSymbols.js b\/packages\/shared\/ReactSymbols.js\nindex acc990d04c..6e6dd6c306 100644\n--- a\/packages\/shared\/ReactSymbols.js\n+++ b\/packages\/shared\/ReactSymbols.js\n@@ -51,7 +51,7 @@ export const REACT_SUSPENSE_LIST_TYPE = hasSymbol\n : 0xead8;\n export const REACT_MEMO_TYPE = hasSymbol ? Symbol.for('react.memo') : 0xead3;\n export const REACT_LAZY_TYPE = hasSymbol ? Symbol.for('react.lazy') : 0xead4;\n-export const REACT_CHUNK_TYPE = hasSymbol ? Symbol.for('react.chunk') : 0xead9;\n+export const REACT_BLOCK_TYPE = hasSymbol ? Symbol.for('react.block') : 0xead9;\n export const REACT_FUNDAMENTAL_TYPE = hasSymbol\n ? Symbol.for('react.fundamental')\n : 0xead5;\ndiff --git a\/packages\/shared\/ReactWorkTags.js b\/packages\/shared\/ReactWorkTags.js\nindex 9fa017983f..c8675c7225 100644\n--- a\/packages\/shared\/ReactWorkTags.js\n+++ b\/packages\/shared\/ReactWorkTags.js\n@@ -54,4 +54,4 @@ export const DehydratedFragment = 18;\n export const SuspenseListComponent = 19;\n export const FundamentalComponent = 20;\n export const ScopeComponent = 21;\n-export const Chunk = 22;\n+export const Block = 22;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex 44fa3a158f..58bf3098db 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -23,7 +23,7 @@ export const enableProfilerTimer = __PROFILE__;\n export const enableSchedulerTracing = __PROFILE__;\n export const enableSuspenseServerRenderer = false;\n export const enableSelectiveHydration = false;\n-export const enableChunksAPI = false;\n+export const enableBlocksAPI = false;\n export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;\n export const warnAboutShorthandPropertyCollision = true;\n export const enableSchedulerDebugging = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex a637eb75d0..91d29d5f5a 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -20,7 +20,7 @@ export const enableProfilerTimer = __PROFILE__;\n export const enableSchedulerTracing = __PROFILE__;\n export const enableSuspenseServerRenderer = false;\n export const enableSelectiveHydration = false;\n-export const enableChunksAPI = false;\n+export const enableBlocksAPI = false;\n export const disableJavaScriptURLs = false;\n export const disableInputAttributeSyncing = false;\n export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.persistent.js b\/packages\/shared\/forks\/ReactFeatureFlags.persistent.js\nindex 17a66058dc..05bd97dd2e 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.persistent.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.persistent.js\n@@ -20,7 +20,7 @@ export const enableProfilerTimer = __PROFILE__;\n export const enableSchedulerTracing = __PROFILE__;\n export const enableSuspenseServerRenderer = false;\n export const enableSelectiveHydration = false;\n-export const enableChunksAPI = false;\n+export const enableBlocksAPI = false;\n export const disableJavaScriptURLs = false;\n export const disableInputAttributeSyncing = false;\n export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex 05375f1f04..d1edf59b7c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -20,7 +20,7 @@ export const enableProfilerTimer = __PROFILE__;\n export const enableSchedulerTracing = __PROFILE__;\n export const enableSuspenseServerRenderer = false;\n export const enableSelectiveHydration = false;\n-export const enableChunksAPI = false;\n+export const enableBlocksAPI = false;\n export const disableJavaScriptURLs = false;\n export const disableInputAttributeSyncing = false;\n export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex 423947d8b6..175bf15fe7 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -20,7 +20,7 @@ export const enableProfilerTimer = __PROFILE__;\n export const enableSchedulerTracing = __PROFILE__;\n export const enableSuspenseServerRenderer = false;\n export const enableSelectiveHydration = false;\n-export const enableChunksAPI = false;\n+export const enableBlocksAPI = false;\n export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;\n export const warnAboutShorthandPropertyCollision = true;\n export const enableSchedulerDebugging = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\nindex f19cecb601..2969b38630 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n@@ -20,7 +20,7 @@ export const enableProfilerTimer = __PROFILE__;\n export const enableSchedulerTracing = __PROFILE__;\n export const enableSuspenseServerRenderer = false;\n export const enableSelectiveHydration = false;\n-export const enableChunksAPI = false;\n+export const enableBlocksAPI = false;\n export const disableJavaScriptURLs = false;\n export const disableInputAttributeSyncing = false;\n export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\nindex d82f90c473..11c5ddbe4e 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n@@ -20,7 +20,7 @@ export const enableProfilerTimer = false;\n export const enableSchedulerTracing = false;\n export const enableSuspenseServerRenderer = true;\n export const enableSelectiveHydration = true;\n-export const enableChunksAPI = true;\n+export const enableBlocksAPI = true;\n export const disableJavaScriptURLs = true;\n export const disableInputAttributeSyncing = false;\n export const exposeConcurrentModeAPIs = true;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex e9d2d9b3f3..2972553b8a 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -50,7 +50,7 @@ export const exposeConcurrentModeAPIs = true;\n export const enableSuspenseServerRenderer = true;\n export const enableSelectiveHydration = true;\n \n-export const enableChunksAPI = true;\n+export const enableBlocksAPI = true;\n \n export const disableJavaScriptURLs = true;\n \ndiff --git a\/packages\/shared\/getComponentName.js b\/packages\/shared\/getComponentName.js\nindex f90ca1fbe3..e2ad538e58 100644\n--- a\/packages\/shared\/getComponentName.js\n+++ b\/packages\/shared\/getComponentName.js\n@@ -21,7 +21,7 @@ import {\n REACT_SUSPENSE_TYPE,\n REACT_SUSPENSE_LIST_TYPE,\n REACT_LAZY_TYPE,\n- REACT_CHUNK_TYPE,\n+ REACT_BLOCK_TYPE,\n } from 'shared\/ReactSymbols';\n import {refineResolvedLazyComponent} from 'shared\/ReactLazyComponent';\n \n@@ -80,7 +80,7 @@ function getComponentName(type: mixed): string | null {\n return getWrappedName(type, type.render, 'ForwardRef');\n case REACT_MEMO_TYPE:\n return getComponentName(type.type);\n- case REACT_CHUNK_TYPE:\n+ case REACT_BLOCK_TYPE:\n return getComponentName(type.render);\n case REACT_LAZY_TYPE: {\n const thenable: LazyComponent = (type: any);\ndiff --git a\/packages\/shared\/isValidElementType.js b\/packages\/shared\/isValidElementType.js\nindex c4a6ce0d4e..187dcf8c8f 100644\n--- a\/packages\/shared\/isValidElementType.js\n+++ b\/packages\/shared\/isValidElementType.js\n@@ -22,7 +22,7 @@ import {\n REACT_FUNDAMENTAL_TYPE,\n REACT_RESPONDER_TYPE,\n REACT_SCOPE_TYPE,\n- REACT_CHUNK_TYPE,\n+ REACT_BLOCK_TYPE,\n } from 'shared\/ReactSymbols';\n \n export default function isValidElementType(type: mixed) {\n@@ -46,6 +46,6 @@ export default function isValidElementType(type: mixed) {\n type.$$typeof === REACT_FUNDAMENTAL_TYPE ||\n type.$$typeof === REACT_RESPONDER_TYPE ||\n type.$$typeof === REACT_SCOPE_TYPE ||\n- type.$$typeof === REACT_CHUNK_TYPE))\n+ type.$$typeof === REACT_BLOCK_TYPE))\n );\n }\n","body":"Sounds like this is the name we're going with. This also helps us\r\ndistinguish it from other \"chunking\" implementation details."}

dillon1000/react

Files changed