{"files":[{"status":"M","path":"packages\/react-devtools-shared\/src\/__tests__\/profilingCommitTreeBuilder-test.js"}],"commit":{"shortRevision":"65db1000b9","revision":"65db1000b944c8a07b5947c06b38eb8364dce4f2","authorName":"Sebastian \"Sebbie\" Silbermann","authorEmail":"sebastian.silbermann@vercel.com","authoredAt":"2026-02-06T16:00:43+01:00","subject":"[test] Move profilingCommitTreeBuilder to versioned renderer (#35711)"},"body":"","parents":["2a879cdc95228b1b3b4cdc81cfc04599716b5562"],"patch":"diff --git a\/packages\/react-devtools-shared\/src\/__tests__\/profilingCommitTreeBuilder-test.js b\/packages\/react-devtools-shared\/src\/__tests__\/profilingCommitTreeBuilder-test.js\nindex 968fda10da..f08629dd05 100644\n--- a\/packages\/react-devtools-shared\/src\/__tests__\/profilingCommitTreeBuilder-test.js\n+++ b\/packages\/react-devtools-shared\/src\/__tests__\/profilingCommitTreeBuilder-test.js\n@@ -9,10 +9,7 @@\n \n import type Store from 'react-devtools-shared\/src\/devtools\/store';\n \n-import {\n- getLegacyRenderImplementation,\n- getModernRenderImplementation,\n-} from '.\/utils';\n+import {getVersionedRenderImplementation} from '.\/utils';\n \n describe('commit tree', () => {\n let React = require('react');\n@@ -32,12 +29,10 @@ describe('commit tree', () => {\n Scheduler = require('scheduler');\n });\n \n- const {render: legacyRender} = getLegacyRenderImplementation();\n- const {render: modernRender} = getModernRenderImplementation();\n+ const {render} = getVersionedRenderImplementation();\n \n \/\/ @reactVersion >= 16.9\n- \/\/ @reactVersion <= 18.2\n- it('should be able to rebuild the store tree for each commit (legacy render)', () => {\n+ it('should be able to rebuild the store tree for each commit', () => {\n const Parent = ({count}) => {\n Scheduler.unstable_advanceTime(10);\n return new Array(count)\n@@ -50,13 +45,13 @@ describe('commit tree', () => {\n });\n \n utils.act(() => store.profilerStore.startProfiling());\n- utils.act(() => legacyRender());\n+ utils.act(() => render());\n expect(store).toMatchInlineSnapshot(`\n [root]\n ▾ \n [Memo]\n `);\n- utils.act(() => legacyRender());\n+ utils.act(() => render());\n expect(store).toMatchInlineSnapshot(`\n [root]\n ▾ \n@@ -64,73 +59,14 @@ describe('commit tree', () => {\n [Memo]\n [Memo]\n `);\n- utils.act(() => legacyRender());\n+ utils.act(() => render());\n expect(store).toMatchInlineSnapshot(`\n [root]\n ▾ \n [Memo]\n [Memo]\n `);\n- utils.act(() => legacyRender());\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- \n- `);\n- utils.act(() => store.profilerStore.stopProfiling());\n-\n- const rootID = store.roots[0];\n- const commitTrees = [];\n- for (let commitIndex = 0; commitIndex < 4; commitIndex++) {\n- commitTrees.push(\n- store.profilerStore.profilingCache.getCommitTree({\n- commitIndex,\n- rootID,\n- }),\n- );\n- }\n-\n- expect(commitTrees[0].nodes.size).toBe(3); \/\/ + + \n- expect(commitTrees[1].nodes.size).toBe(5); \/\/ + + x 3\n- expect(commitTrees[2].nodes.size).toBe(4); \/\/ + + x 2\n- expect(commitTrees[3].nodes.size).toBe(2); \/\/ + \n- });\n-\n- \/\/ @reactVersion >= 18\n- it('should be able to rebuild the store tree for each commit (createRoot)', () => {\n- const Parent = ({count}) => {\n- Scheduler.unstable_advanceTime(10);\n- return new Array(count)\n- .fill(true)\n- .map((_, index) => );\n- };\n- const Child = React.memo(function Child() {\n- Scheduler.unstable_advanceTime(2);\n- return null;\n- });\n-\n- utils.act(() => store.profilerStore.startProfiling());\n- utils.act(() => modernRender());\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- ▾ \n- [Memo]\n- `);\n- utils.act(() => modernRender());\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- ▾ \n- [Memo]\n- [Memo]\n- [Memo]\n- `);\n- utils.act(() => modernRender());\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- ▾ \n- [Memo]\n- [Memo]\n- `);\n- utils.act(() => modernRender());\n+ utils.act(() => render());\n expect(store).toMatchInlineSnapshot(`\n [root]\n \n@@ -179,10 +115,9 @@ describe('commit tree', () => {\n });\n \n \/\/ @reactVersion >= 16.9\n- \/\/ @reactVersion <= 18.2\n- it('should support Lazy components (legacy render)', async () => {\n+ it('should support Lazy components', async () => {\n utils.act(() => store.profilerStore.startProfiling());\n- utils.act(() => legacyRender());\n+ utils.act(() => render());\n await Promise.resolve();\n expect(store).toMatchInlineSnapshot(`\n [root]\n@@ -191,7 +126,7 @@ describe('commit tree', () => {\n [suspense-root] rects={null}\n \n `);\n- utils.act(() => legacyRender());\n+ utils.act(() => render());\n expect(store).toMatchInlineSnapshot(`\n [root]\n ▾ \n@@ -200,7 +135,7 @@ describe('commit tree', () => {\n [suspense-root] rects={null}\n \n `);\n- utils.act(() => legacyRender());\n+ utils.act(() => render());\n expect(store).toMatchInlineSnapshot(`\n [root]\n \n@@ -223,55 +158,10 @@ describe('commit tree', () => {\n expect(commitTrees[2].nodes.size).toBe(2); \/\/ + \n });\n \n- \/\/ @reactVersion >= 18.0\n- it('should support Lazy components (createRoot)', async () => {\n- utils.act(() => store.profilerStore.startProfiling());\n- utils.act(() => modernRender());\n- await Promise.resolve();\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- ▾ \n- \n- [suspense-root] rects={null}\n- \n- `);\n- utils.act(() => modernRender());\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- ▾ \n- ▾ \n- \n- [suspense-root] rects={null}\n- \n- `);\n- utils.act(() => modernRender());\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- \n- `);\n- utils.act(() => store.profilerStore.stopProfiling());\n-\n- const rootID = store.roots[0];\n- const commitTrees = [];\n- for (let commitIndex = 0; commitIndex < 3; commitIndex++) {\n- commitTrees.push(\n- store.profilerStore.profilingCache.getCommitTree({\n- commitIndex,\n- rootID,\n- }),\n- );\n- }\n-\n- expect(commitTrees[0].nodes.size).toBe(3); \/\/ + + \n- expect(commitTrees[1].nodes.size).toBe(4); \/\/ + + + \n- expect(commitTrees[2].nodes.size).toBe(2); \/\/ + \n- });\n-\n \/\/ @reactVersion >= 16.9\n- \/\/ @reactVersion <= 18.2\n- it('should support Lazy components that are unmounted before resolving (legacy render)', async () => {\n+ it('should support Lazy components that are unmounted before resolving', async () => {\n utils.act(() => store.profilerStore.startProfiling());\n- utils.act(() => legacyRender());\n+ utils.act(() => render());\n expect(store).toMatchInlineSnapshot(`\n [root]\n ▾ \n@@ -279,7 +169,7 @@ describe('commit tree', () => {\n [suspense-root] rects={null}\n \n `);\n- utils.act(() => legacyRender());\n+ utils.act(() => render());\n expect(store).toMatchInlineSnapshot(`\n [root]\n \n@@ -300,38 +190,5 @@ describe('commit tree', () => {\n expect(commitTrees[0].nodes.size).toBe(3);\n expect(commitTrees[1].nodes.size).toBe(2); \/\/ + \n });\n-\n- \/\/ @reactVersion >= 18.0\n- it('should support Lazy components that are unmounted before resolving (createRoot)', async () => {\n- utils.act(() => store.profilerStore.startProfiling());\n- utils.act(() => modernRender());\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- ▾ \n- \n- [suspense-root] rects={null}\n- \n- `);\n- utils.act(() => modernRender());\n- expect(store).toMatchInlineSnapshot(`\n- [root]\n- \n- `);\n- utils.act(() => store.profilerStore.stopProfiling());\n-\n- const rootID = store.roots[0];\n- const commitTrees = [];\n- for (let commitIndex = 0; commitIndex < 2; commitIndex++) {\n- commitTrees.push(\n- store.profilerStore.profilingCache.getCommitTree({\n- commitIndex,\n- rootID,\n- }),\n- );\n- }\n-\n- expect(commitTrees[0].nodes.size).toBe(3); \/\/ + + \n- expect(commitTrees[1].nodes.size).toBe(2); \/\/ + \n- });\n });\n });\n"}

dillon1000/react

Files changed