{"commit":{"revision":"67081159377b438b48e3c2f2278af8e5f56b9f64","authorEmail":"jkassens@meta.com","authoredAt":"2024-03-22T11:20:18-04:00","subject":"Use `declare const` instead of `declare var` (#28599)","shortRevision":"6708115937","authorName":"Jan Kassens"},"body":"Use `declare const` instead of `declare var`","parents":["fee786a057774ab687aff765345dd86fce534ab2"],"files":[{"status":"M","path":"packages\/react-client\/src\/forks\/ReactFlightClientConfig.custom.js"},{"status":"M","path":"packages\/react-devtools-extensions\/flow-typed\/jest.js"},{"status":"M","path":"packages\/react-native-renderer\/src\/ReactNativeTypes.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberDevToolsHook.js"},{"status":"M","path":"packages\/react-reconciler\/src\/forks\/ReactFiberConfig.custom.js"},{"status":"M","path":"packages\/react-server\/src\/ReactFlightServerConfigBundlerCustom.js"},{"status":"M","path":"packages\/react-server\/src\/forks\/ReactFizzConfig.custom.js"},{"status":"M","path":"packages\/react-server\/src\/forks\/ReactServerStreamConfig.custom.js"},{"status":"M","path":"packages\/scheduler\/src\/forks\/SchedulerNative.js"},{"status":"M","path":"scripts\/flow\/environment.js"},{"status":"M","path":"scripts\/flow\/react-devtools.js"},{"status":"M","path":"scripts\/flow\/react-native-host-hooks.js"},{"status":"M","path":"scripts\/flow\/xplat.js"},{"status":"M","path":"scripts\/jest\/typescript\/jest.d.ts"}],"patch":"diff --git a\/packages\/react-client\/src\/forks\/ReactFlightClientConfig.custom.js b\/packages\/react-client\/src\/forks\/ReactFlightClientConfig.custom.js\nindex 45a47a8c14..3add5988aa 100644\n--- a\/packages\/react-client\/src\/forks\/ReactFlightClientConfig.custom.js\n+++ b\/packages\/react-client\/src\/forks\/ReactFlightClientConfig.custom.js\n@@ -23,7 +23,7 @@\n \/\/ So `$$$config` looks like a global variable, but it's\n \/\/ really an argument to a top-level wrapping function.\n \n-declare var $$$config: any;\n+declare const $$$config: any;\n \n export opaque type ModuleLoading = mixed;\n export opaque type SSRModuleMap = mixed;\ndiff --git a\/packages\/react-devtools-extensions\/flow-typed\/jest.js b\/packages\/react-devtools-extensions\/flow-typed\/jest.js\nindex 066655593a..cdbe32bee7 100644\n--- a\/packages\/react-devtools-extensions\/flow-typed\/jest.js\n+++ b\/packages\/react-devtools-extensions\/flow-typed\/jest.js\n@@ -960,7 +960,7 @@ declare function beforeAll(\n ): void;\n \n \/** A context for grouping tests together *\/\n-declare var describe: {\n+declare const describe: {\n \/**\n * Creates a block that groups together several related tests in one \"test suite\"\n *\/\n@@ -991,7 +991,7 @@ declare var describe: {\n };\n \n \/** An individual test unit *\/\n-declare var it: {\n+declare const it: {\n \/**\n * An individual test unit\n *\n@@ -1079,15 +1079,15 @@ declare function fit(\n timeout?: number\n ): void;\n \/** An individual test unit *\/\n-declare var test: typeof it;\n+declare const test: typeof it;\n \/** A disabled group of tests *\/\n-declare var xdescribe: typeof describe;\n+declare const xdescribe: typeof describe;\n \/** A focused group of tests *\/\n-declare var fdescribe: typeof describe;\n+declare const fdescribe: typeof describe;\n \/** A disabled individual test *\/\n-declare var xit: typeof it;\n+declare const xit: typeof it;\n \/** A disabled individual test *\/\n-declare var xtest: typeof it;\n+declare const xtest: typeof it;\n \n type JestPrettyFormatColors = {\n comment: {close: string, open: string},\n@@ -1139,7 +1139,7 @@ type JestPrettyFormatPlugin = {\n type JestPrettyFormatPlugins = Array;\n \n \/** The expect function is used every time you want to test a value *\/\n-declare var expect: {\n+declare const expect: {\n \/** The object that you want to make assertions against *\/\n (\n value: any\n@@ -1173,4 +1173,4 @@ declare var expect: {\n };\n \n \/** Holds all functions related to manipulating test runner *\/\n-declare var jest: JestObjectType;\n+declare const jest: JestObjectType;\ndiff --git a\/packages\/react-native-renderer\/src\/ReactNativeTypes.js b\/packages\/react-native-renderer\/src\/ReactNativeTypes.js\nindex f02b921b6c..0b44ef7f81 100644\n--- a\/packages\/react-native-renderer\/src\/ReactNativeTypes.js\n+++ b\/packages\/react-native-renderer\/src\/ReactNativeTypes.js\n@@ -125,7 +125,7 @@ export type NativeMethods = $ReadOnly<{|\n |}>;\n \n \/\/ This validates that INativeMethods and NativeMethods stay in sync using Flow!\n-declare var ensureNativeMethodsAreSynced: NativeMethods;\n+declare const ensureNativeMethodsAreSynced: NativeMethods;\n (ensureNativeMethodsAreSynced: INativeMethods);\n \n export type HostComponent = AbstractComponent>;\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberDevToolsHook.js b\/packages\/react-reconciler\/src\/ReactFiberDevToolsHook.js\nindex abf56e90fa..dead0fda46 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberDevToolsHook.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberDevToolsHook.js\n@@ -41,7 +41,7 @@ import {\n import {setSuppressWarning} from 'shared\/consoleWithStackDev';\n import {disableLogs, reenableLogs} from 'shared\/ConsolePatchingDev';\n \n-declare var __REACT_DEVTOOLS_GLOBAL_HOOK__: Object | void;\n+declare const __REACT_DEVTOOLS_GLOBAL_HOOK__: Object | void;\n \n let rendererID = null;\n let injectedHook = null;\ndiff --git a\/packages\/react-reconciler\/src\/forks\/ReactFiberConfig.custom.js b\/packages\/react-reconciler\/src\/forks\/ReactFiberConfig.custom.js\nindex c2c6fd21e5..5bf200268e 100644\n--- a\/packages\/react-reconciler\/src\/forks\/ReactFiberConfig.custom.js\n+++ b\/packages\/react-reconciler\/src\/forks\/ReactFiberConfig.custom.js\n@@ -23,7 +23,7 @@\n \/\/ So `$$$config` looks like a global variable, but it's\n \/\/ really an argument to a top-level wrapping function.\n \n-declare var $$$config: any;\n+declare const $$$config: any;\n export opaque type Type = mixed; \/\/ eslint-disable-line no-undef\n export opaque type Props = mixed; \/\/ eslint-disable-line no-undef\n export opaque type Container = mixed; \/\/ eslint-disable-line no-undef\ndiff --git a\/packages\/react-server\/src\/ReactFlightServerConfigBundlerCustom.js b\/packages\/react-server\/src\/ReactFlightServerConfigBundlerCustom.js\nindex e11c154d05..00578a4da2 100644\n--- a\/packages\/react-server\/src\/ReactFlightServerConfigBundlerCustom.js\n+++ b\/packages\/react-server\/src\/ReactFlightServerConfigBundlerCustom.js\n@@ -7,7 +7,7 @@\n * @flow\n *\/\n \n-declare var $$$config: any;\n+declare const $$$config: any;\n \n export opaque type ClientManifest = mixed;\n export opaque type ClientReference = mixed; \/\/ eslint-disable-line no-unused-vars\ndiff --git a\/packages\/react-server\/src\/forks\/ReactFizzConfig.custom.js b\/packages\/react-server\/src\/forks\/ReactFizzConfig.custom.js\nindex cf1e05a541..495a74fb18 100644\n--- a\/packages\/react-server\/src\/forks\/ReactFizzConfig.custom.js\n+++ b\/packages\/react-server\/src\/forks\/ReactFizzConfig.custom.js\n@@ -26,7 +26,7 @@\n import type {Request} from 'react-server\/src\/ReactFizzServer';\n import type {TransitionStatus} from 'react-reconciler\/src\/ReactFiberConfig';\n \n-declare var $$$config: any;\n+declare const $$$config: any;\n export opaque type Destination = mixed; \/\/ eslint-disable-line no-undef\n export opaque type RenderState = mixed;\n export opaque type HoistableState = mixed;\ndiff --git a\/packages\/react-server\/src\/forks\/ReactServerStreamConfig.custom.js b\/packages\/react-server\/src\/forks\/ReactServerStreamConfig.custom.js\nindex e372e8903f..22cd6551c0 100644\n--- a\/packages\/react-server\/src\/forks\/ReactServerStreamConfig.custom.js\n+++ b\/packages\/react-server\/src\/forks\/ReactServerStreamConfig.custom.js\n@@ -23,7 +23,7 @@\n \/\/ So `$$$config` looks like a global variable, but it's\n \/\/ really an argument to a top-level wrapping function.\n \n-declare var $$$config: any;\n+declare const $$$config: any;\n export opaque type Destination = mixed; \/\/ eslint-disable-line no-undef\n \n export opaque type PrecomputedChunk = mixed; \/\/ eslint-disable-line no-undef\ndiff --git a\/packages\/scheduler\/src\/forks\/SchedulerNative.js b\/packages\/scheduler\/src\/forks\/SchedulerNative.js\nindex a7370d92a6..3832cbc697 100644\n--- a\/packages\/scheduler\/src\/forks\/SchedulerNative.js\n+++ b\/packages\/scheduler\/src\/forks\/SchedulerNative.js\n@@ -32,7 +32,7 @@ type NativeSchedulerType = {\n unstable_now: () => DOMHighResTimeStamp,\n };\n \n-declare var nativeRuntimeScheduler: void | NativeSchedulerType;\n+declare const nativeRuntimeScheduler: void | NativeSchedulerType;\n \n export const unstable_UserBlockingPriority: PriorityLevel =\n typeof nativeRuntimeScheduler !== 'undefined'\ndiff --git a\/scripts\/flow\/environment.js b\/scripts\/flow\/environment.js\nindex 255ed4a2b9..cba4dd5e61 100644\n--- a\/scripts\/flow\/environment.js\n+++ b\/scripts\/flow\/environment.js\n@@ -9,25 +9,25 @@\n \n \/* eslint-disable *\/\n \n-declare var __PROFILE__: boolean;\n-declare var __UMD__: boolean;\n-declare var __EXPERIMENTAL__: boolean;\n-declare var __VARIANT__: boolean;\n+declare const __PROFILE__: boolean;\n+declare const __UMD__: boolean;\n+declare const __EXPERIMENTAL__: boolean;\n+declare const __VARIANT__: boolean;\n \n-declare var __REACT_DEVTOOLS_GLOBAL_HOOK__: any; \/*?{\n+declare const __REACT_DEVTOOLS_GLOBAL_HOOK__: any; \/*?{\n inject: ?((stuff: Object) => void)\n };*\/\n \n-declare var globalThis: Object;\n+declare const globalThis: Object;\n \n-declare var queueMicrotask: (fn: Function) => void;\n-declare var reportError: (error: mixed) => void;\n-declare var AggregateError: Class;\n+declare const queueMicrotask: (fn: Function) => void;\n+declare const reportError: (error: mixed) => void;\n+declare const AggregateError: Class;\n \n-declare var FinalizationRegistry: any;\n+declare const FinalizationRegistry: any;\n \n declare module 'create-react-class' {\n- declare var exports: React$CreateClass;\n+ declare const exports: React$CreateClass;\n }\n \n \/\/ Flow hides the props of React$Element, this overrides it to unhide\n@@ -43,7 +43,7 @@ declare opaque type React$Element<\n +ref: any,\n };\n \n-declare var trustedTypes: {\n+declare const trustedTypes: {\n isHTML: (value: any) => boolean,\n isScript: (value: any) => boolean,\n isScriptURL: (value: any) => boolean,\n@@ -89,22 +89,22 @@ declare module 'EventListener' {\n }\n \n declare function __webpack_chunk_load__(id: string): Promise;\n-declare var __webpack_require__: ((id: string) => any) & {\n+declare const __webpack_require__: ((id: string) => any) & {\n u: string => string,\n };\n \n declare function __turbopack_load__(id: string): Promise;\n-declare var __turbopack_require__: ((id: string) => any) & {\n+declare const __turbopack_require__: ((id: string) => any) & {\n u: string => string,\n };\n \n declare module 'fs\/promises' {\n- declare var access: (path: string, mode?: number) => Promise;\n- declare var lstat: (\n+ declare const access: (path: string, mode?: number) => Promise;\n+ declare const lstat: (\n path: string,\n options?: ?{bigint?: boolean},\n ) => Promise;\n- declare var readdir: (\n+ declare const readdir: (\n path: string,\n options?:\n | ?string\n@@ -113,7 +113,7 @@ declare module 'fs\/promises' {\n withFileTypes?: ?boolean,\n },\n ) => Promise;\n- declare var readFile: (\n+ declare const readFile: (\n path: string,\n options?:\n | ?string\n@@ -121,7 +121,7 @@ declare module 'fs\/promises' {\n encoding?: ?string,\n },\n ) => Promise;\n- declare var readlink: (\n+ declare const readlink: (\n path: string,\n options?:\n | ?string\n@@ -129,7 +129,7 @@ declare module 'fs\/promises' {\n encoding?: ?string,\n },\n ) => Promise;\n- declare var realpath: (\n+ declare const realpath: (\n path: string,\n options?:\n | ?string\n@@ -137,13 +137,13 @@ declare module 'fs\/promises' {\n encoding?: ?string,\n },\n ) => Promise;\n- declare var stat: (\n+ declare const stat: (\n path: string,\n options?: ?{bigint?: boolean},\n ) => Promise;\n }\n declare module 'pg' {\n- declare var Pool: (options: mixed) => {\n+ declare const Pool: (options: mixed) => {\n query: (query: string, values?: Array) => void,\n };\n }\n@@ -320,7 +320,7 @@ declare class AsyncLocalStorage {\n enterWith(store: T): void;\n }\n \n-declare var async_hooks: {\n+declare const async_hooks: {\n createHook(callbacks: any): any,\n executionAsyncId(): number,\n };\n@@ -332,7 +332,7 @@ declare module 'node:worker_threads' {\n }\n }\n \n-declare var Bun: {\n+declare const Bun: {\n hash(\n input: string | $TypedArray | DataView | ArrayBuffer | SharedArrayBuffer,\n ): number,\ndiff --git a\/scripts\/flow\/react-devtools.js b\/scripts\/flow\/react-devtools.js\nindex 86968330ec..361ca16819 100644\n--- a\/scripts\/flow\/react-devtools.js\n+++ b\/scripts\/flow\/react-devtools.js\n@@ -9,12 +9,12 @@\n \n \/* eslint-disable no-unused-vars *\/\n \n-declare var __EXTENSION__: boolean;\n-declare var __TEST__: boolean;\n+declare const __EXTENSION__: boolean;\n+declare const __TEST__: boolean;\n \n-declare var DARK_MODE_DIMMED_WARNING_COLOR: string;\n-declare var DARK_MODE_DIMMED_ERROR_COLOR: string;\n-declare var DARK_MODE_DIMMED_LOG_COLOR: string;\n-declare var LIGHT_MODE_DIMMED_WARNING_COLOR: string;\n-declare var LIGHT_MODE_DIMMED_ERROR_COLOR: string;\n-declare var LIGHT_MODE_DIMMED_LOG_COLOR: string;\n+declare const DARK_MODE_DIMMED_WARNING_COLOR: string;\n+declare const DARK_MODE_DIMMED_ERROR_COLOR: string;\n+declare const DARK_MODE_DIMMED_LOG_COLOR: string;\n+declare const LIGHT_MODE_DIMMED_WARNING_COLOR: string;\n+declare const LIGHT_MODE_DIMMED_ERROR_COLOR: string;\n+declare const LIGHT_MODE_DIMMED_LOG_COLOR: string;\ndiff --git a\/scripts\/flow\/react-native-host-hooks.js b\/scripts\/flow\/react-native-host-hooks.js\nindex e1b8b0ca72..9c86a8ffeb 100644\n--- a\/scripts\/flow\/react-native-host-hooks.js\n+++ b\/scripts\/flow\/react-native-host-hooks.js\n@@ -49,21 +49,21 @@ declare module 'react-native\/Libraries\/ReactPrivate\/ReactNativePrivateInterface'\n ): boolean;\n declare export function deepFreezeAndThrowOnMutationInDev(obj: T): T;\n declare export function flattenStyle(style: any): any;\n- declare export var RCTEventEmitter: {\n+ declare export const RCTEventEmitter: {\n register: (eventEmitter: mixed) => void,\n ...\n };\n- declare export var TextInputState: {\n+ declare export const TextInputState: {\n blurTextInput: (object: any) => void,\n focusTextInput: (object: any) => void,\n ...\n };\n- declare export var ReactFiberErrorDialog: {\n+ declare export const ReactFiberErrorDialog: {\n showErrorDialog: (error: __CapturedError) => boolean,\n ...\n };\n- declare export var Platform: {OS: string, ...};\n- declare export var UIManager: {\n+ declare export const Platform: {OS: string, ...};\n+ declare export const UIManager: {\n customBubblingEventTypes: Object,\n customDirectEventTypes: Object,\n createView: (\n@@ -123,15 +123,15 @@ declare module 'react-native\/Libraries\/ReactPrivate\/ReactNativePrivateInterface'\n ) => void,\n ...\n };\n- declare export var legacySendAccessibilityEvent: (\n+ declare export const legacySendAccessibilityEvent: (\n reactTag: number,\n eventTypeName: string,\n ) => void;\n- declare export var BatchedBridge: {\n+ declare export const BatchedBridge: {\n registerCallableModule: (name: string, module: Object) => void,\n ...\n };\n- declare export var ReactNativeViewConfigRegistry: {\n+ declare export const ReactNativeViewConfigRegistry: {\n customBubblingEventTypes: Object,\n customDirectEventTypes: Object,\n \n@@ -139,7 +139,7 @@ declare module 'react-native\/Libraries\/ReactPrivate\/ReactNativePrivateInterface'\n get: (name: string) => __ReactNativeBaseComponentViewConfig,\n ...\n };\n- declare export var RawEventEmitter: {\n+ declare export const RawEventEmitter: {\n emit: (channel: string, event: RawEventEmitterEvent) => string,\n ...\n };\n@@ -171,7 +171,7 @@ declare const RN$enableMicrotasksInReact: boolean;\n \n \/\/ This is needed for a short term solution.\n \/\/ See https:\/\/github.com\/facebook\/react\/pull\/15490 for more info\n-declare var nativeFabricUIManager: {\n+declare const nativeFabricUIManager: {\n createNode: (\n reactTag: number,\n viewName: string,\ndiff --git a\/scripts\/flow\/xplat.js b\/scripts\/flow\/xplat.js\nindex 9c458c2c8e..61e3a5692f 100644\n--- a\/scripts\/flow\/xplat.js\n+++ b\/scripts\/flow\/xplat.js\n@@ -8,16 +8,16 @@\n *\/\n \n declare module 'ReactNativeInternalFeatureFlags' {\n- declare export var alwaysThrottleDisappearingFallbacks: boolean;\n- declare export var alwaysThrottleRetries: boolean;\n- declare export var consoleManagedByDevToolsDuringStrictMode: boolean;\n- declare export var enableAsyncActions: boolean;\n- declare export var enableComponentStackLocations: boolean;\n- declare export var enableDeferRootSchedulingToMicrotask: boolean;\n- declare export var enableInfiniteRenderLoopDetection: boolean;\n- declare export var enableRenderableContext: boolean;\n- declare export var enableUnifiedSyncLane: boolean;\n- declare export var enableUseRefAccessWarning: boolean;\n- declare export var passChildrenWhenCloningPersistedNodes: boolean;\n- declare export var useModernStrictMode: boolean;\n+ declare export const alwaysThrottleDisappearingFallbacks: boolean;\n+ declare export const alwaysThrottleRetries: boolean;\n+ declare export const consoleManagedByDevToolsDuringStrictMode: boolean;\n+ declare export const enableAsyncActions: boolean;\n+ declare export const enableComponentStackLocations: boolean;\n+ declare export const enableDeferRootSchedulingToMicrotask: boolean;\n+ declare export const enableInfiniteRenderLoopDetection: boolean;\n+ declare export const enableRenderableContext: boolean;\n+ declare export const enableUnifiedSyncLane: boolean;\n+ declare export const enableUseRefAccessWarning: boolean;\n+ declare export const passChildrenWhenCloningPersistedNodes: boolean;\n+ declare export const useModernStrictMode: boolean;\n }\ndiff --git a\/scripts\/jest\/typescript\/jest.d.ts b\/scripts\/jest\/typescript\/jest.d.ts\nindex 43aa392287..57e9378366 100644\n--- a\/scripts\/jest\/typescript\/jest.d.ts\n+++ b\/scripts\/jest\/typescript\/jest.d.ts\n@@ -1,16 +1,16 @@\n-declare var __DEV__: boolean;\n-declare var __TEST__: boolean;\n-declare var __EXTENSION__: boolean;\n+declare const __DEV__: boolean;\n+declare const __TEST__: boolean;\n+declare const __EXTENSION__: boolean;\n \n declare function afterEach(fn: any): any;\n declare function beforeEach(fn: any): any;\n declare function describe(name: string, fn: any): void;\n-declare var it: {\n+declare const it: {\n (name: string, fn: any): void;\n only: (name: string, fn: any) => void;\n }\n declare function expect(val: any): Expect;\n-declare var jest: Jest;\n+declare const jest: Jest;\n declare function pit(name: string, fn: any): void;\n declare function spyOnDev(obj: any, key: string): any;\n declare function spyOnDevAndProd(obj: any, key: string): any;\n@@ -70,5 +70,5 @@ interface MockFunction {\n mockReturnValueOnce(value: any): MockFunction\n }\n \n-declare var check: any;\n-declare var gen: any;\n+declare const check: any;\n+declare const gen: any;\n"}

dillon1000/react

Files changed