dillon1000/react

Commit

Replace ReactComponentMixin with ReactReconciler

Instead of putting the shared code in a base class method, we use a wrapper
call around all invokations. That way they're free to add code before AND
after the non-shared code.

That way we ensure that component extensions don't need to implement
ReactComponentMixin and do super() calls into it. This helps to create a
tighter API for custom component extensions.

This provides the first step towards moving these methods to static
methods which allows to use a different dispatch mechanism instead of
virtual method calls. E.g. pattern matching.
Browse files
Changed paths14 files
First-parent comparison
M src/browser/ui/React.js ModifiedM src/browser/ui/ReactDOMComponent.js ModifiedM src/browser/ui/ReactDOMTextComponent.js ModifiedM src/browser/ui/ReactMount.js ModifiedM src/browser/ui/__tests__/ReactDOMComponent-test.js ModifiedM src/core/ReactChildReconciler.js ModifiedD src/core/ReactComponent.js DeletedM src/core/ReactCompositeComponent.js ModifiedM src/core/ReactMultiChild.js ModifiedA src/core/ReactReconciler.js AddedM src/core/__tests__/ReactComponentLifeCycle-test.js ModifiedM src/core/__tests__/ReactCompositeComponent-test.js ModifiedM src/core/__tests__/ReactMockedComponent-test.js ModifiedM src/core/instantiateReactComponent.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…