dillon1000/react

Commit

Add hasOwnProperty checks where appropriate

For boolean-like objects, I've added hasOwnProperty checks in addition to the existing truthiness check even though for most of these dicts, we leave out false keys instead of setting them explicitly to false.

In DOMPropertyOperations, we don't need to check hasOwnProperty if the property is in isStandardName because (with the exception of getPossibleStandardName) the dicts on DOMProperty will now be consistently populated with every valid attribute.
Browse files
Changed paths10 files
First-parent comparison
M src/addons/transitions/ReactTransitionChildMapping.js ModifiedM src/addons/update.js ModifiedM src/browser/ReactEventEmitter.js ModifiedM src/browser/eventPlugins/AnalyticsEventPluginFactory.js ModifiedM src/browser/ui/ReactDOMComponent.js ModifiedM src/browser/ui/dom/DOMProperty.js ModifiedM src/browser/ui/dom/DOMPropertyOperations.js ModifiedM src/browser/ui/dom/dangerousStyleValue.js ModifiedM src/core/ReactCompositeComponent.js ModifiedM src/event/EventPluginRegistry.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…