dillon1000/react

Commit

Remove codeframe/nodepath options from CompilerError

These were effectively unused since we almost always passed in null when 
creating errors, so remove them and instead pass in a `loc` explicitly. The 
downside is that we no longer will see Babel codeframes in our test fixtures, 
which doesn't seem like a huge loss
Browse files
Changed paths15 files
First-parent comparison
M compiler/forget/apps/playground/lib/forgetMonacoDiagnostics.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/CompilerError.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Entrypoint/Program.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/BuildHIR.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/CodegenReactiveFunction.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Validation/ValidateFrozenLambdas.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Validation/ValidateHooksUsage.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Validation/ValidateNoRefAccesInRender.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Validation/ValidateUnconditionalHooks.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error._todo.computed-lval-in-destructure.expect.md ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-destructure-assignment-to-global.expect.md ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-destructure-to-local-global-variables.expect.md ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-kitchensink.expect.md ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.useMemo-callback-generator.expect.md ModifiedM compiler/forget/packages/eslint-plugin-react-forget/src/rules/ReactForgetDiagnostics.ts Modified
Patch

Files changed

Rendering syntax-highlighted changes…