{"body":"Rolled out internally. Removing flag.","files":[{"path":"packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js","status":"M"},{"path":"packages\/react-dom-bindings\/src\/shared\/possibleStandardNames.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMAttribute-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js","status":"M"},{"path":"packages\/shared\/ReactFeatureFlags.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.www.js","status":"M"}],"parents":["425f72bdd4263dcaba829cf52545309bbfde56b4"],"patch":"diff --git a\/packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js b\/packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js\nindex 523babf87e..715b241cdb 100644\n--- a\/packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js\n+++ b\/packages\/react-dom-bindings\/src\/client\/ReactDOMComponent.js\n@@ -70,7 +70,6 @@ import {\n disableIEWorkarounds,\n enableTrustedTypesIntegration,\n enableFilterEmptyStringAttributesDOM,\n- enableNewBooleanProps,\n } from 'shared\/ReactFeatureFlags';\n import {\n mediaEventTypes,\n@@ -668,24 +667,20 @@ function setProp(\n break;\n }\n \/\/ Boolean\n- case 'inert':\n- if (!enableNewBooleanProps) {\n- setValueForAttribute(domElement, key, value);\n- break;\n- } else {\n- if (__DEV__) {\n- if (value === '' && !didWarnForNewBooleanPropsWithEmptyValue[key]) {\n- didWarnForNewBooleanPropsWithEmptyValue[key] = true;\n- console.error(\n- 'Received an empty string for a boolean attribute `%s`. ' +\n- 'This will treat the attribute as if it were false. ' +\n- 'Either pass `false` to silence this warning, or ' +\n- 'pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.',\n- key,\n- );\n- }\n+ case 'inert': {\n+ if (__DEV__) {\n+ if (value === '' && !didWarnForNewBooleanPropsWithEmptyValue[key]) {\n+ didWarnForNewBooleanPropsWithEmptyValue[key] = true;\n+ console.error(\n+ 'Received an empty string for a boolean attribute `%s`. ' +\n+ 'This will treat the attribute as if it were false. ' +\n+ 'Either pass `false` to silence this warning, or ' +\n+ 'pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.',\n+ key,\n+ );\n }\n }\n+ }\n \/\/ fallthrough for new boolean props without the flag on\n case 'allowFullScreen':\n case 'async':\n@@ -2764,32 +2759,30 @@ function diffHydratedGenericElement(\n );\n continue;\n case 'inert':\n- if (enableNewBooleanProps) {\n- if (__DEV__) {\n- if (\n- value === '' &&\n- !didWarnForNewBooleanPropsWithEmptyValue[propKey]\n- ) {\n- didWarnForNewBooleanPropsWithEmptyValue[propKey] = true;\n- console.error(\n- 'Received an empty string for a boolean attribute `%s`. ' +\n- 'This will treat the attribute as if it were false. ' +\n- 'Either pass `false` to silence this warning, or ' +\n- 'pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.',\n- propKey,\n- );\n- }\n+ if (__DEV__) {\n+ if (\n+ value === '' &&\n+ !didWarnForNewBooleanPropsWithEmptyValue[propKey]\n+ ) {\n+ didWarnForNewBooleanPropsWithEmptyValue[propKey] = true;\n+ console.error(\n+ 'Received an empty string for a boolean attribute `%s`. ' +\n+ 'This will treat the attribute as if it were false. ' +\n+ 'Either pass `false` to silence this warning, or ' +\n+ 'pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.',\n+ propKey,\n+ );\n }\n- hydrateBooleanAttribute(\n- domElement,\n- propKey,\n- propKey,\n- value,\n- extraAttributes,\n- serverDifferences,\n- );\n- continue;\n }\n+ hydrateBooleanAttribute(\n+ domElement,\n+ propKey,\n+ propKey,\n+ value,\n+ extraAttributes,\n+ serverDifferences,\n+ );\n+ continue;\n \/\/ fallthrough for new boolean props without the flag on\n default: {\n if (\ndiff --git a\/packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js b\/packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js\nindex 6716811bf4..423e6aba6c 100644\n--- a\/packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js\n+++ b\/packages\/react-dom-bindings\/src\/server\/ReactFizzConfigDOM.js\n@@ -31,7 +31,6 @@ import {\n enableBigIntSupport,\n enableFilterEmptyStringAttributesDOM,\n enableFizzExternalRuntime,\n- enableNewBooleanProps,\n } from 'shared\/ReactFeatureFlags';\n \n import type {\n@@ -1423,29 +1422,27 @@ function pushAttribute(\n pushStringAttribute(target, 'xml:space', value);\n return;\n case 'inert': {\n- if (enableNewBooleanProps) {\n- if (__DEV__) {\n- if (value === '' && !didWarnForNewBooleanPropsWithEmptyValue[name]) {\n- didWarnForNewBooleanPropsWithEmptyValue[name] = true;\n- console.error(\n- 'Received an empty string for a boolean attribute `%s`. ' +\n- 'This will treat the attribute as if it were false. ' +\n- 'Either pass `false` to silence this warning, or ' +\n- 'pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.',\n- name,\n- );\n- }\n- }\n- \/\/ Boolean\n- if (value && typeof value !== 'function' && typeof value !== 'symbol') {\n- target.push(\n- attributeSeparator,\n- stringToChunk(name),\n- attributeEmptyString,\n+ if (__DEV__) {\n+ if (value === '' && !didWarnForNewBooleanPropsWithEmptyValue[name]) {\n+ didWarnForNewBooleanPropsWithEmptyValue[name] = true;\n+ console.error(\n+ 'Received an empty string for a boolean attribute `%s`. ' +\n+ 'This will treat the attribute as if it were false. ' +\n+ 'Either pass `false` to silence this warning, or ' +\n+ 'pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.',\n+ name,\n );\n }\n- return;\n }\n+ \/\/ Boolean\n+ if (value && typeof value !== 'function' && typeof value !== 'symbol') {\n+ target.push(\n+ attributeSeparator,\n+ stringToChunk(name),\n+ attributeEmptyString,\n+ );\n+ }\n+ return;\n }\n \/\/ fallthrough for new boolean props without the flag on\n default:\ndiff --git a\/packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js b\/packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js\nindex b80d23cbd0..3e49fa637f 100644\n--- a\/packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js\n+++ b\/packages\/react-dom-bindings\/src\/shared\/ReactDOMUnknownPropertyHook.js\n@@ -9,7 +9,6 @@ import {ATTRIBUTE_NAME_CHAR} from '.\/isAttributeNameSafe';\n import isCustomElement from '.\/isCustomElement';\n import possibleStandardNames from '.\/possibleStandardNames';\n import hasOwnProperty from 'shared\/hasOwnProperty';\n-import {enableNewBooleanProps} from 'shared\/ReactFeatureFlags';\n \n const warnedProperties = {};\n const EVENT_NAME_REGEX = \/^on.\/;\n@@ -228,18 +227,12 @@ function validateProperty(tagName, name, value, eventRegistry) {\n case 'seamless':\n case 'itemScope':\n case 'capture':\n- case 'download': {\n+ case 'download':\n+ case 'inert': {\n \/\/ Boolean properties can accept boolean values\n return true;\n }\n \/\/ fallthrough\n- case 'inert': {\n- if (enableNewBooleanProps) {\n- \/\/ Boolean properties can accept boolean values\n- return true;\n- }\n- }\n- \/\/ fallthrough for new boolean props without the flag on\n default: {\n const prefix = name.toLowerCase().slice(0, 5);\n if (prefix === 'data-' || prefix === 'aria-') {\n@@ -311,15 +304,10 @@ function validateProperty(tagName, name, value, eventRegistry) {\n case 'reversed':\n case 'scoped':\n case 'seamless':\n- case 'itemScope': {\n- break;\n- }\n+ case 'itemScope':\n case 'inert': {\n- if (enableNewBooleanProps) {\n- break;\n- }\n+ break;\n }\n- \/\/ fallthrough for new boolean props without the flag on\n default: {\n return true;\n }\ndiff --git a\/packages\/react-dom-bindings\/src\/shared\/possibleStandardNames.js b\/packages\/react-dom-bindings\/src\/shared\/possibleStandardNames.js\nindex d2d90877b5..6c06b47c64 100644\n--- a\/packages\/react-dom-bindings\/src\/shared\/possibleStandardNames.js\n+++ b\/packages\/react-dom-bindings\/src\/shared\/possibleStandardNames.js\n@@ -4,7 +4,6 @@\n * This source code is licensed under the MIT license found in the\n * LICENSE file in the root directory of this source tree.\n *\/\n-import {enableNewBooleanProps} from 'shared\/ReactFeatureFlags';\n \n \/\/ When adding attributes to the HTML or SVG allowed attribute list, be sure to\n \/\/ also add them to this module to ensure casing and incorrect name\n@@ -83,6 +82,7 @@ const possibleStandardNames = {\n id: 'id',\n imagesizes: 'imageSizes',\n imagesrcset: 'imageSrcSet',\n+ inert: 'inert',\n innerhtml: 'innerHTML',\n inputmode: 'inputMode',\n integrity: 'integrity',\n@@ -503,8 +503,4 @@ const possibleStandardNames = {\n zoomandpan: 'zoomAndPan',\n };\n \n-if (enableNewBooleanProps) {\n- possibleStandardNames.inert = 'inert';\n-}\n-\n export default possibleStandardNames;\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMAttribute-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMAttribute-test.js\nindex 402693c407..13fa1cba49 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMAttribute-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMAttribute-test.js\n@@ -12,14 +12,12 @@\n describe('ReactDOM unknown attribute', () => {\n let React;\n let ReactDOMClient;\n- let ReactFeatureFlags;\n let act;\n \n beforeEach(() => {\n jest.resetModules();\n React = require('react');\n ReactDOMClient = require('react-dom\/client');\n- ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n act = require('internal-test-utils').act;\n });\n \n@@ -98,15 +96,9 @@ describe('ReactDOM unknown attribute', () => {\n await act(() => {\n root.render(

);\n });\n- }).toErrorDev(\n- ReactFeatureFlags.enableNewBooleanProps\n- ? []\n- : ['Warning: Received `true` for a non-boolean attribute `inert`.'],\n- );\n+ }).toErrorDev([]);\n \n- expect(el.firstChild.getAttribute('inert')).toBe(\n- ReactFeatureFlags.enableNewBooleanProps ? '' : null,\n- );\n+ expect(el.firstChild.getAttribute('inert')).toBe(true ? '' : null);\n });\n \n it('warns once for empty strings in new boolean props', async () => {\n@@ -117,20 +109,14 @@ describe('ReactDOM unknown attribute', () => {\n await act(() => {\n root.render(

);\n });\n- }).toErrorDev(\n- ReactFeatureFlags.enableNewBooleanProps\n- ? [\n- 'Warning: Received an empty string for a boolean attribute `inert`. ' +\n- 'This will treat the attribute as if it were false. ' +\n- 'Either pass `false` to silence this warning, or ' +\n- 'pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.',\n- ]\n- : [],\n- );\n-\n- expect(el.firstChild.getAttribute('inert')).toBe(\n- ReactFeatureFlags.enableNewBooleanProps ? null : '',\n- );\n+ }).toErrorDev([\n+ 'Warning: Received an empty string for a boolean attribute `inert`. ' +\n+ 'This will treat the attribute as if it were false. ' +\n+ 'Either pass `false` to silence this warning, or ' +\n+ 'pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.',\n+ ]);\n+\n+ expect(el.firstChild.getAttribute('inert')).toBe(true ? null : '');\n \n \/\/ The warning is only printed once.\n await act(() => {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js\nindex 80467e5efc..5d798e3f58 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js\n@@ -742,36 +742,24 @@ describe('ReactDOMServerIntegration', () => {\n });\n \n itRenders('new boolean `true` attributes', async render => {\n- const element = await render(\n-

,\n- ReactFeatureFlags.enableNewBooleanProps ? 0 : 1,\n- );\n+ const element = await render(

, 0);\n \n- expect(element.getAttribute('inert')).toBe(\n- ReactFeatureFlags.enableNewBooleanProps ? '' : null,\n- );\n+ expect(element.getAttribute('inert')).toBe('');\n });\n \n itRenders('new boolean `\"\"` attributes', async render => {\n const element = await render(\n

,\n- ReactFeatureFlags.enableNewBooleanProps\n- ? \/\/ Warns since this used to render `inert=\"\"` like `inert={true}`\n- \/\/ but now renders it like `inert={false}`.\n- 1\n- : 0,\n+ \/\/ Warns since this used to render `inert=\"\"` like `inert={true}`\n+ \/\/ but now renders it like `inert={false}`.\n+ 1,\n );\n \n- expect(element.getAttribute('inert')).toBe(\n- ReactFeatureFlags.enableNewBooleanProps ? null : '',\n- );\n+ expect(element.getAttribute('inert')).toBe(null);\n });\n \n itRenders('new boolean `false` attributes', async render => {\n- const element = await render(\n-

,\n- ReactFeatureFlags.enableNewBooleanProps ? 0 : 1,\n- );\n+ const element = await render(

, 0);\n \n expect(element.getAttribute('inert')).toBe(null);\n });\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex d2fad79056..4d4fc361f4 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -183,13 +183,6 @@ export const disableLegacyMode = __NEXT_MAJOR__;\n \n export const disableDOMTestUtils = __NEXT_MAJOR__;\n \n-\/\/ HTML boolean attributes need a special PropertyInfoRecord.\n-\/\/ Between support of these attributes in browsers and React supporting them as\n-\/\/ boolean props library users can use them as `

`.\n-\/\/ However, once React considers them as boolean props an empty string will\n-\/\/ result in false property i.e. break existing usage.\n-export const enableNewBooleanProps = __NEXT_MAJOR__;\n-\n \/\/ Make equivalent to instead of \n export const enableRenderableContext = __NEXT_MAJOR__;\n \ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex cf821b1554..13e8d00c5b 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -78,7 +78,6 @@ export const enableLazyContextPropagation = false;\n export const enableLegacyHidden = false;\n export const forceConcurrentByDefaultForTesting = false;\n export const allowConcurrentByDefault = false;\n-export const enableNewBooleanProps = true;\n \n export const enableTransitionTracing = false;\n \ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex 710b7ed4ef..904f165c21 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -99,7 +99,6 @@ export const enableLazyContextPropagation = false;\n export const enableLegacyHidden = false;\n export const forceConcurrentByDefaultForTesting = false;\n export const allowConcurrentByDefault = false;\n-export const enableNewBooleanProps = true;\n export const enableTransitionTracing = false;\n export const enableDO_NOT_USE_disableStrictPassiveEffect = false;\n export const passChildrenWhenCloningPersistedNodes = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex 6d6ab23ae1..df84dd4d4c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -92,7 +92,6 @@ export const enableBigIntSupport = __NEXT_MAJOR__;\n export const disableLegacyMode = __NEXT_MAJOR__;\n export const disableLegacyContext = __NEXT_MAJOR__;\n export const disableDOMTestUtils = __NEXT_MAJOR__;\n-export const enableNewBooleanProps = __NEXT_MAJOR__;\n export const enableRenderableContext = __NEXT_MAJOR__;\n export const enableReactTestRendererWarning = __NEXT_MAJOR__;\n \ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\nindex d36d9cfb60..879806d751 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n@@ -59,7 +59,6 @@ export const enableLegacyHidden = false;\n export const forceConcurrentByDefaultForTesting = false;\n export const enableUnifiedSyncLane = true;\n export const allowConcurrentByDefault = true;\n-export const enableNewBooleanProps = true;\n \n export const consoleManagedByDevToolsDuringStrictMode = false;\n \ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex 671d55aa82..137852fad7 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -59,7 +59,6 @@ export const enableLegacyHidden = false;\n export const forceConcurrentByDefaultForTesting = false;\n export const enableUnifiedSyncLane = true;\n export const allowConcurrentByDefault = true;\n-export const enableNewBooleanProps = false;\n \n export const consoleManagedByDevToolsDuringStrictMode = false;\n \ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js b\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\nindex b542bbb10a..95b9927092 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js\n@@ -30,7 +30,6 @@ export const enableUseDeferredValueInitialArg = __VARIANT__;\n export const enableRenderableContext = __VARIANT__;\n export const useModernStrictMode = __VARIANT__;\n export const enableRefAsProp = __VARIANT__;\n-export const enableNewBooleanProps = __VARIANT__;\n export const enableRetryLaneExpiration = __VARIANT__;\n export const favorSafetyOverHydrationPerf = __VARIANT__;\n export const retryLaneExpirationMs = 5000;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex fccd09645e..79ff994a0a 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -38,7 +38,6 @@ export const {\n enableRenderableContext,\n useModernStrictMode,\n enableRefAsProp,\n- enableNewBooleanProps,\n favorSafetyOverHydrationPerf,\n } = dynamicFeatureFlags;\n \n","commit":{"authorName":"Jack Pope","authorEmail":"jackpope1@gmail.com","shortRevision":"6cd6ba703d","revision":"6cd6ba703de77e332ab201518b6e30e47cd49aaf","authoredAt":"2024-03-29T16:02:32-04:00","subject":"Land enableNewBooleanProps everywhere (#28676)"}}

dillon1000/react

Files changed