dillon1000/react

Commit

Renamed selfBaseTime/treeBaseTime Fiber attributes to selfBaseDuration/treeBaseDuration (#13156)

This is an unobservable change to all but the (under development) DevTools Profiler plugin. It is being done so that the plugin can safely feature detect a version of React that supports it. The profiler API has existed since the 16.4.0 release, but it did not support the DevTools plugin prior to PR #13058.

Side note: I am not a big fan of the term "base duration". Both it and "actual duration" are kind of awkward and vague. If anyone has suggestions for better names– this is the best time to bikeshed about them.
Browse files
Brian Vaughn authored 6f6b560a645adb595ba1e40630a3915d8abdf038 Parent 1386ccd
Changed paths5 files
First-parent comparison
M packages/react-reconciler/src/ReactFiber.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-reconciler/src/ReactFiberScheduler.js ModifiedM packages/react-reconciler/src/ReactProfilerTimer.js ModifiedM packages/react/src/__tests__/ReactProfilerDevToolsIntegration-test.internal.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…