{"parents":["9fe1031244903e442de179821f1d383a9f2a59f2"],"files":[{"status":"M","path":"packages\/react-reconciler\/src\/__tests__\/ReactFragment-test.js"}],"patch":"diff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactFragment-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactFragment-test.js\nindex 38e6c972f3..10537e0d5a 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactFragment-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactFragment-test.js\n@@ -722,6 +722,149 @@ describe('ReactFragment', () => {\n expect(ReactNoop.getChildren()).toEqual([div(div(), span())]);\n });\n \n+ it('should not preserve state when switching a nested unkeyed fragment to a passthrough component', function() {\n+ const ops = [];\n+\n+ function Passthrough({children}) {\n+ return children;\n+ }\n+\n+ class Stateful extends React.Component {\n+ componentDidUpdate() {\n+ ops.push('Update Stateful');\n+ }\n+\n+ render() {\n+ return

Hello<\/div>;\n+ }\n+ }\n+\n+ function Foo({condition}) {\n+ return condition ? (\n+ <>\n+ <>\n+ \n+ <\/>\n+ <\/>\n+ ) : (\n+ <>\n+ \n+ \n+ <\/Passthrough>\n+ <\/>\n+ );\n+ }\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ expect(ops).toEqual([]);\n+ expect(ReactNoop.getChildren()).toEqual([div()]);\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ expect(ops).toEqual([]);\n+ expect(ReactNoop.getChildren()).toEqual([div()]);\n+ });\n+\n+ it('should not preserve state when switching a nested keyed fragment to a passthrough component', function() {\n+ const ops = [];\n+\n+ function Passthrough({children}) {\n+ return children;\n+ }\n+\n+ class Stateful extends React.Component {\n+ componentDidUpdate() {\n+ ops.push('Update Stateful');\n+ }\n+\n+ render() {\n+ return

Hello<\/div>;\n+ }\n+ }\n+\n+ function Foo({condition}) {\n+ return condition ? (\n+ <>\n+ \n+ \n+ <\/React.Fragment>\n+ <\/>\n+ ) : (\n+ <>\n+ \n+ \n+ <\/Passthrough>\n+ <\/>\n+ );\n+ }\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ expect(ops).toEqual([]);\n+ expect(ReactNoop.getChildren()).toEqual([div()]);\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ expect(ops).toEqual([]);\n+ expect(ReactNoop.getChildren()).toEqual([div()]);\n+ });\n+\n+ it('should not preserve state when switching a nested keyed array to a passthrough component', function() {\n+ const ops = [];\n+\n+ function Passthrough({children}) {\n+ return children;\n+ }\n+\n+ class Stateful extends React.Component {\n+ componentDidUpdate() {\n+ ops.push('Update Stateful');\n+ }\n+\n+ render() {\n+ return

Hello<\/div>;\n+ }\n+ }\n+\n+ function Foo({condition}) {\n+ return condition ? (\n+ <>{[]}<\/>\n+ ) : (\n+ <>\n+ \n+ \n+ <\/Passthrough>\n+ <\/>\n+ );\n+ }\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ expect(ops).toEqual([]);\n+ expect(ReactNoop.getChildren()).toEqual([div()]);\n+\n+ ReactNoop.render();\n+ expect(Scheduler).toFlushWithoutYielding();\n+\n+ expect(ops).toEqual([]);\n+ expect(ReactNoop.getChildren()).toEqual([div()]);\n+ });\n+\n it('should preserve state when it does not change positions', function() {\n const ops = [];\n \n","commit":{"shortRevision":"6fef7c47a9","revision":"6fef7c47a984cf0d07776c017e58b45f5af8276e","authorEmail":"dan.abramov@gmail.com","authoredAt":"2019-12-18T15:21:42+00:00","authorName":"Dan Abramov","subject":"Add a regression test for switching from Fragment to a component (#17647)"},"body":"* Add a regression test for switching from Fragment to a component\r\n\r\n* Add a few more tests"}

dillon1000/react

Files changed