{"commit":{"authorEmail":"bvaughn@fb.com","authorName":"Brian Vaughn","subject":"Added Flow types to profiling test","revision":"705cd9b10993fab6d05844f2a7d527d555dbeea6","shortRevision":"705cd9b109","authoredAt":"2019-05-06T09:44:01-07:00"},"body":"","parents":["c29483122ce8297c7c136c50cdf31cb89fcb4c04"],"files":[{"path":"flow-typed\/npm\/react-test-renderer_v16.x.x.js","status":"A"},{"path":"src\/__tests__\/profiling-test.js","status":"M"},{"path":"src\/__tests__\/utils.js","status":"M"}],"patch":"diff --git a\/flow-typed\/npm\/react-test-renderer_v16.x.x.js b\/flow-typed\/npm\/react-test-renderer_v16.x.x.js\nnew file mode 100644\nindex 0000000000..87a149a1d3\n--- \/dev\/null\n+++ b\/flow-typed\/npm\/react-test-renderer_v16.x.x.js\n@@ -0,0 +1,81 @@\n+\/\/ flow-typed signature: b6bb53397d83d2d821e258cc73818d1b\n+\/\/ flow-typed version: 9c71eca8ef\/react-test-renderer_v16.x.x\/flow_>=v0.47.x\n+\n+\/\/ Type definitions for react-test-renderer 16.x.x\n+\/\/ Ported from: https:\/\/github.com\/DefinitelyTyped\/DefinitelyTyped\/blob\/master\/types\/react-test-renderer\n+\n+type ReactComponentInstance = React$Component;\n+\n+type ReactTestRendererJSON = {\n+ type: string,\n+ props: { [propName: string]: any },\n+ children: null | ReactTestRendererJSON[],\n+};\n+\n+type ReactTestRendererTree = ReactTestRendererJSON & {\n+ nodeType: 'component' | 'host',\n+ instance: ?ReactComponentInstance,\n+ rendered: null | ReactTestRendererTree,\n+};\n+\n+type ReactTestInstance = {\n+ instance: ?ReactComponentInstance,\n+ type: string,\n+ props: { [propName: string]: any },\n+ parent: null | ReactTestInstance,\n+ children: Array,\n+\n+ find(predicate: (node: ReactTestInstance) => boolean): ReactTestInstance,\n+ findByType(type: React$ElementType): ReactTestInstance,\n+ findByProps(props: { [propName: string]: any }): ReactTestInstance,\n+\n+ findAll(\n+ predicate: (node: ReactTestInstance) => boolean,\n+ options?: { deep: boolean }\n+ ): ReactTestInstance[],\n+ findAllByType(\n+ type: React$ElementType,\n+ options?: { deep: boolean }\n+ ): ReactTestInstance[],\n+ findAllByProps(\n+ props: { [propName: string]: any },\n+ options?: { deep: boolean }\n+ ): ReactTestInstance[],\n+};\n+\n+type TestRendererOptions = {\n+ createNodeMock(element: React$Element): any,\n+};\n+\n+declare module 'react-test-renderer' {\n+ declare export type ReactTestRenderer = {\n+ toJSON(): null | ReactTestRendererJSON,\n+ toTree(): null | ReactTestRendererTree,\n+ unmount(nextElement?: React$Element): void,\n+ update(nextElement: React$Element): void,\n+ getInstance(): ?ReactComponentInstance,\n+ root: ReactTestInstance,\n+ };\n+\n+ declare type Thenable = {\n+ then(resolve: () => mixed, reject?: () => mixed): mixed,\n+ };\n+\n+ declare function create(\n+ nextElement: React$Element,\n+ options?: TestRendererOptions\n+ ): ReactTestRenderer;\n+\n+ declare function act(callback: () => void): Thenable;\n+}\n+\n+declare module 'react-test-renderer\/shallow' {\n+ declare export default class ShallowRenderer {\n+ static createRenderer(): ShallowRenderer;\n+ getMountedInstance(): ReactTestInstance;\n+ getRenderOutput>(): E;\n+ getRenderOutput(): React$Element;\n+ render(element: React$Element, context?: any): void;\n+ unmount(): void;\n+ }\n+}\ndiff --git a\/src\/__tests__\/profiling-test.js b\/src\/__tests__\/profiling-test.js\nindex de2d4cf04c..5bd2e037bb 100644\n--- a\/src\/__tests__\/profiling-test.js\n+++ b\/src\/__tests__\/profiling-test.js\n@@ -1,12 +1,17 @@\n \/\/ @flow\n \n+import type React from 'react';\n+import type ReactDOM from 'react-dom';\n+import typeof ReactTestRenderer from 'react-test-renderer';\n+import type Store from 'src\/devtools\/store';\n+\n describe('profiling', () => {\n- let React;\n- let ReactDOM;\n+ let React: React;\n+ let ReactDOM: ReactDOM;\n let Scheduler;\n let SchedulerTracing;\n- let TestRenderer;\n- let store;\n+ let TestRenderer: ReactTestRenderer;\n+ let store: Store;\n let utils;\n \n beforeEach(() => {\n@@ -161,17 +166,21 @@ describe('profiling', () => {\n const rootID = store.roots[0];\n \n for (let index = 0; index < store.numElements; index++) {\n- await utils.actSuspense(() =>\n+ await utils.actSuspense(() => {\n+ const fiberID = store.getElementIDAtIndex(index);\n+ if (fiberID == null) {\n+ throw Error(`Unexpected null ID for element at index ${index}`);\n+ }\n TestRenderer.create(\n \n \n <\/React.Suspense>\n- )\n- );\n+ );\n+ });\n }\n \n done();\ndiff --git a\/src\/__tests__\/utils.js b\/src\/__tests__\/utils.js\nindex cb15590ee5..1e3acc55ac 100644\n--- a\/src\/__tests__\/utils.js\n+++ b\/src\/__tests__\/utils.js\n@@ -1,5 +1,7 @@\n \/\/ @flow\n \n+import typeof ReactTestRenderer from 'react-test-renderer';\n+\n export function act(callback: Function): void {\n const TestUtils = require('react-dom\/test-utils');\n TestUtils.act(() => {\n@@ -10,7 +12,7 @@ export function act(callback: Function): void {\n jest.runAllTimers();\n }\n \n-export async function actSuspense(callback: Function) {\n+export async function actSuspense(callback: Function): Promise {\n const TestUtils = require('react-dom\/test-utils');\n const Scheduler = require('scheduler');\n \n@@ -26,7 +28,7 @@ export async function actSuspense(callback: Function) {\n Scheduler.flushAll();\n }\n \n-export function beforeEachProfiling() {\n+export function beforeEachProfiling(): void {\n \/\/ Mock React's timing information so that test runs are predictable.\n jest.mock('scheduler', () =>\n \/\/ $FlowFixMe Flow does not konw about requireActual\n@@ -41,7 +43,7 @@ export function beforeEachProfiling() {\n );\n }\n \n-export function getRendererID() {\n+export function getRendererID(): number {\n if (global.agent == null) {\n throw Error('Agent unavailable.');\n }\n@@ -49,10 +51,10 @@ export function getRendererID() {\n if (ids.length !== 1) {\n throw Error('Multiple renderers attached.');\n }\n- return ids[0];\n+ return parseInt(ids[0], 10);\n }\n \n-export function requireTestRenderer() {\n+export function requireTestRenderer(): ReactTestRenderer {\n let hook;\n try {\n \/\/ Hide the hook before requiring TestRenderer, so we don't end up with a loop.\n"}

dillon1000/react

Files changed