dillon1000/react

Commit

Correctly remove attributes when deleting props

The most obvious manifestation of this bug is visible here:
http://jsfiddle.net/spicyj/zzGas/. In short, when props are removed from a
component, the underlying HTML element doesn't have the attribute
removed.

This change should fix it, but unfortunately it (presumably) makes
_updateDOMProperties a bit slower.
Browse files
Changed paths10 files
First-parent comparison
M src/core/ReactComponent.js ModifiedM src/core/ReactDOMIDOperations.js ModifiedM src/core/ReactEventEmitter.js ModifiedM src/core/ReactNativeComponent.js ModifiedM src/core/__tests__/ReactNativeComponent-test.js ModifiedM src/dom/CSSProperty.js ModifiedM src/dom/CSSPropertyOperations.js ModifiedM src/dom/DOMProperty.js ModifiedM src/dom/DOMPropertyOperations.js ModifiedM src/event/EventPluginHub.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…