{"files":[{"path":"packages\/react-dom\/src\/__tests__\/ReactIdentity-test.js","status":"M"}],"commit":{"shortRevision":"710d5137e2","authoredAt":"2024-02-15T19:14:19+01:00","authorName":"Sebastian Silbermann","subject":"Remove ReactTestUtils from ReactIdentity (#28332)","authorEmail":"silbermann.sebastian@gmail.com","revision":"710d5137e27db578dfec723b2c006821a1a61973"},"body":"","parents":["2e470a788e359e34feeadb422daaff046baf66cc"],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactIdentity-test.js b\/packages\/react-dom\/src\/__tests__\/ReactIdentity-test.js\nindex 5c25daf7d8..293916261c 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactIdentity-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactIdentity-test.js\n@@ -11,7 +11,6 @@\n \n let React;\n let ReactDOMClient;\n-let ReactTestUtils;\n let act;\n \n describe('ReactIdentity', () => {\n@@ -19,7 +18,6 @@ describe('ReactIdentity', () => {\n jest.resetModules();\n React = require('react');\n ReactDOMClient = require('react-dom\/client');\n- ReactTestUtils = require('react-dom\/test-utils');\n act = require('internal-test-utils').act;\n });\n \n@@ -127,7 +125,7 @@ describe('ReactIdentity', () => {\n expect(window.YOUVEBEENH4X0RED).toBe(undefined);\n });\n \n- it('should let restructured components retain their uniqueness', () => {\n+ it('should let restructured components retain their uniqueness', async () => {\n const instance0 = ;\n const instance1 = ;\n const instance2 = ;\n@@ -155,12 +153,16 @@ describe('ReactIdentity', () => {\n }\n }\n \n- expect(function () {\n- ReactTestUtils.renderIntoDocument();\n- }).not.toThrow();\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(\n+ act(() => {\n+ root.render();\n+ }),\n+ ).resolves.not.toThrow();\n });\n \n- it('should let nested restructures retain their uniqueness', () => {\n+ it('should let nested restructures retain their uniqueness', async () => {\n const instance0 = ;\n const instance1 = ;\n const instance2 = ;\n@@ -190,12 +192,16 @@ describe('ReactIdentity', () => {\n }\n }\n \n- expect(function () {\n- ReactTestUtils.renderIntoDocument();\n- }).not.toThrow();\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(\n+ act(() => {\n+ root.render();\n+ }),\n+ ).resolves.not.toThrow();\n });\n \n- it('should let text nodes retain their uniqueness', () => {\n+ it('should let text nodes retain their uniqueness', async () => {\n class TestComponent extends React.Component {\n render() {\n return (\n@@ -218,9 +224,13 @@ describe('ReactIdentity', () => {\n }\n }\n \n- expect(function () {\n- ReactTestUtils.renderIntoDocument();\n- }).not.toThrow();\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(\n+ act(() => {\n+ root.render();\n+ }),\n+ ).resolves.not.toThrow();\n });\n \n it('should retain key during updates in composite components', async () => {\n@@ -272,7 +282,7 @@ describe('ReactIdentity', () => {\n expect(beforeB).toBe(afterB);\n });\n \n- it('should not allow implicit and explicit keys to collide', () => {\n+ it('should not allow implicit and explicit keys to collide', async () => {\n const component = (\n

\n \n@@ -280,9 +290,13 @@ describe('ReactIdentity', () => {\n <\/div>\n );\n \n- expect(function () {\n- ReactTestUtils.renderIntoDocument(component);\n- }).not.toThrow();\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(\n+ act(() => {\n+ root.render(component);\n+ }),\n+ ).resolves.not.toThrow();\n });\n \n it('should throw if key is a Temporal-like object', async () => {\n"}

dillon1000/react

Files changed