dillon1000/react

Commit

Refactor findHostInstance and findNodeHandle (#12575)

* Move findNodeHandle into the renderers and use instantiation

This is just like ReactDOM does it. This also lets us get rid of injection
for findNodeHandle. Instead I move NativeMethodsMixin and ReactNativeComponent
to use instantiation.

* Refactor findHostInstance

The reconciler shouldn't expose the Fiber data structure. We should pass
the component instance to the reconciler, since the reconciler is the
thing that is supposed to be instancemap aware.

* Fix devtools injection
Browse files
Sebastian Markbåge authored 725c054d4d5d07c5c553a1ca724b01f2e6a43c5d Parent b99d0b1
Changed paths10 files
First-parent comparison
M packages/react-dom/src/__tests__/findDOMNode-test.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-native-renderer/src/NativeMethodsMixin.js ModifiedM packages/react-native-renderer/src/ReactFabric.js ModifiedM packages/react-native-renderer/src/ReactNativeComponent.js ModifiedM packages/react-native-renderer/src/ReactNativeRenderer.js ModifiedD packages/react-native-renderer/src/findNodeHandle.js DeletedD packages/react-native-renderer/src/findNumericNodeHandle.js DeletedM packages/react-noop-renderer/src/ReactNoop.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…