dillon1000/react

Commit

Add invariant for problematic LeaveSSA case

The new LeaveSSA looks ahead to the phis of fallback blocks. However, HIR can 
sometimes have multiple blocks with the same fallthrough (totally fine), so this 
diff clears the phis of fallbacks as they are reached to avoid reprocessing 
them. This caused a previously incorrect case to now fail, yay.
Browse files
Joe Savona authored 73ad571c6b52cd7e5321ab52c81c5a133fd1d201 Parent 4b66531
Changed paths7 files
First-parent comparison
M compiler/forget/src/HIR/HIRBuilder.ts ModifiedM compiler/forget/src/HIR/LeaveSSA.ts ModifiedM compiler/forget/src/HIR/Pipeline.ts ModifiedM compiler/forget/src/HIR/logger.ts ModifiedD compiler/forget/src/__tests__/fixtures/hir/_bug_inverted-if-else.expect.md DeletedA compiler/forget/src/__tests__/fixtures/hir/error.inverted-if-else.expect.md AddedR compiler/forget/src/__tests__/fixtures/hir/_bug_inverted-if-else.js →compiler/forget/src/__tests__/fixtures/hir/error.inverted-if-else.js Renamed
Patch

Files changed

Rendering syntax-highlighted changes…