{"patch":"diff --git a\/compiler\/forget\/crates\/forget_build_hir\/src\/build.rs b\/compiler\/forget\/crates\/forget_build_hir\/src\/build.rs\nindex a7913e6495..eea36ffd00 100644\n--- a\/compiler\/forget\/crates\/forget_build_hir\/src\/build.rs\n+++ b\/compiler\/forget\/crates\/forget_build_hir\/src\/build.rs\n@@ -2,9 +2,8 @@ use std::collections::HashSet;\n \n use forget_diagnostics::Diagnostic;\n use forget_estree::{\n- AssignmentTarget, BinaryExpression, BlockStatement, Expression, ExpressionOrSpread,\n- ExpressionOrSuper, ForInit, ForStatement, Function, FunctionExpression, IfStatement,\n- IntoFunction, JsValue, Literal, Number, Pattern, Statement, VariableDeclaration,\n+ AssignmentTarget, BlockStatement, Expression, ExpressionOrSpread, ExpressionOrSuper, ForInit,\n+ Function, IntoFunction, JsValue, Pattern, Statement, VariableDeclaration,\n VariableDeclarationKind,\n };\n use forget_hir::{\n@@ -13,7 +12,7 @@ use forget_hir::{\n Operand, PlaceOrSpread, TerminalValue,\n };\n \n-use crate::builder::{Binding, Builder, LoopScope};\n+use crate::builder::{Builder, LoopScope};\n use crate::context::get_context_identifiers;\n use crate::error::BuildHIRError;\n \n@@ -490,9 +489,7 @@ fn lower_function(\n _builder: &mut Builder,\n function: &T,\n ) -> Result {\n- println!(\"get_context_identifiers() ...\");\n let context_identifiers = get_context_identifiers(env, function);\n- println!(\"ok\");\n let mut context = Vec::new();\n let mut seen = HashSet::new();\n for declaration_id in context_identifiers {\n@@ -526,7 +523,7 @@ fn lower_jsx_element(\n .iter()\n .map(|attr| lower_jsx_attribute(env, builder, attr))\n .collect();\n- let props = props?;\n+ let _props = props?;\n let children: Result, Diagnostic> = expr\n .children\n .iter()\n@@ -535,7 +532,7 @@ fn lower_jsx_element(\n Ok(Operand { effect: None, ix })\n })\n .collect();\n- let children = children?;\n+ let _children = children?;\n todo!(\"lower jsx element\");\n \/\/ Ok(JSXElement {\n \/\/ tag: todo!(),\n@@ -549,17 +546,17 @@ fn lower_jsx_element(\n }\n \n fn lower_jsx_attribute(\n- env: &Environment,\n- builder: &mut Builder,\n- attr: &forget_estree::JSXAttributeOrSpread,\n+ _env: &Environment,\n+ _builder: &mut Builder,\n+ _attr: &forget_estree::JSXAttributeOrSpread,\n ) -> Result {\n todo!(\"lower jsx attribute\")\n }\n \n fn lower_jsx_child(\n- env: &Environment,\n- builder: &mut Builder,\n- child: &forget_estree::JSXChildItem,\n+ _env: &Environment,\n+ _builder: &mut Builder,\n+ _child: &forget_estree::JSXChildItem,\n ) -> Result {\n todo!(\"lower jsx child\")\n }\n@@ -603,7 +600,7 @@ fn lower_assignment_pattern(\n \n fn lower_identifier_for_assignment(\n env: &Environment,\n- builder: &mut Builder,\n+ _builder: &mut Builder,\n kind: InstructionKind,\n node: &forget_estree::Identifier,\n ) -> Result {\ndiff --git a\/compiler\/forget\/crates\/forget_build_hir\/src\/builder.rs b\/compiler\/forget\/crates\/forget_build_hir\/src\/builder.rs\nindex cf035976bf..f74ae80b75 100644\n--- a\/compiler\/forget\/crates\/forget_build_hir\/src\/builder.rs\n+++ b\/compiler\/forget\/crates\/forget_build_hir\/src\/builder.rs\n@@ -3,9 +3,9 @@ use std::rc::Rc;\n \n use forget_diagnostics::Diagnostic;\n use forget_hir::{\n- initialize_hir, BasicBlock, BlockId, BlockKind, Blocks, Environment, GotoKind, Identifier,\n- IdentifierData, InstrIx, Instruction, InstructionIdGenerator, InstructionValue, Terminal,\n- TerminalValue, Type, HIR,\n+ initialize_hir, BasicBlock, BlockId, BlockKind, Blocks, Environment, GotoKind, IdentifierData,\n+ InstrIx, Instruction, InstructionIdGenerator, InstructionValue, Terminal, TerminalValue, Type,\n+ HIR,\n };\n \n use crate::BuildHIRError;\n@@ -42,12 +42,6 @@ pub(crate) struct WipBlock {\n pub instructions: Vec,\n }\n \n-pub(crate) enum Binding {\n- Local(Identifier),\n- Module(Identifier),\n- Global,\n-}\n-\n #[derive(Clone, PartialEq, Eq, Debug)]\n enum ControlFlowScope {\n Loop(LoopScope),\ndiff --git a\/compiler\/forget\/crates\/forget_build_hir\/src\/context.rs b\/compiler\/forget\/crates\/forget_build_hir\/src\/context.rs\nindex f23ed9b76c..6bfaa65ddd 100644\n--- a\/compiler\/forget\/crates\/forget_build_hir\/src\/context.rs\n+++ b\/compiler\/forget\/crates\/forget_build_hir\/src\/context.rs\n@@ -9,10 +9,6 @@ pub(crate) fn get_context_identifiers(\n node: &T,\n ) -> Vec {\n let function_scope = env.scope(node.function()).unwrap();\n- println!(\n- \"get_context_identifiers for function scope {:?}\",\n- function_scope.id()\n- );\n let mut free = FreeVariables::default();\n let mut seen = HashSet::new();\n populate_free_variable_references(&mut free, &mut seen, function_scope);\n@@ -28,28 +24,11 @@ fn populate_free_variable_references(\n ) {\n for reference in scope.references() {\n if !seen.insert(reference.declaration().id()) {\n- println!(\n- \"skip {}${:?}\",\n- reference.declaration().name(),\n- reference.declaration().id()\n- );\n continue;\n }\n let declaration_scope = reference.declaration().scope();\n if !declaration_scope.is_descendant_of(scope) {\n- println!(\n- \"free variable: not descendant {}${:?}\",\n- reference.declaration().name(),\n- reference.declaration().id()\n- );\n free.push(reference.declaration().id())\n- } else {\n- println!(\n- \"local variable: descendant {}${:?} scope={:?}\",\n- reference.declaration().name(),\n- reference.declaration().id(),\n- reference.declaration().scope().id()\n- );\n }\n }\n for child in scope.children() {\ndiff --git a\/compiler\/forget\/crates\/forget_estree\/src\/generated.rs b\/compiler\/forget\/crates\/forget_estree\/src\/generated.rs\nindex d135569dba..1caca408d2 100644\n--- a\/compiler\/forget\/crates\/forget_estree\/src\/generated.rs\n+++ b\/compiler\/forget\/crates\/forget_estree\/src\/generated.rs\n@@ -1,5 +1,8 @@\n \/\/ @generated\n #![cfg_attr(rustfmt, rustfmt_skip)]\n+#![allow(dead_code)]\n+#![allow(unused_variables)]\n+#![allow(non_snake_case)]\n use std::num::NonZeroU32;\n use serde::ser::{Serializer, SerializeMap};\n use serde::{Serialize, Deserialize};\ndiff --git a\/compiler\/forget\/crates\/forget_estree\/src\/old.lib.rs b\/compiler\/forget\/crates\/forget_estree\/src\/old.lib.rs\ndeleted file mode 100644\nindex b7c9188767..0000000000\n--- a\/compiler\/forget\/crates\/forget_estree\/src\/old.lib.rs\n+++ \/dev\/null\n@@ -1,1358 +0,0 @@\n-use serde::{Deserialize, Serialize};\n-use static_assertions::assert_eq_size;\n-use std::{fmt::Display, num::NonZeroU32};\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct SourceLocation {\n- pub source: Option,\n-\n- pub start: Position,\n-\n- pub end: Position,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug, Clone)]\n-pub struct Position {\n- \/\/\/ >= 1\n- pub line: NonZeroU32,\n- \/\/\/ >= 0\n- pub column: u32,\n-}\n-assert_eq_size!(Option, u64);\n-\n-#[derive(Serialize, Deserialize, Debug, Clone)]\n-pub struct SourceRange {\n- pub start: u32,\n- \/\/ end is exclusive so it can always be non-zero. This allows\n- \/\/ Option to not take any additional bytes.\n- pub end: NonZeroU32,\n-}\n-assert_eq_size!(Option, u64);\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct Program {\n- \/\/\/ sourceType\n- #[serde(rename = \"sourceType\")]\n- #[serde(default)]\n- pub source_type: SourceType,\n-\n- pub body: Vec,\n-\n- #[serde(default)]\n- pub comments: Option>,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum SourceType {\n- \/\/\/ \"module\"\n- #[serde(rename = \"module\")]\n- Module,\n- \/\/\/ \"script\"\n- #[serde(rename = \"script\")]\n- Script,\n-}\n-\n-impl Default for SourceType {\n- fn default() -> Self {\n- Self::Module\n- }\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct Comment {\n- pub type_: CommentType,\n- pub value: String,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum CommentType {\n- \/\/\/ \"Line\"\n- Line,\n- \/\/\/ \"Block\"\n- Block,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(untagged)]\n-pub enum ModuleItem {\n- Statement(Box),\n- ImportDeclaration(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum ImportExportDeclaration {\n- ImportDeclaration(Box),\n- \/\/ TODO:\n- \/\/ ExportNamedDeclaration(Box),\n- \/\/ ExportDefaultDeclaration(Box),\n- \/\/ ExportAllDeclaration(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ImportDeclaration {\n- pub specifiers: Vec,\n- pub source: Literal,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum ImportSpecifiers {\n- ImportSpecifier(Box),\n- ImportDefaultSpecifier(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ImportSpecifier {\n- pub imported: Identifier,\n-\n- pub local: Identifier,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ImportDefaultSpecifier {\n- pub local: Identifier,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum Statement {\n- BlockStatement(Box),\n- BreakStatement(Box),\n- ClassDeclaration(Box),\n- ContinueStatement(Box),\n- DebuggerStatement(Box),\n- DoWhileStatement(Box),\n- EmptyStatement(Box),\n- ExpressionStatement(Box),\n- ForInStatement(Box),\n- ForOfStatement(Box),\n- ForStatement(Box),\n- FunctionDeclaration(Box),\n- IfStatement(Box),\n- LabeledStatement(Box),\n- ReturnStatement(Box),\n- StaticBlock(Box),\n- SwitchStatement(Box),\n- ThrowStatement(Box),\n- TryStatement(Box),\n- VariableDeclaration(Box),\n- WhileStatement(Box),\n- WithStatement(Box),\n-}\n-\/\/ Prevent unboxed variants from increasing the size\n-assert_eq_size!(Statement, u128);\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct BlockStatement {\n- pub body: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct BreakStatement {\n- #[serde(default)]\n- pub label: Option,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ClassDeclaration {\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ContinueStatement {\n- #[serde(default)]\n- pub label: Option,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct DebuggerStatement {\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct DoWhileStatement {\n- pub body: Statement,\n- pub test: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct EmptyStatement {\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct FunctionDeclaration {\n- pub id: Option,\n-\n- pub params: Vec,\n-\n- #[serde(rename = \"generator\")]\n- #[serde(default)]\n- pub is_generator: bool,\n-\n- #[serde(rename = \"async\")]\n- #[serde(default)]\n- pub is_async: bool,\n-\n- \/\/ TODO: BlockStatement\n- pub body: Option,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct StaticBlock {\n- pub body: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ExpressionStatement {\n- pub expression: ExpressionLike,\n-\n- #[serde(default)]\n- pub directive: Option,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ForInStatement {\n- pub left: ForPattern,\n- pub right: ExpressionLike,\n- pub body: Statement,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ForOfStatement {\n- #[serde(rename = \"await\")]\n- #[serde(default)]\n- pub is_await: bool,\n-\n- pub left: ForPattern,\n-\n- pub right: ExpressionLike,\n-\n- pub body: Statement,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum ForPattern {\n- VariableDeclaration(Box),\n- Expression(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ForStatement {\n- pub init: Option,\n- pub test: Option,\n- pub update: Option,\n- pub body: Statement,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum ForInit {\n- VariableDeclaration(Box),\n- Expression(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct IfStatement {\n- pub test: ExpressionLike,\n- pub consequent: Statement,\n- pub alternate: Option,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct LabeledStatement {\n- pub label: Identifier,\n- pub body: Statement,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ReturnStatement {\n- pub argument: Option,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct SwitchStatement {\n- pub discriminant: ExpressionLike,\n- pub cases: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct SwitchCase {\n- pub test: Option,\n- pub consequent: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ThrowStatement {\n- pub argument: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct TryStatement {\n- \/\/ TODO: block: BlockStatement\n- pub block: Statement,\n- pub handler: Option,\n- \/\/ TODO: finalizer: BlockStatement\n- pub finalizer: Option,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct CatchClause {\n- pub param: Option,\n- pub body: Statement,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct VariableDeclaration {\n- pub declarations: Vec,\n- pub kind: VariableDeclarationKind,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct VariableDeclarator {\n- pub id: Pattern,\n- pub init: Option,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum VariableDeclarationKind {\n- #[serde(rename = \"const\")]\n- Const,\n- #[serde(rename = \"let\")]\n- Let,\n- #[serde(rename = \"var\")]\n- Var,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct WhileStatement {\n- pub test: ExpressionLike,\n- pub body: Statement,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct WithStatement {\n- pub object: ExpressionLike,\n- pub body: Statement,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-\/\/\/ Expressions and expression-like nodes\n-\/\/\/ we flatten these into a single enum to work around limits\n-\/\/\/ of serde enum format with handling arbitrary unions\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum ExpressionLike {\n- ArrayExpression(Box),\n- ArrowFunctionExpression(Box),\n- AssignmentExpression(Box),\n- AwaitExpression(Box),\n- BinaryExpression(Box),\n- CallExpression(Box),\n- ChainExpression(Box),\n- ClassExpression(Box),\n- ConditionalExpression(Box),\n- FunctionExpression(Box),\n- Identifier(Box),\n- ImportExpression(Box),\n- Literal(Box),\n- LogicalExpression(Box),\n- MemberExpression(Box),\n- MetaProperty(Box),\n- NewExpression(Box),\n- ObjectExpression(Box),\n- SequenceExpression(Box),\n- TaggedTemplateExpression(Box),\n- TemplateLiteral(Box),\n- ThisExpression(Box),\n- UnaryExpression(Box),\n- UpdateExpression(Box),\n- YieldExpression(Box),\n-\n- \/\/ pseudo-expressions to work with serde\n- Super(Box),\n-\n- \/\/ patterns to work with serde\n- ArrayPattern(Box),\n- AssignmentPattern(Box),\n- ObjectPattern(Box),\n- Property(Box),\n- RestElement(Box),\n- SpreadElement(Box),\n-\n- \/\/ jsx expression-ish types to work with serde\n- JSXClosingElement(Box),\n- JSXElement(Box),\n- JSXExpressionContainer(Box),\n- JSXIdentifier(Box),\n- JSXMemberExpression(Box),\n- JSXNamedspacedName(Box),\n- JSXOpeningElement(Box),\n- JSXText(Box),\n-}\n-\/\/ Prevent unboxed variants from increasing the size\n-assert_eq_size!(ExpressionLike, u128);\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ArrayExpression {\n- pub elements: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ArrowFunctionExpression {\n- pub params: Vec,\n-\n- #[serde(rename = \"generator\")]\n- #[serde(default)]\n- pub is_generator: bool,\n-\n- #[serde(rename = \"async\")]\n- #[serde(default)]\n- pub is_async: bool,\n-\n- #[serde(rename = \"expression\")]\n- #[serde(default)]\n- pub is_expression: bool,\n-\n- pub body: BlockOrExpression,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum BlockOrExpression {\n- BlockStatement(Box),\n- Expression(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct AssignmentExpression {\n- pub operator: AssignmentOperator,\n- pub left: AssignmentTarget,\n- pub right: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum AssignmentOperator {\n- \/\/\/ =\n- #[serde(rename = \"=\")]\n- Equals,\n- \/\/\/ +=\n- #[serde(rename = \"+=\")]\n- PlusEquals,\n- \/\/ -=\n- #[serde(rename = \"-=\")]\n- MinusEquals,\n- \/\/\/ *=\n- #[serde(rename = \"*=\")]\n- AsteriskEquals,\n- \/\/\/ \/=\n- #[serde(rename = \"\/=\")]\n- SlashEquals,\n- \/\/\/ %=\n- #[serde(rename = \"%=\")]\n- PercentEquals,\n- \/\/\/ **=\n- #[serde(rename = \"**=\")]\n- AsteriskAsteriskEquals,\n- \/\/\/ <<=\n- #[serde(rename = \"<<=\")]\n- LtLtEquals,\n- \/\/\/ >>=\n- #[serde(rename = \">>=\")]\n- GtGtEquals,\n- \/\/\/ >>>=\n- #[serde(rename = \">>>=\")]\n- GtGtGtEquals,\n- \/\/\/ |=\n- #[serde(rename = \"|=\")]\n- PipeEquals,\n- \/\/\/ ^=\n- #[serde(rename = \"^=\")]\n- CaretEquals,\n- \/\/\/ &=\n- #[serde(rename = \"&&=\")]\n- AmpersandEquals,\n- \/\/\/ ||=\n- #[serde(rename = \"||=\")]\n- PipePipeEquals,\n- \/\/\/ &&=\n- #[serde(rename = \"&&=\")]\n- AmpersandAmpersandEquals,\n- \/\/ ??=\n- #[serde(rename = \"??=\")]\n- QuestionQuestionEquals,\n-}\n-\n-impl AssignmentOperator {\n- pub fn is_simple_equals(&self) -> bool {\n- matches!(self, AssignmentOperator::Equals)\n- }\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(untagged)]\n-pub enum AssignmentTarget {\n- Pattern(Box),\n- MemberExpression(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct AwaitExpression {\n- pub argument: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct BinaryExpression {\n- pub operator: BinaryOperator,\n- pub left: ExpressionLike,\n- pub right: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum BinaryOperator {\n- \/\/\/ ==\n- #[serde(rename = \"==\")]\n- EqualsEquals,\n- \/\/\/ !=\n- #[serde(rename = \"!=\")]\n- NotEquals,\n- \/\/\/ ===\n- #[serde(rename = \"===\")]\n- TripleEquals,\n- \/\/\/ !==\n- #[serde(rename = \"!==\")]\n- NotTripleEquals,\n- \/\/\/ <\n- #[serde(rename = \"<\")]\n- LessThan,\n- \/\/\/ <=\n- #[serde(rename = \"<=\")]\n- LessThanEquals,\n- \/\/\/ >\n- #[serde(rename = \">\")]\n- GreaterThan,\n- \/\/\/ >=\n- #[serde(rename = \">=\")]\n- GreaterThanEquals,\n- \/\/\/ <<\n- #[serde(rename = \"<<\")]\n- LtLt,\n- \/\/\/ >>\n- #[serde(rename = \">>\")]\n- GtGt,\n- \/\/\/ >>>\n- #[serde(rename = \">>>\")]\n- GtGtGt,\n- \/\/\/ +\n- #[serde(rename = \"+\")]\n- Plus,\n- \/\/\/ -\n- #[serde(rename = \"-\")]\n- Minus,\n- \/\/\/ *\n- #[serde(rename = \"*\")]\n- Asterisk,\n- \/\/\/ \/\n- #[serde(rename = \"\/\")]\n- Slash,\n- \/\/\/ %\n- #[serde(rename = \"%\")]\n- Percent,\n- \/\/\/ **\n- #[serde(rename = \"**\")]\n- AsteriskAsterisk,\n- \/\/\/ |\n- #[serde(rename = \"|\")]\n- Pipe,\n- \/\/\/ ^\n- #[serde(rename = \"^\")]\n- Caret,\n- \/\/\/ &\n- #[serde(rename = \"&\")]\n- Ampersand,\n- \/\/\/ in\n- #[serde(rename = \"in\")]\n- In,\n- \/\/\/ instanceof\n- #[serde(rename = \"instanceof\")]\n- Instanceof,\n-}\n-\n-impl Display for BinaryOperator {\n- fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {\n- let name = match self {\n- Self::Plus => \"+\",\n- Self::LessThan => \"<\",\n- _ => todo!(\"display for operator: {:#?}\", self),\n- };\n- f.write_str(name)\n- }\n-}\n-\n-impl std::str::FromStr for BinaryOperator {\n- type Err = String;\n-\n- fn from_str(s: &str) -> Result {\n- match s {\n- \"+\" => Ok(Self::Plus),\n- \"-\" => Ok(Self::Minus),\n- _ => Err(format!(\"Invalid BinaryOperator: `{}`\", s)),\n- }\n- }\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct CallExpression {\n- #[serde(rename = \"optional\")]\n- #[serde(default)]\n- pub is_optional: bool,\n-\n- pub callee: ExpressionLike,\n-\n- pub arguments: Vec,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ChainExpression {\n- pub expression: ChainElement,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum ChainElement {\n- CallExpression(Box),\n- MemberExpression(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ClassExpression {\n- \/\/ TODO\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ConditionalExpression {\n- pub test: ExpressionLike,\n- pub alternate: ExpressionLike,\n- pub consequent: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct FunctionExpression {\n- \/\/ TODO\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ImportExpression {\n- \/\/ TODO\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct Literal {\n- pub value: LiteralValue,\n-\n- #[serde(default)]\n- pub raw: Option,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(untagged)]\n-pub enum LiteralValue {\n- BigInt(String),\n- Boolean(bool),\n- Null,\n- Number(Number),\n- RegExp(RegExp),\n- String(String),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct Number(u64);\n-\n-impl From for Number {\n- fn from(value: u64) -> Self {\n- Number(value)\n- }\n-}\n-\n-impl From for Number {\n- fn from(value: f64) -> Self {\n- Number(value.to_bits())\n- }\n-}\n-\n-impl From for f64 {\n- fn from(value: Number) -> Self {\n- f64::from_bits(value.0)\n- }\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct RegExp {\n- pub raw: Option,\n- pub regex: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct RegExpValue {\n- pub pattern: String,\n- pub flags: String,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct LogicalExpression {\n- pub operator: LogicalOperator,\n- pub left: ExpressionLike,\n- pub right: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum LogicalOperator {\n- \/\/\/ ||\n- #[serde(rename = \"||\")]\n- PipePipe,\n- \/\/\/ &&\n- #[serde(rename = \"&&\")]\n- AmpersandAmpersand,\n- \/\/\/ ??\n- #[serde(rename = \"??\")]\n- QuestionQuestion,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct MetaProperty {\n- \/\/ TODO\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct NewExpression {\n- pub callee: ExpressionLike,\n- pub arguments: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ObjectExpression {\n- pub properties: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct SequenceExpression {\n- pub expressions: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct TaggedTemplateExpression {\n- pub tag: ExpressionLike,\n- pub quasi: TemplateLiteral,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct TemplateLiteral {\n- pub quasis: Vec,\n- pub expressions: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct TemplateElement {\n- #[serde(rename = \"tail\")]\n- #[serde(default)]\n- pub is_tail: bool,\n-\n- \/\/ TODO: add value: {cooked, raw} wrapper object\n- pub cooked: Option,\n-\n- pub raw: String,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ThisExpression {\n- \/\/ TODO\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct UnaryExpression {\n- pub operator: UnaryOperator,\n-\n- #[serde(rename = \"prefix\")]\n- #[serde(default)]\n- pub is_prefix: bool,\n-\n- pub argument: ExpressionLike,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum UnaryOperator {\n- \/\/\/ -\n- #[serde(rename = \"+\")]\n- Minus,\n- \/\/\/ +\n- #[serde(rename = \"+\")]\n- Plus,\n- \/\/\/ !\n- #[serde(rename = \"!\")]\n- Exclamation,\n- \/\/\/ ~\n- #[serde(rename = \"~\")]\n- Tilde,\n- \/\/\/ typeof\n- #[serde(rename = \"typeof\")]\n- Typeof,\n- \/\/\/ void\n- #[serde(rename = \"void\")]\n- Void,\n- \/\/\/ delete\n- #[serde(rename = \"delete\")]\n- Delete,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct UpdateExpression {\n- pub operator: UpdateOperator,\n-\n- pub argument: ExpressionLike,\n-\n- #[serde(rename = \"prefix\")]\n- #[serde(default)]\n- pub is_prefix: bool,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum UpdateOperator {\n- \/\/\/ ++\n- #[serde(rename = \"++\")]\n- PlusPlus,\n- \/\/\/ --\n- #[serde(rename = \"--\")]\n- MinusMinus,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct YieldExpression {\n- pub argument: Option,\n-\n- #[serde(rename = \"delegate\")]\n- #[serde(default)]\n- pub is_delegate: bool,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-\/\/ Pattern etc\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum Pattern {\n- ArrayPattern(Box),\n- AssignmentPattern(Box),\n- Identifier(Box),\n- MemberExpression(Box),\n- ObjectPattern(Box),\n- RestElement(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ArrayPattern {\n- pub elements: Vec,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct AssignmentPattern {\n- pub left: Pattern,\n- pub right: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct Identifier {\n- pub name: String,\n-\n- #[serde(default)]\n- pub binding: Option,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(tag = \"type\")]\n-pub enum Binding {\n- Local(BindingId),\n- Module(BindingId),\n- Global,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Hash, Clone, Copy)]\n-#[serde(transparent)]\n-pub struct BindingId(NonZeroU32);\n-\n-impl BindingId {\n- pub fn new(id: NonZeroU32) -> Self {\n- Self(id)\n- }\n-}\n-\n-impl From for u32 {\n- fn from(value: BindingId) -> Self {\n- value.0.into()\n- }\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct MemberExpression {\n- pub object: ExpressionLike,\n-\n- pub property: ExpressionLike, \/\/ ExpressionOrPrivateIdentifier\n-\n- #[serde(rename = \"computed\")]\n- #[serde(default)]\n- pub is_computed: bool,\n-\n- #[serde(rename = \"optional\")]\n- #[serde(default)]\n- pub is_optional: bool,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct Super {\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct PrivateIdentifier {\n- pub name: String,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct ObjectPattern {\n- pub properties: Vec,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct Property {\n- pub key: ExpressionLike,\n-\n- pub value: PropertyValue,\n-\n- pub kind: PropertyKind,\n-\n- #[serde(rename = \"method\")]\n- #[serde(default)]\n- pub is_method: bool,\n-\n- #[serde(rename = \"shorthand\")]\n- #[serde(default)]\n- pub is_shorthand: bool,\n-\n- #[serde(rename = \"computed\")]\n- #[serde(default)]\n- pub is_computed: bool,\n-\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-#[serde(untagged)]\n-pub enum PropertyValue {\n- Expression(Box),\n- Pattern(Box),\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub enum PropertyKind {\n- #[serde(rename = \"init\")]\n- Init,\n- #[serde(rename = \"get\")]\n- Get,\n- #[serde(rename = \"set\")]\n- Set,\n-}\n-\n-impl Default for PropertyKind {\n- fn default() -> Self {\n- Self::Init\n- }\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct RestElement {\n- pub argument: Pattern,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct SpreadElement {\n- pub argument: ExpressionLike,\n- pub loc: Option,\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXElement {\n- #[serde(rename = \"openingElement\")]\n- pub opening_element: ExpressionLike,\n-\n- pub children: Vec,\n-\n- #[serde(rename = \"closingElement\")]\n- pub closing_element: Option,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXOpeningElement {\n- pub name: ExpressionLike,\n-\n- pub attributes: Vec,\n-\n- #[serde(rename = \"selfClosing\")]\n- #[serde(default)]\n- pub self_closing: bool,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXClosingElement {\n- pub name: ExpressionLike,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXMemberExpression {\n- pub object: ExpressionLike,\n-\n- pub property: ExpressionLike,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXIdentifier {\n- pub name: String,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXNamedspacedName {\n- pub namespace: ExpressionLike,\n-\n- pub name: ExpressionLike,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXAttribute {\n- pub name: ExpressionLike,\n-\n- pub value: ExpressionLike,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXExpressionContainer {\n- expression: ExpressionLike,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[derive(Serialize, Deserialize, Debug)]\n-pub struct JSXText {\n- value: String,\n- raw: String,\n-\n- pub loc: Option,\n-\n- #[serde(default)]\n- pub range: Option,\n-}\n-\n-#[cfg(test)]\n-mod tests {\n- use super::*;\n- use insta::{assert_snapshot, glob};\n- use serde_json;\n-\n- #[test]\n- fn for_statement() {\n- let source = include_str!(\"for-statement.json\");\n- let ast: Program = serde_json::from_str(&source).unwrap();\n- println!(\"deserialized:\\n{:#?}\", ast);\n- let serialized = serde_json::to_string_pretty(&ast).unwrap();\n- println!(\"serialized:\\n{}\", serialized);\n- }\n-\n- #[test]\n- fn simple() {\n- let source = include_str!(\"simple.json\");\n- let ast: Program = serde_json::from_str(&source).unwrap();\n- println!(\"deserialized:\\n{:#?}\", ast);\n- let serialized = serde_json::to_string_pretty(&ast).unwrap();\n- println!(\"serialized:\\n{}\", serialized);\n- }\n-\n- \/\/\/ TODO: enable once this deserializes\n- fn _kitchen_sink() {\n- let source = include_str!(\"kitchen-sink.json\");\n- let ast: Program = match serde_json::from_str(&source) {\n- Ok(ast) => ast,\n- Err(err) => panic!(\"{:#?}\", err),\n- };\n- println!(\"deserialized:\\n{:#?}\", ast);\n- let serialized = serde_json::to_string_pretty(&ast).unwrap();\n- println!(\"serialized:\\n{}\", serialized);\n- }\n-\n- #[test]\n- fn import() {\n- let source = include_str!(\"import.json\");\n- let ast: Program = serde_json::from_str(&source).unwrap();\n- println!(\"deserialized:\\n{:#?}\", ast);\n- let serialized = serde_json::to_string_pretty(&ast).unwrap();\n- println!(\"serialized:\\n{}\", serialized);\n- }\n-\n- #[test]\n- fn test() {\n- let source = include_str!(\"test.json\");\n- let ast: Program = serde_json::from_str(&source).unwrap();\n- println!(\"deserialized:\\n{:#?}\", ast);\n- let serialized = serde_json::to_string_pretty(&ast).unwrap();\n- println!(\"serialized:\\n{}\", serialized);\n- }\n-\n- #[test]\n- fn fixtures() {\n- glob!(\"fixtures\/**.json\", |path| {\n- let input = std::fs::read_to_string(path).unwrap();\n- let ast: Program = serde_json::from_str(&input).unwrap();\n- let serialized = serde_json::to_string_pretty(&ast).unwrap();\n- assert_snapshot!(format!(\"Input:\\n{input}\\n\\nOutput:\\n{serialized}\"));\n- });\n- }\n-}\ndiff --git a\/compiler\/forget\/crates\/forget_estree\/src\/visit.rs b\/compiler\/forget\/crates\/forget_estree\/src\/visit.rs\nindex 4196cb7f66..ebe2ac2da5 100644\n--- a\/compiler\/forget\/crates\/forget_estree\/src\/visit.rs\n+++ b\/compiler\/forget\/crates\/forget_estree\/src\/visit.rs\n@@ -145,7 +145,7 @@ pub trait Visitor_DEPRECATED<'ast> {\n self.visit_variable_declarator(declarator)\n }\n }\n- Declaration::TSTypeAliasDeclaration(declaration) => {\n+ Declaration::TSTypeAliasDeclaration(_declaration) => {\n todo!(\"visit TSTypeAliasDeclaration\")\n }\n }\n@@ -268,7 +268,7 @@ pub trait Visitor_DEPRECATED<'ast> {\n self.visit_expression(&stmt.object);\n self.visit_statement(&stmt.body);\n }\n- Statement::TSTypeAliasDeclaration(stmt) => {\n+ Statement::TSTypeAliasDeclaration(_stmt) => {\n todo!(\"visit TSTypeAliasDeclaration\")\n }\n }\ndiff --git a\/compiler\/forget\/crates\/forget_estree_codegen\/src\/codegen.rs b\/compiler\/forget\/crates\/forget_estree_codegen\/src\/codegen.rs\nindex 7b28b2bb3b..2fafd91b8f 100644\n--- a\/compiler\/forget\/crates\/forget_estree_codegen\/src\/codegen.rs\n+++ b\/compiler\/forget\/crates\/forget_estree_codegen\/src\/codegen.rs\n@@ -88,10 +88,11 @@ impl Grammar {\n .map(|(name, operator)| operator.codegen(name))\n .collect();\n \n- \/\/ println!(\"{}\", quote! {#(#node_visitors)*});\n- \/\/ println!(\"{}\", quote! {#(#enum_visitors)*});\n-\n quote! {\n+ #![allow(dead_code)]\n+ #![allow(unused_variables)]\n+ #![allow(non_snake_case)]\n+\n use std::num::NonZeroU32;\n use serde::ser::{Serializer, SerializeMap};\n use serde::{Serialize,Deserialize};\n@@ -406,9 +407,7 @@ impl Node {\n if let Some(convert_with) = &field.hermes_convert_with {\n let convert_with = format_ident!(\"{}\", convert_with);\n return quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = #convert_with(cx, unsafe { hermes::parser::#helper(node) } );\n- \/\/ println!(\"ok\");\n }\n }\n match type_kind {\n@@ -416,30 +415,22 @@ impl Node {\n match type_name_str.as_ref() {\n \"bool\" => {\n quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = unsafe { hermes::parser::#helper(node) };\n- \/\/ println!(\"ok\");\n }\n }\n \"Number\" => {\n quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = convert_number(unsafe { hermes::parser::#helper(node) });\n- \/\/ println!(\"ok\");\n }\n }\n \"String\" => {\n quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = convert_string(cx, unsafe { hermes::parser::#helper(node) });\n- \/\/ println!(\"ok\");\n }\n }\n _ => {\n quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = #type_name::convert(cx, unsafe { hermes::parser::#helper(node) });\n- \/\/ println!(\"ok\");\n }\n }\n }\n@@ -448,32 +439,24 @@ impl Node {\n match type_name_str.as_ref() {\n \"String\" => {\n quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = convert_option_string(cx, unsafe { hermes::parser::#helper(node) });\n- \/\/ println!(\"ok\");\n }\n }\n _ => {\n quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = convert_option(unsafe { hermes::parser::#helper(node) }, |node| #type_name::convert(cx, node));\n- \/\/ println!(\"ok\");\n }\n }\n }\n }\n TypeKind::Vec => {\n quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = convert_vec(unsafe { hermes::parser::#helper(node) }, |node| #type_name::convert(cx, node));\n- \/\/ println!(\"ok\");\n }\n }\n TypeKind::VecOfOption => {\n quote! {\n- \/\/ println!(\"read {}.{}\", #name_str, #name);\n let #field_name = convert_vec_of_option(unsafe { hermes::parser::#helper(node) }, |node| #type_name::convert(cx, node));\n- \/\/ println!(\"ok\");\n }\n }\n }\ndiff --git a\/compiler\/forget\/crates\/forget_fixtures\/tests\/fixtures_test.rs b\/compiler\/forget\/crates\/forget_fixtures\/tests\/fixtures_test.rs\nindex b951333055..964fccda30 100644\n--- a\/compiler\/forget\/crates\/forget_fixtures\/tests\/fixtures_test.rs\n+++ b\/compiler\/forget\/crates\/forget_fixtures\/tests\/fixtures_test.rs\n@@ -22,7 +22,6 @@ fn fixtures() {\n let mut output = String::new();\n \n let analysis = analyze(&ast);\n- \/\/ println!(\"{:#?}\", analysis.debug());\n let environment = Environment::new(\n Features {\n validate_frozen_lambdas: true,\n@@ -38,10 +37,6 @@ fn fixtures() {\n }\n match build(&environment, &fun.function) {\n Ok(mut fun) => {\n- \/\/ println!(\"{fun:#?}\");\n- \/\/ let mut out = String::new();\n- \/\/ fun.print(&fun.body, &mut out).unwrap();\n- \/\/ println!(\"{out}\");\n println!(\"ok build\");\n enter_ssa(&environment, &mut fun).unwrap();\n println!(\"ok enter_ssa\");\ndiff --git a\/compiler\/forget\/crates\/forget_hir\/src\/environment.rs b\/compiler\/forget\/crates\/forget_hir\/src\/environment.rs\nindex 4ecc4939d9..bcc7218dca 100644\n--- a\/compiler\/forget\/crates\/forget_hir\/src\/environment.rs\n+++ b\/compiler\/forget\/crates\/forget_hir\/src\/environment.rs\n@@ -1,10 +1,9 @@\n use std::cell::{Cell, RefCell};\n use std::collections::HashMap;\n-use std::process::id;\n use std::rc::Rc;\n \n-use forget_estree::{BindingId, ESTreeNode};\n-use forget_semantic_analysis::{AstNode, DeclarationId, ScopeManager, ScopeView};\n+use forget_estree::ESTreeNode;\n+use forget_semantic_analysis::{DeclarationId, ScopeManager, ScopeView};\n \n use crate::{\n BlockId, Features, Identifier, IdentifierData, IdentifierId, Registry, Type, TypeVarId,\ndiff --git a\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/analyzer.rs b\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/analyzer.rs\nindex 6a06909637..872cd72a3c 100644\n--- a\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/analyzer.rs\n+++ b\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/analyzer.rs\n@@ -1,9 +1,8 @@\n use forget_diagnostics::Diagnostic;\n use forget_estree::{\n AssignmentOperator, AssignmentPropertyOrRestElement, AssignmentTarget, Expression,\n- ExpressionOrSuper, ForInInit, ForInit, Function, FunctionBody, Identifier, IntoFunction,\n- JSXElementName, Pattern, Program, SourceRange, SourceType, Statement, VariableDeclarationKind,\n- Visitor,\n+ ExpressionOrSuper, ForInInit, ForInit, FunctionBody, Identifier, IntoFunction, JSXElementName,\n+ Pattern, Program, SourceRange, SourceType, Statement, VariableDeclarationKind, Visitor,\n };\n \n use crate::{AstNode, DeclarationKind, LabelKind, ReferenceKind, ScopeId, ScopeKind, ScopeManager};\ndiff --git a\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_manager.rs b\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_manager.rs\nindex 7711dfa363..412e973d93 100644\n--- a\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_manager.rs\n+++ b\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_manager.rs\n@@ -180,11 +180,11 @@ impl ScopeManager {\n }\n }\n \n- pub fn lookup_break(&self, scope: ScopeId) -> Option<&Label> {\n+ pub fn lookup_break(&self, _scope: ScopeId) -> Option<&Label> {\n todo!()\n }\n \n- pub fn lookup_continue(&self, scope: ScopeId) -> Option<&Label> {\n+ pub fn lookup_continue(&self, _scope: ScopeId) -> Option<&Label> {\n todo!()\n }\n \ndiff --git a\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_view.rs b\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_view.rs\nindex 7a137218e9..de4270b1da 100644\n--- a\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_view.rs\n+++ b\/compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_view.rs\n@@ -142,6 +142,7 @@ impl<'m> std::fmt::Debug for ScopeView<'m> {\n \n #[derive(Clone, Copy)]\n pub struct LabelView<'m> {\n+ #[allow(dead_code)]\n pub(crate) manager: &'m ScopeManager,\n pub(crate) label: &'m Label,\n }\ndiff --git a\/compiler\/forget\/crates\/forget_ssa\/src\/enter.rs b\/compiler\/forget\/crates\/forget_ssa\/src\/enter.rs\nindex df8c8cf167..eeae6d6278 100644\n--- a\/compiler\/forget\/crates\/forget_ssa\/src\/enter.rs\n+++ b\/compiler\/forget\/crates\/forget_ssa\/src\/enter.rs\n@@ -184,9 +184,9 @@ impl<'e, 'f> Builder<'e, 'f> {\n \/\/ Else we have to look at predecessor blocks: bail if no predecessors\n let block = self.blocks.block(block_id);\n if block.predecessors.is_empty() {\n- println!(\"Unable to find previous id for {old_identifier:?}\");\n- self.unknown.insert(old_identifier.id);\n- return old_identifier.clone();\n+ panic!(\"Unable to find previous id for {old_identifier:?}\");\n+ \/\/ self.unknown.insert(old_identifier.id);\n+ \/\/ return old_identifier.clone();\n }\n \/\/ If we haven't visited all predecessors, synthesize a new identifier\n \/\/ and save it as an incomplete phi\n","commit":{"subject":"[rust] Autofix lints","revision":"74a062ba9dfe0228069bfc776abc3e5bd9176440","authoredAt":"2023-08-10T10:59:50-04:00","shortRevision":"74a062ba9d","authorName":"Joe Savona","authorEmail":"joesavona@fb.com"},"parents":["b8f1d37b6a4e5abbf3c9d80b45b6fc773fbd4c50"],"body":"","files":[{"status":"M","path":"compiler\/forget\/crates\/forget_build_hir\/src\/build.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_build_hir\/src\/builder.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_build_hir\/src\/context.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_estree\/src\/generated.rs"},{"status":"D","path":"compiler\/forget\/crates\/forget_estree\/src\/old.lib.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_estree\/src\/visit.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_estree_codegen\/src\/codegen.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_fixtures\/tests\/fixtures_test.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_hir\/src\/environment.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_semantic_analysis\/src\/analyzer.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_manager.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_semantic_analysis\/src\/scope_view.rs"},{"status":"M","path":"compiler\/forget\/crates\/forget_ssa\/src\/enter.rs"}]}

dillon1000/react

Files changed