dillon1000/react

Commit

fix[devtools/inspectElement]: dont pause initial inspectElement call when user switches tabs (#27488)

There are not so many changes, most of them are changing imports,
because I've moved types for UI in a single file.

In https://github.com/facebook/react/pull/27357 I've added support for
pausing polling events: when user inspects an element, we start polling
React DevTools backend for updates in props / state. If user switches
tabs, extension's service worker can be killed by browser and this
polling will start spamming errors.

What I've missed is that we also have a separate call for this API, but
which is executed only once when user selects an element. We don't
handle promise rejection here and this can lead to some errors when user
selects an element and switches tabs right after it.

The only change here is that this API now has
`shouldListenToPauseEvents` param, which is `true` for polling, so we
will pause polling once user switches tabs. It is `false` by default, so
we won't pause initial call by accident.


https://github.com/hoxyq/react/blob/af8beeebf63b5824497fcd0bb35b7c0ac8fe60a0/packages/react-devtools-shared/src/backendAPI.js#L96
Browse files
Changed paths58 files
First-parent comparison
M packages/react-devtools-core/src/backend.js ModifiedM packages/react-devtools-core/src/standalone.js ModifiedM packages/react-devtools-inline/src/backend.js ModifiedM packages/react-devtools-inline/src/frontend.js ModifiedM packages/react-devtools-shared/src/__tests__/legacy/inspectElement-test.js ModifiedM packages/react-devtools-shared/src/__tests__/ownersListContext-test.js ModifiedM packages/react-devtools-shared/src/__tests__/profilerStore-test.js ModifiedM packages/react-devtools-shared/src/__tests__/storeComponentFilters-test.js ModifiedM packages/react-devtools-shared/src/__tests__/utils.js ModifiedM packages/react-devtools-shared/src/backend/StyleX/utils.js ModifiedM packages/react-devtools-shared/src/backend/agent.js ModifiedM packages/react-devtools-shared/src/backend/legacy/renderer.js ModifiedM packages/react-devtools-shared/src/backend/renderer.js ModifiedM packages/react-devtools-shared/src/backend/types.js ModifiedM packages/react-devtools-shared/src/backend/utils.js ModifiedM packages/react-devtools-shared/src/backendAPI.js ModifiedM packages/react-devtools-shared/src/bridge.js ModifiedM packages/react-devtools-shared/src/devtools/store.js ModifiedM packages/react-devtools-shared/src/devtools/utils.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/Badge.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/CannotSuspendWarningMessage.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/Element.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/HocBadges.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementContext.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementContextTree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementErrorsAndWarningsTree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementPropsTree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementStateTree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementStyleXPlugin.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementSuspenseToggle.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementView.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/NativeStyleEditor/context.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/NewArrayValue.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/NewKeyValue.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/OwnersListContext.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/OwnersStack.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/SelectedTreeHighlight.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/TreeContext.js ModifiedD packages/react-devtools-shared/src/devtools/views/Components/types.js DeletedM packages/react-devtools-shared/src/devtools/views/DevTools.js ModifiedM packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js ModifiedM packages/react-devtools-shared/src/devtools/views/Profiler/RankedChartBuilder.js ModifiedM packages/react-devtools-shared/src/devtools/views/Profiler/Updaters.js ModifiedM packages/react-devtools-shared/src/devtools/views/Profiler/types.js ModifiedM packages/react-devtools-shared/src/devtools/views/Settings/ComponentsSettings.js ModifiedM packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js ModifiedR packages/react-devtools-shared/src/types.js →packages/react-devtools-shared/src/frontend/types.js RenamedM packages/react-devtools-shared/src/hook.js ModifiedM packages/react-devtools-shared/src/hookNamesCache.js ModifiedM packages/react-devtools-shared/src/hooks/parseHookNames/index.js ModifiedM packages/react-devtools-shared/src/hooks/parseHookNames/parseSourceAndMetadata.js ModifiedM packages/react-devtools-shared/src/hydration.js ModifiedM packages/react-devtools-shared/src/inspectedElementCache.js ModifiedM packages/react-devtools-shared/src/inspectedElementMutableSource.js ModifiedM packages/react-devtools-shared/src/utils.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…