dillon1000/react
Commit
Browse files Update root children using the appendChild/insertBefore/removeChild methods
This removes updateContainer and instead uses the regular child mutation methods to insert into the root container and portals. Since we're no longer clearing out the container DOM in updateContainer we have to do that manually during initial mount. This now works on a document and one of the tests end up unmounting the body when you render into the document so I had to work around that bit since we don't yet properly support rendering into the document root.
Changed paths8 files
First-parent comparisonscripts/fiber/tests-failing.txt ModifiedM scripts/fiber/tests-passing.txt ModifiedM src/renderers/dom/fiber/ReactDOMFiber.js ModifiedM src/renderers/noop/ReactNoop.js ModifiedM src/renderers/shared/fiber/ReactFiberBeginWork.js ModifiedM src/renderers/shared/fiber/ReactFiberCommitWork.js ModifiedM src/renderers/shared/fiber/ReactFiberCompleteWork.js ModifiedM src/renderers/shared/fiber/ReactFiberReconciler.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…