dillon1000/react

Commit

Fix backbone todo example bugs.

Fixed:
- New todo not submitting correctly (page refreshes. `preventDefault`
wasn't there.
- Old checked todo being removed will leave the checkmark on the next
todo replacing its position.
- Cannot change todo (`value`'s now a controlled field).
- `autofocus` (should be `autoFocus`, how ironic given the current
situation) on new todo input isn't working. Switched to manual
`focus()` in `componentDidMount` for now.
- More consistent breathing space between lines.
- Gutter at 80.

Added:
- Use todomvc-common base.css. The old one had to change ids to
classes. No longer necessary.
- Give `cx` a better name and move it in `Utils`.
- Trim input upon finishing edit.
- Remove todo if the new edited value is empty.
- Submit edited todo value on input blur.
- README to explain the existence of this example. Being able to
maintain a non-compilant version allows nice deviations from the
todomvc specs, such as animations, in the future.
Browse files
Changed paths4 files
First-parent comparison
A examples/todomvc-backbone/README.md AddedM examples/todomvc-backbone/css/base.css ModifiedM examples/todomvc-backbone/index.html ModifiedM examples/todomvc-backbone/js/app.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…