{"parents":["6fb8133ed3aa6b23063375dd345c6e413b05f0fe"],"files":[{"path":"packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.js","status":"R082","previousPath":"packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.internal.js"},{"path":"packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberBeginWork.new.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberBeginWork.old.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.js","status":"M"},{"path":"packages\/shared\/ReactFeatureFlags.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.testing.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.testing.www.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.www.js","status":"M"}],"patch":"diff --git a\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js b\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js\nindex 2b9eea6d66..af31e5e6fd 100644\n--- a\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js\n+++ b\/packages\/react-debug-tools\/src\/__tests__\/ReactHooksInspectionIntegration-test.js\n@@ -898,7 +898,11 @@ describe('ReactHooksInspectionIntegration', () => {\n \n await LazyFoo;\n \n- Scheduler.unstable_flushAll();\n+ expect(() => {\n+ Scheduler.unstable_flushAll();\n+ }).toErrorDev([\n+ 'Foo: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.',\n+ ]);\n \n const childFiber = renderer.root._currentFiber();\n const tree = ReactDebugTools.inspectHooksOfFiber(childFiber);\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js\nindex 7a4ca9d246..030e5093e5 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMFizzServer-test.js\n@@ -291,6 +291,18 @@ describe('ReactDOMFizzServer', () => {\n }\n \n it('should asynchronously load a lazy component', async () => {\n+ const originalConsoleError = console.error;\n+ const mockError = jest.fn();\n+ console.error = (...args) => {\n+ if (args.length > 1) {\n+ if (typeof args[1] === 'object') {\n+ mockError(args[0].split('\\n')[0]);\n+ return;\n+ }\n+ }\n+ mockError(...args.map(normalizeCodeLocInfo));\n+ };\n+\n let resolveA;\n const LazyA = React.lazy(() => {\n return new Promise(r => {\n@@ -313,48 +325,66 @@ describe('ReactDOMFizzServer', () => {\n punctuation: '!',\n };\n \n- await act(async () => {\n- const {pipe} = renderToPipeableStream(\n-

\n-

\n- }>\n- \n- <\/Suspense>\n- <\/div>\n+ try {\n+ await act(async () => {\n+ const {pipe} = renderToPipeableStream(\n

\n- }>\n- \n- <\/Suspense>\n- <\/div>\n+

\n+ }>\n+ \n+ <\/Suspense>\n+ <\/div>\n+

\n+ }>\n+ \n+ <\/Suspense>\n+ <\/div>\n+ <\/div>,\n+ );\n+ pipe(writable);\n+ });\n+\n+ expect(getVisibleChildren(container)).toEqual(\n+

\n+

Loading...<\/div>\n+

Loading...<\/div>\n+ <\/div>,\n+ );\n+ await act(async () => {\n+ resolveA({default: Text});\n+ });\n+ expect(getVisibleChildren(container)).toEqual(\n+

\n+

Hello<\/div>\n+

Loading...<\/div>\n+ <\/div>,\n+ );\n+ await act(async () => {\n+ resolveB({default: TextWithPunctuation});\n+ });\n+ expect(getVisibleChildren(container)).toEqual(\n+

\n+

Hello<\/div>\n+

world!<\/div>\n <\/div>,\n );\n- pipe(writable);\n- });\n \n- expect(getVisibleChildren(container)).toEqual(\n-

\n-

Loading...<\/div>\n-

Loading...<\/div>\n- <\/div>,\n- );\n- await act(async () => {\n- resolveA({default: Text});\n- });\n- expect(getVisibleChildren(container)).toEqual(\n-

\n-

Hello<\/div>\n-

Loading...<\/div>\n- <\/div>,\n- );\n- await act(async () => {\n- resolveB({default: TextWithPunctuation});\n- });\n- expect(getVisibleChildren(container)).toEqual(\n-

\n-

Hello<\/div>\n-

world!<\/div>\n- <\/div>,\n- );\n+ if (__DEV__) {\n+ expect(mockError).toHaveBeenCalledWith(\n+ 'Warning: %s: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.%s',\n+ 'TextWithPunctuation',\n+ '\\n in TextWithPunctuation (at **)\\n' +\n+ ' in Lazy (at **)\\n' +\n+ ' in Suspense (at **)\\n' +\n+ ' in div (at **)\\n' +\n+ ' in div (at **)',\n+ );\n+ } else {\n+ expect(mockError).not.toHaveBeenCalled();\n+ }\n+ } finally {\n+ console.error = originalConsoleError;\n+ }\n });\n \n it('#23331: does not warn about hydration mismatches if something suspended in an earlier sibling', async () => {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.js\nsimilarity index 82%\nrename from packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.internal.js\nrename to packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.js\nindex a72c62cf7f..6b532c72b3 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDeprecationWarnings-test.js\n@@ -10,7 +10,6 @@\n 'use strict';\n \n let React;\n-let ReactFeatureFlags;\n let ReactNoop;\n let Scheduler;\n let JSXDEVRuntime;\n@@ -19,19 +18,11 @@ describe('ReactDeprecationWarnings', () => {\n beforeEach(() => {\n jest.resetModules();\n React = require('react');\n- ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n ReactNoop = require('react-noop-renderer');\n Scheduler = require('scheduler');\n if (__DEV__) {\n JSXDEVRuntime = require('react\/jsx-dev-runtime');\n }\n- ReactFeatureFlags.warnAboutDefaultPropsOnFunctionComponents = true;\n- ReactFeatureFlags.warnAboutStringRefs = true;\n- });\n-\n- afterEach(() => {\n- ReactFeatureFlags.warnAboutDefaultPropsOnFunctionComponents = false;\n- ReactFeatureFlags.warnAboutStringRefs = false;\n });\n \n it('should warn when given defaultProps', () => {\n@@ -51,6 +42,27 @@ describe('ReactDeprecationWarnings', () => {\n );\n });\n \n+ it('should warn when given defaultProps on a memoized function', () => {\n+ const MemoComponent = React.memo(function FunctionalComponent(props) {\n+ return null;\n+ });\n+\n+ MemoComponent.defaultProps = {\n+ testProp: true,\n+ };\n+\n+ ReactNoop.render(\n+

\n+ \n+ <\/div>,\n+ );\n+ expect(() => expect(Scheduler).toFlushWithoutYielding()).toErrorDev(\n+ 'Warning: FunctionalComponent: Support for defaultProps ' +\n+ 'will be removed from memo components in a future major ' +\n+ 'release. Use JavaScript default parameters instead.',\n+ );\n+ });\n+\n it('should warn when given string refs', () => {\n class RefComponent extends React.Component {\n render() {\n@@ -74,9 +86,7 @@ describe('ReactDeprecationWarnings', () => {\n );\n });\n \n- it('should not warn when owner and self are the same for string refs', () => {\n- ReactFeatureFlags.warnAboutStringRefs = false;\n-\n+ it('should warn when owner and self are the same for string refs', () => {\n class RefComponent extends React.Component {\n render() {\n return null;\n@@ -87,7 +97,11 @@ describe('ReactDeprecationWarnings', () => {\n return ;\n }\n }\n- ReactNoop.renderLegacySyncRoot();\n+ expect(() => {\n+ ReactNoop.renderLegacySyncRoot();\n+ }).toErrorDev([\n+ 'Component \"Component\" contains the string ref \"refComponent\". Support for string refs will be removed in a future major release.',\n+ ]);\n expect(Scheduler).toFlushWithoutYielding();\n });\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js b\/packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js\nindex 9f51cb5fba..10f53b6962 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactFunctionComponent-test.js\n@@ -367,11 +367,12 @@ describe('ReactFunctionComponent', () => {\n Child.defaultProps = {test: 2};\n Child.propTypes = {test: PropTypes.string};\n \n- expect(() => ReactTestUtils.renderIntoDocument()).toErrorDev(\n+ expect(() => ReactTestUtils.renderIntoDocument()).toErrorDev([\n+ 'Warning: Child: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.',\n 'Warning: Failed prop type: Invalid prop `test` of type `number` ' +\n 'supplied to `Child`, expected `string`.\\n' +\n ' in Child (at **)',\n- );\n+ ]);\n });\n \n it('should receive context', () => {\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.new.js b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.new.js\nindex 27c086160f..23991b9ea7 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.new.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.new.js\n@@ -496,6 +496,20 @@ function updateMemoComponent(\n getComponentNameFromType(type),\n );\n }\n+ if (\n+ warnAboutDefaultPropsOnFunctionComponents &&\n+ Component.defaultProps !== undefined\n+ ) {\n+ const componentName = getComponentNameFromType(type) || 'Unknown';\n+ if (!didWarnAboutDefaultPropsOnFunctionComponent[componentName]) {\n+ console.error(\n+ '%s: Support for defaultProps will be removed from memo components ' +\n+ 'in a future major release. Use JavaScript default parameters instead.',\n+ componentName,\n+ );\n+ didWarnAboutDefaultPropsOnFunctionComponent[componentName] = true;\n+ }\n+ }\n }\n const child = createFiberFromTypeAndProps(\n Component.type,\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.old.js b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.old.js\nindex c3fed9d3c4..072850255f 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.old.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.old.js\n@@ -496,6 +496,20 @@ function updateMemoComponent(\n getComponentNameFromType(type),\n );\n }\n+ if (\n+ warnAboutDefaultPropsOnFunctionComponents &&\n+ Component.defaultProps !== undefined\n+ ) {\n+ const componentName = getComponentNameFromType(type) || 'Unknown';\n+ if (!didWarnAboutDefaultPropsOnFunctionComponent[componentName]) {\n+ console.error(\n+ '%s: Support for defaultProps will be removed from memo components ' +\n+ 'in a future major release. Use JavaScript default parameters instead.',\n+ componentName,\n+ );\n+ didWarnAboutDefaultPropsOnFunctionComponent[componentName] = true;\n+ }\n+ }\n }\n const child = createFiberFromTypeAndProps(\n Component.type,\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\nindex 682ceb87df..8f196324d6 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\n@@ -293,7 +293,12 @@ describe('ReactLazy', () => {\n \n await Promise.resolve();\n \n- expect(Scheduler).toFlushAndYield(['Hi']);\n+ expect(() => expect(Scheduler).toFlushAndYield(['Hi'])).toErrorDev(\n+ 'Warning: T: Support for defaultProps ' +\n+ 'will be removed from function components in a future major ' +\n+ 'release. Use JavaScript default parameters instead.',\n+ );\n+\n expect(root).toMatchRenderedOutput('Hi');\n \n T.defaultProps = {text: 'Hi again'};\n@@ -343,7 +348,14 @@ describe('ReactLazy', () => {\n \n await Promise.resolve();\n \n- expect(Scheduler).toFlushAndYield(['Lazy', 'Sibling', 'A']);\n+ expect(() =>\n+ expect(Scheduler).toFlushAndYield(['Lazy', 'Sibling', 'A']),\n+ ).toErrorDev(\n+ 'Warning: LazyImpl: Support for defaultProps ' +\n+ 'will be removed from function components in a future major ' +\n+ 'release. Use JavaScript default parameters instead.',\n+ );\n+\n expect(root).toMatchRenderedOutput('SiblingA');\n \n \/\/ Lazy should not re-render\n@@ -643,7 +655,12 @@ describe('ReactLazy', () => {\n expect(root).not.toMatchRenderedOutput('Hi Bye');\n \n await Promise.resolve();\n- expect(Scheduler).toFlushAndYield(['Hi Bye']);\n+ expect(() => expect(Scheduler).toFlushAndYield(['Hi Bye'])).toErrorDev(\n+ 'Warning: T: Support for defaultProps ' +\n+ 'will be removed from function components in a future major ' +\n+ 'release. Use JavaScript default parameters instead.',\n+ );\n+\n expect(root).toMatchRenderedOutput('Hi Bye');\n \n root.update(\n@@ -732,7 +749,11 @@ describe('ReactLazy', () => {\n );\n });\n \n- async function verifyInnerPropTypesAreChecked(Add) {\n+ async function verifyInnerPropTypesAreChecked(\n+ Add,\n+ shouldWarnAboutFunctionDefaultProps,\n+ shouldWarnAboutMemoDefaultProps,\n+ ) {\n const LazyAdd = lazy(() => fakeImport(Add));\n expect(() => {\n LazyAdd.propTypes = {};\n@@ -753,15 +774,28 @@ describe('ReactLazy', () => {\n );\n \n expect(Scheduler).toFlushAndYield(['Loading...']);\n+\n expect(root).not.toMatchRenderedOutput('22');\n \n \/\/ Mount\n await Promise.resolve();\n expect(() => {\n Scheduler.unstable_flushAll();\n- }).toErrorDev([\n- 'Invalid prop `inner` of type `string` supplied to `Add`, expected `number`.',\n- ]);\n+ }).toErrorDev(\n+ shouldWarnAboutFunctionDefaultProps\n+ ? [\n+ 'Add: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.',\n+ 'Invalid prop `inner` of type `string` supplied to `Add`, expected `number`.',\n+ ]\n+ : shouldWarnAboutMemoDefaultProps\n+ ? [\n+ 'Add: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.',\n+ 'Invalid prop `inner` of type `string` supplied to `Add`, expected `number`.',\n+ ]\n+ : [\n+ 'Invalid prop `inner` of type `string` supplied to `Add`, expected `number`.',\n+ ],\n+ );\n expect(root).toMatchRenderedOutput('22');\n \n \/\/ Update\n@@ -792,7 +826,7 @@ describe('ReactLazy', () => {\n Add.defaultProps = {\n innerWithDefault: 42,\n };\n- await verifyInnerPropTypesAreChecked(Add);\n+ await verifyInnerPropTypesAreChecked(Add, true);\n });\n \n it('respects propTypes on function component without defaultProps', async () => {\n@@ -874,7 +908,7 @@ describe('ReactLazy', () => {\n Add.defaultProps = {\n innerWithDefault: 42,\n };\n- await verifyInnerPropTypesAreChecked(Add);\n+ await verifyInnerPropTypesAreChecked(Add, false, true);\n });\n \n it('respects propTypes on outer memo component without defaultProps', async () => {\n@@ -901,7 +935,7 @@ describe('ReactLazy', () => {\n Add.defaultProps = {\n innerWithDefault: 42,\n };\n- await verifyInnerPropTypesAreChecked(React.memo(Add));\n+ await verifyInnerPropTypesAreChecked(React.memo(Add), true);\n });\n \n it('respects propTypes on inner memo component without defaultProps', async () => {\n@@ -944,9 +978,10 @@ describe('ReactLazy', () => {\n await Promise.resolve();\n expect(() => {\n expect(Scheduler).toFlushAndYield(['Inner default text']);\n- }).toErrorDev(\n+ }).toErrorDev([\n+ 'T: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.',\n 'The prop `text` is marked as required in `T`, but its value is `undefined`',\n- );\n+ ]);\n expect(root).toMatchRenderedOutput('Inner default text');\n \n \/\/ Update\n@@ -1058,7 +1093,11 @@ describe('ReactLazy', () => {\n \n \/\/ Mount\n await Promise.resolve();\n- expect(Scheduler).toFlushWithoutYielding();\n+ expect(() => {\n+ expect(Scheduler).toFlushWithoutYielding();\n+ }).toErrorDev(\n+ 'Unknown: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.',\n+ );\n expect(root).toMatchRenderedOutput('4');\n \n \/\/ Update (shallowly equal)\n@@ -1142,7 +1181,12 @@ describe('ReactLazy', () => {\n \n \/\/ Mount\n await Promise.resolve();\n- expect(Scheduler).toFlushWithoutYielding();\n+ expect(() => {\n+ expect(Scheduler).toFlushWithoutYielding();\n+ }).toErrorDev([\n+ 'Memo: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.',\n+ 'Unknown: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.',\n+ ]);\n expect(root).toMatchRenderedOutput('4');\n \n \/\/ Update\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.js\nindex c58a11820c..cc6347bec9 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.js\n@@ -75,6 +75,7 @@ describe('memo', () => {\n }\n ReactNoop.render();\n expect(() => expect(Scheduler).toFlushWithoutYielding()).toErrorDev([\n+ 'App: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.',\n 'Warning: Function components cannot be given refs. Attempts to access ' +\n 'this ref will fail.',\n ]);\n@@ -441,7 +442,11 @@ describe('memo', () => {\n );\n expect(Scheduler).toFlushAndYield(['Loading...']);\n await Promise.resolve();\n- expect(Scheduler).toFlushAndYield([15]);\n+ expect(() => {\n+ expect(Scheduler).toFlushAndYield([15]);\n+ }).toErrorDev([\n+ 'Counter: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.',\n+ ]);\n expect(ReactNoop.getChildren()).toEqual([span(15)]);\n \n \/\/ Should bail out because props have not changed\n@@ -552,7 +557,11 @@ describe('memo', () => {\n \n <\/div>,\n );\n- expect(Scheduler).toFlushWithoutYielding();\n+ expect(() => {\n+ expect(Scheduler).toFlushWithoutYielding();\n+ }).toErrorDev([\n+ 'Inner: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.',\n+ ]);\n \n \/\/ Mount\n expect(() => {\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex 3a52dfd100..23e74d128c 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -213,7 +213,7 @@ export const disableTextareaChildren = false;\n \/\/ Part of the simplification of React.createElement so we can eventually move\n \/\/ from React.createElement to React.jsx\n \/\/ https:\/\/github.com\/reactjs\/rfcs\/blob\/createlement-rfc\/text\/0000-create-element-changes.md\n-export const warnAboutDefaultPropsOnFunctionComponents = false; \/\/ deprecate later, not 18.0\n+export const warnAboutDefaultPropsOnFunctionComponents = true; \/\/ deprecate later, not 18.0\n \n \/\/ Enables a warning when trying to spread a 'key' to an element;\n \/\/ a deprecated pattern we want to get rid of in the future\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex f14d33de63..ac5f8de086 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -41,7 +41,7 @@ export const warnAboutDeprecatedLifecycles = true;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = false;\n+export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex 296d4012ab..994fab5272 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -31,7 +31,7 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = false;\n+export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex 86f0d54eea..2105a3e303 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -31,7 +31,7 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = false;\n+export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\nindex f734afa272..a9574a110a 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n@@ -31,7 +31,7 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = false;\n+export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex 7ec00cbb2e..3c0de034a7 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -31,7 +31,7 @@ export const disableInputAttributeSyncing = false;\n export const enableScopeAPI = true;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = true;\n-export const warnAboutDefaultPropsOnFunctionComponents = false;\n+export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\nindex efe5ef51e2..3e7ec4d238 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n@@ -31,7 +31,7 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = false;\n+export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\nindex f9e6b26567..56fee41690 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n@@ -31,7 +31,7 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = true;\n export const enableCreateEventHandleAPI = true;\n export const enableSuspenseCallback = true;\n-export const warnAboutDefaultPropsOnFunctionComponents = false;\n+export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const warnAboutStringRefs = true;\n export const disableLegacyContext = __EXPERIMENTAL__;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex b0516f7f49..513c7562c7 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -67,7 +67,7 @@ export const enableSchedulerDebugging = true;\n export const warnAboutDeprecatedLifecycles = true;\n export const disableLegacyContext = __EXPERIMENTAL__;\n export const warnAboutStringRefs = true;\n-export const warnAboutDefaultPropsOnFunctionComponents = false;\n+export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const enableGetInspectorDataForInstanceInProduction = false;\n \n export const enableCache = true;\n","commit":{"shortRevision":"7b17f7bbf3","authorName":"Sebastian Markbåge","authorEmail":"sebastian@calyptus.eu","revision":"7b17f7bbf3243c2890cb830902be8ef8b51db3da","subject":"Enable warning for defaultProps on function components for everyone (#25699)","authoredAt":"2022-11-17T12:22:23-05:00"},"body":"This also fixes a gap where were weren't warning on memo components."}

dillon1000/react

Files changed