dillon1000/react

Commit

[compiler] Represent phis with places rather than identifiers

Summary:
The fact that phis are identifiers rather than places is unfortunate in a few cases. In some later analyses, we might wish to know whether a phi is reactive, but we don't have an easy way to do that currently.

Most of the changes here is just replacing phi.id with phi.place.identifier and such. Interesting bits are EnterSSA (several functions now take places rather than identifiers, and InferReactivePlaces now needs to mark places as reactive explicitly.

ghstack-source-id: 5f4fb396cd86b421008c37832a5735ac40f8806e
Pull Request resolved: https://github.com/facebook/react/pull/31171
Browse files
Mike Vitousek authored 7b7fac073d1473df839a1caf8d0444c32bf4de49 Parent 70fb136
Changed paths20 files
First-parent comparison
M compiler/packages/babel-plugin-react-compiler/src/HIR/AssertConsistentIdentifiers.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/HIR/AssertValidMutableRanges.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/HIR/HIR.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/HIR/MergeConsecutiveBlocks.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/HIR/PrintHIR.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/HIR/PropagateScopeDependenciesHIR.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Inference/InferAliasForPhis.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Inference/InferMutableLifetimes.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Inference/InferReactivePlaces.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Inference/InferReferenceEffects.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Optimization/ConstantPropagation.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Optimization/DeadCodeElimination.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Optimization/PruneMaybeThrows.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/InferReactiveScopeVariables.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/SSA/EliminateRedundantPhi.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/SSA/EnterSSA.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/TypeInference/InferTypes.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/TypeInference/PropagatePhiTypes.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateHooksUsage.ts ModifiedM compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateNoRefAccesInRender.ts Modified
Patch

Files changed

Rendering syntax-highlighted changes…