{"files":[{"status":"M","path":"packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberCompleteWork.js"}],"commit":{"subject":"[Flare] Adds support for hydrating host components with listeners (#16304)","revision":"7c838a6450f5b80c5d645b79b9dae78864e046b9","authorEmail":"trueadm@users.noreply.github.com","shortRevision":"7c838a6450","authorName":"Dominic Gannaway","authoredAt":"2019-08-06T23:05:16+01:00"},"body":"","patch":"diff --git a\/packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js b\/packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js\nindex 6a4894de17..14c52faefd 100644\n--- a\/packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js\n+++ b\/packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js\n@@ -112,6 +112,35 @@ describe('DOMEventResponderSystem', () => {\n expect(output).toBe(`

Hello world<\/div>`);\n });\n \n+ it('can render correctly with the ReactDOMServer hydration', () => {\n+ const onEvent = jest.fn();\n+ const TestResponder = createEventResponder({\n+ targetEventTypes: ['click'],\n+ onEvent,\n+ });\n+ const ref = React.createRef();\n+\n+ function Test() {\n+ const listener = React.unstable_useResponder(TestResponder, {});\n+\n+ return (\n+

\n+ \n+ Hello world\n+ <\/span>\n+ <\/div>\n+ );\n+ }\n+ const output = ReactDOMServer.renderToString();\n+ expect(output).toBe(\n+ `

Hello world<\/span><\/div>`,\n+ );\n+ container.innerHTML = output;\n+ ReactDOM.hydrate(, container);\n+ dispatchClickEvent(ref.current);\n+ expect(onEvent).toHaveBeenCalledTimes(1);\n+ });\n+\n it('the event responders should fire on click event', () => {\n let eventResponderFiredCount = 0;\n let eventLog = [];\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js b\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\nindex 5d635f4b5f..d77db8557a 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\n@@ -739,6 +739,18 @@ function completeWork(\n \/\/ commit-phase we mark this as such.\n markUpdate(workInProgress);\n }\n+ if (enableFlareAPI) {\n+ const instance = workInProgress.stateNode;\n+ const listeners = newProps.listeners;\n+ if (listeners != null) {\n+ updateEventListeners(\n+ listeners,\n+ instance,\n+ rootContainerInstance,\n+ workInProgress,\n+ );\n+ }\n+ }\n } else {\n let instance = createInstance(\n type,\n","parents":["ed497007967b4324798b70be1708e478d95c5802"]}

dillon1000/react

Files changed