dillon1000/react

Commit

[DevTools] Remove the dead Timeline profiler code (#37187)

## Summary

With the tab gone, everything that fed it is unreachable. This deletes
`packages/react-devtools-timeline` (74 files) and the backend that
produced its data, `backend/profilingHooks.js`, along with
`SidebarEventInfo`, the two timeline test suites, the `timelineData`
snapshot serializer, and the scheduling-profiler fixture.

It also unwires the plumbing that only existed to carry timeline data:
`recordTimeline` across the reload-and-profile path (hook →
sessionStorage → agent → renderer), `timelineData` on
`ProfilingDataBackend` and the profile export, the `supportsTimeline`
Store config, the `rootSupportsTimelineProfiling` capability, the
`DevToolsProfilingHooks` type and the `ReactRenderer` members DevTools
used to inject it, the 40 `--color-timeline-*` theme variables in both
themes plus the orphaned `--color-scroll-caret`, and `hook.js`'s
internal-module-range tracking with its `react-devtools-facade` stubs.

`yarn.lock` is regenerated: 52 distinct package-versions and 68
requirement specs drop out, with no additions and no version changes to
anything that remains.

## Deliberate non-changes

- **`PROFILER_EXPORT_VERSION` stays at 5.**
`prepareProfilingDataFrontendFromExport` compares versions with `!==`,
so a bump would reject every profile anyone has already saved.
`timelineData` was an optional key, so dropping it is invisible in both
directions.
- **Profiling flag bit `0b010` is retired, not reused**, and the
constant is replaced by a comment saying so. Shipped backends keep
setting it, so renumbering `PROFILING_FLAG_PERFORMANCE_TRACKS_SUPPORT`
into that slot would make a new frontend misread older backends as
tracks-capable.
- **The `displayName` properties on DevTools' cache thenables are
kept.** They look timeline-only, but `ReactFiberThenable` reads
`thenable.displayName` to name I/O in async debug info, which feeds the
Performance tracks. Only their stale comments are corrected.
- **`react-reconciler`, `shared/ReactFeatureFlags.js` and
`scripts/rollup` are untouched**; `enableSchedulingProfiler` is still
live for www and native-fb.

## Follow-ups (not in this stack)

Three stale comments still name the removed package:
`scripts/rollup/wrappers.js:532` and `ReactFiberLane.js:38,125`. Left
alone to keep this stack purely DevTools-side.

## Test plan

`yarn linc`, `yarn flow dom-node`, and the DevTools suite all pass on
this commit in isolation (40/40 suites, 582 tests).
Browse files
Changed paths115 files
First-parent comparison
M .eslintignore ModifiedM .eslintrc.js ModifiedM .gitignore ModifiedM .prettierignore ModifiedD fixtures/devtools/scheduling-profiler/.gitignore DeletedD fixtures/devtools/scheduling-profiler/README.md DeletedD fixtures/devtools/scheduling-profiler/app.js DeletedD fixtures/devtools/scheduling-profiler/index.html DeletedD fixtures/devtools/scheduling-profiler/run.js DeletedM packages/react-devtools-core/README.md ModifiedM packages/react-devtools-extensions/src/main/index.js ModifiedM packages/react-devtools-facade/src/DevToolsFacade.js ModifiedM packages/react-devtools-inline/src/frontend.js ModifiedD packages/react-devtools-shared/src/__tests__/TimelineProfiler-test.js DeletedD packages/react-devtools-shared/src/__tests__/__serializers__/timelineDataSerializer.js DeletedD packages/react-devtools-shared/src/__tests__/preprocessData-test.js DeletedM packages/react-devtools-shared/src/__tests__/profilerContext-test.js ModifiedM packages/react-devtools-shared/src/__tests__/setupTests.js ModifiedM packages/react-devtools-shared/src/__tests__/utils.js ModifiedM packages/react-devtools-shared/src/backend/agent.js ModifiedM packages/react-devtools-shared/src/backend/fiber/renderer.js ModifiedD packages/react-devtools-shared/src/backend/profilingHooks.js DeletedM packages/react-devtools-shared/src/backend/types.js ModifiedM packages/react-devtools-shared/src/constants.js ModifiedM packages/react-devtools-shared/src/devtools/ProfilerStore.js ModifiedM packages/react-devtools-shared/src/devtools/constants.js ModifiedM packages/react-devtools-shared/src/devtools/store.js ModifiedM packages/react-devtools-shared/src/devtools/views/DevTools.js ModifiedM packages/react-devtools-shared/src/devtools/views/ErrorBoundary/cache.js ModifiedM packages/react-devtools-shared/src/devtools/views/Profiler/ReloadAndProfileButton.js ModifiedD packages/react-devtools-shared/src/devtools/views/Profiler/SidebarEventInfo.css DeletedD packages/react-devtools-shared/src/devtools/views/Profiler/SidebarEventInfo.js DeletedM packages/react-devtools-shared/src/devtools/views/Profiler/types.js ModifiedM packages/react-devtools-shared/src/devtools/views/Profiler/utils.js ModifiedM packages/react-devtools-shared/src/dynamicImportCache.js ModifiedM packages/react-devtools-shared/src/hook.js ModifiedM packages/react-devtools-shared/src/hookNamesCache.js ModifiedM packages/react-devtools-shared/src/inspectedElementCache.js ModifiedM packages/react-devtools-shared/src/utils.js ModifiedD packages/react-devtools-timeline/README.md DeletedD packages/react-devtools-timeline/package.json DeletedD packages/react-devtools-timeline/src/CanvasPage.css DeletedD packages/react-devtools-timeline/src/CanvasPage.js DeletedD packages/react-devtools-timeline/src/CanvasPageContextMenu.js DeletedD packages/react-devtools-timeline/src/EventTooltip.css DeletedD packages/react-devtools-timeline/src/EventTooltip.js DeletedD packages/react-devtools-timeline/src/Timeline.css DeletedD packages/react-devtools-timeline/src/Timeline.js DeletedD packages/react-devtools-timeline/src/TimelineContext.js DeletedD packages/react-devtools-timeline/src/TimelineNotSupported.css DeletedD packages/react-devtools-timeline/src/TimelineNotSupported.js DeletedD packages/react-devtools-timeline/src/TimelineSearchContext.js DeletedD packages/react-devtools-timeline/src/TimelineSearchInput.js DeletedD packages/react-devtools-timeline/src/constants.js DeletedD packages/react-devtools-timeline/src/content-views/ComponentMeasuresView.js DeletedD packages/react-devtools-timeline/src/content-views/FlamechartView.js DeletedD packages/react-devtools-timeline/src/content-views/NativeEventsView.js DeletedD packages/react-devtools-timeline/src/content-views/NetworkMeasuresView.js DeletedD packages/react-devtools-timeline/src/content-views/ReactMeasuresView.js DeletedD packages/react-devtools-timeline/src/content-views/SchedulingEventsView.js DeletedD packages/react-devtools-timeline/src/content-views/SnapshotsView.js DeletedD packages/react-devtools-timeline/src/content-views/SuspenseEventsView.js DeletedD packages/react-devtools-timeline/src/content-views/ThrownErrorsView.js DeletedD packages/react-devtools-timeline/src/content-views/TimeAxisMarkersView.js DeletedD packages/react-devtools-timeline/src/content-views/UserTimingMarksView.js DeletedD packages/react-devtools-timeline/src/content-views/constants.js DeletedD packages/react-devtools-timeline/src/content-views/index.js DeletedD packages/react-devtools-timeline/src/content-views/utils/__tests__/__modules__/module-one.js DeletedD packages/react-devtools-timeline/src/content-views/utils/__tests__/__modules__/module-two.js DeletedD packages/react-devtools-timeline/src/content-views/utils/__tests__/colors-test.js DeletedD packages/react-devtools-timeline/src/content-views/utils/__tests__/moduleFilters-test.js DeletedD packages/react-devtools-timeline/src/content-views/utils/colors.js DeletedD packages/react-devtools-timeline/src/content-views/utils/moduleFilters.js DeletedD packages/react-devtools-timeline/src/content-views/utils/positioning.js DeletedD packages/react-devtools-timeline/src/content-views/utils/text.js DeletedD packages/react-devtools-timeline/src/createDataResourceFromImportedFile.js DeletedD packages/react-devtools-timeline/src/import-worker/InvalidProfileError.js DeletedD packages/react-devtools-timeline/src/import-worker/importFile.js DeletedD packages/react-devtools-timeline/src/import-worker/importFile.worker.js DeletedD packages/react-devtools-timeline/src/import-worker/index.js DeletedD packages/react-devtools-timeline/src/import-worker/preprocessData.js DeletedD packages/react-devtools-timeline/src/import-worker/readInputData.js DeletedD packages/react-devtools-timeline/src/timelineCache.js DeletedD packages/react-devtools-timeline/src/types.js DeletedD packages/react-devtools-timeline/src/utils/flow.js DeletedD packages/react-devtools-timeline/src/utils/formatting.js DeletedD packages/react-devtools-timeline/src/utils/getBatchRange.js DeletedD packages/react-devtools-timeline/src/utils/useSmartTooltip.js DeletedD packages/react-devtools-timeline/src/view-base/BackgroundColorView.js DeletedD packages/react-devtools-timeline/src/view-base/HorizontalPanAndZoomView.js DeletedD packages/react-devtools-timeline/src/view-base/Surface.js DeletedD packages/react-devtools-timeline/src/view-base/VerticalScrollView.js DeletedD packages/react-devtools-timeline/src/view-base/View.js DeletedD packages/react-devtools-timeline/src/view-base/__tests__/geometry-test.js DeletedD packages/react-devtools-timeline/src/view-base/constants.js DeletedD packages/react-devtools-timeline/src/view-base/geometry.js DeletedD packages/react-devtools-timeline/src/view-base/index.js DeletedD packages/react-devtools-timeline/src/view-base/layouter.js DeletedD packages/react-devtools-timeline/src/view-base/resizable/ResizableView.js DeletedD packages/react-devtools-timeline/src/view-base/resizable/ResizeBarView.js DeletedD packages/react-devtools-timeline/src/view-base/resizable/index.js DeletedD packages/react-devtools-timeline/src/view-base/useCanvasInteraction.js DeletedD packages/react-devtools-timeline/src/view-base/utils/__tests__/clamp-test.js DeletedD packages/react-devtools-timeline/src/view-base/utils/__tests__/scrollState-test.js DeletedD packages/react-devtools-timeline/src/view-base/utils/clamp.js DeletedD packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js DeletedD packages/react-devtools-timeline/src/view-base/utils/scrollState.js DeletedD packages/react-devtools-timeline/src/view-base/vertical-scroll-overflow/VerticalScrollBarView.js DeletedD packages/react-devtools-timeline/src/view-base/vertical-scroll-overflow/VerticalScrollOverflowView.js DeletedD packages/react-devtools-timeline/src/view-base/vertical-scroll-overflow/index.js DeletedD packages/react-devtools-timeline/src/view-base/vertical-scroll-overflow/withVerticalScrollbarLayout.js DeletedM packages/react-devtools/OVERVIEW.md ModifiedM scripts/devtools/configuration.js ModifiedM scripts/jest/config.build-devtools.js ModifiedM yarn.lock Modified
Patch

Files changed

Rendering syntax-highlighted changes…