{"commit":{"subject":"Import useMemoCache from unstable name","authorEmail":"jkassens@meta.com","revision":"7f17dd84d1504b67f35eecb1703bf0367411903d","authorName":"Jan Kassens","shortRevision":"7f17dd84d1","authoredAt":"2022-10-11T13:16:01-04:00"},"body":"I didn't make this an option as it's unclear we'll really need this. We can \nalways add an option later, I think. \n\nThis is the name that's available on facebook.com at the moment.","files":[{"path":"compiler\/forget\/packages\/playground\/lib\/patchUseMemoCache.ts","status":"M"},{"path":"compiler\/forget\/src\/BackEnd\/JSGen.ts","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/e2e\/hello.e2e.js","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/e2e\/update-button.e2e.js","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md","status":"M"}],"parents":["e575e22925f4dcb6e04cb21b98bf9dc6f90207ba"],"patch":"diff --git a\/compiler\/forget\/packages\/playground\/lib\/patchUseMemoCache.ts b\/compiler\/forget\/packages\/playground\/lib\/patchUseMemoCache.ts\nindex 481c6d0636..96a1f15e59 100644\n--- a\/compiler\/forget\/packages\/playground\/lib\/patchUseMemoCache.ts\n+++ b\/compiler\/forget\/packages\/playground\/lib\/patchUseMemoCache.ts\n@@ -130,7 +130,7 @@ export default function patchUseMemoCache(reactSource: string) {\n () => true, \/\/ always read-only\n );\n \n- React.useMemoCache = useMemoCache;\n+ React.unstable_useMemoCache = React.useMemoCache = useMemoCache;\n \n export default React;\n `;\ndiff --git a\/compiler\/forget\/src\/BackEnd\/JSGen.ts b\/compiler\/forget\/src\/BackEnd\/JSGen.ts\nindex 1a97c4872c..eb59965327 100644\n--- a\/compiler\/forget\/src\/BackEnd\/JSGen.ts\n+++ b\/compiler\/forget\/src\/BackEnd\/JSGen.ts\n@@ -36,7 +36,7 @@ export function run(lirProg: LIR.Prog, context: CompilerContext) {\n \/*specifier*\/ [\n t.importSpecifier(\n t.identifier(\"useMemoCache\"),\n- t.identifier(\"useMemoCache\")\n+ t.identifier(\"unstable_useMemoCache\")\n ),\n ],\n \/*source*\/ t.stringLiteral(\"react\")\ndiff --git a\/compiler\/forget\/src\/__tests__\/e2e\/hello.e2e.js b\/compiler\/forget\/src\/__tests__\/e2e\/hello.e2e.js\nindex d35f16f9c2..ed76812cdb 100644\n--- a\/compiler\/forget\/src\/__tests__\/e2e\/hello.e2e.js\n+++ b\/compiler\/forget\/src\/__tests__\/e2e\/hello.e2e.js\n@@ -10,7 +10,7 @@ import * as React from \"react\";\n import { render } from \"@testing-library\/react\";\n import { expectLogsAndClear, log } from \".\/expectLogs\";\n \n-React.useMemoCache = useMemoCacheStub;\n+React.unstable_useMemoCache = useMemoCacheStub;\n \n function Hello({ name }) {\n \"use forget\";\ndiff --git a\/compiler\/forget\/src\/__tests__\/e2e\/update-button.e2e.js b\/compiler\/forget\/src\/__tests__\/e2e\/update-button.e2e.js\nindex 008bc5b59d..11cae8dc82 100644\n--- a\/compiler\/forget\/src\/__tests__\/e2e\/update-button.e2e.js\n+++ b\/compiler\/forget\/src\/__tests__\/e2e\/update-button.e2e.js\n@@ -9,7 +9,7 @@ import { render } from \"@testing-library\/react\";\n import * as React from \"react\";\n import { useMemoCacheStub } from \"..\/test-utils\/useMemoCacheStub\";\n \n-React.useMemoCache = useMemoCacheStub;\n+React.unstable_useMemoCache = useMemoCacheStub;\n \n function Button({ label }) {\n const theme = useTheme();\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\nindex 7c236f2afe..05808f35db 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\n@@ -53,7 +53,6 @@ function Component$0(props$1) {\n const b$3 = {};\n foo$4(a$2, b$3);\n let _$5 =

<\/div>;\n-\n foo$4(b$3);\n return

<\/div>;\n }\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\nindex 6c27c54b52..703b59f405 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\n@@ -98,7 +98,6 @@ function Component$0(props$1) {\n if (props$1.b) {\n return null;\n }\n-\n a_DEBUG$2.push(props$1.d);\n return a_DEBUG$2;\n }\n@@ -129,7 +128,6 @@ function Component$0(props$1) {\n a$2.push(props$1.c);\n (\"<>\");\n }\n-\n a$2.push(props$1.d);\n return a$2;\n }\n@@ -161,7 +159,6 @@ function Component$0(props$1) {\n a$2.push(props$1.c);\n return null;\n }\n-\n a$2.push(props$1.d);\n return a$2;\n }\n@@ -192,7 +189,6 @@ function Component$0(props$1) {\n a$2.push(props$1.c);\n return a$2;\n }\n-\n a$2.push(props$1.d);\n return a$2;\n }\n@@ -223,7 +219,6 @@ function Component$0(props$1) {\n a$2.push(props$1.d);\n return a$2;\n }\n-\n a$2.push(props$1.c);\n (\"<>\");\n }\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\nindex 7d95dfd50c..2cc637df05 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\n@@ -93,12 +93,10 @@ function Component$0(props$1) {\n a$2.push(props$1.p0);\n (\"<>\");\n }\n-\n if (props$1.p1) {\n b$3.push(props$1.p2);\n (\"<>\");\n }\n-\n return <\/Foo$4>;\n }\n \n@@ -134,12 +132,10 @@ function Component$0(props$1) {\n a$2.push(props$1.p0);\n (\"<>\");\n }\n-\n if (props$1.p1) {\n b$3.push(props$1.p2);\n (\"<>\");\n }\n-\n return <\/Foo$6>;\n }\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md\nindex 0aa2ea7015..045650a9ef 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md\n@@ -53,7 +53,6 @@ function Component$0(props$1) {\n const b$3 = {};\n new Foo$4(a$2, b$3);\n let _$5 =

<\/div>;\n-\n new Foo$4(b$3);\n return

<\/div>;\n }\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\nindex a0828e3d84..ffb2213e6c 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\n@@ -120,7 +120,6 @@ function Component$0(props$1) {\n mutate$5(b$4);\n (\"<>\");\n }\n-\n return <\/Foo$6>;\n }\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\nindex 4528ebedc8..b5d8dc4883 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\n@@ -97,7 +97,6 @@ function Component$0(props$1) {\n foo$5(a$2, b$4);\n (\"<>\");\n }\n-\n return <\/Foo$6>;\n }\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\nindex 1d15cafa2d..57cd445f04 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\n@@ -48,9 +48,7 @@ function Component$0(props$1) {\n x$2 = [];\n (\"<>\");\n }\n-\n let _$4 = <\/Component$0>;\n-\n y$3.push(props$1.p2);\n return <\/Component$0>;\n }\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md\nindex 044f294372..dcdd0301dd 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md\n@@ -40,7 +40,6 @@ function Component$0(props$1) {\n let y$3 = x$2;\n x$2 = [];\n let _$4 = <\/Component$0>;\n-\n y$3.push(props$1.p1);\n return <\/Component$0>;\n }\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md\nindex a301daf79e..d02e9e8166 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md\n@@ -65,22 +65,18 @@ function Component$0(props$1) {\n switch (props$1.p0) {\n case 1:\n break;\n-\n case true: {\n x$2.push(props$1.p2);\n y$3 = [];\n (\"<>\");\n }\n-\n default:\n break;\n-\n case false: {\n y$3 = x$2;\n (\"<>\");\n }\n }\n-\n const child$7 = <\/Component$0>;\n y$3.push(props$1.p4);\n return {child$7}<\/Component$0>;\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md\nindex e10639f01a..f267daf383 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md\n@@ -64,13 +64,11 @@ function Component$0(props$1) {\n y$3 = [];\n (\"<>\");\n }\n-\n case false: {\n y$3 = x$2;\n (\"<>\");\n }\n }\n-\n const child$6 = <\/Component$0>;\n y$3.push(props$1.p4);\n return {child$6}<\/Component$0>;\n"}

dillon1000/react

Files changed