{"commit":{"authorEmail":"silbermann.sebastian@gmail.com","revision":"7f8798a3f2cba588c1b7e5b19d488bce3520f62a","authorName":"Sebastian Silbermann","subject":"Convert ReactDOMSelection to createRoot (#28176)","authoredAt":"2024-02-02T08:58:30+01:00","shortRevision":"7f8798a3f2"},"files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMSelection-test.internal.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMSelection-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMSelection-test.internal.js\nindex 251e98d675..9457137ff4 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMSelection-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMSelection-test.internal.js\n@@ -10,16 +10,18 @@\n 'use strict';\n \n let React;\n-let ReactDOM;\n+let ReactDOMClient;\n let ReactDOMSelection;\n+let act;\n \n let getModernOffsetsFromPoints;\n \n describe('ReactDOMSelection', () => {\n beforeEach(() => {\n React = require('react');\n- ReactDOM = require('react-dom');\n+ ReactDOMClient = require('react-dom\/client');\n ReactDOMSelection = require('react-dom-bindings\/src\/client\/ReactDOMSelection');\n+ act = require('internal-test-utils').act;\n \n ({getModernOffsetsFromPoints} = ReactDOMSelection);\n });\n@@ -74,53 +76,57 @@ describe('ReactDOMSelection', () => {\n \n \/\/ Complicated example derived from a real-world DOM tree. Has a bit of\n \/\/ everything.\n- function getFixture() {\n- return ReactDOM.render(\n-

\n+ async function getFixture() {\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render(\n

\n-

xxxxxxxxxxxxxxxxxxxx<\/div>\n- <\/div>\n- x\n

\n- x\n+

xxxxxxxxxxxxxxxxxxxx<\/div>\n+ <\/div>\n+ x\n+

\n+ x\n

\n-

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx<\/div>\n-

\n-

xxxxxxxxxxxxxxxxxx<\/div>\n+

\n+

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx<\/div>\n+

\n+

xxxxxxxxxxxxxxxxxx<\/div>\n+ <\/div>\n <\/div>\n <\/div>\n <\/div>\n+

\n <\/div>\n-

\n- <\/div>\n-

\n-

xxxx<\/div>\n-

xxxxxxxxxxxxxxxxxxx<\/div>\n+

\n+

xxxx<\/div>\n+

xxxxxxxxxxxxxxxxxxx<\/div>\n+ <\/div>\n <\/div>\n- <\/div>\n-

xxx<\/div>\n-

xxxxx<\/div>\n-

xxx<\/div>\n-

\n+

xxx<\/div>\n+

xxxxx<\/div>\n+

xxx<\/div>\n

\n-

{['x', 'x', 'xxx']}<\/div>\n+

\n+

{['x', 'x', 'xxx']}<\/div>\n+ <\/div>\n <\/div>\n <\/div>\n <\/div>\n- <\/div>\n-

\n-

xxxxxx<\/div>\n- <\/div>\n- <\/div>,\n- document.createElement('div'),\n- );\n+

\n+

xxxxxx<\/div>\n+ <\/div>\n+ <\/div>,\n+ );\n+ });\n+ return container.firstChild;\n }\n \n it('returns correctly for base case', () => {\n@@ -135,8 +141,8 @@ describe('ReactDOMSelection', () => {\n });\n });\n \n- it('returns correctly for fuzz test', () => {\n- const fixtureRoot = getFixture();\n+ it('returns correctly for fuzz test', async () => {\n+ const fixtureRoot = await getFixture();\n const allNodes = [fixtureRoot].concat(\n Array.from(fixtureRoot.querySelectorAll('*')),\n );\n","parents":["fa8a34bfac9be820269b52f1e55afe9fe89bfcf1"],"body":""}

dillon1000/react

Files changed