dillon1000/react

Commit

Match Preact behavior for boolean props on custom elements (#24541)

* Log unexpected warnings when testing with ReactDOMServerIntegrationTestUtils

* Add test

Following https://github.com/facebook/react/issues/9230#issuecomment-322007671 except that `foo={true}` renders an empty string.
See https://github.com/facebook/react/issues/9230#issuecomment-1123464720 for rationale.

* Match Preact behavior for boolean props on custom elements

* Poke CircleCI
Browse files
Sebastian Silbermann authored 82c64e1a49239158c0daa7f0d603d2ad2ee667a9 Parent 6e2f38f
Changed paths8 files
First-parent comparison
M packages/react-dom/src/__tests__/DOMPropertyOperations-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js ModifiedM packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js ModifiedM packages/react-dom/src/client/DOMPropertyOperations.js ModifiedM packages/react-dom/src/client/ReactDOMComponent.js ModifiedM packages/react-dom/src/server/ReactDOMServerFormatConfig.js ModifiedM packages/react-dom/src/shared/DOMProperty.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…