dillon1000/react
Commit
Browse files Turn value block within try/catch into todo (from invariant)
Within a try/catch, every instruction is followed by a maybe-throw terminal. This currently breaks the logic in BuildReactiveFunction which tries to reassemble the value block, since it isn't expecting the maybe-throw. Conceptually the logic should just ignore it — we could even flatten away maybe-throw terminals before this pass — but for now since this pattern is rare we can just make it a todo.
Changed paths2 files
First-parent comparisoncompiler/packages/babel-plugin-react-forget/src/ReactiveScopes/BuildReactiveFunction.ts ModifiedM compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-logical-expression-within-try-catch.expect.md ModifiedPatch
Files changed
Rendering syntax-highlighted changes…