dillon1000/react
Commit
Browse files Don't minify symbols in production builds (#28881)
This disables symbol renaming in production builds. The original variable and function names are preserved. All other forms of compression applied by Closure (dead code elimination, inlining, etc) are unchanged — the final program is identical to what we were producing before, just in a more readable form. The motivation is to make it easier to debug React issues that only occur in production — the same reason we decided to start shipping sourcemaps in #28827 and #28827. However, because most apps run their own minification step on their npm dependencies, it's not necessary for us to minify the symbols before publishing — it'll be handled the app, if desired. This is the same strategy Meta has used to ship React for years. The React build itself has unminified symbols, but they get minified as part of Meta's regular build pipeline. Even if an app does not minify their npm dependencies, gzip covers most of the cost of symbol renaming anyway. This saves us from having to ship sourcemaps, which means even apps that don't have sourcemaps configured will be able to debug the React build as easily as they would any other npm dependency.
Changed paths83 files
First-parent comparisondangerfile.js ModifiedM package.json ModifiedM packages/eslint-plugin-react-hooks/npm/index.js ModifiedM packages/jest-react/npm/index.js ModifiedM packages/react-art/npm/index.js ModifiedM packages/react-cache/npm/index.js ModifiedM packages/react-client/npm/flight.js ModifiedM packages/react-debug-tools/npm/index.js ModifiedM packages/react-dom/npm/index.js ModifiedM packages/react-dom/npm/profiling.js ModifiedM packages/react-dom/npm/react-dom.react-server.js ModifiedM packages/react-dom/npm/server-rendering-stub.js ModifiedM packages/react-dom/npm/server.browser.js ModifiedM packages/react-dom/npm/server.bun.js ModifiedM packages/react-dom/npm/server.edge.js ModifiedM packages/react-dom/npm/server.node.js ModifiedM packages/react-dom/npm/static.browser.js ModifiedM packages/react-dom/npm/static.edge.js ModifiedM packages/react-dom/npm/static.node.js ModifiedM packages/react-dom/npm/test-utils.js ModifiedM packages/react-dom/npm/unstable_testing.js ModifiedM packages/react-is/npm/index.js ModifiedM packages/react-noop-renderer/npm/flight-client.js ModifiedM packages/react-noop-renderer/npm/flight-server.js ModifiedM packages/react-noop-renderer/npm/index.js ModifiedM packages/react-noop-renderer/npm/persistent.js ModifiedM packages/react-noop-renderer/npm/server.js ModifiedM packages/react-reconciler/npm/constants.js ModifiedM packages/react-reconciler/npm/index.js ModifiedM packages/react-reconciler/npm/reflection.js ModifiedM packages/react-refresh/npm/babel.js ModifiedM packages/react-refresh/npm/runtime.js ModifiedR packages/react-server-dom-esm/esm/react-server-dom-esm-node-loader.production.min.js →packages/react-server-dom-esm/esm/react-server-dom-esm-node-loader.production.js RenamedM packages/react-server-dom-esm/npm/client.browser.js ModifiedM packages/react-server-dom-esm/npm/client.node.js ModifiedM packages/react-server-dom-esm/npm/server.node.js ModifiedM packages/react-server-dom-esm/package.json ModifiedR packages/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.min.js →packages/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js RenamedM packages/react-server-dom-turbopack/npm/client.browser.js ModifiedM packages/react-server-dom-turbopack/npm/client.edge.js ModifiedM packages/react-server-dom-turbopack/npm/client.node.js ModifiedM packages/react-server-dom-turbopack/npm/client.node.unbundled.js ModifiedM packages/react-server-dom-turbopack/npm/server.browser.js ModifiedM packages/react-server-dom-turbopack/npm/server.edge.js ModifiedM packages/react-server-dom-turbopack/npm/server.node.js ModifiedM packages/react-server-dom-turbopack/npm/server.node.unbundled.js ModifiedM packages/react-server-dom-turbopack/package.json ModifiedR packages/react-server-dom-webpack/esm/react-server-dom-webpack-node-loader.production.min.js →packages/react-server-dom-webpack/esm/react-server-dom-webpack-node-loader.production.js RenamedM packages/react-server-dom-webpack/npm/client.browser.js ModifiedM packages/react-server-dom-webpack/npm/client.edge.js ModifiedM packages/react-server-dom-webpack/npm/client.node.js ModifiedM packages/react-server-dom-webpack/npm/client.node.unbundled.js ModifiedM packages/react-server-dom-webpack/npm/server.browser.js ModifiedM packages/react-server-dom-webpack/npm/server.edge.js ModifiedM packages/react-server-dom-webpack/npm/server.node.js ModifiedM packages/react-server-dom-webpack/npm/server.node.unbundled.js ModifiedM packages/react-server-dom-webpack/package.json ModifiedM packages/react-server/npm/flight.js ModifiedM packages/react-server/npm/index.js ModifiedM packages/react-test-renderer/npm/index.js ModifiedM packages/react/npm/index.js ModifiedM packages/react/npm/jsx-dev-runtime.js ModifiedM packages/react/npm/jsx-runtime.js ModifiedM packages/react/npm/jsx-runtime.react-server.js ModifiedM packages/react/npm/react.react-server.js ModifiedM packages/react/npm/unstable-cache.js ModifiedM packages/scheduler/npm/index.js ModifiedM packages/scheduler/npm/index.native.js ModifiedM packages/scheduler/npm/unstable_mock.js ModifiedM packages/scheduler/npm/unstable_post_task.js ModifiedM packages/use-subscription/npm/index.js ModifiedM packages/use-sync-external-store/npm/index.js ModifiedM packages/use-sync-external-store/npm/shim/index.js ModifiedM packages/use-sync-external-store/npm/shim/index.native.js ModifiedM packages/use-sync-external-store/npm/shim/with-selector.js ModifiedM packages/use-sync-external-store/npm/with-selector.js ModifiedM scripts/bench/benchmarks/hacker-news/build.js ModifiedM scripts/bench/benchmarks/pe-class-components/build.js ModifiedM scripts/bench/benchmarks/pe-functional-components/build.js ModifiedM scripts/bench/benchmarks/pe-no-components/build.js ModifiedM scripts/rollup/build.js ModifiedM scripts/rollup/bundles.js ModifiedM yarn.lock ModifiedPatch
Files changed
Rendering syntax-highlighted changes…