{"patch":"diff --git a\/compiler\/forget\/src\/HIR\/InferMutableLifetimes.ts b\/compiler\/forget\/src\/HIR\/InferMutableLifetimes.ts\nindex da282034f6..da9e00dbe7 100644\n--- a\/compiler\/forget\/src\/HIR\/InferMutableLifetimes.ts\n+++ b\/compiler\/forget\/src\/HIR\/InferMutableLifetimes.ts\n@@ -5,7 +5,9 @@\n * LICENSE file in the root directory of this source tree.\n *\/\n \n-import { HIRFunction } from \".\/HIR\";\n+import { assertExhaustive } from \"..\/Common\/utils\";\n+import { Effect, HIRFunction, Instruction, Place } from \".\/HIR\";\n+import { printInstruction, printPlace } from \".\/PrintHIR\";\n \n \/**\n * For each usage of a value in the given function, determines if the usage\n@@ -24,6 +26,7 @@ import { HIRFunction } from \".\/HIR\";\n *\n * == Algorithm\n *\n+ * TODO:\n * 1. Forward data-flow analysis to determine aliasing. Unlike InferReferenceCapability\n * which only tracks aliasing of top-level variables (`y = x`), this analysis needs\n * to know if a value is aliased anywhere (`y.x = x`). The forward data flow tracks\n@@ -38,10 +41,9 @@ import { HIRFunction } from \".\/HIR\";\n * mutate(y); \/\/ can infer that y mutates v0 and v1\n * ```\n *\n- * 2. Backward data-flow analysis to compute mutability liveness. Walk backwards over\n- * the CFG and track which values are mutated in a successor. Then when visiting\n- * preceding statements, mark any reference to a value that is known mutated as\n- * mutable.\n+ * DONE:\n+ * 2. Forward data-flow analysis to compute mutability liveness. Walk forwards over\n+ * the CFG and track which values are mutated in a successor.\n *\n * ```\n * mutate(y); \/\/ mutable y => v0, v1 mutated\n@@ -49,4 +51,119 @@ import { HIRFunction } from \".\/HIR\";\n * ...\n * ```\n *\/\n-function inferMutableLifetimes(fn: HIRFunction) {}\n+\n+function inferPlace(place: Place, instr: Instruction) {\n+ switch (place.effect) {\n+ case Effect.Unknown: {\n+ throw new Error(\n+ `Found an unkown place ${printPlace(place)} at ${printInstruction(\n+ instr\n+ )}!`\n+ );\n+ }\n+ case Effect.Read:\n+ case Effect.Freeze:\n+ return;\n+ case Effect.Mutate: {\n+ place.identifier.mutableRange.end = instr.id;\n+ return;\n+ }\n+ default:\n+ assertExhaustive(place.effect, `Unexpected ${printPlace(place)} effect`);\n+ }\n+}\n+\n+export function inferMutableRanges(func: HIRFunction) {\n+ for (const [_, block] of func.body.blocks) {\n+ for (const phi of block.phis) {\n+ phi.id.mutableRange = {\n+ start: -1, \/\/ TODO(gsn): This is a hack, we should assign proper ids to phis.\n+ end: -1,\n+ };\n+ }\n+\n+ for (const instr of block.instructions) {\n+ for (const input of collectInputs(instr)) {\n+ inferPlace(input, instr);\n+ }\n+\n+ if (instr.lvalue !== null) {\n+ if (instr.lvalue.place.memberPath === null) {\n+ const lvalueId = instr.lvalue.place.identifier;\n+\n+ \/\/ lvalue start being mutable when they're initially assigned a\n+ \/\/ value.\n+ lvalueId.mutableRange.start = instr.id;\n+\n+ \/\/ Let's be optimistic and assume this lvalue is not mutable by\n+ \/\/ default.\n+ lvalueId.mutableRange.end = instr.id;\n+ } else {\n+ inferPlace(instr.lvalue.place, instr);\n+ }\n+ }\n+ }\n+ }\n+}\n+\n+function* collectInputs(instr: Instruction) {\n+ const instrValue = instr.value;\n+ switch (instrValue.kind) {\n+ case \"NewExpression\":\n+ case \"CallExpression\": {\n+ yield instrValue.callee;\n+ for (const arg of instrValue.args) {\n+ yield arg;\n+ }\n+ break;\n+ }\n+ case \"BinaryExpression\": {\n+ yield instrValue.left;\n+ yield instrValue.right;\n+ break;\n+ }\n+ case \"Identifier\": {\n+ yield instrValue;\n+ break;\n+ }\n+ case \"UnaryExpression\": {\n+ yield instrValue.value;\n+ break;\n+ }\n+ case \"JsxExpression\": {\n+ yield instrValue.tag;\n+ for (const place of instrValue.props.values()) {\n+ yield place;\n+ }\n+ if (instrValue.children) {\n+ for (const c of instrValue.children) {\n+ yield c;\n+ }\n+ }\n+ break;\n+ }\n+ case \"ObjectExpression\": {\n+ if (instrValue.properties !== null) {\n+ const props = instrValue.properties;\n+ for (const place of props.values()) {\n+ yield place;\n+ }\n+ }\n+ break;\n+ }\n+ case \"ArrayExpression\": {\n+ for (const e of instrValue.elements) {\n+ yield e;\n+ }\n+ break;\n+ }\n+ case \"OtherStatement\":\n+ case \"Primitive\":\n+ case \"JSXText\": {\n+ break;\n+ }\n+ default: {\n+ console.log(`unhandled instruction: ${printInstruction(instr)}`);\n+ }\n+ }\n+}\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\nindex 6b4d89bee1..266571ba79 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\n@@ -34,8 +34,8 @@ function foo$0() {\n \n ```\n bb0:\n- [1] Const mutate a$10 = Array []\n- [2] Const mutate b$11 = Object { }\n+ [1] Const mutate a$10[1:3] = Array []\n+ [2] Const mutate b$11[2:6] = Object { }\n [3] Call mutate foo$4(mutate a$10, mutate b$11)\n [4] Const mutate $12 = \"div\"\n [5] Let mutate _$13 = JSX <\/read $12>\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\nindex a76216d800..7fcd194f5b 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\n@@ -45,9 +45,9 @@ bb0:\n bb1:\n predecessor blocks: bb0 bb4 bb7\n items$33: phi(bb0: items$27, bb4: items$33, bb7: items$33)\n- item$35: phi(bb0: item$10, bb4: item$35, bb7: item$35)\n- seen$38: phi(bb0: seen$30, bb4: seen$38, bb7: seen$38)\n- renderedItems$46: phi(bb0: renderedItems$29, bb4: renderedItems$46, bb7: renderedItems$46)\n+ item$35[-1:11]: phi(bb0: item$10, bb4: item$35, bb7: item$35)\n+ seen$38[-1:11]: phi(bb0: seen$30, bb4: seen$38, bb7: seen$38)\n+ renderedItems$46[-1:14]: phi(bb0: renderedItems$29, bb4: renderedItems$46, bb7: renderedItems$46)\n max$48: phi(bb0: max$32, bb4: max$48, bb7: max$48)\n If (read items$33) then:bb3 else:bb2\n bb3:\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\nindex 28f5d4c4db..a85337da08 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\n@@ -78,7 +78,7 @@ function Component(props) {\n \n ```\n bb0:\n- [1] Const mutate a_DEBUG$5 = Array []\n+ [1] Const mutate a_DEBUG$5[1:4] = Array []\n [2] Call mutate a_DEBUG$5.push(read props$4.a)\n If (read props$4.b) then:bb2 else:bb1\n bb2:\n@@ -110,7 +110,7 @@ function Component$0(props$4) {\n \n ```\n bb0:\n- [1] Const mutate a$4 = Array []\n+ [1] Const mutate a$4[1:4] = Array []\n [2] Call mutate a$4.push(read props$3.a)\n If (read props$3.b) then:bb2 else:bb1\n bb2:\n@@ -143,7 +143,7 @@ function Component$0(props$3) {\n \n ```\n bb0:\n- [1] Const mutate a$5 = Array []\n+ [1] Const mutate a$5[1:5] = Array []\n [2] Call mutate a$5.push(read props$4.a)\n If (read props$4.b) then:bb2 else:bb1\n bb2:\n@@ -177,7 +177,7 @@ function Component$0(props$4) {\n \n ```\n bb0:\n- [1] Const mutate a$4 = Array []\n+ [1] Const mutate a$4[1:4] = Array []\n [2] Call mutate a$4.push(read props$3.a)\n If (read props$3.b) then:bb2 else:bb1\n bb2:\n@@ -210,7 +210,7 @@ function Component$0(props$3) {\n \n ```\n bb0:\n- [1] Const mutate a$4 = Array []\n+ [1] Const mutate a$4[1:4] = Array []\n [2] Call mutate a$4.push(read props$3.a)\n If (read props$3.b) then:bb1 else:bb2\n bb2:\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\nindex 626c0a99c3..2486702d44 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\n@@ -67,8 +67,8 @@ function mayMutate() {}\n \n ```\n bb0:\n- [1] Const mutate a$7 = Array []\n- [2] Const mutate b$8 = Array []\n+ [1] Const mutate a$7[1:3] = Array []\n+ [2] Const mutate b$8[2:4] = Array []\n If (read b$8) then:bb2 else:bb1\n bb2:\n predecessor blocks: bb0\n@@ -111,8 +111,8 @@ function Component$0(props$6) {\n \n ```\n bb0:\n- [1] Const mutate a$9 = Array []\n- [2] Const mutate b$10 = Array []\n+ [1] Const mutate a$9[1:4] = Array []\n+ [2] Const mutate b$10[2:5] = Array []\n [3] Const mutate $11 = Call mutate mayMutate$4(mutate b$10)\n If (read $11) then:bb2 else:bb1\n bb2:\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md\nindex f30a6e0b8f..db938165ec 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md\n@@ -34,8 +34,8 @@ function Foo$0() {\n \n ```\n bb0:\n- [1] Const mutate a$10 = Array []\n- [2] Const mutate b$11 = Object { }\n+ [1] Const mutate a$10[1:3] = Array []\n+ [2] Const mutate b$11[2:6] = Object { }\n [3] New mutate Foo$4(mutate a$10, mutate b$11)\n [4] Const mutate $12 = \"div\"\n [5] Let mutate _$13 = JSX <\/read $12>\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\nindex d284f83424..f06f4eacbc 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\n@@ -97,8 +97,8 @@ function Foo$0() {\n \n ```\n bb0:\n- [1] Const mutate a$9 = Call mutate compute$3(read props$8.a)\n- [2] Const mutate b$10 = Call mutate compute$3(read props$8.b)\n+ [1] Const mutate a$9[1:3] = Call mutate compute$3(read props$8.a)\n+ [2] Const mutate b$10[2:4] = Call mutate compute$3(read props$8.b)\n If (read props$8.c) then:bb2 else:bb1\n bb2:\n predecessor blocks: bb0\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\nindex df4fc3170b..e5c457b009 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\n@@ -76,8 +76,8 @@ function Foo$0() {\n \n ```\n bb0:\n- [1] Const mutate a$9 = Call mutate compute$3(read props$8.a)\n- [2] Const mutate b$10 = Call mutate compute$3(read props$8.b)\n+ [1] Const mutate a$9[1:3] = Call mutate compute$3(read props$8.a)\n+ [2] Const mutate b$10[2:3] = Call mutate compute$3(read props$8.b)\n If (read props$8.c) then:bb2 else:bb1\n bb2:\n predecessor blocks: bb0\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent.expect.md\nindex 605ea980de..45febb30c1 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent.expect.md\n@@ -28,8 +28,8 @@ function Foo() {}\n \n ```\n bb0:\n- [1] Const mutate a$9 = Call mutate compute$3(read props$8.a)\n- [2] Const mutate b$10 = Call mutate compute$3(read props$8.b)\n+ [1] Const mutate a$9[1:3] = Call mutate compute$3(read props$8.a)\n+ [2] Const mutate b$10[2:3] = Call mutate compute$3(read props$8.b)\n [3] Call mutate foo$5(mutate a$9, mutate b$10)\n [4] Const mutate $11 = JSX <\/read Foo$6>\n Return read $11\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md\nindex 30ee6eb4fd..433d12ce41 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md\n@@ -84,15 +84,15 @@ bb1:\n b$20: phi(bb0: b$14, bb3: b$23)\n c$22: phi(bb0: c$15, bb3: c$25)\n d$24: phi(bb0: d$16, bb3: d$26)\n- mutate$27: phi(bb0: mutate$7, bb3: mutate$27)\n- cond$28: phi(bb0: cond$8, bb3: cond$28)\n+ mutate$27[-1:14]: phi(bb0: mutate$7, bb3: mutate$27)\n+ cond$28[-1:12]: phi(bb0: cond$8, bb3: cond$28)\n [5] Const mutate $17 = true\n If (read $17) then:bb3 else:bb2\n bb3:\n predecessor blocks: bb1\n [6] Let mutate z$19 = read a$18\n- [7] Reassign mutate a$21 = read b$20\n- [8] Reassign mutate b$23 = read c$22\n+ [7] Reassign mutate a$21[7:12] = read b$20\n+ [8] Reassign mutate b$23[8:11] = read c$22\n [9] Reassign mutate c$25 = read d$24\n [10] Reassign mutate d$26 = read z$19\n [11] Call mutate mutate$27(mutate a$21, mutate b$23)\n@@ -103,7 +103,7 @@ bb2:\n a$30: phi(bb1: a$18, bb3: a$21)\n b$31: phi(bb1: b$20, bb3: b$23)\n c$32: phi(bb1: c$22, bb3: c$25)\n- d$33: phi(bb1: d$24, bb3: d$26)\n+ d$33[-1:14]: phi(bb1: d$24, bb3: d$26)\n If (read a$30) then:bb7 else:bb7\n bb7:\n predecessor blocks: bb2\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-with-aliasing.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-with-aliasing.expect.md\nindex 27a16c6523..aa33bf8ec4 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-with-aliasing.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-with-aliasing.expect.md\n@@ -57,9 +57,9 @@ bb0:\n [1] Const mutate a$11 = Object { }\n [2] Const mutate b$12 = Array [read a$11]\n [3] Const mutate c$13 = Object { }\n- [4] Const mutate d$14 = Object { c: read c$13 }\n- [5] Const mutate x$15 = Object { }\n- [6] Reassign mutate x$15.b = read b$12\n+ [4] Const mutate d$14[4:7] = Object { c: read c$13 }\n+ [5] Const mutate x$15[5:9] = Object { }\n+ [6] Reassign mutate x$15.b[5:9] = read b$12\n [7] Const mutate y$16 = Call mutate mutate$8(mutate x$15, mutate d$14)\n If (read a$11) then:bb1 else:bb1\n bb1:\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md\nnew file mode 100644\nindex 0000000000..42554bc7ca\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md\n@@ -0,0 +1,122 @@\n+\n+## Input\n+\n+```javascript\n+function mutate() {}\n+function cond() {}\n+\n+function Component(props) {\n+ let a = {};\n+ let b = {};\n+ let c = {};\n+ let d = {};\n+ while (true) {\n+ mutate(a, b);\n+ if (cond(a)) {\n+ break;\n+ }\n+ }\n+\n+ \/\/ all of these tests are seemingly readonly, since the values are never directly\n+ \/\/ mutated again. but they are all aliased by `d`, which is later modified, and\n+ \/\/ these are therefore mutable references:\n+ if (a) {\n+ }\n+ if (b) {\n+ }\n+ if (c) {\n+ }\n+ if (d) {\n+ }\n+\n+ mutate(d, null);\n+}\n+\n+```\n+\n+## HIR\n+\n+```\n+bb0:\n+ Return\n+```\n+\n+## Code\n+\n+```javascript\n+function mutate$0() {\n+ return;\n+}\n+\n+```\n+## HIR\n+\n+```\n+bb0:\n+ Return\n+```\n+\n+## Code\n+\n+```javascript\n+function cond$0() {\n+ return;\n+}\n+\n+```\n+## HIR\n+\n+```\n+bb0:\n+ [1] Let mutate a$12 = Object { }\n+ [2] Let mutate b$13 = Object { }\n+ [3] Let mutate c$14 = Object { }\n+ [4] Let mutate d$15 = Object { }\n+ Goto bb1\n+bb1:\n+ predecessor blocks: bb0 bb3\n+ mutate$17[-1:9]: phi(bb0: mutate$6, bb3: mutate$17)\n+ a$18[-1:7]: phi(bb0: a$12, bb3: a$18)\n+ b$19[-1:6]: phi(bb0: b$13, bb3: b$19)\n+ cond$20[-1:7]: phi(bb0: cond$7, bb3: cond$20)\n+ c$25: phi(bb0: c$14, bb3: c$25)\n+ d$27[-1:9]: phi(bb0: d$15, bb3: d$27)\n+ [5] Const mutate $16 = true\n+ If (read $16) then:bb3 else:bb2\n+bb3:\n+ predecessor blocks: bb1\n+ [6] Call mutate mutate$17(mutate a$18, mutate b$19)\n+ [7] Const mutate $21 = Call mutate cond$20(mutate a$18)\n+ If (read $21) then:bb2 else:bb1\n+bb2:\n+ predecessor blocks: bb1 bb3\n+ If (read a$18) then:bb7 else:bb7\n+bb7:\n+ predecessor blocks: bb2\n+ If (read b$19) then:bb9 else:bb9\n+bb9:\n+ predecessor blocks: bb7\n+ If (read c$25) then:bb11 else:bb11\n+bb11:\n+ predecessor blocks: bb9\n+ If (read d$27) then:bb13 else:bb13\n+bb13:\n+ predecessor blocks: bb11\n+ [8] Const mutate $28 = null\n+ [9] Call mutate mutate$17(mutate d$27, read $28)\n+ Return\n+```\n+\n+## Code\n+\n+```javascript\n+function Component$0(props$11) {\n+ let a$12 = {};\n+ let b$13 = {};\n+ let c$14 = {};\n+ let d$15 = {};\n+ (\"<>\");\n+}\n+\n+```\n+ \n\\ No newline at end of file\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.js b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.js\nnew file mode 100644\nindex 0000000000..5b42db6831\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.js\n@@ -0,0 +1,29 @@\n+function mutate() {}\n+function cond() {}\n+\n+function Component(props) {\n+ let a = {};\n+ let b = {};\n+ let c = {};\n+ let d = {};\n+ while (true) {\n+ mutate(a, b);\n+ if (cond(a)) {\n+ break;\n+ }\n+ }\n+\n+ \/\/ all of these tests are seemingly readonly, since the values are never directly\n+ \/\/ mutated again. but they are all aliased by `d`, which is later modified, and\n+ \/\/ these are therefore mutable references:\n+ if (a) {\n+ }\n+ if (b) {\n+ }\n+ if (c) {\n+ }\n+ if (d) {\n+ }\n+\n+ mutate(d, null);\n+}\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/property-assignment.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/property-assignment.expect.md\nindex 2cfc0b6f18..de900df71c 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/property-assignment.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/property-assignment.expect.md\n@@ -17,9 +17,9 @@ function Component(props) {\n \n ```\n bb0:\n- [1] Const mutate x$7 = Object { }\n+ [1] Const mutate x$7[1:5] = Object { }\n [2] Const mutate y$8 = Array []\n- [3] Reassign mutate x$7.y = read y$8\n+ [3] Reassign mutate x$7.y[1:5] = read y$8\n [4] Const mutate child$9 = JSX <\/read Component$0>\n [5] Call mutate x$7.y.push(read props$6.p0)\n [6] Const mutate $10 = JSX {read child$9}<\/read Component$0>\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\nindex 8fb855cc49..35613a3c03 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\n@@ -23,7 +23,7 @@ function Component(props) {\n \n ```\n bb0:\n- [1] Let mutate x$7 = Array []\n+ [1] Let mutate x$7[1:2] = Array []\n [2] Call mutate x$7.push(read props$6.p0)\n [3] Let mutate y$8 = read x$7\n If (read props$6.p1) then:bb2 else:bb1\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md\nindex 82422ddac2..e51b468c63 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md\n@@ -21,9 +21,9 @@ function Component(props) {\n \n ```\n bb0:\n- [1] Let mutate x$7 = Array []\n+ [1] Let mutate x$7[1:2] = Array []\n [2] Call mutate x$7.push(read props$6.p0)\n- [3] Let mutate y$8 = read x$7\n+ [3] Let mutate y$8[3:6] = read x$7\n [4] Reassign mutate x$9 = Array []\n [5] Let mutate _$10 = JSX <\/read Component$0>\n [6] Call mutate y$8.push(read props$6.p1)\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md\nnew file mode 100644\nindex 0000000000..ae6089d562\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md\n@@ -0,0 +1,76 @@\n+\n+## Input\n+\n+```javascript\n+\/\/ @Pass runMutableRangeAnalysis\n+function foo() {}\n+\n+function Component(props) {\n+ const a = [];\n+ const b = {};\n+ foo(a, b);\n+ if (foo()) {\n+ let _ =

;\n+ }\n+ foo(a, b);\n+ return

;\n+}\n+\n+```\n+\n+## HIR\n+\n+```\n+bb0:\n+ Return\n+```\n+\n+## Code\n+\n+```javascript\n+function foo$0() {\n+ return;\n+}\n+\n+```\n+## HIR\n+\n+```\n+bb0:\n+ [1] Const mutate a$11[1:3] = Array []\n+ [2] Const mutate b$12[2:7] = Object { }\n+ [3] Call mutate foo$4(mutate a$11, mutate b$12)\n+ [4] Const mutate $13 = Call mutate foo$4()\n+ If (read $13) then:bb2 else:bb1\n+bb2:\n+ predecessor blocks: bb0\n+ [5] Const mutate $14 = \"div\"\n+ [6] Let mutate _$15 = JSX <\/read $14>\n+ Goto bb1\n+bb1:\n+ predecessor blocks: bb0 bb2\n+ [7] Call mutate foo$4(read a$11, mutate b$12)\n+ [8] Const mutate $19 = \"div\"\n+ [9] Const mutate $20 = JSX <\/read $19>\n+ Return read $20\n+```\n+\n+## Code\n+\n+```javascript\n+function Component$0(props$10) {\n+ const a$11 = [];\n+ const b$12 = {};\n+ foo$4(a$11, b$12);\n+ if (foo$4()) {\n+ let _$15 =

<\/div>;\n+\n+ (\"<>\");\n+ }\n+\n+ foo$4(a$11, b$12);\n+ return

<\/div>;\n+}\n+\n+```\n+ \n\\ No newline at end of file\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.js b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.js\nnew file mode 100644\nindex 0000000000..6d1ad38ab3\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.js\n@@ -0,0 +1,13 @@\n+\/\/ @Pass runMutableRangeAnalysis\n+function foo() {}\n+\n+function Component(props) {\n+ const a = [];\n+ const b = {};\n+ foo(a, b);\n+ if (foo()) {\n+ let _ =

;\n+ }\n+ foo(a, b);\n+ return

;\n+}\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.expect.md\nindex 6b4d89bee1..97d41cf519 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.expect.md\n@@ -9,7 +9,7 @@ function Component(props) {\n const b = {};\n foo(a, b);\n let _ =

;\n- foo(b);\n+ foo(a, b);\n return

;\n }\n \n@@ -34,12 +34,12 @@ function foo$0() {\n \n ```\n bb0:\n- [1] Const mutate a$10 = Array []\n- [2] Const mutate b$11 = Object { }\n+ [1] Const mutate a$10[1:3] = Array []\n+ [2] Const mutate b$11[2:6] = Object { }\n [3] Call mutate foo$4(mutate a$10, mutate b$11)\n [4] Const mutate $12 = \"div\"\n [5] Let mutate _$13 = JSX <\/read $12>\n- [6] Call mutate foo$4(mutate b$11)\n+ [6] Call mutate foo$4(read a$10, mutate b$11)\n [7] Const mutate $14 = \"div\"\n [8] Const mutate $15 = JSX <\/read $14>\n Return read $15\n@@ -54,7 +54,7 @@ function Component$0(props$9) {\n foo$4(a$10, b$11);\n let _$13 =

<\/div>;\n \n- foo$4(b$11);\n+ foo$4(a$10, b$11);\n return

<\/div>;\n }\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.js b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.js\nindex d0c79ac766..3e95b19d45 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.js\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.js\n@@ -5,6 +5,6 @@ function Component(props) {\n const b = {};\n foo(a, b);\n let _ =

;\n- foo(b);\n+ foo(a, b);\n return

;\n }\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-newexpression.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-newexpression.expect.md\nindex b8ecf3f4d4..6396717787 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-newexpression.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-newexpression.expect.md\n@@ -32,8 +32,8 @@ function Foo$0() {\n \n ```\n bb0:\n- [1] Const mutate a$7 = Array []\n- [2] Const mutate b$8 = Object { }\n+ [1] Const mutate a$7[1:3] = Array []\n+ [2] Const mutate b$8[2:3] = Object { }\n [3] Let mutate c$9 = New mutate Foo$5(mutate a$7, mutate b$8)\n Return freeze c$9\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property-call.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property-call.expect.md\nindex bf7ef0f1c6..6bb23e8e1e 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property-call.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property-call.expect.md\n@@ -16,8 +16,8 @@ function foo() {\n ```\n bb0:\n [1] Const mutate x$4 = Array []\n- [2] Const mutate y$5 = Object { x: read x$4 }\n- [3] Const mutate $6 = Array []\n+ [2] Const mutate y$5[2:4] = Object { x: read x$4 }\n+ [3] Const mutate $6[3:4] = Array []\n [4] Call mutate y$5.x.push(mutate $6)\n Return freeze y$5\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property.expect.md\nindex 87434143ca..bf0031ed4c 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property.expect.md\n@@ -16,8 +16,8 @@ function foo() {\n ```\n bb0:\n [1] Const mutate x$3 = Array []\n- [2] Const mutate y$4 = Object { }\n- [3] Reassign mutate y$4.x = read x$3\n+ [2] Const mutate y$4[2:3] = Object { }\n+ [3] Reassign mutate y$4.x[2:3] = read x$3\n Return freeze y$4\n ```\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md\nindex 4c5272940f..77f4be0e2a 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md\n@@ -32,7 +32,7 @@ function Component(props) {\n \n ```\n bb0:\n- [1] Let mutate x$10 = Array []\n+ [1] Let mutate x$10[1:6] = Array []\n [2] Let mutate y$11 = undefined\n [3] Const mutate $12 = false\n [4] Const mutate $13 = true\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md\nindex 06766890c0..359543d96e 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md\n@@ -28,7 +28,7 @@ function Component(props) {\n \n ```\n bb0:\n- [1] Let mutate x$9 = Array []\n+ [1] Let mutate x$9[1:6] = Array []\n [2] Let mutate y$10 = undefined\n [3] Const mutate $11 = false\n [4] Const mutate $12 = true\ndiff --git a\/compiler\/forget\/src\/__tests__\/hir-test.ts b\/compiler\/forget\/src\/__tests__\/hir-test.ts\nindex 7ec5ad5dee..d7db98f479 100644\n--- a\/compiler\/forget\/src\/__tests__\/hir-test.ts\n+++ b\/compiler\/forget\/src\/__tests__\/hir-test.ts\n@@ -18,6 +18,7 @@ import { lower } from \"..\/HIR\/BuildHIR\";\n import codegen from \"..\/HIR\/Codegen\";\n import { HIRFunction } from \"..\/HIR\/HIR\";\n import { Environment } from \"..\/HIR\/HIRBuilder\";\n+import { inferMutableRanges } from \"..\/HIR\/InferMutableLifetimes\";\n import inferReferenceEffects from \"..\/HIR\/InferReferenceEffects\";\n import printHIR from \"..\/HIR\/PrintHIR\";\n import buildSSA from \"..\/HIR\/SSAify\";\n@@ -64,6 +65,7 @@ describe(\"React Forget (HIR version)\", () => {\n const ir: HIRFunction = lower(nodePath, env);\n buildSSA(ir, env);\n inferReferenceEffects(ir);\n+ inferMutableRanges(ir);\n \/\/ const lifetimeGraph = buildDefUseGraph(ir);\n const textHIR = printHIR(ir.body);\n \/\/ const textLifetimeGraph = printGraph(lifetimeGraph);\n","parents":["c75a1fe6bb8aa3c8376a536445b3ac48f1f6914a"],"files":[{"status":"M","path":"compiler\/forget\/src\/HIR\/InferMutableLifetimes.ts"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/constructor.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-with-aliasing.expect.md"},{"status":"A","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md"},{"status":"A","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.js"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/property-assignment.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment.expect.md"},{"status":"A","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md"},{"status":"A","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.js"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx.js"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-newexpression.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property-call.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-property.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch-non-final-default.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/switch.expect.md"},{"status":"M","path":"compiler\/forget\/src\/__tests__\/hir-test.ts"}],"commit":{"shortRevision":"871a171a1f","authorEmail":"gsathya.ceg@gmail.com","revision":"871a171a1f6f04a473c71238a2bfa56fc3807883","subject":"[hir] Add InferMutableRange pass","authoredAt":"2022-11-04T16:39:45+00:00","authorName":"Sathya Gunasekaran"},"body":""}

dillon1000/react

Files changed