dillon1000/react

Commit

DevTools: Named hooks supports "cheap-module-source-map" (#21874)

"cheap-module-source-map" is the default source-map generation mode used in created-react-dev mode because of speed. The major trade-off is that the source maps generated don't contain column numbers, so DevTools needs to be more lenient when matching AST nodes in this mode.

In this case, it can ignore column numbers and match nodes using line numbers only– so long as only a single node matches. If more than one match is found, treat it the same as if none were found, and fall back to no name.
Browse files
Changed paths15 files
First-parent comparison
M packages/react-devtools-extensions/package.json ModifiedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/ComponentWithCustomHook.js AddedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/ComponentWithExternalCustomHooks.js AddedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/ComponentWithMultipleHooksPerLine.js AddedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/ContainingStringSourceMappingURL.js AddedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/Example.js AddedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/InlineRequire.js AddedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/ToDoList.js AddedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/index.js AddedA packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/no-columns/useTheme.js AddedM packages/react-devtools-extensions/src/__tests__/parseHookNames-test.js ModifiedM packages/react-devtools-extensions/src/__tests__/updateMockSourceMaps.js ModifiedM packages/react-devtools-extensions/src/astUtils.js ModifiedM packages/react-devtools-extensions/src/parseHookNames.js ModifiedM yarn.lock Modified
Patch

Files changed

Rendering syntax-highlighted changes…