dillon1000/react
Commit
Browse files Remove invokeGuardedCallback and replay trick (#28515)
We broke the ability to "break on uncaught exceptions" by adding a try/catch higher up in the scheduling. We're giving up on fixing that so we can remove the replay trick inside an event handler. The issue with that approach is that we end up double logging a lot of errors in DEV since they get reported to the page. It's also a lot of complexity around this feature.
Changed paths60 files
First-parent comparisonfixtures/dom/src/toWarnDev.js ModifiedM packages/react-cache/src/__tests__/ReactCacheOld-test.internal.js ModifiedM packages/react-devtools-shared/src/__tests__/TimelineProfiler-test.js ModifiedM packages/react-dom-bindings/src/events/DOMPluginEventSystem.js ModifiedM packages/react-dom/src/__tests__/InvalidEventListeners-test.js ModifiedM packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.js ModifiedM packages/react-dom/src/__tests__/ReactCompositeComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMConsoleErrorReporting-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMConsoleErrorReportingLegacy-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMHydrationDiff-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationLegacyContext-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationLegacyContextDisabled-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationSelect-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyErrorBoundaries-test.internal.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtils.js ModifiedM packages/react-native-renderer/src/legacy-events/EventBatching.js ModifiedM packages/react-native-renderer/src/legacy-events/EventPluginUtils.js ModifiedM packages/react-reconciler/src/ReactFiber.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-reconciler/src/ReactFiberErrorLogger.js ModifiedM packages/react-reconciler/src/ReactFiberHydrationContext.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.js ModifiedM packages/react-reconciler/src/__tests__/ErrorBoundaryReconciliation-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactBatching-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactConcurrentErrorRecovery-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorLogging-test.js ModifiedD packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.internal.js DeletedM packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseEffectsSemantics-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseFuzz-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspensePlaceholder-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js ModifiedM packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js ModifiedM packages/react/src/__tests__/ReactCoffeeScriptClass-test.coffee ModifiedM packages/react/src/__tests__/ReactES6Class-test.js ModifiedM packages/react/src/__tests__/ReactElementValidator-test.internal.js ModifiedM packages/react/src/__tests__/ReactProfiler-test.internal.js ModifiedM packages/react/src/__tests__/ReactTypeScriptClass-test.ts ModifiedM packages/react/src/__tests__/forwardRef-test.internal.js ModifiedD packages/shared/ReactErrorUtils.js DeletedM packages/shared/ReactFeatureFlags.js ModifiedD packages/shared/__tests__/ReactErrorUtils-test.internal.js DeletedM packages/shared/forks/ReactFeatureFlags.native-fb.js ModifiedM packages/shared/forks/ReactFeatureFlags.native-oss.js ModifiedM packages/shared/forks/ReactFeatureFlags.test-renderer.js ModifiedM packages/shared/forks/ReactFeatureFlags.test-renderer.native.js ModifiedM packages/shared/forks/ReactFeatureFlags.test-renderer.www.js ModifiedM packages/shared/forks/ReactFeatureFlags.www-dynamic.js ModifiedM packages/shared/forks/ReactFeatureFlags.www.js ModifiedD packages/shared/forks/invokeGuardedCallbackImpl.www.js DeletedD packages/shared/invokeGuardedCallbackImpl.js DeletedM packages/use-sync-external-store/src/__tests__/useSyncExternalStoreShared-test.js ModifiedM scripts/jest/shouldIgnoreConsoleError.js ModifiedM scripts/rollup/forks.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…